GitLab

apparently not at fault

> Revert 181812
> 
> Speculative revert to see whether this broke browser_tests on Win Aura Tests(2)
> 
> A DCHECK() about invalid strings is hit
> 
> > Add a set passphrase dialog which allows to set a passphrase for a managed user account. In a later changelist this will be used for authentication in order to change settings of the account.
> > This changelist is extracted from the changelist here: https://codereview.chromium.org/11783008/ in order to break it up.
> > A screenshot of the set passphrase page is available here:
> > https://docs.google.com/a/google.com/drawings/d/1qXtLoSN2C8Z_qrnNB8yHlJHG96NqL79ciMGaW3amWkw/edit?usp=sharing
> > 
> > BUG=171370
> > TEST=browser_tests, unit_tests
> > 
> > Review URL: https://chromiumcodereview.appspot.com/12208068
> 
> TBR=akuegel@chromium.org
> Review URL: https://codereview.chromium.org/12210136

TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/12217132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181905 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181901 0039d316-1c4b-4281-b951-d872f2087c98

this change was not at fault

> Revert 181806
> 
> Speculative revert to see whether this broke browser_tests on Win Aura Tests(2)
> 
> A DCHECK() about invalid strings is hit
> 
> > Update NetworkStateListDetailedView, add network_icon::GetImageForTray
> > 
> > This integrates chanhes to the network list and icon code,
> > and uses the Ash icon code in the network tray.
> > 
> > This completes the changes for:
> > 161869:	Create NetworkStateHandler version of Ash network tray
> > (Still behind a flag)
> > 
> > BUG=161869
> > TBR=sky@chromium.org (for ash_strings)
> > 
> > Review URL: https://codereview.chromium.org/12221112
> 
> TBR=stevenjb@chromium.org
> Review URL: https://codereview.chromium.org/12218116

TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/12210137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181899 0039d316-1c4b-4281-b951-d872f2087c98

Speculative revert to see whether this broke browser_tests on Win Aura Tests(2)

A DCHECK() about invalid strings is hit

> Add a set passphrase dialog which allows to set a passphrase for a managed user account. In a later changelist this will be used for authentication in order to change settings of the account.
> This changelist is extracted from the changelist here: https://codereview.chromium.org/11783008/ in order to break it up.
> A screenshot of the set passphrase page is available here:
> https://docs.google.com/a/google.com/drawings/d/1qXtLoSN2C8Z_qrnNB8yHlJHG96NqL79ciMGaW3amWkw/edit?usp=sharing
> 
> BUG=171370
> TEST=browser_tests, unit_tests
> 
> Review URL: https://chromiumcodereview.appspot.com/12208068

TBR=akuegel@chromium.org
Review URL: https://codereview.chromium.org/12210136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175683
TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/12220117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181897 0039d316-1c4b-4281-b951-d872f2087c98

Speculative revert to see whether this broke browser_tests on Win Aura Tests(2)

A DCHECK() about invalid strings is hit

> Update NetworkStateListDetailedView, add network_icon::GetImageForTray
> 
> This integrates chanhes to the network list and icon code,
> and uses the Ash icon code in the network tray.
> 
> This completes the changes for:
> 161869:	Create NetworkStateHandler version of Ash network tray
> (Still behind a flag)
> 
> BUG=161869
> TBR=sky@chromium.org (for ash_strings)
> 
> Review URL: https://codereview.chromium.org/12221112

TBR=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/12218116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175683
TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/12218115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181895 0039d316-1c4b-4281-b951-d872f2087c98

exists before invoking method on it.

BUG=174872
TEST=none
R=xiyuan@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12226100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181894 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/12225131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181893 0039d316-1c4b-4281-b951-d872f2087c98

extension API.

Trying to land this again after clang problem.  Original review was
here: https://chromiumcodereview.appspot.com/12188027/

(TBR'ing trivial change to profile_dependency_manager.cc)

TBR=davemoore@chromium.org,kalman@chromium.org,pneubeck@chromium.org
BUG=chromium:168713


Review URL: https://chromiumcodereview.appspot.com/12225087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181892 0039d316-1c4b-4281-b951-d872f2087c98

All changes are in comments. This patch doesn't change any semantics.

BUG=175657
TEST=none

R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12225135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181891 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175439


Review URL: https://chromiumcodereview.appspot.com/12224095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181890 0039d316-1c4b-4281-b951-d872f2087c98

TEST=No user visible changes.
BUG=169191
TBR=yosin

Review URL: https://chromiumcodereview.appspot.com/12224093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181889 0039d316-1c4b-4281-b951-d872f2087c98

The test has moved since the issue was reported, and only repro'd if the
full remoting test-suite was run, suggesting that some other test is at
fault.

BUG=167260


Review URL: https://chromiumcodereview.appspot.com/12223066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181888 0039d316-1c4b-4281-b951-d872f2087c98

Hardcoding HOST_DESKTOP_TYPE where necessary.

BUG=129187


Review URL: https://chromiumcodereview.appspot.com/12213075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181887 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174809
TEST=presubmit passes, Files.app launched.

Review URL: https://codereview.chromium.org/12211123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181886 0039d316-1c4b-4281-b951-d872f2087c98

- Fix bugs in translating capture regions into display coordinates.
- Fix MacDeskopConfiguration to support inverse-Cartesian coordinates.

BUG=175261,174090


Review URL: https://chromiumcodereview.appspot.com/12221103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181885 0039d316-1c4b-4281-b951-d872f2087c98

just 32x32.

Note: This is currently not used on Linux, since the Create Shortcuts dialog
builds its own icons. This is in preparation for migrating the icon creation
code.

BUG=175033


Review URL: https://chromiumcodereview.appspot.com/12218069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181884 0039d316-1c4b-4281-b951-d872f2087c98

This reduces the latency between when an upload completes and when the
client is notified.

BUG=173802


Review URL: https://chromiumcodereview.appspot.com/12213073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181883 0039d316-1c4b-4281-b951-d872f2087c98

exceptions, which devtools apparently pick up despite surrounding in try/catch.


BUG=174960


Review URL: https://chromiumcodereview.appspot.com/12210113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181882 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ddorwin@chromium.org
BUG=none
TEST=Tested on Linux x64 on Youtube.

Review URL: https://codereview.chromium.org/12223085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181881 0039d316-1c4b-4281-b951-d872f2087c98

Before, it was only in the context menu, what was not so user friendly. This patch adds this item on top of the gear menu to improve its visibility.

TEST=Enter Files.app, click on the gear menu.
BUG=174623

Review URL: https://codereview.chromium.org/12211124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181880 0039d316-1c4b-4281-b951-d872f2087c98

That space is only used in maximized mode of Files.app. When the extension acts as an open dialog, then there is no need for this space. Along the way, increased the space in Files.app mode to look better.

TEST=Open a browser, press ctrl-o. Verify that there is no extra space like on the screenshot in the bug's description.
BUG=175666

Review URL: https://codereview.chromium.org/12208125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181879 0039d316-1c4b-4281-b951-d872f2087c98

This is the last CL to get rid of BrowserList::const_iterator, BrowserList::begin(), and BrowserList::end() entirely (hopefully -- i.e., I can now build chrome, browser_tests, and unit_tests without these 3 methods -- there are 3 other CLs in the pipeline in parallel, I will land a CL to remove those methods for good once ToT no longer requires them)!

Various browser tests were already making explicit assumptions about native-desktop, hardcoding that some more in some places. Otherwise just replacing all the iterators by BrowserIterator (which in theory is multi-desktop, but in browser tests only the native desktop's list will have browsers for now).

Further changes can be made independently later if multi-desktop browser tests are desired.

BUG=129187

Review URL: https://chromiumcodereview.appspot.com/12210067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181878 0039d316-1c4b-4281-b951-d872f2087c98

Bug=None
Test=Manual, see steps below.

Test steps:
1) Start cycling using three fingers vertically on the track pad.
2) Ensure that lifting said fingers ends cycling. 

Review URL: https://chromiumcodereview.appspot.com/12209109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181877 0039d316-1c4b-4281-b951-d872f2087c98

Fix crash when DecrementCapturerCount() makes a delayed WasHidden() call during WebContentsImpl destruction.

Two parts:

1. WebContentsImpl::DecrementCapturerCount() will restore the true "WasHidden" status of the RenderWidgetHost once the counter reaches zero.  However, DecrementCapturerCount() can be called [indirectly] from the WebContentsImpl destructor.  In this case, it should not attempt to change/notify anything.

2. It's possible for ThumbnailTabHelper::WidgetHidden() to call ThumbnailTabHelper::UpdateThumbnailIfNecessary() with a NULL pointer.  Added a NULL check.

BUG=175275,130097


Review URL: https://chromiumcodereview.appspot.com/12209104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181876 0039d316-1c4b-4281-b951-d872f2087c98

This change also moves some UI code from chrome/browser/extensions into
/chrome/browser/ui/, and cleans up the app_launcher.* code.

BUG=159366


Review URL: https://chromiumcodereview.appspot.com/12095052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181875 0039d316-1c4b-4281-b951-d872f2087c98

Extended crash-on-hang-threads command line switch to
accept the unresponsive seconds. 

For example, if  --crash-on-hang-threads=UI:3:18,IO:3:18 is passed as
command line argument, ThreadWatcher crashes the browser if UI or IO
is not responsive for 18 seconds and the number of browser threads that
are responding is less than or equal to 3.

If there is no command line switch, it defaults to
"UI:3:18,IO:3:18,FILE:3,90" as the value in Canary and Dev.

It defaults to empty string in STABLE channel (i.e., we don't crash
the browser due to jankiness).

For beta channel it defaults to "UI:3:36,IO:3:36,FILE:3:180".

Deleted crash-on-hang-threads command line switch because
crash-on-hang-threads supports this.

R=jar@chromium.org
TEST=unit tests for ThreadWatcher

Review URL: https://chromiumcodereview.appspot.com/12183008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181874 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181873 0039d316-1c4b-4281-b951-d872f2087c98

http://trac.webkit.org/log/?rev=142523&stop_rev=142427&verbose=on

TBR=

BUG=


Review URL: https://chromiumcodereview.appspot.com/12223078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181872 0039d316-1c4b-4281-b951-d872f2087c98

Typo fix, style fix, unused #include/forward-declarations clean up,
adding const, reordering declarations properly, etc.

BUG=none.
TEST=it compiles.

Review URL: https://codereview.chromium.org/12229002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181871 0039d316-1c4b-4281-b951-d872f2087c98

The update script can now be easily updated to build new Chrome-specific
clang tools. The intended use for this is to make it easier to write
tools based on LibTooling to do large-scale refactorings across the
entire Chrome codebase.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/12223047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181870 0039d316-1c4b-4281-b951-d872f2087c98

Inside of TileManager.

BUG=175597


Review URL: https://chromiumcodereview.appspot.com/12220112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181869 0039d316-1c4b-4281-b951-d872f2087c98

page has started but hasn't finished loading.

BUG=175116


Review URL: https://chromiumcodereview.appspot.com/12220109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181868 0039d316-1c4b-4281-b951-d872f2087c98

When docked to the right the dev tool's web view would be cropped.

This bug was due to the way I implemented view layout in r181301.

The dev tool view was being correctly layed out but the subview was not.

To fix this I've removed the container view (DevToolsContainerView). The new code just use the view's auto layout instead.

BUG=173205
TEST=Docked the devtools to the right and opened a new browser window. Verified that the devtools view was correctly layed out.

Review URL: https://codereview.chromium.org/12226086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181867 0039d316-1c4b-4281-b951-d872f2087c98

Currently the Mac omnibox only allows up and down arrow when the popup is open.

With this CL up and down arrow work even if the popup is not open. This matches the behavior of Windows and ChromeOS.

BUG=174690
TEST=Typed something in the omnibox. Clicked on the web page to close the omnibox popup. Clicked in the omnibox and pressed down arrow. Verified that the omnibox popup was displayed.

Review URL: https://codereview.chromium.org/12221124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181866 0039d316-1c4b-4281-b951-d872f2087c98

Opening a link in a new tab from instant search results would cause the instant search result shadow to stay visible.

The problem was that there were three ways the shadow could be hidden:
   (1) -showPreview:..:drawDropShadow:NO
   (2) - hidePreview
   (3) - onActivateTabWithContents:
(1) and (2) correctly hid the shadow but (3) didn't.

Fix was consolidate all the code into (1) and have everyone call that method.

BUG=173778
TEST=See comment 7 in bug 173778 for an easy way to reproduce this bug. Verified that without my fix the shadow is not removed and with my fix the shadow is removed.

Review URL: https://codereview.chromium.org/12224052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181865 0039d316-1c4b-4281-b951-d872f2087c98

This ensures that while the screen is actively being captured,
the host system will not suspend, e.g. due to inactivity.

BUG=129912


Review URL: https://chromiumcodereview.appspot.com/12211101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181864 0039d316-1c4b-4281-b951-d872f2087c98

Patch originally by Sam Dutton <dutton@google.com>.

TBR=dutton@google.com

Review URL: https://chromiumcodereview.appspot.com/12220106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174479


Review URL: https://chromiumcodereview.appspot.com/12217121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181862 0039d316-1c4b-4281-b951-d872f2087c98