- 17 Jun, 2020 40 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I562f831f2a66596db52007f6b33f7543aa66c6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249044Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779156}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia0140e53dcd5f66735bcd44a6bca6395df28a177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248804Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779155}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f08a82b52dbf..de980231f62c 2020-06-16 csmartdalton@google.com Add a test for wide butt caps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I72bfc1e3e2bd6fab1a99a33c308d3c0bf54e43e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246273Reviewed-by:
-
Jihwan Marc Kim authored
Although * has been changed to be an invalid item for supported_origin, an error message still claims that "*" can be used. Bug: 1093394 Change-Id: I7f6399c91f13a799396ad4a4f628bfb8a7a582b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246008Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779153}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d49aa6fb8b3a..3eb899a1e52d 2020-06-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Iff8156def7441958a75f6a68c75e8f0cfebd7a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246911Reviewed-by:
-
Yu Han authored
Prior to this CL, an img with CSS height, width and empty alt text renders as nothing. This is wrong because [2] states that the img should be rendered as a replaced element with its intrinsic dimensions. The fix continues from the previous fix to the img title attribute by adding an additional check to see if the alt text is empty too. [1] https://html.spec.whatwg.org/multipage/rendering.html#images-3::represents-2 Bug: 753868 Change-Id: I9b127c54d9d5eb0f1e900dee47f24aff09f2ed8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238327 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#779151}
-
Li Lin authored
Bug: b/120678625 Test: manual test Change-Id: Ida9461c19e064cc9937d8be0c598b0d7599ea33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247240 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#779150}
-
Haiyang Pan authored
It looks like the timeout issue also occurs in gtest. See crbug.com/1093602#c6 Bug: 1093602 Change-Id: Idf46f3aecdc3907d9893192ac41fae01576a5c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247213 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#779149}
-
Nate Chapin authored
Bug: 1092889 Test: html/semantics/embedded-content/the-audio-element/audio-appendChild-to-inactive-document-crash.html Change-Id: I14d78db39b74d4593f3ed71b8440ca108fafdd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247120 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#779148}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bfd0b6e1. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" 458dc853 "WPT: Migrate content-visibility tests to wpt." 84f61c81 "Exclude non relevants reports from the COOP-opener-breakage tests." 90a6fd96 "Origin isolation: refactor and deduplicate web platform tests" d3784620 "Avoid memory allocation in AudioWorkletProcessor.process()" a3c30f62 "[TransformInterop] Always consider main-thread layers visible for cc" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id2fa0ad2169af35ec7b06ea60197eae3d3ca02cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248842Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779147}
-
Meredith Lane authored
Part of the ongoing effort to consolidate AXNodeObject and AXLayoutObject, with the eventual goal to remove AXLayoutObject entirely. This patch migrates the following methods to AXNodeObject: - Dropeffects - AriaDescribedByElements - AriaOwnsElements - SupportsARIADragging - SupportsARIAOwns - LiveRegionStatus - LiveRegionRelevant Written with aboxhall and chrishall AX-Relnotes: N/A Bug: 1093651 Change-Id: I4df071b43b5f61b397888ce58340e0e4df4c73ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239632Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#779146}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b1201523fc7a..9edc4da71626 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC calamity@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: calamity@google.com Change-Id: I48602f433eb34493482da55d6c9ea97969bea7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248907Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779145}
-
Andrew Grieve authored
This reverts commit f294b4bd. Reason for revert: Causing android-binary-size to fail with: ninja: error: unknown target '/chrome/android:monochrome_public_minimal_apks', did you mean 'chrome/android:monochrome_public_minimal_apks'? TBR=bpastene No-Try: True No-Presubmit: True Change-Id: I7b261a6ee4f849907130916854fdcb19e97bf528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248466Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#779144}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2a4ea4edc6fa03321984ced1e554a85428b23f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249165Reviewed-by:
-
tby authored
The next step for suggested files is to run an experiment to establish QPS. We want to change the ranking to make the results clearer. This CL does two things: 1. Splits 'files' in the chips into drive files and local files, to be ranked separately. 2. Changes the ranking to a simpler algorithm (chip_ranker.cc lines 144-end). This ranking always puts apps first, then drive files, then local files. The ranking determines how many of each type we show, but takes into a account a minimum number of results from each type. The current minimums mean we only ever decide on one chip by ranking, but we'll probably relax the minimums soon. Once we've decided on the minimums, I'll add back the tests removed here. Bug: 1034842 Change-Id: Id58614265e7a79d2761b08f3bffd0529b18c385d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245939Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#779142}
-
chrome://media-appDavid authored
Let errors that are thrown from the untrusted context message pipe when invoking delete & rename IPC get thrown to callee functions internally. Previously we were handling errors and returning a negative error code, however there are many errors (most are uncommon) that can occur and it makes more sense to handle them internally. Bug: b/156566771, 996088 Change-Id: I9427999b5944585135fdae663b4be46f29b58ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239427Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#779141}
-
Rachel Carpenter authored
This was only meant to be shown for a single release, M84. Bug: b/155141919 Change-Id: If6a276c8b45ed6dda5905cd1ff148341233fdad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245167Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#779140}
-
Victor Costan authored
DoesSupport() is synchronous, so it's incompatible with making QuotaClient a mojo interface. This CL removes it, to facilitate the transition to the Storage Service. DoesSupport() supports the TEMPORARY vs PERMANENT namespace split introduced in the Chrome-only (old) File System API. The API failed to achieve cross-browser adoption, and no other storage API adopted the namespace split. Therefore, all QuotaClients except for FileSystemQuotaClient have the same DoesSupport() implementation, stating that only the kTemporary type is selected. The non-trivial behavior in FileSystemQuotaClient is migrated to QuotaManager::RegisterClient() and FileSystemContext. At a high level, storage backends are responsible for declaring the quota types they support as they register with the QuotaManager. Bug: 1016065 Change-Id: I92ba64ae720aeadfcc6055b3e9ed3572d7799204 Tbr: avi, falken Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241955Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#779139}
-
Wenyu Fu authored
This reverts commit bce8a024. Reason for revert: <Abandon as the fix for the test is landed lately> Change-Id: I7b378bf37dc92906e6fc1c3ece52c737e78d670f TBR=xingliu@chromium.org Change-Id: I7b378bf37dc92906e6fc1c3ece52c737e78d670f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247351 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#779138}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3fe84b5b33b7..3f4f35661151 2020-06-16 natlee@microsoft.com Fix D3D12 Device Initialize calls NextSerial 2020-06-16 bryan.bernhart@intel.com D3D12: Workaround incorrect debug layer error handling 2020-06-16 rharrison@chromium.org Use Tint public header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1094477 Tbr: cwallez@google.com Change-Id: I5968760e43102f1030e7070ec84894fddf8efbca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246906Reviewed-by:
-
Andrey Shponko authored
When popups are removed not in ther order they were added we need to move them down even in inverse mode. This might happen if popups have different TTL for example if some of them require interaction. Change-Id: Id475e5d3c456af7ab09e885767f3eda2d0638e03 Bug: 1009374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829699 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Auto-Submit: Andrey Shponko <ashponko@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#779136}
-
Hirokazu Honda authored
When VideoEncoderClient creates DecoderBuffer from a bitstream encoded by VideoEncodeAccelerator, it sets the size of DecoderBuffer to the entire size of the underlying buffer. This CL fixes the bug; we must rather set the payload size specified by metadata given in BitstreamBufferReady(). Bug: 1045825 Test: video_encode_accelerator_tests on eve Change-Id: Ie3199357c8524143a662973f1475e7a13494434c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247942 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#779135}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/b3483d68abd7..ea4aec9cfcd7 2020-06-16 jophba@chromium.org Apply code review feedback for capture_reccs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I0102908f26c9b751f6ad7122a658f88db7ed6a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248897Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592330368-995f9d40f9200b48ea66f14ee9d22a1bdedc987c.profdata to chrome-mac-master-1592351803-853e31be24ca6a2ab7be452c8083d82053228cd8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7fc23cf38a784e0a344fe343d38bf8a42d465a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246910Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates FrameHostMsg_UpdateState to UpdateState in FrameHost interface. Bug: 1093919 TEST=RenderViewImplTest.OnNavStateChanged. Change-Id: Ic0bff0c4b03dc10817a3e5e9c994bb6ff7939362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246005Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#779132}
-
Saho Kobayashi authored
Add content change types to mojom to support CONTENT_CHANGE_TYPE_STATE_DESCRIPTION. Android side CL is ag/11788321 crrev/c/2235584 is reverted, because content change types should be int list property, not int property. AX-Relnotes: n/a. Bug: b/154433831 Change-Id: Ie305a99a443079719fc931863c29064699db9764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245945Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Saho Kobayashi <sahok@chromium.org> Cr-Commit-Position: refs/heads/master@{#779131}
-
Gavin Williams authored
This element will be used in CrOS Print Preview to display a printer icon layered with a colored status badge. This element consist of 3 layers. The first layer is a printer icon. The second layer is the background badge which is a circle whose color matches the current background. The third layer is the status badge which is a circle inside the background badge whose color will indicate the status of a the printer. Bug: 1059607 Change-Id: Iafb9b961514f5408c5999dbd71ac82b0ccf60e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234125 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#779130}
-
Zach Trudo authored
ReportQueues will need to respect policy by only storing events when allowed by policy. Added the ability to provide a callback to ReportQueueConfiguration for denying ReportQueue Add calls. Also - minor cleanup deleting unused classes. Bug: chromium:1078512 Change-Id: I1966a94cc40a19c5be065c5e3ff95d0338db231b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241344 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Auto-Submit: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#779129}
-
Frank Liberato authored
This reverts commit 3a58dbb7. Reason for revert: might be causing failures such as: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8877299825241158736/+/steps/unit_tests/0/logs/Deterministic_failure:_PasswordSaveUpdateWithAccountStoreViewTest.OnThemesChangedShouldNotCrashForFederatedCredentials__status_CRASH_/0 Change-Id: I94fc317d821105d0ef1d48a796027f6ad710e4c4 TBR: vasilii,treib,bcwhite,twellington,mamir Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249041Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#779128}
-
Andrew Grieve authored
Makes them easier to rename / add / remove. Bug: 1095654 Change-Id: I1af1211eef4a8b305c7f9ed5bf81441abf0aa756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247092Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#779127}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2e94de596ef3..4db954eec112 2020-06-16 hbos@webrtc.org Add RTC_EXPORT to webrtc::Resource so that it can be used in Chrome. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3705e8bb9a6af805399899d3ce1d0463196ec9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248904Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ec3508aaef7a..f08a82b52dbf 2020-06-16 johnstiles@google.com Return tuple from GrConvexPolyEffect::Make denoting success or failure. 2020-06-16 brianosman@google.com Support viewing/changing backend shaders in Viewer 2020-06-16 fmalita@chromium.org [skottie] Simplify SkColor conversion 2020-06-16 brianosman@google.com Fix caching of HLSL in D3D backend 2020-06-16 adlai@google.com Elevate the target list of Ganesh tasks to base class If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I9586a3977a46c10759f164e742fca00b536362fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248919Reviewed-by:
-
Moe Ahmadi authored
Adds an entry for the WebUI NTP experiment on Desktop replacing the non-WebUI (aka local or instant) NTP. The field trial config entry enables NtpWebUI and DisableSearchSuggestChips features. The CL modifies local NTP specific tests to explicitly navigate to the local NTP (chrome-search://local-ntp/local-ntp.html) rather than chrome://newtab/ which displays the WebUI NTP (chrome://new-tab-page). It also adjusts the expectations in other tests to expect an NTP upon opening a new tab but not necessarily an "instant" NTP. Bug: 1075755 Change-Id: I73e48c058e294a4ce8ca22a0b300c2680fdc8795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242194 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#779124}
-
alex linker authored
BUG=1052947 Change-Id: Ie9bfa90de05239a567b4803a27f53d300d1a1639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060393 Commit-Queue: Alex Linker <ajlinker@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#779123}
-
Steven Bennetts authored
This CL moves network_health.mojom to chromeos/services to address two issues: 1. The way that the current network_health_resources.grd provides network_health.mojom.html creates a relative path situation that creates a subtle html parsing error (crbug.com/1093958). 2. We need a shared network-health component for oobe and Settings integration. That is added here in ui/webui/resources/cr_components/ and needs access to network_health.mojom (but is not allowed access to src/chrome). This CL addresses both issues to make that future dependency more visible, even though the "shared" component is currently only used in the debugging UI chrome://network. Bug: 1093958, 1076178 Change-Id: I10b9c25a2bf437d0c264213b617b313d0fc4e933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240903 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#779122}
-
Regan Hsu authored
* Narrow mode search icon spacing aligns with search input icon spacing. * No search results aligns with search input text. Screenshot: https://screenshot.googleplex.com/cMF7bYjHk7g results aligned https://screenshot.googleplex.com/DJuWA95Bmhf no results aligned Fixed: 1090166 Change-Id: I6d4ea54e0f54c1ad2f0ab8b7249947c862a39b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242842Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
-
Tom Anderson authored
This CL connection/capabilities checks when making requests, getting extensions, or waiting for replies. This reduces the amount of checks clients have to make. In particular, clients don't have to check the connection state when making requests. Instead, the request will just generate an empty reply. This fixes a crash due to missing checks when the connection has gone down. This behavior also applies to getting extensions. If an extension was not available, the extension object was nullptr. Now the object is always valid, but makes no-op requests. extension->present() is used to check if the extension is available. The extension getters now return references instead of pointers. Finally, the connection setup data is default-initialized if the connection was never set up. The setup data getters now return references instead of pointers. BUG=1066670,1092691 R=sky Change-Id: I9fd1e9557936a939a6428e959abdd17d55c18726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243841 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#779120}
-
Harald Alvestrand authored
Bug: chromium:840659 Change-Id: Ic59d52e78cd145e21e572d196e30d2fbe60375ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248189Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#779119}
-
Rachel Carpenter authored
Creates a field trial to control the first run experience of the Help App. The trial is client controlled because the first run experience happens before a variations seed is available. The trial group chosen on first run is persisted to local state prefs and reused on subsequent runs. This keeps the behaviour of the help app stable between opens. Local state prefs can be reset via powerwash which will results in re-randomisation, but this also sends the user through the first-run flow again so their experience should be consistent from the end of the OOBE (out-of-box experience) onwards. Tracking bug: b/158540665 Launch bug: https://crbug.com/1042109 Tested: Manually, running through the first run experience a few times to determine that the group was randomly selected and correct experience happened for the given group. Bug: b/138969582 Change-Id: Id843af832c0106fecfd6e4544f5c16fd5cb4933c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245158Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#779118}
-
Peter Kasting authored
Without this, users have to instantiate an ImageSkia just to see what size of an image they have. Bug: none Change-Id: I78f07cbe04b92a62a3932432b8f73f80b7db6857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248891 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
