- 28 Sep, 2015 40 commits
-
-
thestig authored
- Pick up latest release - Adjust build files - Update README.chromium BUG=497302 Review URL: https://codereview.chromium.org/1367323002 Cr-Commit-Position: refs/heads/master@{#351207}
-
michaelpg authored
Allow MD Settings pages to specify policy indicator icon types. BUG=521791 Review URL: https://codereview.chromium.org/1376553002 Cr-Commit-Position: refs/heads/master@{#351206}
-
davidben authored
It's believed that the majority (over 80%) of TLS version downgrades remaining come from out-of-date IIS servers with the AES-GCM bug (crbug/433406). From probing servers some time back, it appears that, of those, the IIS 8.0 ones prefer TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384 over the broken GCMs. Adding that cipher may drive the number down enough to be worthwhile. Experimentally add this cipher to the list to see what it does to the metrics. It may yet be worth trying to drop the fallback without this workaround, since the server-side fix is so easy, but run with this a bit to get numbers on what the options are. As we otherwise would not have exposed a new legacy CBC mode cipher, this cipher is placed on the deprecated cipher fallback. This way we can continue to monitor things which need it and hopefully eventually phase it out once the install-base has taken their updates. BUG=536200 Review URL: https://codereview.chromium.org/1366253005 Cr-Commit-Position: refs/heads/master@{#351205}
-
nasko authored
During cross-process navigation, it is possible to create a LocalFrame that doesn't have a FrameView, since the latter gets created at the time a document commits. Since the commit in this case happens later in time, the current code crashes as it expects the view to be there. BUG=357747 Review URL: https://codereview.chromium.org/1374783005 Cr-Commit-Position: refs/heads/master@{#351204}
-
pfeldman authored
BUG=529471 Review URL: https://codereview.chromium.org/1369063002 Cr-Commit-Position: refs/heads/master@{#351203}
-
andybons authored
+ Turn on precompiled headers on Mac. + Change the toolchains to use asmflags instead of cflags and cflags_c. + Remove a TODO to hardcode the Mac SDK since the location of the SDK is not always guaranteed (on bots, for example). + GN: .S or .asm files no longer trigger cflags or cflags_c to be written to the ninja file. BUG=none Review URL: https://codereview.chromium.org/1368223002 Cr-Commit-Position: refs/heads/master@{#351202}
-
skobes authored
This adds a check to handle the case where the bounds rect passed to Paint() is too small to fully contain the border pieces. In this case we skip the border and fill the entire bounds rect with the center image. This fixes visual glitches in scrollbar painting when the track is short (we incorrectly paint a few pixels of track on top of the stepper buttons). BUG=536234 Review URL: https://codereview.chromium.org/1365503007 Cr-Commit-Position: refs/heads/master@{#351201}
-
lukasza authored
This CL replaces ViewMsg_GetSerializedHtmlDataForCurrentPageWithLocalLinks and ViewHostMsg_SendSerializedHtmlData IPC messages by their frame-oriented equivalents: FrameMsg_GetSerializedHtmlDataWithLocalLinks and FrameHostMsg_SerializedHtmlDataWithLocalLinksResponse. BUG=526786 Review URL: https://codereview.chromium.org/1320453004 Cr-Commit-Position: refs/heads/master@{#351200}
-
asvitkine authored
This CL adds the following: - Two new APIs on FeatureList to be used during initialization. One to associate a field trial for reporting purposes when the feature is forced from the command line and the other to override the feature state via a field trial. - Passing the FeatureList instance to VariationsService during browser start up. - Extension of VariationsService (and associated proto changes) to invoke the two above APIs, when processing variations with the new proto fields. - A new API on FieldTrial to get the group name of a field trial without activating it, used by VariationsService when association a field trial. BUG=526169 Review URL: https://codereview.chromium.org/1306653004 Cr-Commit-Position: refs/heads/master@{#351199}
-
rockot authored
URLRequests can be canceled (e.g. on destruction) before they're ever started, meaning that a NetworkDelegate may be notified of request completion without ever being notified of request start. extensions::ProcessManager was making the incorrect assumption that this couldn't happen (i.e. that a completion notification must always follow a corresponding start notification), and was indiscriminately decrementing keepalive count on all URLRequest completion notifications. This CL fixes the glitch. BUG=535716 R=rdevlin.cronin@chromium.org Review URL: https://codereview.chromium.org/1366393002 Cr-Commit-Position: refs/heads/master@{#351198}
-
rkc authored
To be able to reuse the bluetooth DBus clients on linux, we need to be able to separate them out from DBusThreadManager and move them out of //chromeos. This CL introduces no functional change but instead only refactors the code so we now have a BluezDbusManager that handles a Bluetooth specific DBus client bundle to create all the bluetooth related DBus clients. We will be able to extend this code to add a Linux specific BluezDbusManager implementation, allowing us to reuse all these DBus clients on Linux instead of copy/pasting the code. R=armansito@chromium.org, stevenjb@chromium.org BUG=522663 Review URL: https://codereview.chromium.org/1347193004 Cr-Commit-Position: refs/heads/master@{#351197}
-
aiolos authored
Switch to using binary_manager for the crash_service executable, eliminating downloads of this binary from cloud storage. (A follow-on CL will likely forbid the bots from downloading this and other executables from cloud storage entirely, rather than continuing to use this as a fallback path.) Telemetry's isolates are currently specified fairly differently for the GYP and GN builds; other CLs underway will unify their specification more. Follow up CL's will be needed to add the client config to gpu's tests. authors=kbr@,aiolos@ BUG=466877 Review URL: https://codereview.chromium.org/1361523003 Cr-Commit-Position: refs/heads/master@{#351196}
-
felt authored
SSLErrorClassification can be shared cross-platform if the Chrome-specific captive portal logic is moved to its own helper. This also is a nice clean separation of purposes, since the captive portal logic was fairly disjoint from the other work being done in SSLErrorClassification. Now the captive portal logic is handled as a metrics helper. I also made the ownership of the metrics helper clearer by changing to use a scoped_ptr. BUG=488673 R=estark@chromium.org TBR=mattm@chromium.org Review URL: https://codereview.chromium.org/1365733005 Cr-Commit-Position: refs/heads/master@{#351195}
-
gavinp authored
This was intended to help debug issue 424562 (see Issue 702473009 for more details), and it isn't needed any more. R=thakis@chromium.org,pasko@chromium.org,thestig@chromium.org BUG=424562 Review URL: https://codereview.chromium.org/1372113002 Cr-Commit-Position: refs/heads/master@{#351194}
-
mmenke authored
BUG=535601 Review URL: https://codereview.chromium.org/1375733002 Cr-Commit-Position: refs/heads/master@{#351193}
-
michaelbai authored
BUG=532598 Review URL: https://codereview.chromium.org/1360313004 Cr-Commit-Position: refs/heads/master@{#351192}
-
dbeam authored
R=creis@chromium.org BUG=535059,385352 Review URL: https://codereview.chromium.org/1367343002 Cr-Commit-Position: refs/heads/master@{#351191}
-
michaelbai authored
Instead of using the locale zip in dep graph, alternative locale zip could be used when building APK. - Using dedicated variables in all_dependencies_settings for locale zip - Not using locale zip from all_dependences_settings if alternative file specified. - Make resources_zip_path in locale_pak_resources.gypi setable, so the file could be used as alternative lcoale zip for APK. BUG=535379 Review URL: https://codereview.chromium.org/1357423011 Cr-Commit-Position: refs/heads/master@{#351190}
-
tommycli authored
Previously, if a user navigated to a subpage directly via URL, i.e. chrome://settings/searchEngines, and then tried to close that subpage, the animation would not work correctly. This patch fixes that issue. BUG=535013 Review URL: https://codereview.chromium.org/1372713002 Cr-Commit-Position: refs/heads/master@{#351189}
-
andybons authored
$ git log 2eb98d819..772999bc2 --date=short --format='%ad %ae %s' 2015-09-28 andybons fix comment typo in BUILD.gn 2015-09-28 andybons Update build file to use asmflags instead of cflags. BUG=none R=brettw@chromium.org CC=ajm@google.com Review URL: https://codereview.chromium.org/1374003002 Cr-Commit-Position: refs/heads/master@{#351188}
-
guoweis authored
This change implements FilteringNetworkManager which wraps IpcNetworkManager from PeerConnectionDependencyFactory and exposes rtc::NetworkManager to WebRTC. P2PNetworkManager will check mic/camera permissions and only if at least one of them is granted, the full network list from IpcNetworkManager is provided to WebRTC calls. Otherwise, WebRTC can only bind to the "any" address. Currently, this is disabled by default and can be enabled with a finch experiment "WebRTC-LocalIPPermissionCheck". UMAs are added to track how many calls are impacted (either denied due to lack of permissions, or call set up time delayed) before fully turned on. Test cases added for FilteringNetworkManager to test its handling of api StartUpdating() and asynchronous signals such as permission status update and IpcNetworkManager's SignalNetworksChanged in different order. When multiple_routes option is not requested, EmptyNetworkManager is used instead which simply just returns BLOCKED as permission status which will cause WebRTC to use the "any" address networks. This depends on the ongoing CL for MediaPermissionDispatcher https://codereview.chromium.org/1351443005/ In my test with my dev machine, I don't see the setup time has been increased by this call change and we have UMA to check that too. BUG=520101 Review URL: https://codereview.chromium.org/1349823004 Cr-Commit-Position: refs/heads/master@{#351187}
-
aurimas authored
BUG=None Review URL: https://codereview.chromium.org/1374533003 Cr-Commit-Position: refs/heads/master@{#351186}
-
nywang authored
The existing PropertySet::Get function is asynchronous. This CL adds the synchronous version of PropertySet::Get. It is defined as PropertySet::GetAndBlock. Also fix some typos and indent problems in previous introduced SetAndBlock(). BUG=https://b.corp.google.com/u/0/issues/24131409 TEST=manually tested Review URL: https://codereview.chromium.org/1368713002 Cr-Commit-Position: refs/heads/master@{#351185}
-
apacible authored
This changes adds a new entry point for the Media Router dialog by adding a "Cast..." menu item into the overflow/wrench menu as well as page/audio/video contextual menus. This new menu item is currently only surfaced if Media Router is enabled (--enable-media-router) and if the user is not in Incognito mode. Once Media Router is re-enabled for Incognito, that check should be removed. BUG=534841 Review URL: https://codereview.chromium.org/1360323002 Cr-Commit-Position: refs/heads/master@{#351184}
-
reillyg authored
On OS X Snow Leopard and Lion (currently supported by Chrome) the kIOHIDReportDescriptorKey is not available as it is in later versions of the operating system. Since we are also unable to get the device's report descriptor on Windows it seems okay to just ignore the failure. BUG=479210 Review URL: https://codereview.chromium.org/1373923003 Cr-Commit-Position: refs/heads/master@{#351183}
-
aurimas authored
Relanding https://codereview.chromium.org/1364043003/ after fixing Svelte crash and CustomTabs test failure. - Svelte was crashing due to getActivityTab being null when onOverviewModeFinishedHiding is called. - CustomTabsActivity sets the status bar color explicitly and does not need to inherit setStatusBarColor calls from ChromeActivity. BUG=535235,536698 Review URL: https://codereview.chromium.org/1375693002 Cr-Commit-Position: refs/heads/master@{#351182}
-
vmpstr authored
This patch creates a solid color tiling that pretends that it's not solid, so that tiles can be created. This ensures that we don't try to allocate resources/staging buffers for the tiles, and avoid a crash. BUG=534911 R=danakj CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1365793003 Cr-Commit-Position: refs/heads/master@{#351181}
-
jamiewalch authored
One of the design considerations in https://codereview.chromium.org/1358173005/ was that using base.copyWithoutNullFields made the code future-proof if new options are added. This unit test ensures that that holds true and also improves some of the existing unit tests to catch some obvious errors. Review URL: https://codereview.chromium.org/1366093003 Cr-Commit-Position: refs/heads/master@{#351180}
-
jkarlin authored
BUG=490488 Review URL: https://codereview.chromium.org/1376533002 Cr-Commit-Position: refs/heads/master@{#351179}
-
sdefresne authored
Xcode 7.0 has been publicly released and iOS downstream requires it to build so use the iOS 9.0 SDK with Xcode 7.0 for the bots upstream. Run the tests on all the currently supported iOS version 7.1, 8.3 and 9.0. BUG=516606 Review URL: https://codereview.chromium.org/1369243002 Cr-Commit-Position: refs/heads/master@{#351178}
-
eugenebut authored
This change is needed for testing recoverable SSL interstitials for WKWebView. BUG=462427 Review URL: https://codereview.chromium.org/1358033002 Cr-Commit-Position: refs/heads/master@{#351177}
-
ericrk authored
The memory dump provider for OutputSurface was registered on the client thread, but could be unregistered on the main thread in cases when the client was cleaned up before the destructor was called (very common). Move the unregistration code to the parallel of the registration code, so that both only when appropriate, on the client thread. BUG=536824 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1371163002 Cr-Commit-Position: refs/heads/master@{#351176}
-
lambroslambrou authored
Tints all action-bar menu icons so they are the same color as the system icons (home/up button and three-dots overflow icon). Review URL: https://codereview.chromium.org/1369653002 Cr-Commit-Position: refs/heads/master@{#351175}
-
yzshen authored
These are types that we've seen on page_cycler.typical_25. BUG= Review URL: https://codereview.chromium.org/1372273002 Cr-Commit-Position: refs/heads/master@{#351174}
-
palmer authored
The "N cookies from this site" link gets updated in real time (to update the value of N). That causes the link to lose click events and its tab index. Solve the problem by only updating the link text, rather than destroying and rebuilding the entire layout. BUG=535587 Review URL: https://codereview.chromium.org/1372453002 Cr-Commit-Position: refs/heads/master@{#351173}
-
sclittle authored
This allows users and integration tests to use the Data Saver API, but override the list of Data Reduction Proxies to use for HTTP proxies with a custom list. BUG=526827 Review URL: https://codereview.chromium.org/1345523005 Cr-Commit-Position: refs/heads/master@{#351172}
-
pavely authored
Revert of scheduler: Add a base directory (patchset #4 id:60001 of https://codereview.chromium.org/1374653003/ ) Reason for revert: Change causes compile failure: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/6135 Original issue's description: > scheduler: Add a base directory > > This patch moves the more fundamental scheduling primitives (e.g., > TaskQueueManager) to a separate base/ directory. This makes the layered > architecture of the scheduler more obvious and reduces the likelihood of > accidentally introducing layering violations. > > With this refactoring, the overall dependencies are: > > +------+ > | base | > +------+ > ^ > | > +-------+ +------+ > | child |<----| test | > +-------+ +------+ > ^ ^ ^ ^ > | | | | > | '----------|-|---. > | .----------' '-. | > | | | | > +----------+ +-------+ > | renderer | | ppapi | > +----------+ +-------+ > > Committed: https://crrev.com/516bee16e9437521cdd20a78d683f9dbaf35df3e > Cr-Commit-Position: refs/heads/master@{#351109} TBR=jochen@chromium.org,alexclarke@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1370343002 Cr-Commit-Position: refs/heads/master@{#351171}
-
mmenke authored
Revert of Small fix for URLRequestJobs when entering suspending mode. (patchset #3 id:40001 of https://codereview.chromium.org/1366203004/ ) Reason for revert: Seeing odd failures that make no sense on android bots that may somehow be due to this CL...Trying a revert. :( Original issue's description: > Small fix for URLRequestJobs when entering suspending mode. > > When entering suspend mode, there was a window of time between > when the request was canceled, and when the NetworkDelegate was > informed it was canceled. This didn't exist for other cancellation > paths, and if an embedder invoked certain callbacks in this period, > thinking the request was still live, crashes could result. > > BUG=289715 > > Committed: https://crrev.com/05608da225e05b4a20da3f4ca0cb9a5276fcf3d6 > Cr-Commit-Position: refs/heads/master@{#350938} TBR=davidben@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=289715 Review URL: https://codereview.chromium.org/1372213003 Cr-Commit-Position: refs/heads/master@{#351170}
-
dpranke authored
R=prasadv@chromium.org BUG=432959 Review URL: https://codereview.chromium.org/1375693003 Cr-Commit-Position: refs/heads/master@{#351169}
-
estade authored
BUG=520266 Review URL: https://codereview.chromium.org/1364913005 Cr-Commit-Position: refs/heads/master@{#351168}
-