GitLab

BUG=422869

Review URL: https://codereview.chromium.org/898443004

Cr-Commit-Position: refs/heads/master@{#314286}

In FindPreviousFocusableViewImpl, in the recursive call to visit the
sibling node, preserves can_go_up, rather than forcing it to true.

Added FocusTraversalNonFocusableTest (test the pathological case
outlined in the bug report).

Also fixed existing comment in test file describing the view hierarchy
to match reality.

BUG=453699
BUG=438425
BUG=451140

Review URL: https://codereview.chromium.org/886033002

Cr-Commit-Position: refs/heads/master@{#314285}

BUG=312380

Review URL: https://codereview.chromium.org/881733002

Cr-Commit-Position: refs/heads/master@{#314284}

In nacl_helper_nonsfi, getpid() is prohibited to be called by seccomp-bpf
(will be implemented somehow soon). So, base::GetCurrentProcID() used in IPC
library, which uses getpid(), would cause a SIGSYS crashing.
As, in nacl_helper_nonsfi, PID is actually not used, so this CL replaces it
with -1 (dummy PID).

Note that the more generic CL crrev.com/695353005, which replaces PID with
dummy also on Linux platforms, was landed once, but reverted due to it was
still in use (crbug.com/441312). This CL extracts only Non-SFI related
part to avoid breakage.

TEST=Ran bots.
BUG=358465, 441312
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm

Review URL: https://codereview.chromium.org/879303004

Cr-Commit-Position: refs/heads/master@{#314283}

The visible viewport is the area of the window that is visible. For example,
when the on-screen keyboard obscures part of the window we shrink the visible
viewport to allow the page to "overscroll" the obscured area into view.
When we resize the window, the visible viewport should be resized along
with it.

Also renamed ResizeSynchronously since it sets the rect, not just the size.
Same for initial_pos_.

This was breaking the
css3/viewport-percentage-lengths/viewport-percentage-lengths-resize.html
layout test upon turning on virtual-viewport.

BUG=444952

Review URL: https://codereview.chromium.org/894193003

Cr-Commit-Position: refs/heads/master@{#314282}

Adds support for automatic on-line reconfiguration of the VP8 software
encoder whenever the video frame size changes.  libvpx supports
shrinking frame sizes without tearing down the encoder, but growing
frames sizes still requires a full tear-down and re-creation.

Most of this change involves adding extensive unit testing to confirm
media/cast is now capable of handling variable frames sizes end-to-end.
In addition, the cast_sender_app and cast_receiver_app diagnostic tools
have been updated.

An upcoming change will eliminate the width and height properties from
media::cast::VideoSenderConfig, which are both being ignored now.

BUG=451277
TBR=hubbe@chromium.org

Review URL: https://codereview.chromium.org/892383002

Cr-Commit-Position: refs/heads/master@{#314281}

See bug for details. This patch makes it so that we fire
the events  IA2_EVENT_TEXT_INSERTED and IA2_EVENT_TEXT_REMOVED
when the children referenced by the embedded object characters
changed, not just when the text changed.

This patch also avoids incorrectly firing these same two
events on a newly-created node.

BUG=425861

Review URL: https://codereview.chromium.org/859133003

Cr-Commit-Position: refs/heads/master@{#314280}

The class will be used as the base class of all metadata provider.  The class has abstrct
getImpl method and sub-class of the class should inherit the function. The class
also contains MetadataProviderCache that is a sub-class of MetadataCacheSet, and
caches the result of getImpl method.

BUG=410766
TEST=FileManagerJsTest.NewMetadataProvider

Review URL: https://codereview.chromium.org/894283002

Cr-Commit-Position: refs/heads/master@{#314279}

Currently most objects in the Chromoting Webapp doesn't unhook events until
the page is unloaded.  This introduces unintentional coupling between an object's
lifetime and the app's lifetime.

This CL implements a lightweight utility class to make unhooking listeners easier.

BUG=454552

Review URL: https://codereview.chromium.org/863863003

Cr-Commit-Position: refs/heads/master@{#314278}

BUG=454335

Review URL: https://codereview.chromium.org/863863005

Cr-Commit-Position: refs/heads/master@{#314277}

BUG=452608
TEST=existing unit tests

Review URL: https://codereview.chromium.org/890293002

Cr-Commit-Position: refs/heads/master@{#314276}

A previous change to skip displaying zoom levels for host and scheme
zoom changes caused host-only zoom changes to be skipped due to surprise
case fallthrough. This adds a break so the correct zoom settings are
displayed.

BUG=454254

Review URL: https://codereview.chromium.org/879333003

Cr-Commit-Position: refs/heads/master@{#314275}

Revert of offset namespace ids (patchset #7 id:120001 of https://codereview.chromium.org/881253004/)

Reason for revert:
Tests now only work if they ran in the "right" order. DOMStorageContextImplTest.Basic fails if the tests are shuffled:

content_unittests --gtest_filter=DOMStorageContextImplTest.*:DOMStorageAreaTest.* --gtest_shuffle

Original issue's description:
> [DOMStorage] Offset the session storage namespace ids generated by different contexts to help identify when an id from one is mistakenly used in another.
>
> Committed: https://crrev.com/36dcef3da5317365ab95e50a5f6b7fa98ada1d5e
> Cr-Commit-Position: refs/heads/master@{#314256}

TBR=jsbell@chromium.org,michaeln@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/896733002

Cr-Commit-Position: refs/heads/master@{#314274}

* Create a new skeleton InfoBarDelegate for app banners containing
  information about apps defined by web manifests.

* Displays an infobar when the user navigates to a page
  with a manifest.

* Adds a string for "Add to homescreen" for the new infobar.

BUG=453170

Review URL: https://codereview.chromium.org/893073002

Cr-Commit-Position: refs/heads/master@{#314273}

This feature should exist for hosted apps, currently there is no option
to search a page. Instead of removing these two menu items, they are now
hidden if the app that is currently focussed is not a hosted app.

BUG=450834

Review URL: https://codereview.chromium.org/864153003

Cr-Commit-Position: refs/heads/master@{#314272}

BUG=410766
TEST=None
R=yawano@chromium.org

Review URL: https://codereview.chromium.org/895723003

Cr-Commit-Position: refs/heads/master@{#314271}

Currently the startRequests method of metadata models has a responsibility to
create requests as well as to mark the cache as loading.

In the following patch, we need to apply the requests that are generated by
another cache set. Thus the method should be split into two methods (one is for
creating requests and another is for marking cache as loading).

BUG=410766
TEST=FileManagerJsTest.MetadataCacheSet,FileManagerJsTest.MetadataCacheItem
R=yawano@chromium.org

Review URL: https://codereview.chromium.org/895783003

Cr-Commit-Position: refs/heads/master@{#314270}

The trees this composites may contain SurfaceLayers, so they have to be aggregated into a Display before being drawn. Also move OnscreenDisplayClient and SurfaceDisplayOutputSurface into cc/surfaces/ so they can be used by ui/compositor.

Review URL: https://codereview.chromium.org/888783002

Cr-Commit-Position: refs/heads/master@{#314269}

On Mac, events need to be mapped to "Action" messages by an NSResponder
to obey platform behaviour and user customizations (e.g. a "Home"
keypress should be interpreted as beginning of document, not beginning
of line). Action messages are also the manner by which a user on Mac can
add custom keybindings, by making entries in
~/Library/KeyBindings/DefaultKeyBinding.dict

ActionMessages map well to editing commands for text fields, but not as
well for other controls. For example, MenuController needs to catch the
action message "cancel:" to handle the escape key.

The approach in this CL is for BridgedContentView, an NSResponder, to
map Action Messages to the editing command as well as the KeyCode that
toolkit-views expects for that action.

To test, textfield_unittests are updated to allow two kinds of event
dispatch. Before this CL, all the TextfieldTest views_unittests were
already passing on a toolkit-views Mac build. This is because the tests
send KeyCodes directly to the InputMethod rather than to the window.
However, this meant that action messages didn't come into play.

To test "real" keystrokes on Mac and get good coverage of the action
message overloads, the ui::test::EventGenerator is now used in
textfield_unittest.cc to generate platform-specific events that are
dispatched to the Window. Previously, all keyboard events were
redirected to the InputMethod.

BUG=378134

Review URL: https://codereview.chromium.org/879253002

Cr-Commit-Position: refs/heads/master@{#314268}

Revert of [ServiceWorker] Re-enable service_worker.service_worker perf test. (patchset #1 id:1 of https://codereview.chromium.org/794013002/)

Reason for revert:
Still flaky on Mac

Original issue's description:
> [ServiceWorker] Re-enable service_worker.service_worker perf test.
>
> This test was disabled because of the lack of avconv in the try bots.
>
> BUG=433943
>
> Committed: https://crrev.com/78e4cdcf2b533033c14e342e5d83440d3b5e749e
> Cr-Commit-Position: refs/heads/master@{#307851}

TBR=tonyg@chromium.org,horo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=433943

Review URL: https://codereview.chromium.org/883013005

Cr-Commit-Position: refs/heads/master@{#314267}

This changes the app banner content setting from being a dictionary of
app key to bool, to being a dictionary of app key to dictionary.

The sub dictionary contains one bool for whether the banner has been
blocked, and also a list of dates. The list of dates will contain at
most 14 dates, and will be used to record distinct dates on which the
banner could have been shown.

This is to allow more complex triggering. The goal is to actually show
banners if they could otherwise have been shown on a previous date in
the last 14 days.

Note the complex triggering is not currently used.

BUG=452825

Review URL: https://codereview.chromium.org/884373002

Cr-Commit-Position: refs/heads/master@{#314266}

Despite this not being the OSX way, users are complaining that Enter doesn't
activate the buttons in the menu, because it used to. I think the easiest
way is to wrap all buttons in a view that responds to Enter, and activates
the button accordingly.

BUG=454467
TEST=Start Chrome with --enable-new-avatar-menu. Open the avatar bubble and
tab through items. Pressing enter should perform the button's action.

Review URL: https://codereview.chromium.org/890143005

Cr-Commit-Position: refs/heads/master@{#314265}

NOTRY=true
TBR=dyen@chromium.org
BUG=453131

Review URL: https://codereview.chromium.org/896583004

Cr-Commit-Position: refs/heads/master@{#314264}

BUG=453571
R=inferno@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/864123003

Cr-Commit-Position: refs/heads/master@{#314263}

TBR=dyen@chromium.org
NOTRY=true
BUG=453131

Review URL: https://codereview.chromium.org/870203004

Cr-Commit-Position: refs/heads/master@{#314262}

BUG=452727

Review URL: https://codereview.chromium.org/882813006

Cr-Commit-Position: refs/heads/master@{#314261}

Revert of Revert of Report viewport memory and timing correctly for Slimming Paint. (patchset #1 id:1 of https://codereview.chromium.org/885753004/)

Reason for revert:
This CL wasn't the culprit after all, it seems.

Original issue's description:
> Revert of Report viewport memory and timing correctly for Slimming Paint. (patchset #3 id:60001 of https://codereview.chromium.org/867803003/)
>
> Reason for revert:
> Reverting due to https://crbug.com/453131
>
> Original issue's description:
> > Report viewport memory and timing correctly for Slimming Paint.
> >
> > The rasterize_and_record benchmark was not using data from the
> > DisplayItemList. Now it does.
> >
> > R=ajuma@chromium.org,vmpstr@chromium.org
> > BUG=451448
> >
> > Committed: https://crrev.com/c76f528131949d7fe60b7facf1e7b40362aacfd5
> > Cr-Commit-Position: refs/heads/master@{#313420}
>
> TBR=ajuma@chromium.org,vmpstr@chromium.org,schenney@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=451448
>
> Committed: https://crrev.com/fae3da55913e8e163faabf787b26791a96938ab7
> Cr-Commit-Position: refs/heads/master@{#314226}

TBR=ajuma@chromium.org,vmpstr@chromium.org,schenney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=451448

Review URL: https://codereview.chromium.org/886673003

Cr-Commit-Position: refs/heads/master@{#314260}

The CL:
 * Adds createSnapshot and hasFreshCache methods to MetadataCacheSet
 * Adds clone and hasFreshCache mehtods to MetadataCacheItem

The createSnapshot and clone are the methods to generage deep copy of the model.
The hasFreshCache is the method to check the cache contains all required caches.

BUG=410766
TEST=FileManagerJsTest.MetadataCacheSet,FileManagerJsTest.MetadataCacheItem

Review URL: https://codereview.chromium.org/898533003

Cr-Commit-Position: refs/heads/master@{#314259}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4bf1ce2..e67164d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/890893008

Cr-Commit-Position: refs/heads/master@{#314258}

BUG=448817

Review URL: https://codereview.chromium.org/850013004

Cr-Commit-Position: refs/heads/master@{#314257}

[DOMStorage] Offset the session storage namespace ids generated by different contexts to help identify when an id from one is mistakenly used in another.

Review URL: https://codereview.chromium.org/881253004

Cr-Commit-Position: refs/heads/master@{#314256}

This adds details about each individual DisplayItem to
DisplayItemList's trace output. Each DrawingDisplayItem's
SkPicture is also included in the trace output.

Review URL: https://codereview.chromium.org/884473005

Cr-Commit-Position: refs/heads/master@{#314255}

This is proving useful for test filters involving >1 test, which I'm
using heavily as I work on the net test server.

BUG=428729

Review URL: https://codereview.chromium.org/892273002

Cr-Commit-Position: refs/heads/master@{#314254}

It's flaky on Mac and Linux.
BUG=442752
TBR=horo@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/876593004

Cr-Commit-Position: refs/heads/master@{#314253}

This method is no longer used. All Android code assumes that new profile
management is enabled.

BUG=393335
R=aruslan@chromium.org

Review URL: https://codereview.chromium.org/890113002

Cr-Commit-Position: refs/heads/master@{#314252}

This adds a new third_party directory, android_data_chart, which
contains the data usage chart UI widget from Android's Settings app. The
widget shows a graph of how much data the user has used and saved over
time.

BUG=428885
R=bengr@chromium.org, cpu@chromium.org, dannyb@google.com, tedchoc@chromium.org

Review URL: https://codereview.chromium.org/866813004

Cr-Commit-Position: refs/heads/master@{#314251}

ChromeSwitchPreference uses setWidgetLayoutResource() to show a Material
switch, but on BLU Life Play devices, this has no effect and the default
switch is shown instead. As a result ChromeSwitchPreference.onBindView()
couldn't find the Material switch and was crashing with a NPE. This
fixes the crash by adding a null check, though these devices will still
show a non-material switch.

BUG=451447
R=dtrainor@chromium.org

Review URL: https://codereview.chromium.org/894873004

Cr-Commit-Position: refs/heads/master@{#314250}

BUG=454037

Review URL: https://codereview.chromium.org/878523005

Cr-Commit-Position: refs/heads/master@{#314249}

Otherwise, on Ash, it seems to steal the initial focus away from the
widget.

BUG=453284
TEST=Start Chrome with --enable-new-avatar menu, and in Metro mode.
Choose "Switch Person" from the avatar menu. In the user manager, start
tabbing (without clicking on the user manager). This should work, and
tabbing should change the selected user pod.

Review URL: https://codereview.chromium.org/894723003

Cr-Commit-Position: refs/heads/master@{#314248}

BUG=433539

Review URL: https://codereview.chromium.org/879993002

Cr-Commit-Position: refs/heads/master@{#314247}