- 09 Jun, 2020 40 commits
-
-
Dirk Pranke authored
The current version of pyjson5 was v0.6.1, more than two years old :(. There's no real significant new functionality in this new version and the performance is still slow, but there are a number of bug fixes. R=aboxhall@chromium.org Change-Id: Ic293163382a1b0fa1111aca5b04a455eb9b72a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216513 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#776381}
-
Mitsuru Oshima authored
I verified this with clean build. I'll hland this after branch cut, just in case. Bug: 1046624 Change-Id: I92e8f45b8556eabb0f4d1d903e1fe2ca702f1101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101296Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#776380}
-
dpapad authored
Specifically: - Move AddStringsForPdf and AddAdditionalDataForPdf from resources_private_api.cc to pdf_extension_util.cc - Update to base:Value instead of base::DictionaryValue - Update chrome_component_extension_resource_manager.cc to register strings for the PDF viewer, which in turn makes $i18n{} replacements work. - Update viewer-pdf-toolbar.html to use $i18n{} replacements, as an example. Other files will be updated in future CLs. Also had to wrap parts of the viewer-pdf-tooolbar.html with <if expr="chromeos">, so that they are not included in other OSes. There are probably more such cleanups that can be done now that https://crbug.com/1010663 is fixed and PDF annotation related stuff is only relevant on CrOS. Bug: 1091516 Change-Id: I8beeaa005fcb16780608b8a480be0b55b5e03bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231751 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#776379}
-
Jonah Ryan-Davis authored
This CL splits the pixel_skia_gold_tests, maps_pixel_test, screenshot_sync_test, and context_loss_test into variations to run on the passthrough/validating command decoder. Windows will only run passthrough. Linux will run both. Mac/Android will only run validating. Bug: chromium:1090853 Change-Id: I5a1f80a6c80f91c94a51cf825c63716352c72d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229006 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#776378}
-
My Nguyen authored
In preparation for moving ui/chromeos/ime to chrome/browser/chromeos/input_method/ui, fix presubmit errors. Change-Id: I488bf5d81a3b541d8954c89456a15aafe0602323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228429Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776377}
-
Yoichi Osato authored
This CL implements a part of https://fetch.spec.whatwg.org/#http-network-or-cache-fetch: "10. If response’s status is 401, ... 2. If request’s body is non-null, then: 1. If request’s body’s source is null, then return a network error.." Bug: 688906 Change-Id: I272118f2ba066278287560b26b1622d4f49bd79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228437Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#776376}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dcb5c85b51e1..37e562110fa5 2020-06-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ie0610f9b0797429002b4508db89781e228ae1c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236104Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776375}
-
Oksana Zhuravlova authored
This is a reland of 5c76e821 The test failures that caused the revert have been fixed in https://r.android.com/1325791 and rolled into chromium in https://crrev.com/c/2236240. Original change's description: > [tools/perf] Add webview_cpu_usage metric > > This change adds a metric that calculates the amount of time WebView > spends on different frequencies. > > Bug: b/157855323 > Change-Id: Ibb1fa61cc2ba1479f2b76ef642dc03c64a9a14b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231452 > Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775713} Bug: b/157855323 Change-Id: I45552ebb5b3ca49c05506495e16a7a20e02ade86 TBR: khokhlov@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236055 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#776374}
-
Tarun Bansal authored
Change-Id: I3bd8fd7ecaf0393848ec91296dacc8996251a14d Bug: 1090417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236679 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#776373}
-
Lukasz Anforowicz authored
Let's consider the following call: base::WrapUnique(ptr_field_). If |ptr_field_| is a CheckedPtr<SomeClass> (rather than a raw pointer like |SomeClass*|), then the template will not match (|T*| will not match |CheckedPtr<SomeClass>|): template <typename T> ... WrapUnique(T* ptr) { ... } Initially we planned to add CheckedPtr-specific overloads to the affected template functions (e.g. see https://crrev.com/c/2167634), but this approach was abandoned once we realized 1) there are quite a few of such functions and 2) we can't change functions in non-Chromium code (e.g. std::sort). This CL addresses the problem, by appending |.get()| at the callsites so that the type of the argument stays the same after the rewrite: base::WrapUnique(ptr_field_.get()). The CL covers: 1. Parameters with a type that refers to a template parameter. 1.1. This covers |T param| and |T* param|. 1.2. Deeper nesting (e.g. std::unique_ptr<T> or base::Optional<T>) is also covered. 1.3. |T& param| is explicitly excluded, to avoid affecting things like std::swap(T1&, T2&) or std::tie(T&... args)) 2. Function and constructor parameters. This seems sufficient in practice. If there is a need, then in the future coverage may be added for other cases (e.g. parameters of assignment operator and/or other operators). 3. Arguments that directly refer to a raw pointer field that is being rewritten into a CheckedPtr. A follow-up CL will handle things like std::sort(ptr_field_, ptr_field_ + size) - see https://crrev.com/c/2196820. Bug: 1069567 Change-Id: I0805275b080926ece8f33e4e527c1a7ca983c6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202653Reviewed-by:Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#776372}
-
Lukasz Anforowicz authored
If the right click happens on top of text, then on Mac the text will become selected before showing the context menu, leading to different context menu items being shown. This CL starts to use an empty subframe to avoid this problem. This helps enable the test on Mac platform. Bug: 1090891 Change-Id: Ie4f78aa6adaa36d970e0f538fc80f28b09eb0592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229658 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776371}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/3ae59d04d192..778bf126ad38 2020-06-09 rwkeane@google.com Discovery: Add support for non-cyclic SRV pointers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I377c8ffca343df28e347b89d9c0acd72b77a6448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236907Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2040ac7e6d33..91286aa462fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alancutter@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1021757,chromium:1092666 Tbr: alancutter@google.com Change-Id: If9f73ae0129ad3a9457977e680e71dbdfc50a54a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236325Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776369}
-
Jorge Lucangeli Obes authored
This got added a *long* time ago, but never reported: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/233260/2/cryptohome/service.cc#1681 Further refactorings left this as the only active codepath reporting user session mount duration. Log it on the server side. BUG=1091286 TEST=validate_format.py, pretty_print.py. Change-Id: I1a81baacabd30c28c8960be0047ea04045ea777e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232678 Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#776368}
-
Evan Stade authored
Bug: 1089645 Change-Id: Ibdbf79fe5ae1e77fb7e4a4351143369a0d0f9fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236097Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#776367}
-
Xing Liu authored
DownloadSchedule carries application data for download later feature, this CL plumbs it from DownloadDialogBridge to DownloadTargetInfo. This is mostly plumbing a base::nullopt through the pipeline. There will be a few more CLs to plumb it to DownloadItemImpl and the in progress download db. Bug: 1078454 Change-Id: I187269c340d775997b6840ba1f16d67815a1b845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234129Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776366}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Ia153e9057856786356876b4430d7c017e567837d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235740Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776365}
-
Lei Zhang authored
The code that recorded the histogram was removed 5 years ago in crrev.com/312672. Bug: 1089322 Change-Id: Iad14af1d7ef0d73d26710db3cc5b7ae32a0aa1b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236756Reviewed-by:
-
Mounir Lamouri authored
Bug: 1088914 Change-Id: Ic08cfc76668659b2babb0c75878395dd1b628f80 Fixes: 1088914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232959Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#776363}
-
Giovanni Ortuño Urquidi authored
Adds support for structs with no constants, enums, or default values. No tests are included because any bugs would just result in a compilation failure. Also removes some new lines to make the generated code nicer. Bug: 1011609 Change-Id: I061e758a4d66bfa4c057e94765402e34586a2ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232305Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#776362}
-
Wen-Chien Wang authored
Virtual keyboard and Search box are expected to be dismissed at one tap/click when there is no text in the search box. Add a test case that will tap/click somewhere outside the search box when there is no text in the search box, which is different from the original one that search box is not empty. R=tbarzic@google.com Bug: 1021276 Change-Id: I8358eb6b4eb754e0fa40c99e24ce0a0f6f170a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233687Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Wen-Chien Wang <wcwang@google.com> Cr-Commit-Position: refs/heads/master@{#776361}
-
Tim Volodine authored
Implement WebLayer API and the corresponding internal Safe Browsing bits to make Safe Browsing user opt-in/opt-out possible. Using this API the embedder can disable/enable the Safe Browsing functionality (which checks whether the loaded URLs and resources are safe) and obtain its current state. This can be done using two methods introduced in this patch which are defined on the WebLayer's Profile class: - setBooleanSetting(SettingType, boolean) - getBooleanSetting(SettingType) For example, to opt-out of Safe Browsing the embedder can call getProfile().setBooleanSetting(SettingType.BASIC_SAFE_BROWSING_ENABLED, false) on its browser instance. Safe Browsing in weblayer is enabled by default, so the current semantics is that this is an opt-out option. When toggling the state (e.g. opting out) the settings take effect on next load. The setting applies to both the browser and renderer initiated loads. In this patch: - Implement internal bits to disable/enable Safe Browsing checks. - Make sure to apply the setting via Profile for both browser and renderer initiated loads. - Implement getter/setter WebLayer API for the embedder to set user opt-in/opt-out via Profile. - Add SettingType interfaces (with the BASIC_SAFE_BROWSING_ENABLED setting) and the corresponding {Get,Set}BooleanSetting() methods. - Add the necessary plumbing to the aidl and jni parts of the profile classes. BUG=1083376 Change-Id: I3e3b9e314404d262bef57da26e070909feefb095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225756 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#776360}
-
Clark DuVall authored
The weblayer unittests needed a small fix to be able to run on Android, these should be running on the bots. This will be useful for adding site isolation unittests, which should be tested on both Android and desktop. Bug: 1058364 Change-Id: I7188a6140cff2811594bc7ab6d2e9b2dd58366ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235941Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7c56f7ee. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" 101c532f "[css-lists] Fix list image gradient with dynamic zoom" a8a28083 "[Security][Coop] Browsing context switch reporting WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I8089a0b355a0bd9296077cd2803e2133191cf0f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235736Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776358}
-
Emily Stark authored
This implements the flag omnibox-ui-hide-steady-state-url-path-query-and-ref-on-interaction. In this variation, the path is shown on page load until the user interacts with the page. Bug: 1090393 Change-Id: Ie21b67a0939dbc7938e00ba477c2c7abab59b61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234128 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#776357}
-
Jeff Yoon authored
The validation step already ensures that profraw files are good. When they are invalid, they are set aside, and the merge_error detection mechanism raises these. PGO skips the validation, so any failures merging should be raised directly. Bug: 1091310 Change-Id: Iea3460356f9ad7e5b914bd99f2b88bde5cb0bb05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231263Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#776356}
-
Chris Lu authored
Bug: 1071914 Change-Id: Ieb1c78e1c6a771672c84ae7011ad7bf4815655c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236597 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#776355}
-
Tao Bai authored
No feature change. Bug: 949555 Change-Id: I73ccacc91694bfac3b1016de6310f628403805cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234016 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#776354}
-
Yoshifumi Inoue authored
This patch introduces tests for |{End,Start}OfLine()| to record current behavior to help implementing EditingNG. Bug: 707656 Change-Id: I0cbf1ecbbbf1fdfb0ed2647b78cde9d37f8554d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235224 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776353}
-
Nigel Tao authored
Bug: 1086733 Change-Id: If34d48c06619639470ba27de8ba003591219766a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235134Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#776352}
-
Aga Wronska authored
ManagedUsers.Whitelist.Count has some data for Chrome <= M77, so it extended. It should be removed together with the feature code when confirmed that it is obsolete. The following metrics have no data and are being marked obsolete: ManagedUsers.Whitelist.JsonParseDuration ManagedUsers.Whitelist.TotalLoadDuration ManagedUsers.Whitelist.ReadDuration Bug: 1088898 Change-Id: I965f33c75a710043768a0458bb4e5d249cd69bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227891 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ac68fc0764f5..f19675c75eab 2020-06-08 lalitm@google.com Merge "tp: fix GetNonNull function for dense nullable vector" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie24eb5c18b6f4fbf2c16f570fe5a9df0d17917e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236380Reviewed-by:
-
Nigel Tao authored
Bug: 1086733 Change-Id: I0eeab461cb147d8cd175fac15c8feb448f9aeffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235219 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#776349}
-
Nate Chapin authored
Bug: 1029822 Change-Id: I3b14ea528a0b82ca79a63566921d3c72abb141c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233493 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#776348}
-
Xinghui Lu authored
Currently returning the expiration time of an access token is not supported on Android, because only a plain string is returned from the Java side. In this CL, we add support to return the expiration time by adding a holder class named AccessTokenData. If the API doesn't support expiration time, the time will be set to 0. In the external repository, the first party API is not available, so we continue setting the expiration time to 0. The CL for setting the expiration time will be added in https://crrev.com/i/3022086. Bug: 1070324 Change-Id: Ibb7ba5a47131af6046fdbd64725729486c07d753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209641 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#776347}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ief9379c061e91e8414b4bd6d78e54e326e98fbfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236677Reviewed-by:
-
danielng authored
Adding the basic UI requirements needed for plugin vm camera permissions and putting it all behind a feature flag whilst it's being worked on. Bug: 1071873 Change-Id: I2930f03eeb6dc23a65cf1ddbcaa534e25f27f379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230427Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#776345}
-
Xinghui Lu authored
This CL creates classes for enterprise real time URL lookup. chrome_content_browser_client injects an enterprise or consumer real time URL object based on the type of the user. A feature flag SafeBrowsingRealTimeUrlLookupEnabledForEnterprise is also added in this CL. It is disabled by default. The implementation for StartLookup will be added in a future CL. The enterprise policy for real time URL check will also be added in a future CL. Bug: 1085261 Change-Id: I3741bbcb326c6f17e3bc95b45f1366874e97a98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234794 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#776344}
-
Lukasz Anforowicz authored
This change has been generated by a clang tool developed for the go/miracleptr project. Bug: 1080832 Change-Id: Ie7f428c8ad300db1df95d873668163d0ac719a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231843Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#776343}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/93f2980477a5..1c7e7fdfb4d6 2020-06-08 joselea@microsoft.com Devtools personalization - Movable tabs 2020-06-08 chrche@microsoft.com [A11y] fix DOM breakpoint checkbox not announced by screen reader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1075732,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I95122b00d60e4b719a02a3dcd3546b3dd2b5d19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236379Reviewed-by:
-
