- 02 Nov, 2018 40 commits
-
-
Sadrul Habib Chowdhury authored
Use the size from the Quad, instead of always hardcoding to 5x5. Bug: none Change-Id: Ic6c552f3a780da002c194918226cc8b3a32c8ab3 Reviewed-on: https://chromium-review.googlesource.com/c/1314142Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#604959}
-
Eric Stevenson authored
This CL adds an experimental GN arg, use_uncompressed_dex, which will force .dex files to be stored uncompressed in APKs. Currently, monochrome_public_apk and trichrome_chrome_apk are affected. The corresponding bundle targets are not affected. Bug: 777858 Change-Id: Ib8e0922328da02a45f5c5e71675d4d76e907d087 Reviewed-on: https://chromium-review.googlesource.com/c/1311661 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#604958}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/879aea82..b5f94ce7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I068297268d9c5a04b50724048370b5a788c3aaaa Reviewed-on: https://chromium-review.googlesource.com/c/1315387Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604957}
-
Emircan Uysaler authored
Bug: 900718 Change-Id: Iade6c516120ced7c64991cecc5c1bfef7740d036 Reviewed-on: https://chromium-review.googlesource.com/c/1311694Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604956}
-
Lukasz Anforowicz authored
Summary ======= This CL makes layout tests use the default site isolation from the platform they are run on (instead of opting out of strict site isolation via LayoutTestContentBrowserClient::ShouldEnableStrictSiteIsolation). Additionally, on platforms where strict site isolation is enabled, layout tests opt into slightly stricter isolation by enabling isolation of same-site origins used by Web Platform Tests - this ensures that features covered by WPT also get sufficient coverage of out-of-process iframes (OOPIFs). After this CL, expectations for tests that differ in behavior with and without OOPIFs are being moved from LayoutTests/FlagExpectations/site-per-process to: - LayoutTests/VirtualTestSuites (virtual/not-site-per-process suite) - LayoutTests/virtual/not-site-per-process/README.md - LayoutTests/TestExpectations and LayoutTests/NeverFixTests ("Site Isolation failures" section) Desirability ============ The CL helps with the following: - Focusing on testing the mode that is actually shipped to end users - Helping ensure that newly developed features get site-per-process coverage without having to set up a separate step (i.e. it is sufficient to set-up a bot that runs layout tests with --enable-features=NewFeature without also having to have a separate test step for runing layout tests with *both* --enable-features=NewFeature *and* --site-per-process This CL does *not* help with reducing requirements for CQ capacity, because we need to maintain a separate not_site_per_process_webkit_layout_tests step to make sure that tests pass without isolation (which is the mode Chrome ships on Android). Also note that layout test coverage on Android is very sparse - see https://groups.google.com/a/chromium.org/d/topic/blink-dev/SOXhTYysYkE/discussion Preserving test coverage ======================== Most tests ---------- The CL preserves covering most layout tests with and without OOPIFs, by relying on the fact that CQ/waterfall run layout tests on both kinds of platforms - ones that default to strict site isolation (desktop platforms) and ones that default to no site isolation (Android). Tests that used to be excluded FlagExpectations/site-per-process ---------------------------------------------------------------- Around 40 tests fail when run in presence of OOPIFs. Such tests are disabled by this CL by moving test expectations from FlagExpectations/site-per-process into the main TestExpectations file. The CL preserves non-OOPIF test coverage provided by the disabled tests by introducing virtual/not-site-per-process directory which runs all such tests with site isolation disabled. Using a virtual test suites for preserving the test coverage relies on the ability to have separate test expectations for these tests (i.e. relying on the fact that disabling these tests in TestExpectations doesn't disable their virtual/not-site-per-process equivalents). Note that the CL keeps isolating "oopif.test" site even in virtual/not-site-per-process suite. This site should only be used by tests that require an OOPIF. Preserving site-per-process-specific test expectations ------------------------------------------------------ Some tests have site-per-process-specific expectations: - http/tests/inspector-protocol/network/security-info-on-response.js - http/tests/inspector-protocol/network/raw-headers-for-protected-document.js The tests above highlight that cross-origin cookies are not displayed in site-per-process mode (a known regression tracked by https://crbug.com/849483). This CL preserves expectations and coverage by shuffling things around: - old, main expectation -> android expectation - old, site-per-process expectation -> main expectation There is one additional test with site-per-process-specific expectations: - external/wpt/dom/events/EventListener-addEventListener.sub.window.js Unlike the other 2 tests, it seems less important to preserve exact test expectations for the case when the test fails with Site Isolation. Therefore this test is covered by virtual/not-site-per-process test suite and an expectation for this test is added to the main TestExpectations. Lost test coverage ------------------ Even with extra caution described above, some test coverage may be lost: - Features covered by tests only on one kind of platform (e.g. disabled on Android) are at risk of losing OOPIF or non-OOPIF coverage. - Before this CL, site-per-process was also applied to all other `virtual/...` test suites. After this CL, `virtual/not-site-per-process` will not provide such coverage. Cleaned up test expectations ---------------------------- Some additional test expectations clean-up is done, while preserving test coverage: - The http/tests/perf/large-inlined-script.html test has been already present in `SlowTests` and therefore I didn't include this test in the new `virtual/not-site-per-process` suite. - The http/tests/devtools/network/network-datareceived.js test was already marked as expecting a `[Failure]` in TestExpectations and therefore I didn't include this test in the new `virtual/not-site-per-process` suite. - The http/tests/devtools/console-cross-origin-iframe-logging.js test was already marked as `[Timeout]` in the old TestExpectations but for Win only. Since I can repro a timeout on Linux (with and without site isolation), I just extended the old expectation to all platforms and I didn't include this test in the new `virtual/not-site-per-process` suite. I also removed the test from SlowTests (since timeouts in the test are not expected everywhere). Bug: 870761 Change-Id: I74d8ac4ebee8f0402d449fda2cec46ba3b49cf64 Reviewed-on: https://chromium-review.googlesource.com/c/1302662 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#604955}
-
Varun Khaneja authored
Change-Id: Id2d3a40f75221b4bdae33ac5558d9b323e149c40 Reviewed-on: https://chromium-review.googlesource.com/c/1311915Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604954}
-
Daniel Verkamp authored
This lets concierge choose the appropriate disk image type for the kernel and filesystem. Bug: 893380 Signed-off-by:
Daniel Verkamp <dverkamp@chromium.org> Change-Id: I2b8d9ae847e5d2a87949a2e7b9ef965d038e11f2 Reviewed-on: https://chromium-review.googlesource.com/c/1312568Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#604953}
-
Anthony Vallee-Dubois authored
This CL takes the experimental hrefTranslate attribute on <a> tags and carries it to the creation of NavigationHandle. This allows Translate browser code to be aware of its value in ContentTranslateDriver::DidFinishNavigation. BUG:900586,872777 Change-Id: Ie7c633aca8a91f1137862898c992c5f63cc1fcca Reviewed-on: https://chromium-review.googlesource.com/c/1308434Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#604952}
-
Ross McIlroy authored
Line numbers will change with a V8 change, will rebaseline after that rolls. BUG=V8:8405 Change-Id: I3003667ea7f8581dfe4de1fb7252888fb45dcd7d Reviewed-on: https://chromium-review.googlesource.com/c/1313933 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#604951}
-
Scott Violet authored
This is more common and easier to see. BUG=none TEST=none Change-Id: Ieae5f48274430123dbae4dfee4c5b79e1f901b63 Reviewed-on: https://chromium-review.googlesource.com/c/1313829Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#604950}
-
Scott Violet authored
We don't have any clients embedding other clients, so using false is more correct. Additionally this ensures hit testing on renderers does not query viz, which is a big change from the classic case. BUG=none TEST=none Change-Id: If3155f8044d9c1df07165807c41bc15e3d9dbe33 Reviewed-on: https://chromium-review.googlesource.com/c/1308915Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#604949}
-
Owen Min authored
report_extensions_data to ReportExtensionsAndPluginsData report_safe_browsing_data to ReportSafeBrowsingData Bug: 898673 Change-Id: I3a347778857722aeb55eb3193bdde2034b1c37cf Reviewed-on: https://chromium-review.googlesource.com/c/1313332 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#604948}
-
Joe Downing authored
This reverts commit 7ee7bac4. Change-Id: I54247dd56111feee9608e1b50387cb3501a659a4 Reviewed-on: https://chromium-review.googlesource.com/c/1315468Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#604947}
-
Donna Wu authored
Bug: 699790 Change-Id: I00087c1cb36c9db26d9181889c2e19c951b2fb5e Reviewed-on: https://chromium-review.googlesource.com/c/1301119 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#604946}
-
Wei Li authored
When an empty element is hovered, do not show a tiny highlighted square. There is no need to highlight in this case. However, for invisible non-empty element, we still show its bound for information. BUG=898998 Change-Id: I8d5569710c427011dac90ec5ef9bc4dbc63eadd4 Reviewed-on: https://chromium-review.googlesource.com/c/1309413 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#604945}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8923650232d6..20f38b3d064b Created with: gclient setdep -r src-internal@20f38b3d064b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifdef9937fc4acd5c007f458234cb949f709542df Reviewed-on: https://chromium-review.googlesource.com/c/1315327Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604944}
-
Koji Ishii authored
This patch reduces the memory usage for NGBaselineList and NGBaselineRequestList by making the types as index of an array of LayoutUnit. What to do when we add more baseline types is still TBD. The rough plan is when adding baselines for Indic etc., we can probably allocate rare_data pattern for 3 or more baselines. This change does not save memory for NGPhysicalBoxFragment when there are no baselines, because NGBaselineList is the same size as an empty Vector. It does save when there are baselines, and also saves NGBaselineRequestList which is in NGConstraintSpace. All boxes within inline block, or boxes enclosed in legacy layout have baselines and baseline requests. Also when table/flex/grid are implemented in NG, their items and descendents of items will have baselines. At google.com, 19% (128/643) of box fragments have baselines. 20% (77/383) at amazon.com. Change-Id: I6eb25a47528d92425880582ab6662944e9e8c125 Reviewed-on: https://chromium-review.googlesource.com/c/1312183Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#604943}
-
Xiyuan Xia authored
We could have two DeleteSoon scheduled at the same time and cause double deletion. Change LoginDisplayHostMojo::OnFinalize to use ShutdownDisplayHost() so that they will be consolidated into one. Bug: 900615 Change-Id: I2f2db9369079adc7d4cf24bb9ef65b15ebc79320 Reviewed-on: https://chromium-review.googlesource.com/c/1313740Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604942}
-
Daniel Verkamp authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/46e2b4be31c7..b54e73475dd0 $ git log 46e2b4be3..b54e73475 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 semenzato system_api: generate Go bindings for MetricsEvent 2018-10-30 dverkamp system_api: concierge: add DISK_TYPE_AUTO value 2018-10-26 norvez system_api: remove BiometricsManager constants 2018-10-25 iby system_api: Add proto fields to support dependency message in uninstall Created with: roll-dep src/third_party/cros_system_api Change-Id: I242902eea0e44a6c07984d30602ea81a463a7b49 Reviewed-on: https://chromium-review.googlesource.com/c/1312567Reviewed-by:
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d0a4800..155f802 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I54f31ce39913d0956b5893daf3937a4f1a2c06e3 Reviewed-on: https://chromium-review.googlesource.com/c/1315167Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Nicolas Capens <capn@chromium.org> Cr-Commit-Position: refs/heads/master@{#604940}
-
Andrew Grieve authored
For structural nodes, still shows the "idPath", because our data model does not allow mapping subpaths -> components. Also fixes cell alignment in the infocard where titles were center aligned over right-aligned values. Bug: 880671 Change-Id: I5be0bb6b07aba20a9c49bffa4c14da45f8bb0599 Reviewed-on: https://chromium-review.googlesource.com/c/1313076 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#604939}
-
Dave Tapuska authored
Approved Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/vTnSjFcPwNc/kkTX92hpBgAJ BUG=846858 TBR=timvolodine@chromium.org Change-Id: I48c81a799130b7d89157ba0795985fc2eb88ff17 Reviewed-on: https://chromium-review.googlesource.com/c/1291996 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#604938}
-
A Olsen authored
When kStubCrosSettings switch is set, the logged in user is treated as the owner of the device, and of the stubbed settings (which don't need a real owner key). This change moves this promotion of the user to the owner out of ChromeUserManagerImpl and into CrosSettings. This untangles the two classes slightly, and also it means that we can get rid of one call to CrosSettings->Set, which is being removed. See go/writepath for more background Bug: 433840 Change-Id: I9f4a34b34d0160d220558e512b9d1c56b3e253a1 Reviewed-on: https://chromium-review.googlesource.com/c/1314491Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604937}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8ad2ee9a. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mek@chromium.org: external/wpt/webmessaging NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I8e51ba77dedbcbecabb85cfed0bcedc8940b6f48 Reviewed-on: https://chromium-review.googlesource.com/c/1314608 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604936}
-
Ahmed Fakhry authored
We used to limit this detection to internal keyboards, but now we have external keyboards that have this newer layout as well, and we should show the correct strings if any is connected. BUG=b/118644994 TEST=Connect an external Brydge G-Type BT keyboard, and expect that the keyboard settings show the string "Launcher" instead of "Search" Change-Id: I91892b9ac814dbe8b5ba6ec904ed7769e51eb507 Reviewed-on: https://chromium-review.googlesource.com/c/1313748Reviewed-by:Dan Erat <derat@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#604935}
-
Ken Rockot authored
This changes the video_capture service to use ServiceBinding for its Service interface binding, eliminating reliance on ServiceContext as well as EmebddedServiceInfo etc for content integration. Bug: 891780 Change-Id: Ic1b89aa5487e230b4fafef2fdddf4b0e8e307b3c Reviewed-on: https://chromium-review.googlesource.com/c/1311797Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#604934}
-
Owen Min authored
ReportExtensionsAndPluginsData policy blocks extensions and plugins report. ReportSafeBrowsingData policy blocks Safe browsing data report. Bug: 898673 Change-Id: Id2e2446ee342d13c07dcc79f150aa4baaedcb5c8 Reviewed-on: https://chromium-review.googlesource.com/c/1313329Reviewed-by:
-
David Bokan authored
In https://crrev.com/bf23241073ef806810f2aa90bbb153b639239c81, I rewrote UpdateViewportContainerSizes to be compatible with Blink generated property trees. As part of this, we now make use of the outer viewport's clip node. However, unlike the layer's bounds, the clip node's bounds do not include the resize we perform to match the content width of the page. In WebViewImpl::ResizeAfterLayout, we resize the FrameView (and thus the LayoutView) after we do a layout. We do this so that the layout viewport is sized according to the minimum possible page scale (so pos: fixed Elements are in the correct locations when the page is fully zoomed out). However, this isn't accounted for correctly in the ClipNode. This CL applies the minimum scale to the clip bounds directly when computing the clip as a result of URL bar movement. We should really fix the place where the ClipNode is computed but this CL will need to be merged so this is a minimal fix. Note also, the ClipNode is correctly calculated with blink-gen-property- trees enabled. This fix is thus only required when that's turned off. Bug: 898757 Change-Id: I9c8ea517c2e98b6b2ac552b1ae64bd1675547614 Reviewed-on: https://chromium-review.googlesource.com/c/1313278Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604932}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/13853a120d5a..30edaaac1da4 git log 13853a120d5a..30edaaac1da4 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 brianosman@google.com Simplify and generalize alpha image extraction in PDF Created with: gclient setdep -r src/third_party/skia@30edaaac1da4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ic10f1c45c6bd20987d6c31c4c8d3b70ec5b89bb5 Reviewed-on: https://chromium-review.googlesource.com/c/1314103Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604931}
-
Scott Violet authored
TopHosts() and HostRankIfAvailable() are unused, so removing. BUG=none TEST=none Change-Id: I752a671e4e7b77546a7dff590c020a18d683e544 Reviewed-on: https://chromium-review.googlesource.com/c/1313050Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#604930}
-
Xida Chen authored
This reverts commit bf305c6a. Reason for revert: cause crash Original change's description: > Remove TouchActionFilter::num_of_active_touches_ > > This variable was added to test whether the touch start / end can be > acked and released out of order or not. From the reading of the code, > I don't think is true. > > This CL removes this variable, we will monitor crash reports to ensure > this doesn't cause regression. > > To ensure the same behavior, we need a new variable, which is named > |touch_sequence_in_progress_| in this CL. This is specifically for this > scenario: we have received touch event ack for touch start, and then > JS removes / adds touch event listener, which triggers a > OnHasTouchEventHandlers call. In this case, we should not reset > touch action if the |touch_sequence_in_pgoress_| is true. We have the > unit test OnHasTouchEventHandlersReceivedAfterTouchStart to ensure > this behavior. > > Bug: 900195 > Change-Id: I53c3141905b4e2a49ab6e62ea43335c4cee17c15 > Reviewed-on: https://chromium-review.googlesource.com/c/1307250 > Commit-Queue: Xida Chen <xidachen@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604260} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 901147 Change-Id: I4cd8387cd368eb6ca99010585ea872685953ac89 Reviewed-on: https://chromium-review.googlesource.com/c/1313841Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604929}
-
Owen Min authored
Add policy ReportExtensionsAndPluginsData. Add policy ReportSafeBrowsingData Bug: 898673 Change-Id: Ief72e4d7ab9aae2b31c199a2aaa4b2e346be7ef2 Reviewed-on: https://chromium-review.googlesource.com/c/1313512Reviewed-by:
-
Parastoo Geranmayeh authored
Update the profiles' validities for each major version to keep up with the possible changes in the Autofill Profile Validator logic. See: go/autofill-use-validation Bug: 899783 Change-Id: Ie1c52df4c13a5579eb5265bda1eea19d02c5b123 Reviewed-on: https://chromium-review.googlesource.com/c/1311085 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#604927}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/971689c0597c..a6ef719b69f4 git log 971689c0597c..a6ef719b69f4 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 cbruni@chromium.org [wpr] Add httparchive.go merge command Created with: gclient setdep -r src/third_party/catapult@a6ef719b69f4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:896280 TBR=sullivan@chromium.org Change-Id: I618bb6d1addf22744622d33888dd53a452625cf7 Reviewed-on: https://chromium-review.googlesource.com/c/1314104Reviewed-by:
-
vitaliii authored
Because flaky. PictureInPictureWindowControllerBrowserTest.EnterPictureInPictureThenFullscreen TBR=mlamouri@chromium.org Bug: 901235 Change-Id: Iab53371efe290a16b475c0a002c0561b184f8b08 Reviewed-on: https://chromium-review.googlesource.com/c/1315207Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#604925}
-
Ehsan Karamad authored
Currently we send the IPC to renderer in the BrowserPlugin-based case as well which is hitting a NOTREACHED. This IPC is only meant to be used for frame-based MimeHandlerViewGuest. TBR=wjmaclean@chromium.org Bug: 901289 Change-Id: Ib2efb7088d93c9339f1d920f1d3bf5c5a69718e4 Reviewed-on: https://chromium-review.googlesource.com/c/1314609Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#604924}
-
Donna Wu authored
This CL converted USB callings in WebUsbDetector to mojo interfaces by introducing webusb_landing_page in UsbDeviceInfo. Bug: 699790 Change-Id: I6352c35a7eb9090ef4d5cb3d2436b30216d76ec9 Reviewed-on: https://chromium-review.googlesource.com/c/1297747 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
-
Dave Tapuska authored
Add metrics to to track the time taken first contentful paint for pages that use whitelisted hosts for stale while revalidate. This breaks the timings into whether the resource was loaded from the network, cache, stale-cache loads. BUG=348877 Change-Id: I4e710d6f52517a815d68d478584818501c10e0ea Reviewed-on: https://chromium-review.googlesource.com/c/1297461 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#604922}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/41f00de26bb1..56ef305b6767 git log 41f00de26bb1..56ef305b6767 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 ossu@webrtc.org Move event logging of config into AudioSendStream. 2018-11-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 734e273d..e842ab5f (604373:604874) 2018-11-02 nisse@webrtc.org Delete _strnicmp. Uses replaced with abseil functions. Created with: gclient setdep -r src/third_party/webrtc@56ef305b6767 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I544e1cc5b76fde583988db3a8999853dbb4c72c3 Reviewed-on: https://chromium-review.googlesource.com/c/1314106Reviewed-by:
-
Henrique Nakashima authored
TaskScheduler requires the FeatureList, so it needs to be moved from CastBrowserMainParts::PreCreateThreads() to an earlier point, CastMainDelegate::PostEarlyInitialization(). The creation of the "singleton" FieldTrialList instance also needs to be moved to CastMainDelegate::PostEarlyInitialization(), since the FeatureList initialization depends on the FieldTrialList. Its ownership was transferred from BrowserMainParts to CastMainDelegate. A new CastFeatureListCreator class holds ownership of the service while the browser process isn't started. Bug: 887459 Change-Id: I4bcd60720518807e2089ec99a3f7db3e647203d6 Reviewed-on: https://chromium-review.googlesource.com/c/1308096 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604920}
-
