GitLab

This CL fixes 2 issues:
1. When resuming, download is not using the existing content URI for
target path and intermediate path
2. after target determination, no need to set the display name again if it has
already been set. Otherwise, it will infer the file name from the content
URI, and use a number as file name

BUG=943758

Change-Id: Id4cd912b8a8be5731911e6f7c8e1ad420f94a739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531508Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642318}

Bug: 934605
Change-Id: I0c6f69a8c8e2c8d46b44776a1de7661dad2aa5b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526487Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#642317}

The gMock use got in the way of making something that ought to be a
OnceCallback such since it has some limitations with respect to move-only
types.

Also, the tests weren't usefully distinguishing on whether the code was
waiting for Load or LoadForKey to complete first; they do now.

Plus, this group of test had its own ways of doing things totally different from everything
else; now things standardize on the simpler MockPersistentCookieStore.

Change-Id: I933386d311b6cce3fc230944e206b94cd1c0fff2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529074Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642316}

Bug: 736891
Change-Id: Ica1ea0462499c7fd9582d3c6774041cec238b85d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506569
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642315}

This reverts commit 9ab465d9.

Reason for revert: We have enough data to diagnose the crashes.

Original change's description:
> Add diagnostics to catch commits of URLs in incompatible processes.
> 
> These should be removed once we have some data indicating how it is
> occurring in practice.
> 
> BUG=931895
> 
> Change-Id: Ic8977b194892328a32d1db6f4492f9bb84938ba4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524835
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Commit-Queue: Charlie Reis <creis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#641079}

TBR=creis@chromium.org,nasko@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 931895
Change-Id: I1b52d81ed2ac2b89a8b6208650035f79d6714cfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530833Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642314}

This is a run of
run-clang-tidy.py -checks="-*,modernize-use-override" -header-filter=ui/views/* \\src\\ui\\views\\

BUG=940732
TBR=sky@chromium.org

Change-Id: I30fd8d209039d7f357ae38b240afd4b110e8f94d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530839Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642313}

This usage is consistent with what we do in
{Raster,GLES2}DecoderImpl::Destroy.

If you fail to do this, you may end up in an inconsistent state where
a context passes IsCurrent, but no GL bindings are bound.

- ~GLContextVirtual will call SetCurrent(nullptr) and
  SetCurrentGL(nullptr) in parent dtor ~GLContext

- Another context (e.g. shared_context_ or virtual context) may have
  GLContext::IsCurrent return true that method only checks driver state
  (e.g. eglGetCurrentContext()).

Bug: 942579
Change-Id: I9d7967b7618e68f5edd1b617083492f4f77f1cf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531011Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642312}

Implemented Compare of ITextRangeProvider with associated unittests.

Bug: 928948
Change-Id: I396b518cb76786bb9fad7acf58594c3ee9e653e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527864
Commit-Queue: Victor Fei <vicfei@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642311}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2d29261e94ed..3580425baa28


git log 2d29261e94ed..3580425baa28 --date=short --no-merges --format='%ad %ae %s'
2019-03-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-03-19 dpranke@chromium.org Revert "Remove exception for relative CIPD"


Created with:
  gclient setdep -r src/third_party/depot_tools@3580425baa28

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ifaa4c5afe3c77ca05ac69903179f24ff52358cab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531345Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#642310}

Add role=dialog to cr.ui.BaseDialog to keep Chromevox restricted to
dialog's elements, instead of cycling through all focus-able elements
in the DOM.

Change cr.ui.BaseDialog to have aria-label so Chrovevox reads it as
"$DIALOG Dialog ...".

These combined fix the Files app issue when opening "Open With...",
"More actions" and "Change default..." dialogs to be announced by when
they're opened, instead of only announcing its contents.

Bug: 889149
Change-Id: I7c53bb53b44279810a4ff255793aba1f1ad47f5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527912Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642309}

Rather than hard-coding the estimated draw time, calculate it from the
BeginFrame interval.

Change-Id: I5fc7494d5c08cf8ef84a55f1c672c173caf75bd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529621
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642308}

We currently have a race between:
- AppCacheBackendImpl::RegisterHost call coming over it's own mojo pipe and
  looking for precreated AppCacheHost;
- Destroying NavigationRequest, which destroys NavigationHandleImpl, which
  destroys AppCacheHavigationHandle which posts a task to destroy precreated
  AppCacheHost on IO thread.

To combat this, we take AppCacheHavigationHandle from committed NavigationRequest
before destroying it and keep it around in RenderFrameHostImpl. This measure
keeps in a common case when we commit navigation and reach for app cache host.

However, we still cannot assert that we always have a precreated host because
browser can decided to destroy the frame immediately (together with
RenderFrameHostImpl and AppCacheHavigationHandle), while renderer asks for the
AppCacheHost. The best thing we can do in this case is stall AppCacheHost
registration until renderer's frame is inevitably destroyed by the browser's
request.

This is a speculative fix for crashes in issue 941903. Some existing tests, e.g.
http/tests/misc/iframe-reparenting-id-collision.html, easily expose the race,
but since they are not using AppCache, we don't hit the crash point from the bug.

Bug: 941903
Change-Id: I3925d0b9ab9655235b524da561d0e8ba8345fb4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529381Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642307}

Revert "DevTools: add Page.frameRequestedNavigation, deprecate Page.frameScheduledNavigation and frameClearedScheduledNavigation"

This reverts commit a8016f0c.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 642246 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E4MDE2ZjBjYmE0MmQzNWUwNDdkMDUwMDJjNDZjMDNiZTM4MGExNmEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29/89416

Sample Failed Step: webkit_layout_tests

Original change's description:
> DevTools: add Page.frameRequestedNavigation, deprecate Page.frameScheduledNavigation and frameClearedScheduledNavigation
> 
> - add FrameRequestedNavigation probe that gets dispatched whenever client-initiated navigation request is sent to browser and carries reason for navigation;
> - expose the above as Page.frameRequestedNavigation
> - deprecate Page.frameScheduledNavigation and Page.frameClearedScheduledNavigation;
> 
> 
> Change-Id: Ia652b5381c22b68962a6f568e7cb18456dc0269a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524706
> Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#642246}

Change-Id: Ibb40f45320d12e3196136265078316358150897c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531713
Cr-Commit-Position: refs/heads/master@{#642306}

Creates an implementation of CryptAuthEnrollmentManager to be used for
CryptAuth v2 Enrollment. This implementation,
CryptAuthV2EnrollmentManagerImpl, will replace the v1 implementation,
CryptAuthEnrollmentManagerImpl. While the API for the abstract class is
not ideally suited for CryptAuth v2, using it will allow for a smoother
transition from v1 to v2.

Bug: 899080
Change-Id: I3ba278cf7987810687fa199db61a258c36f70e69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1440201
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642305}

Change https://chromium-review.googlesource.com/c/chromium/src/+/1217747/
introduced a side-effect that causes the entire input field to be
selected on a focus event. In the gallery app this caused the Width
input field to be fully selected when doing an image resize. This
change explicitly sets the selection to the end of the field as it
used to work before the regression.

This CL is the second attempt as the original CL 1453696 was
reverted in
https://chromium-review.googlesource.com/c/chromium/src/+/1519947
due to https://bugs.chromium.org/p/chromium/issues/detail?id=931157.

Bug: 914741
Tests: Ran all browser and unit tests, manually checked as well.
Change-Id: I95bd7cc31ccbd0631201414142cfe9b4cf44073f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525253Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642304}

Change the use of constexpr where it is needed.
But, tests and example code need to be arranged.

Bug: 940125
Change-Id: Ie072337a887a499fd003c0692784fe0a1fec7728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517482Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Sangseok Jang <sangseok.jang@navercorp.com>
Cr-Commit-Position: refs/heads/master@{#642303}

https://skia.googlesource.com/skia.git/+log/78e6a4c1ff67..7b49eeb4960b


git log 78e6a4c1ff67..7b49eeb4960b --date=short --no-merges --format='%ad %ae %s'
2019-03-19 fmalita@chromium.org [skottie] Turn on AA for solid layers
2019-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 0e712410582f..2dc0303903b1 (1 commits)
2019-03-19 ethannicholas@google.com Revert "more relaxed precision decorations for SPIR-V output"
2019-03-19 halcanary@google.com Docs: fix more case-sensitive names
2019-03-19 fmalita@chromium.org [skottie] Initial camera support
2019-03-19 michaelludwig@google.com Respect strict constraint in drawEdgeAAImageSet


Created with:
  gclient setdep -r src/third_party/skia@7b49eeb4960b

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I3fbb870e4018108b6730c9ec5b6cff1ef0256987
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531343Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#642302}

The user image screen is not shown during (in session) OOBE anymore, so
it's safe to assume screen manager will not have it (it's not being
created any longer).

BUG=942257

Change-Id: I551a800ec762cf35c749511fa949ffbec0219c4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529479Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642301}

This prevents resizing a vector to a fake and extremely large size.

Bug: 942428
Change-Id: I020b9b3eb3516dfcfc65d4687ce4e3a5a0e3a9ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526305
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642300}

In gpu driver bug item 172, the description is "Use GL_INTEL_framebuffer_CMAA
on ChromeOS" while the workaround name is "disable_framebuffer_cmaa".

It's confusing when it is shown in chrome://gpu page. "Use CMAA on ChromeOS"
description is displayed on all platforms(Windows, Android, etc). Except
on ChromeOS when CMAA is enabled, "Use CMAA on ChromeOS" is not shown in
chrome://gpu page.

This patch changes the workaround name to use_framebuffer_cmaa and makes "Use
CMAA" only showing up in chrome://gpu when CMAA is enabled.

Bug:943416

Change-Id: Iedfe4e353e1f16f91d7bae7ec1f7e432ead70a03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527868
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642299}

This CL is a preparatory CL for iron-list and removes the
expand/collapse animation from the stream item. To make the stream item
a more lightweight component while still maintaining functionality,
iron-collapse is replaced with a div with a hidden property and contents
of #activity-item-main-row are now in the slot for cr-expand-button.

Bug: 932768
Change-Id: Iad7bdcc0ce44d1f3b40600c2d953586da7e00d9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525621Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642298}

This is a run of
run-clang-tidy.py -checks="-*,modernize-make-unique" -header-filter=ui/views/* \\src\\ui\\views\\

BUG=940732
TBR=sky@chromium.org

Change-Id: Ifb08544f0dc310e689d21a1ca9b7ae815e570bb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529869Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642297}

Corrects an oversight in a previous CL where we weren't checking if
thumbnail data had changed.

Bug: 928954
Change-Id: I957b443a8f56b90ab1314aff105c1b302627b537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531511Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642296}

ProcessMemoryMetricsEmitterTest.FetchAndEmitMetricsWithHostedApps is
flaky, so disable it.

Bug: 943207
Change-Id: I7379cd4664c00f071137ff200d7f52d6400123db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529201Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642295}

TBR=pkl@chromium.org

Bug: 911864
Change-Id: I35f0e9c6041d0024787b72d94293bc688a901437
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531509Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642294}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b69b09d2ceaf..924b8b1c0a7f


Created with:
  gclient setdep -r src-internal@924b8b1c0a7f

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=ksakamoto@chromium.org,mmentovai@chromium.org,carlosk@chromium.org,hendrich@chromium.org

Change-Id: I37f7a4a044367e6d3bff48aaafd0afbe514819cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531342Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#642293}

This CL has the following fixes.
* Disable test that checks if 4xx responses with no via header are
fallbacked. These are no longer bypassed/fallbacked.

* Change protocol string from http/1 to http/2.

* Fix tests that use both the command arguments: spdy-proxy-auth-origin,
and data-reduction-proxy-http-proxies. This causes DCHECK failure in
GetOverrideProxiesForHttpFromCommandLine()

* Fix a test that relied on request_headers. Request headers of subresource
requests are no longer sent to DevTools/renderer process, with
network-servicification. Some more tests need to be fixed to not use
request_headers. See http://crbug.com/793692

Bug: 934875
Change-Id: Ia62bdd2f712e2d0320f9c1efdb5c752493ea3763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531480Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642292}

GetEnclosingElement returns the innermost element that encloses
the corresponding text range.

More info here:
https://docs.microsoft.com/en-us/windows/desktop/api/uiautomationcore/nf-uiautomationcore-itextrangeprovider-getenclosingelement

Unit test added.

Bug: 928948
Change-Id: Ie629bc5621e1fff7e837243aed60796ff16276e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521787
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642291}

This patch converts the web test with testharness to get rid of the
redundant -expected.txt for this crash test. It also makes the fixing of
issue 818888 easier.

Bug: 818888
Change-Id: Ib26f52eef84270e33a7b9eae1147e67507015089
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531477Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642290}

Bug: 935710
Change-Id: Iaae75bca959427458d29e7b81bf51d222af5c55a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487801
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642289}

Unfortunately, X11 tracks keyboard modifier state independently of
chrome, which is a problem for CrOS because we want to pretend numlock
is always on. For xwayland apps, pressing the numlock would temporarily
disable that behaviour until the window was refocused (and modifiers
were re-sent).

This fixes the issue by sending the modifier state after a numlock
event. An alternative considered was to block all numlock events
(see crrev.com/c/1524745) but this fix allows the key event to go
through normally (some applications might depend on the actual event).

Bug: 937102
Change-Id: I18080ab31f49367957d7923f68773fe6280b96a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529981
Commit-Queue: Nic Hollingum <hollingum@google.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642288}

Updates the goldctl version to pick up the latest, which fixes a
breaking issue, and removes the --no-skia-gold-failure flag from the
Gold-enabled GPU tests since the Gold integration seems to be working
properly now.

Bug: 850107
Change-Id: Ic6a8dab25694937da9c6753719b930e604c42b39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524999Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642287}

Change-Id: I7c2744d01616b11f5b40a14c223c27658bb4810d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530829
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642286}

Change-Id: I48da3c3c07e58f84bb241e8fbcd8979fd3fe638e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521459Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642285}

Bug: 942164
Change-Id: Iafd7827e722ee3eaa1d8f53fdd64982d53a305c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531476
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642284}

- As part of the proposed design, the Infobar Banner should be dismissed
after 6 seconds of being presented. This functionality is added by this CL.
- This implementation prevents the InfobarBanner from being dismissed while the
user is interacting with it.

Bug: 911864
Change-Id: I4d3942a825c6da3de0b267f341d16c4e7dd24ed0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529353
Auto-Submit: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642283}

Under an experiment flag, when a keyword hint is showing, have right
arrow trigger keyword mode. Since right arrow shouldn't be pressed for
any other reason here, we can interpret it as a more explicit entry
into keyword mode, and e.g. update the suggestions (which we can't do
when the user presses tab.)

Bug: 883901
Change-Id: I7a86a6246a88af137d0f1289e66d8bb1ff424225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528696
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642282}

This change preserves the behavior of existing focus rings. It changes
the interface by which information about the focus rings is communicated
from chrome/ to ash/, to allow for additional parameters and multiple
focus rings concurrently, with different visual styles, from a single
extension.

This change does not add full implementation of the additional
parameters. To keep the change size manageable, the implementation
details will be added in a follow-up change.

Bug: 925103
Change-Id: I83ea9767d7de2b451cbce61b4ff48e97629c8e90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504504
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642281}

Add missing key states modifiers for pointerevent boundary events and
pointerevent coalesced/predicted events.

Bug: 940433
Change-Id: Ieb7bb548fa857639ca7556523fb34b1ae02c65a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525311Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642280}

Their build machines (*not* test machines) were upgraded to 10.13.

R=jbudorick, martiniss

Bug: 943050
Change-Id: Ia59873760150ca493a9700cb496f881db115a45d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531065Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642279}