- 27 Apr, 2017 40 commits
-
-
moshayedi authored
* Use kFoo for enums. * Don't need to use mojom to test serialization of structs. BUG=NONE Review-Url: https://codereview.chromium.org/2843413002 Cr-Commit-Position: refs/heads/master@{#467712}
-
jbroman authored
It's easy to get this wrong and use Set instead, which can invoke author script in unexpected places. This is a convenient helper that does the right thing, similar to blink::V8ObjectBuilder. A unit test and two "real-world" uses are included. BUG= Review-Url: https://codereview.chromium.org/2845463002 Cr-Commit-Position: refs/heads/master@{#467711}
-
altimin authored
Make Platform::*Create methods return a unique_ptr instead of a raw pointer to explictly state ownership logic. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2846843002 Cr-Commit-Position: refs/heads/master@{#467710}
-
mikhail.pozdnyakov authored
At the moment SensorProxy is the only source of error notification for the Sensor class instances, however soon other error notification sources will turn up (e.g. permission subsystem), so we must guarantee that stopping of a Sensor due to an error is reflected on platform side. BUG=606766 Review-Url: https://codereview.chromium.org/2839963004 Cr-Commit-Position: refs/heads/master@{#467709}
-
pkotwicz authored
Previously, whenever the shell_apk in shell_apk_version.gni there was a period of time during which - Chrome tries to update the WebAPK because the "shell_apk" version with which Chrome is compiled with was updated - The WebAPK server is unable to fulfill the update request because the new ShellAPK has not yet been uploaded to the WebAPK server This CL splits shell_apk_version in shell_apk_version.gni into two variables: |template_shell_apk_version| and |expected_shell_apk_version| The new flow for updating android/webapk/shell_apk will be: 1) Write CL which: - Makes changes to code in android/webapk/shell_apk - Increments |template_shell_apk_version| This will: - Update the template ShellAPK which is built on the official build bot - Trigger an alert that the ShellAPK on the WebAPK Minting Server needs to be updated - Does not affect the "WebAPK update logic". 2) Upload new ShellAPK template to the WebAPK Minting Server At this point: - new WebAPK installs will have the updated shell. - Chrome will still not request updates to the new ShellAPK version 3) Write CL which: - Increments |expected_shell_apk_version| This will: - cause Chrome to request updates to the new ShellAPK version BUG=708053 Review-Url: https://codereview.chromium.org/2827233006 Cr-Commit-Position: refs/heads/master@{#467708}
-
tanvir.rizvi authored
Currently textQuads and ComputeTextRects algorithm is mostly same. The difference of behaviour of these two functions can be handled efficiently by using templates. This CL is the Second patch set to achieve the above behaviour. This CL introduces ComputeTextBounds as template function, which will be used by computeTextRects only in this patch. BUG=691198 Review-Url: https://codereview.chromium.org/2839633002 Cr-Commit-Position: refs/heads/master@{#467707}
-
mustaq authored
This "hidden" base class was forcing two virtual calls to reach a Frame from a WebFrame. It is now one virtual call away. BUG=713798 Review-Url: https://codereview.chromium.org/2837593002 Cr-Commit-Position: refs/heads/master@{#467706}
-
peconn authored
Introduce the FullscreenMediaActivity and move Tabs to it when entering fullscreen and away from it when leaving fullscreen. BUG=709042 Review-Url: https://codereview.chromium.org/2807663002 Cr-Commit-Position: refs/heads/master@{#467705}
-
wnwen authored
It is no longer necessary to list all the apk targets as separate modules now that we have the _all pseudo module. Having the separate modules resulted in bugs where Android Studio could not distinguish between prod code and test code since some modules viewed dirs as prod and some as test. The --split-projects flag can be used to see the dependency graph, and when only a single module will be generated, the _all pseudo module will not replace it. For android studio's _all pseudo module, move all known test dirs to androidTest instead of main so that they are properly displayed when filtered. BUG=620034 Review-Url: https://codereview.chromium.org/2837863002 Cr-Commit-Position: refs/heads/master@{#467704}
-
gambard authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2835413003 Cr-Commit-Position: refs/heads/master@{#467703}
-
mthiesse authored
Just a cleanup patch, no change in functionality. BUG= Review-Url: https://codereview.chromium.org/2843993002 Cr-Commit-Position: refs/heads/master@{#467702}
-
jinho.bang authored
The method to check whether the payment instrument for the specified key is stored. Related Spec Link: https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface BUG=661608 TEST=payment_manager_unittest.cc, payment-instruments.html Review-Url: https://codereview.chromium.org/2844673002 Cr-Commit-Position: refs/heads/master@{#467701}
-
fdoray authored
The main thread doesn't pump +system+ messages. R=gab@chromium.org TBR=gab@chromium.org BUG= Review-Url: https://codereview.chromium.org/2847773002 Cr-Commit-Position: refs/heads/master@{#467700}
-
lunalu authored
Replace implementation of allowpaymentrequest and allowfullscreen by feature policy. Enable iframe feature policy by attributes: allow="feature1 feature2", allowfullscreen, and allowpaymentrequest. See design doc: https://docs.google.com/a/chromium.org/document/d/1sskoBi7Ba7hLuuiJQ6VMQ1KYIGBP8Lr87hLbkF76c2I/edit?usp=sharing Part 1: Introduce iframe allowAttr in HTMLIFrameElement::parseAttribute and store featureNames in HTMLIFrameElement (CL: https://codereview.chromium.org/2680083002/) Part 2: Propagate featureNames from HTMLIFrameElement to frame owner and remote frame owner. (CL: https://codereview.chromium.org/2697713003) Part 3: Set iframe feature policy in FrameLoader::didBeginDocument 3.a Replace string by enum in WebParsedFeaturePolicyDeclaration#feature (CL: https://codereview.chromium.org/2727803004/) 3.b Rename WebParsedFeaturePolicyHeader to WebParsedFeaturePolicy (CL: https://codereview.chromium.org/2738953002/) Part 4: Replace implementation of allowpaymentrequest and allowfullscreen by feature policy. BUG=682256 Review-Url: https://codereview.chromium.org/2767983003 Cr-Commit-Position: refs/heads/master@{#467699}
-
sebsg authored
Also make sure that the user cannot click pay until we get the callback from the merchant. BUG=715170,715597 Review-Url: https://codereview.chromium.org/2836353002 Cr-Commit-Position: refs/heads/master@{#467698}
-
dcastagna authored
After https://codereview.chromium.org/2789363004 landed, Ozone Drm supports the KMS "rotation" property that can be used to set a transform to HW overlays. This CL relaxes the transform restrictions of the fullscreen and single on top overlay strategies. Additionally, it makes sure that any configuration containing a transform will be reject if the legacy page flip is being used. After this CL WebGL and Pepper content can be promoted to HW overlay when backed by a Gpu Memory Buffer. BUG=b/36752417 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2794343003 Cr-Commit-Position: refs/heads/master@{#467697}
-
nednguyen authored
The fix for handling case thread_time equals None was landed. BUG=715822 TBR=wangxianzhu@chromium.org Review-Url: https://codereview.chromium.org/2849553002 Cr-Commit-Position: refs/heads/master@{#467696}
-
bmcquade authored
Reland of Break page load metrics test dependency on IPC. (patchset #1 id:1 of https://codereview.chromium.org/2847803002/ ) Reason for revert: The flake that caused the previous revert by zmin existed before the original patch landed, so the original patch is not the cause of the flake. This refactor should help us to un-flake the test, so I'm re-landing it. Original issue's description: > Revert of Break page load metrics test dependency on IPC. (patchset #2 id:20001 of https://codereview.chromium.org/2847513002/ ) > > Reason for revert: > PageLoadMetricsBrowserTest.DocumentWriteReloada is flaky > > https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20MSan%20Tests/387 > > Original issue's description: > > Break page load metrics test dependency on IPC. > > > > This change breaks direct dependencies on IPC for page load metrics > > tests, in order to ease the transition to mojo. > > > > Previously, unit tests exercised the IPC dispatch path. This > > achieved slightly increased coverage but coupled unit tests to > > IPC. We now dispatch simulated timing events directly to callbacks, > > bypassing the IPC dispatch. > > > > Additionally, we break the browsertest dependency on IPC and add > > a MetricsWebContentsObserver::TestingObserver, which can observe > > state changes at the observer level, instead of watching for IPC > > messages. This both simplifies the logic and more directly verifies > > expected behavior at the appropriate level. > > > > BUG=715744 > > TBR=csharrison > > > > Review-Url: https://codereview.chromium.org/2847513002 > > Cr-Commit-Position: refs/heads/master@{#467687} > > Committed: https://chromium.googlesource.com/chromium/src/+/9567f9fa3fcfcaa50fc7b6a6adf66106a2eb6be5 > > TBR=lpy@chromium.org,bmcquade@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=715744 > > Review-Url: https://codereview.chromium.org/2847803002 > Cr-Commit-Position: refs/heads/master@{#467691} > Committed: https://chromium.googlesource.com/chromium/src/+/2cb37fe0beb13e6baa8852662362e9204d1ebfa3 TBR=lpy@chromium.org,zmin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=715744 Review-Url: https://codereview.chromium.org/2849563002 Cr-Commit-Position: refs/heads/master@{#467695}
-
wangxianzhu authored
Many layout changes e.g. resizing doesn't affect computed collapsed borders so don't need to invalidate collapsed borders. We need to invalidate collapsed borders when 1. Table sections are set need recalc (when table structure changes); 2. A cell is appended into a row (which could belong to 1 but we have an optimization not to recalc table sections if the added cell is the last cell of the table); 3. Border style changes; 4. border-collapse CSS property changes; This CL will reduce frame time of PerformanceTests/Mutation/large- table-row-height-change-with-collapsed-border.html (in https://codereview.chromium.org/2842313002/) by about 35% by avoiding unnecessary collapsed border recalculations. BUG=626748 Review-Url: https://codereview.chromium.org/2840723005 Cr-Commit-Position: refs/heads/master@{#467694}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=jialiul@chromium.org Review-Url: https://codereview.chromium.org/2833373004 Cr-Commit-Position: refs/heads/master@{#467693}
-
mlamouri authored
The flag should only be set by tests and will allow all autoplay related restrictions such as autoplay policy and background playback to be disabled. BUG=714676 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2843913003 Cr-Commit-Position: refs/heads/master@{#467692}
-
zmin authored
Revert of Break page load metrics test dependency on IPC. (patchset #2 id:20001 of https://codereview.chromium.org/2847513002/ ) Reason for revert: PageLoadMetricsBrowserTest.DocumentWriteReloada is flaky https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20MSan%20Tests/387 Original issue's description: > Break page load metrics test dependency on IPC. > > This change breaks direct dependencies on IPC for page load metrics > tests, in order to ease the transition to mojo. > > Previously, unit tests exercised the IPC dispatch path. This > achieved slightly increased coverage but coupled unit tests to > IPC. We now dispatch simulated timing events directly to callbacks, > bypassing the IPC dispatch. > > Additionally, we break the browsertest dependency on IPC and add > a MetricsWebContentsObserver::TestingObserver, which can observe > state changes at the observer level, instead of watching for IPC > messages. This both simplifies the logic and more directly verifies > expected behavior at the appropriate level. > > BUG=715744 > TBR=csharrison > > Review-Url: https://codereview.chromium.org/2847513002 > Cr-Commit-Position: refs/heads/master@{#467687} > Committed: https://chromium.googlesource.com/chromium/src/+/9567f9fa3fcfcaa50fc7b6a6adf66106a2eb6be5 TBR=lpy@chromium.org,bmcquade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=715744 Review-Url: https://codereview.chromium.org/2847803002 Cr-Commit-Position: refs/heads/master@{#467691}
-
mattgaunt authored
BUG=715691 Review-Url: https://codereview.chromium.org/2842293002 Cr-Commit-Position: refs/heads/master@{#467690}
-
rouslan authored
After this patch, Android payment applications can support "interledger" payment method by adding the following section to their AndroidManifest.xml file: <activity android:name=".PaymentActivity" android:exported="true"> <intent-filter> <action android:name="org.chromium.intent.action.PAY" /> </intent-filter> <meta-data android:name="org.chromium.default_payment_method_name" android:value="interledger" /> </activity> Flag: chrome://flags/#android-payment-apps Design: https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE BUG=715577 Review-Url: https://codereview.chromium.org/2850503002 Cr-Commit-Position: refs/heads/master@{#467689}
-
gogerald authored
In this patch: Try to fetch all supported web app ids for the payment method from the cache before downloading its manifest online. If cached web app ids contain all matching apps ids, proceed fetching corresponding web apps manifests from the cache. Otherwise fall back to download the payment method's manifest online. If failed to fetch at least one web app's manifest from the cache, then fall back to download payment method's manifest online. In addition: Cache downloaded and parsed supported web apps ids of the payment method for future reference. Cache downloaded and parsed web app manifest sections for future reference. Refer to below doc for details. https://docs.google.com/a/google.com/document/d/1Ncsp96Ae5836NLOdPwHRzcX3zkgj-4-5fq_nI2azC7M BUG=708508 Review-Url: https://codereview.chromium.org/2838433002 Cr-Commit-Position: refs/heads/master@{#467688}
-
bmcquade authored
This change breaks direct dependencies on IPC for page load metrics tests, in order to ease the transition to mojo. Previously, unit tests exercised the IPC dispatch path. This achieved slightly increased coverage but coupled unit tests to IPC. We now dispatch simulated timing events directly to callbacks, bypassing the IPC dispatch. Additionally, we break the browsertest dependency on IPC and add a MetricsWebContentsObserver::TestingObserver, which can observe state changes at the observer level, instead of watching for IPC messages. This both simplifies the logic and more directly verifies expected behavior at the appropriate level. BUG=715744 TBR=csharrison Review-Url: https://codereview.chromium.org/2847513002 Cr-Commit-Position: refs/heads/master@{#467687}
-
moshayedi authored
This CL adds ui.mojom.CandidateWindowProperties and ui.mojom.CandidateWindowEntry and corresponding struct traits. BUG=637416, 672587 Review-Url: https://codereview.chromium.org/2839243002 Cr-Commit-Position: refs/heads/master@{#467686}
-
peter authored
These four properties were not being copied over when populating a WebServiceWorkerRequest from a Request. These properties are already being copied over when converting in the other direction in FetchRequestData::Create(). BUG= Review-Url: https://codereview.chromium.org/2828293002 Cr-Commit-Position: refs/heads/master@{#467685}
-
bratell authored
There were two helper functions IsInDocument implementations in core/input and this moves them to EventHandlingUtil so they can be shared. R=dtapuska@chromium.org Review-Url: https://codereview.chromium.org/2845973002 Cr-Commit-Position: refs/heads/master@{#467684}
-
danakj authored
R=enne@chromium.org Review-Url: https://codereview.chromium.org/2843233002 Cr-Commit-Position: refs/heads/master@{#467683}
-
gambard authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2835643002 Cr-Commit-Position: refs/heads/master@{#467682}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=rkaplow@chromium.org Review-Url: https://codereview.chromium.org/2769803002 Cr-Commit-Position: refs/heads/master@{#467681}
-
sdefresne authored
Duplicates configs defined in //build/config/mac/BUILD.gn that are shared with iOS to //build/config/ios/BUILD.gn. Remove all conditions testing "is_mac" or "is_ios" (as they are now known from the filename). Change dependencies on previously shared targets to select the correct target based on the "target_os". BUG=635745 Review-Url: https://codereview.chromium.org/2843493002 Cr-Commit-Position: refs/heads/master@{#467680}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/594d9c9e..3338869a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2845933003 Cr-Commit-Position: refs/heads/master@{#467679}
-
msarett authored
TBR=reed@google.com NO_TRY=true BUG=skia:6464 Review-Url: https://codereview.chromium.org/2844223003 Cr-Commit-Position: refs/heads/master@{#467678}
-
Robert Sesek authored
Don't do work in DCHECKs. BUG=715792 R=nasko@chromium.org Review-Url: https://codereview.chromium.org/2847573002 . Cr-Commit-Position: refs/heads/master@{#467677}
-
xiaochengh authored
There are some valid DOM positions (*) that do not have corresponding valid flat tree positions. This patch adds special handling of such DOM positions, so that when computing VisibleSelectionInFlatTree from SelectionInDOMTree, such positions are converted to NULL instead of invalid flat tree positions, so that the renderer does not crash. (*) If NODE is a direct child of a shadow host but is not distributed into the flat tree, NODE@BeforeAnchor and NODE@AfterAnchor are valid Position but invalid PositionInFlatTree. This patch handles these two kind of positions. BUG=702756, 709872, 712984 TEST=FrameSelectionTest.SelectInvalidPositionInFlatTreeDoesntCrash Review-Url: https://codereview.chromium.org/2850443002 Cr-Commit-Position: refs/heads/master@{#467676}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2843583002 Cr-Commit-Position: refs/heads/master@{#467675}
-
lanwei authored
In blink, we convert mouse enter and leave events to mouse move events, we should not do it anymore. We should keep their types, so we know they are actual enter or leave events. I looked at the code, PointerEventManager::SendMousePointerEvent has a separate argument called mouse_event_type, which is always the type of mouse move, and mouseevent's type is not referred anymore. It should be safe to remove the conversion. BUG=686196 Review-Url: https://codereview.chromium.org/2839103002 Cr-Commit-Position: refs/heads/master@{#467674}
-
cjgrant authored
This change maps VR controller input to non-content UI elements. The content element is treated separately, so that it can handle scrolling and fling-type input (these are currently not useful to other elements). BUG=715554 Review-Url: https://codereview.chromium.org/2840183003 Cr-Commit-Position: refs/heads/master@{#467673}
-