- 06 Dec, 2017 40 commits
-
-
Tetsui Ohkubo authored
As new style notification is launched in M62, and IsNewStyleNotificationEnabled() returns true by default on Chrome OS, we no longer have to check IsNewStyleNotificaitonEnabled(). This CL makes following changes. - Remove IsNewStyleNotificationEnabled checks under chrome/browser/chromeos. (*.cc) - Remove UI strings that are no longer used. (*.grdp) - Remove icons that are no longer used. (*.png, *.icon) Icons that are not removed are referenced in somewhere. BUG=757703 Change-Id: I46e52295115c3e0a619d1eeefb02321034ce5117 Reviewed-on: https://chromium-review.googlesource.com/802601Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#522004}
-
Zhenyao Mo authored
BUG=774174 TEST=https://github.com/KhronosGroup/WebGL/pull/2555 R=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4f4e7636314502451104730501a5048a5d7b9f3f Reviewed-on: https://chromium-review.googlesource.com/808665 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#522003}
-
Peiyong Lin authored
We want to plumb frame visibility change to GRC. Before that, we want to understand the volume of IPC. This patch adds histogram to record the frame visibility when it's changed. BUG=790680 Change-Id: Ib798308bf18473c1432cbe651ac9217714115b9a Reviewed-on: https://chromium-review.googlesource.com/807351Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: lpy <lpy@chromium.org> Cr-Commit-Position: refs/heads/master@{#522002}
-
Bugs Nash authored
Changed custom applyValue code for border-image-source and -webkit-mask-box-image-source to be hand written instead of generated with a custom template as the savings on code duplication aren't large enough to warrant the added code complexity. These hand written custom methods will be moved to property classes after all the generated methods are moved. Bug: 751354 Change-Id: Ie983aa0b3a13bddc3c0435faf40e0960e2d2dac5 Reviewed-on: https://chromium-review.googlesource.com/810245Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#522001}
-
Tatsuhisa Yamaguchi authored
appWindow object doesn't have reload() method ready until the window is loaded. This is a quick fix to avoid crashing the background script by user operation. Test: manually verified as noted in the bug Bug: 789226 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie2266792d8ca62bd0bae74ff2824b72221acbdb7 Reviewed-on: https://chromium-review.googlesource.com/800910Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#522000}
-
Miguel Casas-Sanchez authored
This CL sorts out a few points to clear the way for crrev.com/c/784330 to be landed again; these changes are, in a nutshell using NumTextures() ISO NumPlanes() where appropriate, and rewriting the service function NumGpuMemoryBuffers() for clarity and to allow for removing FinalVideoFormat(). TEST=all unittests working as before, Video playback in all platforms and with/without video deco acceleration running as on ToT. Bug: 791676 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic8f0a646a7a0d9271d7233681cb0383e3f6f64ba Reviewed-on: https://chromium-review.googlesource.com/807366 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#521999}
-
Dominic Mazzoni authored
The second argument to NotifyAccessibilityEvent is whether we should fire a native event, otherwise just a Chrome OS event is fired. This should almost always be true. Changing this one case from false to true fixes the linked bug where the combobox in the bookmarks popup didn't announce when changing. Bug: 779302 Change-Id: Ida63037d8a7a01e43150e7e3e2398a965d8405eb Reviewed-on: https://chromium-review.googlesource.com/809728Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#521998}
-
chrome-release-bot authored
TBR=mmoss@chromium.org Change-Id: I3cf9c1cfaf12d1ee381806276cc3c01aaad5ef74 Reviewed-on: https://chromium-review.googlesource.com/810273Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#521997}
-
Philip Rogers authored
This patch ensures the scrolling contents layer is repainted when the background color is changed with the inspector protocol. Bug: 781428 Change-Id: Ia7ba3e7acdf55bf557e42cd9fab62d08f2ce3a0c Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Reviewed-on: https://chromium-review.googlesource.com/805006 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#521996}
-
Deepanjan Roy authored
We are experimentally enabling some of the histograms of the new cpu time metric on the perf dashboard so we can evaluate the noise level and discover any other existing issues of the metric. Bug=catapult:#3325 Change-Id: I292d7228bde22dafa7f2daf1689896a0729b2631 Reviewed-on: https://chromium-review.googlesource.com/809202Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Deepanjan Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#521995}
-
Ryan Landay authored
We have several call sites that construct an EphemeralRange from a SelectionTemplate by calling EphemeralRange(selection.ComputeStartPosition(), selection.ComputeEndPosition()). This CL adds a helper method so these callsites can just do selection.ComputeRange(). Change-Id: Iaf9a8d1fa461e45f3070204bc4fd28b2b5793169 Reviewed-on: https://chromium-review.googlesource.com/806439 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
yosin (OOO Dec 11 to Jan 8) <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521994}
-
David Dorwin authored
Bug: 788768 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I205ec4c543c26f42e41d124981a9a258faa7c594 Reviewed-on: https://chromium-review.googlesource.com/798632 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#521993}
-
Dominic Mazzoni authored
Bug: 791634 Change-Id: I1204aa60160afe95c21c27b693283133ea33fd80 Reviewed-on: https://chromium-review.googlesource.com/806878Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#521992}
-
Peng Huang authored
And this CL also fixes an issue to make sure ppapi plugin will request the discardable memory interface from ui service instead of browser when the browser is launched with --mus flag. Bug: 791119 Change-Id: I1ce2b256c2280fe02c364aff8d199ab4c43618f0 Reviewed-on: https://chromium-review.googlesource.com/806482Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521991}
-
Kevin Marshall authored
This reverts commit 0f06f8fd. Reason for revert: CIPD doesn't allow multiple .ensure files to coexist, crbug.com/789809 Original change's description: > Fuchsia: use CIPD to check out arch-specific QEMU binaries. > > These binaries allow us to run QEMU on ARM; the current deployment > in the Fuchsia SDK folder is x86-64 only. > > The "qemu" folder can safely be removed from the Fuchsia SDK > once this CL lands and the trybots are confirmed to still be in > working order. > > Also modify the runner script to use arch-specific QEMU binaries. > > > Bug: 786193 > Change-Id: I1515bdf330f496ff47f88ba3b131629d4e24fea3 > Reviewed-on: https://chromium-review.googlesource.com/783699 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519536} TBR=dpranke@chromium.org,kmarshall@chromium.org,scottmg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 786193 Change-Id: I320cf80f222c337b38e91e0f10ef2a3479f45f9d Reviewed-on: https://chromium-review.googlesource.com/810088 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#521990}
-
Tatsuhisa Yamaguchi authored
VolumeReaderJavaScriptStream::Seek() doesn't return error even when the file is not readable. Also the error in Read() was not handled before. This was causing infinite loop when the archive became inaccessible, such as when the archive was deleted by the user. This change adds error handling on Read(). Bug: 791924 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2774e53ed25eea50e6abe62ec7c52f4237c24c25 Reviewed-on: https://chromium-review.googlesource.com/808524 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#521989}
-
Alexei Filippov authored
BUG=690825 Change-Id: I6c4d4bc7dfe074d5a7b1a63a1ce527bc074ca506 Reviewed-on: https://chromium-review.googlesource.com/809647Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#521988}
-
Steven Holte authored
Bug: 754889 Change-Id: Iabbd43da20b9e1bf8f318b78b141b75f62dd62fd Reviewed-on: https://chromium-review.googlesource.com/804827 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#521987}
-
Kunihiko Sakamoto authored
This reverts commit 134ea9de. Reason for revert: Broke WinMSVC64 (dbg) Build: https://ci.chromium.org/buildbot/chromium.win/WinMSVC64%20(dbg)/740 Original change's description: > Ribbonize ComputedStyleCSSValueMapping colors > > This CL also changes the behavior for ColumnRuleColor. > It used to call VisitedDependentColor(CSSPropertyOutlineColor), > but that seemed wrong so I changed it to use > VisitedDependentColor(CSSPropertyColumnRuleColor). > > There will be more CLs immediately following to finish Ribbonizing > this class. Please ping me for a link to the design doc. > > Bug: 775360 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I2b204146eafdd1fd7a74d8a9b8c8bb707d5f3eea > Reviewed-on: https://chromium-review.googlesource.com/781442 > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: meade_UTC10 <meade@chromium.org> > Commit-Queue: Renée Wright <rjwright@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521980} TBR=aboxhall@chromium.org,haraken@chromium.org,rjwright@chromium.org,meade@chromium.org,shend@chromium.org Change-Id: Ia95e9bd383940bdef3201d7f325973ff9649678c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775360 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/810324Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#521986}
-
Zhenyao Mo authored
BUG=791788 TEST=crash reports R=piman@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic7a68b18e42241b4c67188098bc536c37c2fdeef Reviewed-on: https://chromium-review.googlesource.com/810049Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#521985}
-
Ryan Landay authored
TypingCommand::InsertText(const String&, bool, EditingState*) is sort of messed up right now because it calls AdjustSelectionAfterIncrementalInsertion(), which calls FrameSelection::SetSelection(), which we want to hoist out of here (see discussion at https://goo.gl/GFgLF3). This CL removes AdjustSelectionAfterIncrementalInsertion's call to SetSelection() and replaces it with some logic in InputMethodController::SetComposition() to pull the ending selection out of the most recent UndoStep. This sets us up to avoid an unnecessary selectionchange event. Currently, SetComposition() does the following: 1. Selects the composition range. 2. Replaces the selection with the new text (requesting that the new text be left selected). 3. Converts the selection back into a composition range. This CL sets us up to avoid actually selecting the range in step 2; instead, we can make TypingCommand::InsertText() set it as the ending selection, and InputMethodController can retrieve it from the UndoStep. Bug: 790801 Change-Id: I9111af255f61c34f5bdaf27b94a5e8a659750860 Reviewed-on: https://chromium-review.googlesource.com/807151Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
yosin (OOO Dec 11 to Jan 8) <yosin@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#521984}
-
Andrey Lushnikov authored
The test seems to be passing reliably. BUG=chromium:667371 TBR=dgozman Change-Id: I2a277bcf08d8c4b3820a8553e228a88df0ee66e1 Reviewed-on: https://chromium-review.googlesource.com/809776Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#521983}
-
Lei Zhang authored
Change-Id: Ie30782130f7c28ad3b271c25bff73fd6ff4bb507 Reviewed-on: https://chromium-review.googlesource.com/804671 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#521982}
-
Han Leon authored
This CL moves service_worker_installed_scripts_manager.mojom from content/common/service_worker/ into third_party/WebKit/common/service_worker/, in preparation to merge content::WebServiceWorkerInstalledScriptsManagerImpl into Blink. BUG=789854,789846 Change-Id: Ice64bb4ad56602370fc14fa6cd21fd124d454a42 Reviewed-on: https://chromium-review.googlesource.com/807761 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#521981}
-
Renee Wright authored
This CL also changes the behavior for ColumnRuleColor. It used to call VisitedDependentColor(CSSPropertyOutlineColor), but that seemed wrong so I changed it to use VisitedDependentColor(CSSPropertyColumnRuleColor). There will be more CLs immediately following to finish Ribbonizing this class. Please ping me for a link to the design doc. Bug: 775360 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2b204146eafdd1fd7a74d8a9b8c8bb707d5f3eea Reviewed-on: https://chromium-review.googlesource.com/781442Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#521980}
-
Brett Wilson authored
This simplifies some constructors. Change-Id: I5ca3d141c6ad7d4837cd0d97bdcc17524914629d Reviewed-on: https://chromium-review.googlesource.com/805414 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#521979}
-
zhuoyu.qian authored
This patch makes EFillAttachment, EFillBox, EFillRepeat and EFillLayerType to be enum class for better type safety. Bug: 684966 Signed-off-by:
zhuoyu.qian <zhuoyu.qian@samsung.com> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1738b905c71a566d7063a8467afbe920f4497509 Reviewed-on: https://chromium-review.googlesource.com/776409Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#521978}
-
Chandan Padhi authored
This CL introduces Mojom struct for content::MediaDeviceInfo and removes its IPC_STRUCT_TRAITS in favor of StructTraits. This is in preparation for migration of MediaDevices.enumerateDevices() processing from content to Blink. Bug: 764680 Change-Id: Idc17f1b53963d2fb7a80b4ac98890913cb5ad521 Reviewed-on: https://chromium-review.googlesource.com/807840 Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521977}
-
Alice Boxhall authored
Bug: 768278 Change-Id: I3d5f1aadba1ca967ecf8cb2a0f07e1e22de92559 Reviewed-on: https://chromium-review.googlesource.com/807404 Commit-Queue: meade_UTC10 <meade@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#521976}
-
Chris Harrelson authored
In GPU raster mode, only one raster task can be active at a time. This means that these rasters have to happen quickly, or they will block other work. For this reason, we should not allow pre-paint GPU raster tasks which might have very slow performance to execute, because otherwise they will block future high-priority on-screen raster tasks. Raster tasks can have at-raster image decoding if the memory for storing pre-decoded images has been exhausted. This is the case in the website referenced in the bug. In these cases, rather than allowing the raster to proceed and potentially jank display due to long image decodes, we abort the raster, but still proceed with the image decodes (which don't block other raster, and may be useful to decode in any case). Bug: 768799 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I2ec78361739b7b8f455f26211f21a5f8e995a8b6 Reviewed-on: https://chromium-review.googlesource.com/806855 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521975}
-
Kyle Horimoto authored
Previously, much of the BLE code was keyed by RemoteDevice instead. This can cause subtle race conditions; for example: (1) Register remote device A. (2) CryptAuth sync occurs; device A is updated. (3) Register remote device A again. Since device fields have changed, this would be considered a different device. (4) Multiple connections are attempted to the same device. These issues are recoverable, since the MessageTransferOperation which registered the original device (before the update) will eventually finish and unregister the device; however, during this time period, connections are prone to errors. Bug: 777610, 672263 Change-Id: I9e6ed9c2ad69cb318863268f041db7b5f5ec3bd5 Reviewed-on: https://chromium-review.googlesource.com/738467 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#521974}
-
Raymes Khoury authored
This changes the function which checks whether permissions are controlled by the DSE to take an extra argument for the ContentSettingsType which allows querying whether a particular type is allowed. This simplifies code at callsites since we can centralise the check for the Notifications feature flag and it also means that we can have a central location for the list of supported permissions. As a side effect of this change, the Page Info bubble will now correctly display the text "Allow/Block for the current search engine" next to the notifications permission, when the GrantNotificationsToDSE feature is enabled. Bug: 780344 Change-Id: I0300397e337c47e4eee83a10dd4900d8ca7d86f0 Reviewed-on: https://chromium-review.googlesource.com/795520Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#521973}
-
Sergey Volk authored
Removed SetConfig for optional audio codecs, those are useless and only produce noise in test logs. Also marked PCM/PCM_16BE as mandatory. Bug: none Test: cast_media_unittests Change-Id: I73ea213f109e1bbc26194a88a09d946db47ce346 Reviewed-on: https://chromium-review.googlesource.com/810124 Commit-Queue: Sergey Volk <servolk@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#521972}
-
Chandan Padhi authored
This CL introduces Mojom enum for content::MediaDeviceType and removes its IPC_ENUM_TRAITS in favor of EnumTraits. This is in preparation for migration of MediaDevices.enumerateDevices() processing from content to Blink. Bug: 764680 Change-Id: I5e3c96adb7fd96e1d0ea41dff933ecac017228fa Reviewed-on: https://chromium-review.googlesource.com/806054Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#521971}
-
Raymes Khoury authored
This makes SearchPermissionService preserve the correct content setting values when content setting enterprise policies are in effect. It is changed to use GetUserModifiableContentSetting which will always return the user defined content setting, even when an enterprise policy is in place. Bug: 780344 Change-Id: I8b9362ddd6580c602270f7b5d8d9dafbb467a896 Reviewed-on: https://chromium-review.googlesource.com/807865Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#521970}
-
Darren Shen authored
When parsing custom properties or retrieving them from CSSOM, we need to return a CSSUnparsedValue. Spec: https://drafts.css-houdini.org/css-typed-om-1/#normalize-tokens Bug: 788570, 779477 Change-Id: Ia2fa289dc076ffd6dbacf03822907663209c6284 Reviewed-on: https://chromium-review.googlesource.com/804920Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#521969}
-
Isha Bobra authored
This CL wraps "xyz B" shown on Data saver screen for data statistics with TtsSpan of type TYPE_MEASURE so that TTS engine announces it as "xyz bytes" Bug: 461909, 786947 Change-Id: I8924a3cc904e9dc1f0cccc1dc1fa955f9d52a2b2 Reviewed-on: https://chromium-review.googlesource.com/784052 Commit-Queue: Isha Bobra <ibobra@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#521968}
-
Fumitoshi Ukai authored
new bots were added at https://chromium.googlesource.com/chromium/src.git/+/b7cd67a303ff371a2b04c9f3dcbc24322fa86ebb bots are renamed https://chromium.googlesource.com/chromium/tools/build/+/dff3a4e2f2a4ca45a6f5d6f9459630a672ab2a55 https://chromium.googlesource.com/chromium/tools/build/+/6bed769f844ca3b714071e1bd7deea35ba42da46 https://chrome-internal.googlesource.com/infradata/master-manager/+/781eb935a1025b53fe88fad8e92d2e4cb02cc0f9 ToTWin Goma Canary was removed. http://crbug.com/791837 Bug: 740416 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icc4d2f53864f175b0d9e0f037b0be5edb7d8962b Reviewed-on: https://chromium-review.googlesource.com/807640Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
smut <smut@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#521967}
-
Randy Smith authored
Bug: 785420 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I67ddf477232a12d3a1848b9982695abce3ec397c Reviewed-on: https://chromium-review.googlesource.com/773635Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#521966}
-
Sky Malice authored
On disk timestamps were using second resolution, while in memory and sync representations were using microsecond. This meant that by round tripping data to disk, the actual values would chance slightly. There were several places that compared timestamps, and these difference did no fix themselves, but rather resulted in repeated churn. The database columns were already 64 bit integers, so this change doesn't even modify the schema, just changes the format of data stored. Bug: 775049 Change-Id: I03886d249c4b9195f20b897d309da6063db4bf6f Reviewed-on: https://chromium-review.googlesource.com/806646 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#521965}
-