- 05 Oct, 2017 40 commits
 - 
- 
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/1ea81e766e1a..01f8e41c1368 $ git log 1ea81e766..01f8e41c1 --date=short --no-merges --format='%ad %ae %s' 2017-10-05 robertphillips Revert "Clean up SkString reference counting a bit." Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ide44641f756c3a69826bc65303f58ca7973f8a38 Reviewed-on: https://chromium-review.googlesource.com/701322Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506711}
 - 
Bence Béky authored
Bug: 554220 Change-Id: Id4652e6c43de606dacfb4a32d01d0cb3e057a226 Reviewed-on: https://chromium-review.googlesource.com/700403Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#506710}
 - 
Stephen Martinis authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/691065. Some of that CL changed code structure which we want to keep. We don't want the compile target on the builder anymore though. Bug: 758630 Change-Id: I480018df2bbaa9ded3f2747c93849a5e59a6ddf7 Reviewed-on: https://chromium-review.googlesource.com/695834Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#506709}
 - 
Andy Paicu authored
When updating the history after a cross-origin navigation, the HTML Standard says: "If the browsing context is a top-level browsing context, but not an auxiliary browsing context, then set the browsing context's name to the empty string." Currently we are not doing this which means there's potential information leak. Spec: https://html.spec.whatwg.org/multipage/browsers.html#resetBCName I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/fhUIycdlINU/RLVEOKaNAwAJ Webkit change: https://trac.webkit.org/changeset/209076/webkit Bug: crbug.com/706350 Change-Id: I70cb3efcef06a3442ed4bf9ddd3733e24ccde19d Reviewed-on: https://chromium-review.googlesource.com/645309 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#506708}
 - 
Boris Sazonov authored
Getting account list can take a while, especially in edge cases like after Google Play Services update. This CL addresses this by adding a cache for account list. Accessing the cache is cheap, so getGoogleAccounts() and similar methods can now be safely invoked from UI thread. The only edge case for getGoogleAccounts() is a time period before the cache is populated after Chrome startup. In this case getGoogleAccounts() will wait until the cache is populated. If this waiting occurs on UI thread, it will record waiting time in Signin.AndroidPopulateAccountCacheWaitingTime histogram. Bug: 698258, 759798 Change-Id: I1e9b481cb4ccf4c24ff363fb7f4214d9d8c571f7 Reviewed-on: https://chromium-review.googlesource.com/675684Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#506707}
 - 
Thiemo Nagel authored
This reverts commit 22fa13f2. Reason for revert: interactive_ui_tests are timing out. Speculative revert (the other CL in the regression range looks like an unlikely culprit to me). https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/29628 Original change's description: > Fix spurious DCHECK when WorkStealingInScriptRunner is enabled. > > Bug: 754360 > Change-Id: I8dd792787dcf5835eeb279f5ce535cb871f6d1e0 > Reviewed-on: https://chromium-review.googlesource.com/660698 > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506691} TBR=hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,tzik@chromium.org Change-Id: Ifad44699988aee7f1a8001897e75b592c7d19ebb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754360 Reviewed-on: https://chromium-review.googlesource.com/702336Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#506706}
 - 
Mike West authored
Bug: 636248 Change-Id: Ief5b352862b61707bf2f987339ec8975c9022d02 Reviewed-on: https://chromium-review.googlesource.com/702257 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#506705}
 - 
vitaliii authored
This CL deactivates "Push dummy suggestion in 10 seconds" button in snippets internals if either 1) listener is nullptr (e.g. feature is disabled) 2) listener is not listening. Previously pressing the button when (1) holds lead to a crash, (2) - nothing being pushed without any signal. Bug: 771537 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I788c9d16e277890db97dde2ed7cea166f32a96f7 Reviewed-on: https://chromium-review.googlesource.com/699999 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#506704}
 - 
Andrey Kraynov authored
Use const-ref versions of FirstPositionInOrBeforeNode and LastPositionInOrAfterNode functions instead of deprecated ones. Most changes are quite trivial replacements for call sites where |Node*| can't be a nullptr. No changes in behavior. Bug: 766448 Change-Id: I10ae5adeb1b5dc38e6bf06005a7478870e2f140f Reviewed-on: https://chromium-review.googlesource.com/700678 Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#506703}
 - 
Max Morin authored
The downcast is invalid after https://chromium-review.googlesource.com/c/chromium/src/+/700079 has been relanded. Drive-by: fix an instance of an int16_t[] being stored in a unique_ptr<int16_t>. Bug: 768610 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If74ac21ba59370eeae719d16f337d14e40a91ccc Reviewed-on: https://chromium-review.googlesource.com/702260Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506702}
 - 
Becca Hughes authored
Fix "no matching push" compiler warning in Blink. BUG=771752 Change-Id: I7a4b49c99c2f74cf18c03c025994284730ce9536 Reviewed-on: https://chromium-review.googlesource.com/702275 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#506701}
 - 
Eric Seckler authored
The DisplayScheduler's surface state tracking mechanism was susceptible to overriding a surface's state with an older sequence number, which could cause infinite blocking in wait_for_all_surfaces_before_draw mode. Bug: 697086 Change-Id: Ife6ea5df9ccef729df2a17ff3f199ee5784c880b Reviewed-on: https://chromium-review.googlesource.com/700554 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#506700}
 - 
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22069a18..96fdef6d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Id768b707b49aad61f35c2ab07e7deb65baf86fca Reviewed-on: https://chromium-review.googlesource.com/701737Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#506699}
 - 
Tomasz Garbus authored
Bug: 435047 Change-Id: I87b417cb779efd69d9b5ab2c7fa5a331b1aea19a Reviewed-on: https://chromium-review.googlesource.com/702237Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Tomasz Garbus <tgarbus@chromium.org> Cr-Commit-Position: refs/heads/master@{#506698}
 - 
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b2e961b1171d..b5807979e8a9 $ git log b2e961b11..b5807979e --date=short --no-merges --format='%ad %ae %s' 2017-10-04 xiaoyin.l Use HTTPS links in CheckAuthorizedAuthor 2017-10-04 dnj [vpython] Roll CIPD version. 2017-10-04 phajdan.jr gclient config: add support for custom vars 2017-10-03 phajdan.jr gclient: make predefined variables native 2017-10-03 mmoss Allow gclient solution URLs to be |None|. 2017-08-28 agable Simplify git-cl-diff for Gerrit 2017-10-03 phajdan.jr gclient flatten: properly quote conditionals 2017-09-28 phajdan.jr gclient: add support for native boolean variables 2017-09-29 phajdan.jr gclient flatten: emit conditions for hooks 2017-09-29 siggi Update fetch config with new Syzygy location. 2017-09-29 agable Remove rietveld commit queue command line client 2017-09-29 agable Remove rietveld git cherry-pick-upload command 2017-09-29 borenet roll-dep: Add comments indicating that --no-log needs to keep working 2017-09-28 mmoss Expose new gclient.sync() arg in gclient.checkout(). 2017-09-07 brucedawson Fix autoninja to allow compiling one source file 2017-09-29 agable Remove defunct Rietveld end-to-end tests 2017-09-28 dnj [depot_tools] Add "ensure_bootstrap" script. 2017-09-28 agable bot_update: use patch repo instead of project if it is mapped 2017-09-27 mmoss Add ability to pass extra flags to gclient.sync(). 2017-09-27 dnj Roll "vpython". 2017-09-26 agrieve Fix CheckPatchFormatted() when using inherit-review-settings-ok 2017-09-26 mmoss Remove unused gclient.sync() 'with_branch_heads' arg. 2017-09-25 phajdan.jr gclient: evaluate variables before passing them to GN 2017-09-26 phajdan.jr gclient: expose target_os 2017-09-26 yyanagisawa git-cl upload: adjust code-review score on TBR. 2017-09-25 emso Adds progress argument option to fetch for git checkout 2017-09-18 rharrison Add support for PDFium to my_activity.py 2017-09-18 rmistry Add skia_buildbot config 2017-09-14 mmoss Add some differentiating details to gerrit step names. 2017-09-15 ehmaldonado WebRTC: Remove hack in bot_update.py. 2017-09-13 agable git-cl: Parse new change urls containing project paths 2017-09-11 ehmaldonado WebRTC: Update source-of-truth on 'fetch webrtc' 2017-09-13 iannucci Roll vpython. 2017-09-13 athom Add gsutil.vpython spec to recipe bundles 2017-09-13 ehmaldonado Revert "Fix checkout.py issues when p.patchlevel > 1." 2017-09-12 ehmaldonado Fix checkout.py issues when p.patchlevel > 1. 2017-09-12 iannucci Roll led and vpython 2017-09-12 phajdan.jr gclient flatten: improve reporting of DEPS files 2017-09-11 iannucci Add s390x support for cipd client bootstrap script. 2017-09-11 agable git-cl upload: Send mail when starting CQ 2017-09-11 bjaideep gclient: Add aix to host_os list 2017-09-11 agable Add GCE instructions to git cl creds check 2017-09-11 ehmaldonado WebRTC: Update source-of-truth for 'git-cl' 2017-09-07 dcheng Use dateutil.parser for parsing dates. 2017-09-11 tikuta Update ninja to v1.8.2 2017-09-07 dnj [gsutil] run through "vpython" (2) 2017-09-07 mbjorge Revert "[gsutil] run through "vpython"" 2017-09-07 dnj [gsutil] run through "vpython" 2017-09-07 phajdan.jr Revert "update_depot_tools: make cipd_bin_setup failures fatal" 2017-09-06 phajdan.jr cipd: also support wget as fetch command 2017-09-06 phajdan.jr update_depot_tools: make cipd_bin_setup failures fatal 2017-09-05 phajdan.jr gclient: fetch arbitrary refs 2017-09-06 phajdan.jr Move downstream recipe trybots to production 2017-09-06 brucedawson Revert "Fix autoninja.bat to not swallow ^^ sequences" 2017-09-06 agable Revert "Capture ctrl-c in presubmit multiprocessing pool" 2017-09-05 brucedawson Fix autoninja.bat to not swallow ^^ sequences 2017-09-06 sebmarchand Add a script to make it easier to build a single source file with ninja 2017-09-05 agable git-cl set_close: Don't fail on branches with no issue 2017-09-05 agable Remove gerrit-over-ssh code from my_activity.py 2017-09-05 agable Capture ctrl-c in presubmit multiprocessing pool 2017-08-24 agable Don't send email from git-cl-description 2017-09-04 whesse Dart: Update the config for the "fetch dart" command. 2017-09-05 tikuta Add Nico and Scott to OWNERS for ninja related things 2017-09-02 dpranke Add a --batch mode to `git-cl owners`. 2017-09-04 tikuta Update ninja to v1.8.0. 2017-09-01 iannucci Update led tool to c9c1865b81113f02fd618259624170f59e2c832e. 2017-08-31 dnj [vpython] Update version. Created with: roll-dep src/third_party/depot_tools BUG=771277,769369,764087,741001,None,758725,741001 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=phajdan.jr@chromium.org Change-Id: Icb9ca53560ec8ee470e60fea5ba7fc23a764fb34 Reviewed-on: https://chromium-review.googlesource.com/701321Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506697}
 - 
tzik authored
Bug: 763844 Change-Id: Id348010e19f90b3042b4193a7641760949a12e50 Reviewed-on: https://chromium-review.googlesource.com/700334 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#506696}
 - 
Bernhard Bauer authored
The transition at the bottom starts when the toolbar is in the center of the visible part of the sheet, and keeps it centered throughout. The top transition is symmetric to that. Videos: https://photos.app.goo.gl/psMFW5kRuo0HEfba2 Bug: 759130 Change-Id: I91f518371915ee97fb4b99840e74b7fe8f130a71 Reviewed-on: https://chromium-review.googlesource.com/702259Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#506695}
 - 
Christian Dullweber authored
Record user actions in Clear Browsing Data to keep track of time period changes, switching tabs and deleting from specific tabs. Bug: 725401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1973216047177dfd8a677ccf80b0e8352ba2ecc3 Reviewed-on: https://chromium-review.googlesource.com/678955 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#506694}
 - 
Dominik Röttsches authored
The Calibri Windows font has bitmap strikes for sizes 12, 13, 15, 16, 17, 19. When this font is drawn while using subpixel positioning, letter spacing becomes wonky: Skia/DWrite are not using multiple subpixel aliased glyph versions. Usually, with subpixel positioning and antialiasing 3 or 4 versions of an antialiased glyph exist with different shading and color filtering. Here, only one antialiased glyph variant is used, which is placed at full pixel boundaries. For bitmap strike font sizes Skia/DWrite now rounds the glyph positions within the text to full pixel positions to place this one glyph variant. The result is that the letter spacing becomes uneven, whith glyphs moving closer or further away from each other when the horizontal subpixel offset is changed [1]. As a mitigation of this problem, disable the usage of embedded bitmap strikes for Calibri for now. We have not encountered any other non CJK script fonts that would expose bitmap _and_ vector outline glyphs. The setEmbeddedBitmapText flag of SkPaint mostly controls what to do with fonts that have outlines and embedded bitmaps. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=707713#c5 [2] https://hg.mozilla.org/mozilla-central/rev/c93381b53df3 Bug: 707713 Change-Id: Iae81803ece1ada49e363ff46e0e06df3a26dbcde Reviewed-on: https://chromium-review.googlesource.com/623672 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#506693}
 - 
Sayaka Takayama authored
Callback function classes generated by callback_function.h.tmpl (e.g. V8FrameRequestCallback) have some common objects and each of classes doesn't have to have them. CallbackFunctionBase is a base class for callback function classes and has objects which used to be common for them. Bug: 658073 Change-Id: I7a71cf9813b53edbd7b7141ca647508d88c85510 Reviewed-on: https://chromium-review.googlesource.com/697028 Commit-Queue: Sayaka Takayama <stakayama@google.com> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#506692}
 - 
Daniel Vogelheim authored
Bug: 754360 Change-Id: I8dd792787dcf5835eeb279f5ce535cb871f6d1e0 Reviewed-on: https://chromium-review.googlesource.com/660698Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#506691}
 - 
Bhagirathi Satpathy authored
Added exception when listener (second parameter in addEventListener) is not an object to match the specification. EX: document.getElementById("id").addEventListener('something', 1); Bug: 712778 Change-Id: I2b1dca04f08ffe67c3a48283caf781ec8b373975 Reviewed-on: https://chromium-review.googlesource.com/672623Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#506690}
 - 
Harald Alvestrand authored
Change-Id: I68fa3394a4d7ab62df652d8c06e3360618bfb3cc Reviewed-on: https://chromium-review.googlesource.com/700594 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#506689}
 - 
Roman Sorokin authored
Prevents network error screen shown by setting maximum offline timeout Bug: 770738 Change-Id: I19ae30e1775e758df682a9bab3adb4b2c4037b96 Reviewed-on: https://chromium-review.googlesource.com/700639 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#506688}
 - 
Takashi Toyoshima authored
WebCORSPreflightResultCache was originally a thread local thing, but in the middle of refactoring, it was mistakenly changed to be a per-process instance. In terms of the spec, it's fine to be shared among threads, but WebCORSPreflightResultCache internal implementation isn't thread-safe to be so. As a best effort plan, this patch makes it back to be a thread local to work without any race. Bug: 736308 Change-Id: I68e3243a9ef26da97f76a0c44785bc1394f5dc75 Reviewed-on: https://chromium-review.googlesource.com/697407Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#506687}
 - 
Daniel Bratell authored
There is a Function template in blink's wtf library and it is easy to get mixed up in it if you try to use the symbol "Function" elsewhere in blink. In particular you can easily get an include of platform/wtf/Functional.h (which exports WTF::Function to the global scope) in jumbo builds: Bug: 745732 Change-Id: Ic4f4a02e1aacc5819ce824b94e284bfc6caa964d Reviewed-on: https://chromium-review.googlesource.com/702236Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#506686}
 - 
Kunihiko Sakamoto authored
Before this patch, module scripts were fetched at Low priority, like as classic async / deferred scripts. But this may not be a good default, since module scripts tend to have many sub module scripts and fetching them all at low priority may be too slow. (See the listed bug for more on the discussion.) This patch changes the fetch priority of module scripts to High (same as classic scripts without async / defer). This applies to all module fetches, includes dynamic import. Bug: 769151 Change-Id: I24aa22a886e8394969447785eaf1fe0ab2eea818 Reviewed-on: https://chromium-review.googlesource.com/701937Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#506685}
 - 
Yutaka Hirano authored
TBR=jochen@chromium.org No-Try: True Bug: 762486 Change-Id: I5634090ba14770a5f4b2fcfdfdfbc5c800ce6b5a Reviewed-on: https://chromium-review.googlesource.com/702078Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#506684}
 - 
Yoshifumi Inoue authored
Before this patch, "InsertText" command splits SPAN element containing TAB character when inserting text into it. For example: Before: <span>	a|c</span> Command: insertText "B" After: <span>	a</span>B|<span>c</span> This behavior is introduced by the patch[1], which replaces "class=apple-tab-span" to "style=white-space:pre". This patch changes |IsTabHTMLSpanElement()| to check "white-space:pre" CSS property to make "InsertText" command not to split SPAN element containing TAB character with "white-space: pre". Note: "apple-tab-span" CSS class is MacOS specific feature[2]. On MacOS, UITextView puts following HTML into pasteboard: <style>.Apple-Tab-Span { white-space: pre; }</style> <span class=Apple-Tab-Span>	</span> [1] http://crrev.com/2718543003 Remove EditingAppleTabSpan class handling [2] https://www.cocoanetics.com/2013/06/apple-tab-span/ Bug: 741826 Change-Id: I42d8d388e306b613fbe8ffa614b9e974db254c22 Reviewed-on: https://chromium-review.googlesource.com/697044 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#506683}
 - 
Hidehiko Abe authored
BUG=b:65560282 TEST=Ran trybot. Change-Id: I8766ca2a207212375c6afa29fee2cbfd5ced48b6 Reviewed-on: https://chromium-review.googlesource.com/700237 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#506682}
 - 
tzik authored
Bug: 763844 Change-Id: Icfaf76fd6be189bc16b0d428e4ddcd5060e28139 Reviewed-on: https://chromium-review.googlesource.com/700056Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#506681}
 - 
Morten Stenshorne authored
Intrinsic sizing for multicol used to be defined in the intrinsic and extrinsic sizing CSS spec, but it must have been removed at some point. All we have for inspiration now is the implementation in the legacy engine, which landed with https://chromiumcodereview.appspot.com/23763002 back in 2013. That, and common sense. :) The principles of min/max width calculation are, after all, quite simple: 1. Figure out how much width we need to prevent avoidable overflow (min) 2. Figure out how much width we need to prevent avoidable soft wrapping (max) Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id465449369d0227883e08228ce33346eb5b5cdba Reviewed-on: https://chromium-review.googlesource.com/700460 Commit-Queue: Morten Stenshorne <mstensho@opera.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#506680}
 - 
Daniel Bratell authored
The profile_ member in TriggeredProfileResetter is not read by any code so let us remove it for platforms where it is not used. This warning appeared in jumbo build experiments (jumbo builds give the compiler more information which triggers warnings that were not there before). Bug: 770625 Change-Id: I4fd04d3147b01d0cf853b34c01ac7aa03fbd7d14 Reviewed-on: https://chromium-review.googlesource.com/695102 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#506679}
 - 
Hidehiko Abe authored
Recently, Mojo wire format change was introduced for native structure. https://chromium.googlesource.com/chromium/src/+/fd907634b5ea956b34bd1672c084089aad2150cd It causes a protocol mismatch between ARC and Chrome. Unfortunately, rolled libmojo is too old, so we cannot use values.mojom now. As its workaround, this CL stringifies the JSON value if necessary, and use it for the communication. Note that this is breaking change. Though, the protocol is already broken, so we don't much care about it. BUG=767313 TEST=Ran CTS. Change-Id: Iaaf28065aa7cde0ce17d7231da0571312f23772d Reviewed-on: https://chromium-review.googlesource.com/691495 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#506678}
 - 
Darren Shen authored
Currently the stylesheet_contents_fuzzer, which fuzzs CSS stylesheet parsing, has no dictionary, which means most of the inputs are garbage and will be ignored at the parsing level. This patch adds some common strings seen in CSS stylesheets, which would hopefully produce more valid tokens that can expose more bugs at the parsing level. Bug: 752194 Change-Id: Ibf596a0a78c5b1bfb042f2c9e952ebdc07790a42 Reviewed-on: https://chromium-review.googlesource.com/696441Reviewed-by:
meade_UTC10 <meade@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#506677}
 - 
Alexander Shalamov authored
This CL moves ownership of ISensorManager to sensor thread, so that ISensorManager is initialized when new sensor is created or in use, and destroyed when there are no sensors. Before this CL, ISensorManager could have been reset from IO thread. Bug: 765527 Change-Id: I579f06dfd4cec7b678fe0080fe99cc6b182de27c Reviewed-on: https://chromium-review.googlesource.com/699759Reviewed-by:
Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com> Cr-Commit-Position: refs/heads/master@{#506676}
 - 
Siddhartha authored
Bug: 700245 Change-Id: Id316cb680cecc5755ab52026ccff790e12d1d133 Reviewed-on: https://chromium-review.googlesource.com/702019Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#506675}
 - 
Tsuyoshi Horo authored
When FetchEvent.respondWith() is called with a rejecting promise in a service worker and if OnFetchEventFinished() of ServiceWorkerSubresourceLoader is called before OnResponse(), OnFallback() passes |url_loader_client_| to the network loader factory, and the renderer process crashes while calling OnReceiveResponse(). OnFetchEventFinished() => OnFallback() => std::move(url_loader_client_) OnResponse() => StartResponse() => DeliverErrorResponse() => CommitResponseHeaders() => url_loader_client_->OnReceiveResponse() (* crash here) OnFetchEventFinished() should not call OnFallback() when |status| is ERROR_EVENT_WAITUNTIL_REJECTED. And also, we don't need to fallback to the network because it's for main resource load when FetchEvent failed. Bug: 715640 Change-Id: I78d31c118ad9169740e3db4c561aa25e2dbae83e Reviewed-on: https://chromium-review.googlesource.com/700276Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#506674}
 - 
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/63a614b75273..f8ebe0eae6cb $ git log 63a614b75..f8ebe0eae --date=short --no-merges --format='%ad %ae %s' 2017-10-03 benjhayden Refactor histogram-set-view API. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I06ff71f6464041fbbcdd9cd5d789c28501f8900b Reviewed-on: https://chromium-review.googlesource.com/701665 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506673}
 - 
Naina Raisinghani authored
seek Add UseCounter to check if setting playbackRate causes a compensatory seek forcing a change in start_time_. This is as we want to spec this behaviour on an API level. Bug: Change-Id: Ic6ab06bb482b4e086d2559904bd4f6f4ccdd52eb Reviewed-on: https://chromium-review.googlesource.com/700057 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by:
dstockwell <dstockwell@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#506672}
 
 -