- 18 Jul, 2017 40 commits
-
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/26f2e66be57e..91e883303891 $ git log 26f2e66be..91e883303 --date=short --no-merges --format='%ad %ae %s' 2017-07-18 benjhayden Generalize HistogramSet.deduplicateDiagnostics(). Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5a30fab8c136c7f0ae9b5111ab5168d43a2c43ca Reviewed-on: https://chromium-review.googlesource.com/576082 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487647}
-
Jeff Carpenter authored
From time to time the exporter is unable to find and merge an upstream PR once its been landed. This is caused by the exporter first searching by Commit-Position, which in the case of a landed commit does not correspond to what's on the PR. However, this can lead to false positives where the Commit-Position in a commit points to another, unrelated upstream PR. This change fixes that problem by first looking for PRs by Change-Id, which never changes. Bug: 745880 Change-Id: I36b12a486fcfce9190ef8d2a9320b723b359ba9b Reviewed-on: https://chromium-review.googlesource.com/575785 Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#487646}
-
Charles Harrison authored
It is relatively common to load resources in subframes that navigate but do not trigger ReadyToCommitNavigation in the browser process, or go through the standard NavigationThrottle pipeline. Previously, the component explicitly ignored them since their loads do not align well with our navigation/browser oriented architecture. This CL simply forwards the parent frame's activation state into the child, which the child uses any time it navigates to one of these special URLs. Bug: 739777 Change-Id: I052ce6df3efead9cb78f309211f6ababa8ac3944 Reviewed-on: https://chromium-review.googlesource.com/559732Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#487645}
-
Yuzhu Shen authored
This is a preparation for adding support for Android WebView: - moves some files from chrome/browser to components/safe_browsing/browser. - introduces UrlCheckerDelegate interface and moves chrome-specific logic into a subclass of UrlCheckerDelegate. Bug=715673 Change-Id: I7c7e440f5146e6b7928e71265e7d5657f2c5b295 Reviewed-on: https://chromium-review.googlesource.com/567586 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#487644}
-
Nate Fischer authored
This separates Safe Browsing enabling into 3 requirements: 1. The user must opt into the feature 2. The app can enable/disable via WebSettings#setSafeBrowsingEnabled 3. The app can enable via manifest flag This adds tests to ensure that (1) has the highest priority. We already have tests to ensure that (2) has higher priority than (3). The CLI switch is treated equivalently to the manifest flag (same behavior as before). This also renames AwContentsStatics#{get,set}SafeBrowsingEnabled -> {get,set}SafeBrowsingEnabledByManifest. This is to clarify what this function actually does. The old method can be removed once downstream code no longer uses it. Bug: 731927 Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#testSafeBrowsingUserOptOutOverrides* Change-Id: Id1d1a41f503b259addda14b027df0b3c18325b9c Reviewed-on: https://chromium-review.googlesource.com/572431 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Selim Gurun <sgurun@chromium.org> Cr-Commit-Position: refs/heads/master@{#487643}
-
Quinten Yearsley authored
Bug: 745099 Change-Id: I7386cc1ed68a49d8077fba0e5a72442dd73023f2 Reviewed-on: https://chromium-review.googlesource.com/576194Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#487642}
-
Thoren Paulson authored
When an app starts in background mode and then stops without being displayed, the service-based path crashed due to calling unbindService without calling bindService. This change prevents stop logic from being called if start was never called. BUG=internal 63015237 TEST=cast_shell_junit_tests Change-Id: I8a89580927972b13d6b0842972805853b8c5bbb7 Reviewed-on: https://chromium-review.googlesource.com/576196Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Thoren Paulson <thoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#487641}
-
ananta authored
This patch builds on patch https://codereview.chromium.org/2956373002/ for adding fallback support for subresource requests. This is implemented by passing a proxy URLLoaderClient interface to the network URL service for subresource requests which are sent to the network. We intercept the OnReceiveResponse, OnReceiveRedirect and OnComplete calls for supporting fallback responses in these cases. We could potentially look at moving fallback response reading to the renderer in a later patchset. The changes in this patchset are as below: 1. Add support for passing the ResourceResponseHead to the AppCacheURLLoaderJob. This is required for supporting fallback responses. The request handler looks at headers in the response and the status code to make a call whether a fallback is required. 2. AppCacheRequestHandler::MaybeLoadFallbackForResponse() and MaybeLoadFallbackForRedirect() have changed to allow for the fact that they are called in the network service code by the AppCacheURLLoaderJob. We don't create new job for delivering the fallback in this case. 3. Added methods in the AppCacheRequest class to return the URLRequest override and URLLoader override respectively. Next step is to add support for main resource fallback. BUG=715632 Review-Url: https://codereview.chromium.org/2974733002 Cr-Commit-Position: refs/heads/master@{#487640}
-
Victor Vasiliev authored
Replace QuicIntervalSet with an std::deque in PacketNumberQueue. Protected by --FLAGS_quic_reloadable_flag_quic_frames_deque. Merge internal change: 161114283 R=rch@chromium.org Bug: Change-Id: Id2af2ecf02388973e3e2ea9a6ad001a08752d8ec Reviewed-on: https://chromium-review.googlesource.com/574648 Commit-Queue: Victor Vasiliev <vasilvv@google.com> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#487639}
-
Yuzhu Shen authored
BUG=None Change-Id: I3cae8cee3d77006c659bb9784a7089478276016e Reviewed-on: https://chromium-review.googlesource.com/574682Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Kevin Marshall authored
Fix invalid WeakPtr usage in cert reporting test utils. CertReportJobInterceptor::MaybeInterceptRequest was posting IO thread- affine WeakPtrs onto the UI thread, which is an invalid use of WeakPtr. This CL replaces the use of WeakPtr with Unretained(). WeakPtr seems overkill for test code, as the test cases may block & join to ensure proper destruction ordering. R=vakh@chromium.org CC=wez@chromium.org TBR=vakh@chromium.org Bug: 729716 Change-Id: I99a07e1098d3a8341dbc2043ca2b335b9d97ef60 Reviewed-on: https://chromium-review.googlesource.com/527732 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#487637}
-
Vadim Tryshev authored
Bug=712331 Change-Id: I2ca492c7856546280bca9f1fc7da7a0837866495 Reviewed-on: https://chromium-review.googlesource.com/575702 Commit-Queue: Vadim Tryshev <vadimt@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#487636}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/56725242559d..7d0af80637af $ git log 567252425..7d0af8063 --date=short --no-merges --format='%ad %ae %s' 2017-07-17 tsepez Small tidy of defines in util.h Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I67189943540465ffb348ad6b873f64a20d72ecce Reviewed-on: https://chromium-review.googlesource.com/576487 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487635}
-
Matthew Jones authored
Previously the position of the UrlBar was only recorded if it had focus. This change moves the early return to after the check for the down event so that long press will properly select the omnibox. BUG=744543 Change-Id: Idac3ae70719ea313a48ab300b7228bd559af306a Reviewed-on: https://chromium-review.googlesource.com/575434Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#487634}
-
muyuanli authored
There should be 3 states for voice interaction preferences: undefined, enabled, disabled. It starts at undefined and will do a one-time-only fetch from Android to incorporate OOBE settings. Then the switches are managed by Chrome completely. BUG=b:38175284 Review-Url: https://codereview.chromium.org/2968073002 Cr-Commit-Position: refs/heads/master@{#487633}
-
Rouslan Solomakhin authored
Before this patch, caching a web app manifest with multiple "id" values in "related_applications" sections would not always clear the stale data from the cache. Multiple "id" values in the same web app manifest are useful for using both prod and dev version of a payment app in the same web app manifest, for example. This patch clears the stale data for all "id" values in "related_applications" of a web app manifest that is being cached. Bug: 745765 Change-Id: I116e356d5181792668aa26c6ff4da7258cd11d49 Reviewed-on: https://chromium-review.googlesource.com/575845 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#487632}
-
yolandyan authored
@CommandLineParameter({"", "enable-features=xyz"} is supposed to return flags of ["--enable-features=xyz"], and it currently does not return the two dash prefix in our test harness Bug: 745839 Change-Id: I2d483c0c24b5627a2616e3c05d78192581348b06 Reviewed-on: https://chromium-review.googlesource.com/576388Reviewed-by:Michael Case <mikecase@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#487631}
-
sacomoto authored
BUG=724715 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2973243002 Cr-Commit-Position: refs/heads/master@{#487630}
-
Ahmed Fakhry authored
ChromeVox should read "Night Light: On, Button, pressed" or "Night Light: Off, Button, not pressed". BUG=706067 Change-Id: I36b86f5b9f51ce921b22aca5b7d74f6bd52485e5 Reviewed-on: https://chromium-review.googlesource.com/576393Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#487629}
-
Eugene But authored
Bug: 736480 Change-Id: Ia26ce365ebe41af525e74a805da1b139eb43dc85 Reviewed-on: https://chromium-review.googlesource.com/576145 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#487628}
-
Alexei Filippov authored
Revert "Add a PageLoadMetricsObserver that tracks all observed features and reports a new histogram" This reverts commit 1423af08. Reason for revert: Broke build https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/36753 Original change's description: > Add a PageLoadMetricsObserver that tracks all observed features and reports a new histogram > > For more information, please refer to this doc: > > https: //docs.google.com/document/d/1jaUv28xBPrOrkZV9gck9btEKvgM8u_awO83SXraPbQ4/edit?usp=sharing > Bug: 716565 > Change-Id: I040ecc5e44df15768649684b4f5ee8d5e828c209 > Reviewed-on: https://chromium-review.googlesource.com/534133 > Commit-Queue: Luna Lu <loonybear@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Rick Byers <rbyers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487612} TBR=rbyers@chromium.org,dcheng@chromium.org,mpearson@chromium.org,thakis@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,loonybear@chromium.org Change-Id: I84cb3780b38511fc84394f81c04c339d0cc3a5fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 716565 Reviewed-on: https://chromium-review.googlesource.com/576569Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#487627}
-
Tien-Ren Chen authored
Before this CL, LayoutView of a non-composited sub-frame in non-RLS mode would report the clipped rect as its VisualOverflowRect(). After this CL, such LayoutView will report the whole document rect instead. This change is needed for correctly computing visual rects of LayoutView display items in SPv2. Also it is a layering violation for VisualOverflowRect(), which itself is a compositing input, to depend on compositing state. Change-Id: I67636aa72318770bbfb810b17eb5a5d176816257 Reviewed-on: https://chromium-review.googlesource.com/566086 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487626}
-
robliao authored
This change will allow for the detection of tasks running in TaskScheduler that fail to post their task in a COM STA Task Runner instead. BUG=706512 TBR=gab@chromium.org Previously Reviewed at https://chromium-review.googlesource.com/c/549223/ Review-Url: https://codereview.chromium.org/2978253002 Cr-Commit-Position: refs/heads/master@{#487625}
-
Sean Topping authored
This reverts logic allowing WebMediaPlayerImpl to ignore all suspend requests. Now, content embedders can only specify whether they want idle media players to be suspended automatically after a period of inactivity. Explicit suspends (such as through the content::MediaSession API) will still remain functional. This change is necessary since Chromecast needs to support explicit media suspension when a tab is hidden. BUG=internal b/34257330 Change-Id: I4a1e9891b136e987b5677ac1391ca3d2c1dd1bde Reviewed-on: https://chromium-review.googlesource.com/575513Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
eugenebut authored
Old name was presumably used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with the rest of Chromium code. BUG=695189 Review-Url: https://codereview.chromium.org/2971073002 Cr-Commit-Position: refs/heads/master@{#487623}
-
Robert Kroeger authored
Extract overlay checking status into a stand-alone enum and provide a corresponding mojo EnumTraits for it. BUG=620927 Change-Id: I411e5ec402ce580a61478383ac9b2482a33989f0 Reviewed-on: https://chromium-review.googlesource.com/575701Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#487622}
-
Eric Roman authored
Bug: 745877 Change-Id: I05d3fcdbe55509d808f0ab696b159ca22876a0b8 Reviewed-on: https://chromium-review.googlesource.com/576358Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#487621}
-
Yuwei Huang authored
This CL: * Makes the build target generate the credits page for the app. * Adds the credits page to the help view. Bug: 745233 Change-Id: Id612c7140fbdcc9433854d26f8c33509c28ac3c2 Reviewed-on: https://chromium-review.googlesource.com/575041Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#487620}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/14308731e5446a73ac2258688a9688b524483cb6..0e4a448ab8aa66a38593f68d19fa0a2e340833e4 TBR=davidben@chromium.org BUG=none Change-Id: Ief8d5002ca44783ef35e4836fa7ea2b34e05b38b Reviewed-on: https://chromium-review.googlesource.com/575817 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#487619}
-
Eric Roman authored
Bug: 679030 Change-Id: I431e32e5287602fe3321e0ae803a0314e3d87ea2 Reviewed-on: https://chromium-review.googlesource.com/576364Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#487618}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c432b0ca8a50..312f4b24f96f $ git log c432b0ca8..312f4b24f --date=short --no-merges --format='%ad %ae %s' 2017-07-18 rmistry Copy over private SKPs during SKP asset create command 2017-07-18 halcanary SkPDF: Re-use Jpeg Image Shaders 2017-07-18 ethannicholas sksl now sees vulkan caps 2017-07-18 jvanverth Add some convexity checks to shadow code. 2017-07-18 mtklein start on raster pipeline 2d mode 2017-07-18 csmartdalton vk: Fix geometry-shader input varying locations Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I4eada1f195c6b4360f99205c87a835834e768ce7 Reviewed-on: https://chromium-review.googlesource.com/576361Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487617}
-
lanwei authored
When we disabled the drag and drop on stylus input devices, we also disabled the text selections. We should allow text selection on stylus input devices, so users can copy and paste. Bug:742373 Change-Id: I9ea34111f5caef494c6c973a15ee15401b33c603 Reviewed-on: https://chromium-review.googlesource.com/574654Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#487616}
-
Sean Kau authored
Timer is the preferred method to schedule recurring tasks rather than rescheduling a PostDelayedTask. Bug: 734280 Change-Id: I2200a9fe636eb7e59bf868dc8227aecc82095bcc Reviewed-on: https://chromium-review.googlesource.com/575776Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#487615}
-
alph authored
Revert of Cros Tablet Window management - Split Screen part II (patchset #9 id:160001 of https://codereview.chromium.org/2955203002/ ) Reason for revert: Broke ash_unittests https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/28279 Original issue's description: > Cros Tablet Window management - Split Screen part II > > Wire up the SplitViewController with the overview mode. It's a following > up CL of https://codereview.chromium.org/2960843004/. > > Changes in this CL: > 1. The split view mode can be initiated by dragging the window in > overview mode to the side of the screen > 2. After one window is snapped to one side of the screen, all the other > overview windows will display in the other side of the screen, allowing > the user to select another window to snap. When two windows are snapped > to both sides of the screen, the overview mode will be ended. > 3. The first snapped window will remain snapped until the user > explicitly exit the split view mode. All the other windows (incluing > newly created window) will be open in the other side of the screen. > Clicking/Tapping on the overview button also open the overview windows > in the other side of the screen. > > Not covered in this CL: > 1. The highlighted region showing where split will occur is not > implemented in this CL. > 2. The split divider is not implemented in this CL. > > BUG=725683 > > Review-Url: https://codereview.chromium.org/2955203002 > Cr-Commit-Position: refs/heads/master@{#487542} > Committed: https://chromium.googlesource.com/chromium/src/+/0c6d79c9a3a2bf404ef94220c389924541c92f0b TBR=oshima@chromium.org,varkha@chromium.org,xdai@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=725683 Review-Url: https://codereview.chromium.org/2978273002 Cr-Commit-Position: refs/heads/master@{#487614}
-
sczs authored
When creating a new Webstate we hit a DCHECK since SetWebUsageEnabled is false, this CL fixes that problem by setting the Webstate SetWebUsageEnabled to true on creation. Bug: Change-Id: I0fd5b9d57c9d66d78bc5370d54fe8f38065f5932 Reviewed-on: https://chromium-review.googlesource.com/575841Reviewed-by:
Ed Chin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#487613}
-
Luna Lu authored
For more information, please refer to this doc: https: //docs.google.com/document/d/1jaUv28xBPrOrkZV9gck9btEKvgM8u_awO83SXraPbQ4/edit?usp=sharing Bug: 716565 Change-Id: I040ecc5e44df15768649684b4f5ee8d5e828c209 Reviewed-on: https://chromium-review.googlesource.com/534133 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#487612}
-
Rouslan Solomakhin authored
Before this patch, parsing a web app manifest with multiple "related_applications" would return an empty manifest. Multiple different "fingerprints" would return the first fingerprint multiple times. These bugs occurred because of incorrect usage of index "i" instead of "j" for "fingerprints". The "i" index is used only for "related_applications". This patch adds tests TwoRelatedApplicationsWellFormed for parsing two "related_applications" and TwoDifferentSignaturesWellFormed for parsing multiple different "fingerprints" in the web app manifest. Before the fix, the tests fail. The tests pass after the fix, which is to use "j" instead of "i" index for "fingerprints". After this patch, parsing a web app manifest with multiple "related_applications" returns a manifest with two sections. Parsing multiple different "fingerprints" returns different parsed fingerprints. Bug: 745765 Change-Id: I43953748a405e5d3ef2329e22ba3ff449b10f104 Reviewed-on: https://chromium-review.googlesource.com/575715Reviewed-by:
-
Ted Choc authored
The tests added are: 1.) Search google for this image not shown in context menu (and doesn't crash). 2.) Search engine preference is disabled in settings (also doesn't crash). BUG=720504 Change-Id: Ib481169f83c789a4aa23aac37d13d5fe512c443f Reviewed-on: https://chromium-review.googlesource.com/576387Reviewed-by: -
erikchen authored
Requested by the speed releasing team. Bug: Change-Id: I87228f82856a0fce7034023e90ca18d524af0db1 Reviewed-on: https://chromium-review.googlesource.com/576237 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#487609}
-
Bence Béky authored
Now with unittests! Also do not try to put non-UTF8 strings into NetLog, because a DCHECK files as soon as a TestBoundNetLog is used. Also remove a solitary DVLOG() statement, since other failure modes do not have one. Change-Id: I67e82c09a4e73a8561973c3db432e4364d05ad55 Reviewed-on: https://chromium-review.googlesource.com/570627 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
-
