- 20 Feb, 2020 40 commits
-
-
Sergey Poromov authored
This reverts commit 2eb368c0. Reason for revert: Win7 Tests build failures: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29 Sample run: https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/64350 Original change's description: > Implement FileSystem.rmtree for long paths on Windows > > Changes blinkpy filesystem tests to use remove_contents instead of > rmtree. remove_contents calls into rmtree, but > (1) retries several times to delete the files, and > (2) throws by default instead of silently swallowing errors. > This improves all of the tests. Additionally, the retrying was > actually necessary to pass many tests (files were otherwise still > locked during teardown). > > Extends the test_long_paths test to check spaces and apostrophes. > > FileSystem.rmtree is now implemented on Windows by just calling > a shell with "rmdir /s /q". This is necessary, because > shutil.rmtree doesn't work for \\?\C:\ style "extended-length" paths > on Windows, and several other implementations I tried didn't work: > - Loop using os.walk. os.walk doesn't support long paths, and > though it seemed to work on the bots, it failed tests locally. > - Recursive using os.listdir. os.listdir also doesn't support long > paths. > > Tested on dawn-win10-* try job on crrev.com/c/2050036/17. > Found in dawn-win10-* try jobs on crrev.com/c/2050036/4. > > Change-Id: I7c67bb12305a41244829e35293edfc88901b76f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058065 > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742961} TBR=kainino@chromium.org,robertma@chromium.org Bug: 1054331 Change-Id: Iec3f75c925598f37a228771371b08616cb0d97d5 No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064997 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#743044}
-
Omar Morsi authored
chrome://settings/certificates should display hardware-backed for a certificate if it is saved on a hardware-backed slot and its private key is stored in the TPM. CL:1967781 introduced kKeyInSoftware attribute for private key which can be used to check whether the key is wrapped by the TPM or not. This CL introduces: 1- Taking advantage of the kKeyInSoftware attribute to check if a private key is hardware-backed or not. 2- Adds support for requesting certificate information list from NSS certificate database. Gathering certificates information is done asynchronously. 1- net_unittests --gtest_filter=NSSCertDatabase* 2- unittests --gtest_filter=CertificateManagerModel* 3- Manually by checking that when importing and binding a client certificate with EC key on a TPM version 1.2, it doesn't display (hardware-backed) in chrome://certificate-manager beside the certificate anymore. Bug: chromium:1043083 Test: Change-Id: I3b2551ae04d5ddadbee28cab823bcbb4278480be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022945 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#743043}
-
Antonio Gomes authored
In order to do this, a couple of remarkable changes took place: - The body of RenderFrameImpl::DownloadURL() and SaveImageFromDataUR() have been moved down to blink::LocalFrame. Note that there were other RenderFrameImpl methods that used to call RenderFrameImpl::DownloadURL() - namely RenderFrameImpl::BeginNavigation. In order to keep this code chain unchanged, WebLocalFrame interface got a DownloadURL() method added, so that it can forward calls to LocalFrame::DownloadURL() from there. - content/renderer/render_frame_impl_browsertest.cc: RenderFrameImplTest got its ctor extended similarly to RenderViewImplTest's (in render_view_browsertest.cc). Now it is possible to inject a custom blink::mojom::LocalFrameHost instance, and catch DownloadURL() mojo call. - web_test_download_manager_delegate.cc: In order to run web_tests that trigger download, we could try to intercept LocalFrameHost for web_tests. Instead, the CL lets the browser/ to handle it. The flow is content requests a download. Mojo calls take place. RFHI::DownloadURL gets called and then DownloadManagerImpl. Particularly, for every download that gets started by the renderer, DownloadManagerDelegate::CheckDownloadAllowed is called. This CL added an extra parameter to this method, in order to idenfity that the download was trigger by the renderer (ie the web_test in case), and then replied to the renderer accordingly. See WebTestDownloadManagerDelegate::CheckDownloadAllowed() for details. - DownloadURL() plumbing methods were removed from WebFrameTestClient, WebFrameTestProxy, WebLocalFrameClient, EmptyLocalFrameClient, LocalFrameClientImpl, LocalFrameClient, ChromeClient. - t_p/blink/public/mojom/frame/frame.mojom: In the normal case - see LocalFrame::DownloadURL() - all members of the blink.mojom.DownloadURLParams struct are filled properly. However, there is another call site - see LocalFrame::SaveImageAt - where only |data_url_blob| struct member is filled, leaving all others "null". |url| is nullable so it is fine, but all others cause crashes on unittests if they are not mark as "nullable" accordingly. - web_frame_test.cc: It implements a BlobRegister instance that intercepts the creation of blink::mojom::Blob, or use FakeBlob instead. Given that the content of the Blob is known, and made of bytes only, it reads off the contents from DataElements. The test also implements a custom blink::mojom::LocalFrameHost instance, so it intercepts mojo calls to DownloadURL() and act accordingly. BUG=1041083 Change-Id: I279bdc142624a0efb6be31535d505e9f6cabe5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028708Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#743042}
-
Wei Lee authored
Bug: 980846 Test: Launch CCA with no error shows Change-Id: I808d0c2c5a99e8c068227645e03c8a619310da59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058932 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#743041}
-
Tanmoy Mollik authored
Change-Id: Ibdce0a751ec9754fac8395feb1168e85db6ea9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064909Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#743040}
-
Mirko Bonadei authored
As mentioned on [1], WebRTC uses xcode 10.2 in buckets/webrtc.fyi.star and this may cause the problem mentioned on crbug.com/1052347. [1] - https://bugs.chromium.org/p/chromium/issues/detail?id=1050976#c23 Bug: 1050976 Change-Id: I3e08b4dcce0c9ef8b92f2ac14a822a62ffa3803b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056817Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#743039}
-
Mitsuru Oshima authored
* A window frame should have rounded corners only in normal state, (floating state). All other state won't need them so can be opaque window. * Don't apply this logic if the opacity is explicitly specified (not kInferred) * Old code removed the rounded corner only for maximized/fullscreen. Instead, this CL checks if it's normal. * Consolidated the occlusion region update code for transparent window to WindowState. * Update DCHECK in Window::SetOpaqueRegionsForOcclusion to allow resetting. Bug: 1022544 Test: covered by unit tests. Also tested on the device. OOBE, login screen, arc windows works as intended. Change-Id: Ia8e067945732b81294c3e6733121d433e3087f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059089 Commit-Queue: Mitsuru Oshima (OOO) <oshima@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#743038}
-
Guido Urdaneta authored
With MediaFoundation, VMware exposes a camera even if no physical camera exists. The behavior of this camera is problematic and causes getUserMedia() calls to hang. A previous CL (crrev.com/741120) tried to block this camera, but it had no effect because the blocking mechanism worked only on USB cameras. This CL introduces a blocking mechanism that works on the display name for the camera. Local testing has shown that under DirectShow, the virtual camera is not exposed if no physical camera exists. It works well when a physical camera exists too. Bug: 1044974 Change-Id: I544e33ea4a5717dd91d09784a1bc32e3e268cf0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064996Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#743037}
-
Michael Ershov authored
These requests will allow Chrome OS device to communicate with DM Server to generate a CSR and receive a certificate. CloudPolicyClient encapsulates all the processing of proto structures. CloudPolicyClientCertProvisioningFinishCsrTest.*, CloudPolicyClientCertProvisioningDownloadCertTest.* Bug: 1045895 Change-Id: Ie329692a41103e36b7c99990f80192d83110a834 Test: CloudPolicyClientCertProvisioningStartCsrTest.*, Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059373Reviewed-by: -
chrome://flagsTakashi Toyoshima authored
Now the feature is launched by default, and we do not want to allow users to control the feature via the flag in m82. base::Feature is still remained and command line flags work even after this change. Enterprise policies are also still remained in the current revision, but will be removed behind a finch gate in m82. If there is a serious issue for enterprise users, we may postpone the announced policy removal. Bug: 1053866 Change-Id: Id4abe345878a0d25e74202c3e54620616c223607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065255Reviewed-by:
-
Sergey Poromov authored
This reverts commit b6d8f169. Reason for revert: browser_tests are failing: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3343 Original change's description: > Settings: Migrate about_page/* to Polymer 3 > > Bug: 1026426 > Change-Id: I6ae55030f28fd3588d317f6fd611d04f7bdbfbf8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058067 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742918} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: I2af4e6111deab7bb45c1a306aec449142ffd1cd8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064937Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=ioanap Change-Id: I23175afe330f6d869101fb65c76e9175752f4c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064992Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#743033}
-
Oriol Brufau authored
In r741909 I changed PositionWithAffinityOfHitTestResult to use InnerPossiblyPseudoNode() instead of InnerNode(). HandleSingleClick checks that InnerNode() is not null and has a layout object before calling PositionWithAffinityOfHitTestResult. But seemingly, in some cases the InnerPossiblyPseudoNode() may not have a layout object. This patch changes HandleSingleClick to check InnerPossiblyPseudoNode() in addition to InnerNode(). Hopefully this will fix a possible null deref crash. But I haven't been able to create a testcase. BUG=105345 Change-Id: Ic42a044acc68799c21952a1125b5ffe08bda7494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062282Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#743032}
-
Felipe Erias authored
Add support for the values "jis-b5" and "jis-b4" in the "size" property of the "@page" rule, as specified in the CSS standard: https://www.w3.org/TR/css-page-3/#typedef-page-size-page-size These values represent two Japanese standard paper sizes: - JIS B5 is 182mm wide by 257mm high - JIS-B4 is 257mm wide by 364mm high Test: printing/page-format-data.html Bug: 1047642 Change-Id: Iec39bb535d21ea5a6ee1696b744166e1247be35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059029Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#743031}
-
Side Yilmaz authored
This CL updates the profile passing to HelpAndFeedback activity from SadTab. Currently, it is always regular profile, however it is not safe because of possible data leakage from incognito to regular profile. This CL updates SadTab to receive the current profile (i.e., regular or off-the-record profile) of current tab and pass it to HelpAndFeedback activity. Bug: 1041781 Change-Id: I6c5b85187f627348e2dadbba8eaa3a18d02ddb94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062972Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Marc Treib authored
It had a single implementation, FCMSyncNetworkChannel, and nothing actually referred to the interface. Bug: 1029481 Change-Id: I4791dd4a4760687f29499faee7986d1dfefb5745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062422 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743029}
-
Eric Leese authored
This reverts commit d4838474. Reason for revert: The new build rule js_library("app") was causing build failures due to a missing app.js file. No-Tree-Checks: true Original change's description: > [system-web-apps] Add chrome-untrusted iframe to sample system web app > > An example of how to embed a chrome-untrusted iframe into a system web > app. > > To do so, we need to add abstract methods in WebUI despite WebUIImpl > being the only class to actually implement it. This is so the > WebUIController can add requestable schemes so the WebUI can request > the chrome-untrusted resource. > > Bug: 1048951 > Change-Id: Ia3152e21412845cf421df74bb00a16e0a8f264b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037186 > Commit-Queue: Jessica Huang <jessing@google.com> > Reviewed-by: calamity <calamity@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Auto-Submit: Jessica Huang <jessing@google.com> > Cr-Commit-Position: refs/heads/master@{#742999} TBR=kinuko@chromium.org,calamity@chromium.org,ortuno@chromium.org,jessing@google.com Change-Id: I7036191fd5c92bcfb42743ef23ed05d58b57063e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064932 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL removes the flag for clearing browsing data in web/ Bug: none Change-Id: If7cdadee8e2c88145ee296ccbead9501762d77ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049969Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#743027}
-
Vasilii Sukhanov authored
Bug: 1052997 Change-Id: I2839187374a6399529770144ce211509b50e5e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062447Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#743026}
-
Balazs Engedy authored
While location bar user input in progress, GetContentSettingWebContents will return nullptr, but ContentSettingImageView::AnimationEnded is still invoked. Add a check in the latter to make sure we are not checking on a null WebContent if the promo should be shown. Bug: 1054074 Change-Id: I261bceb410478360f6af2d84ddf5e01f5c9e6cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064968Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#743025}
-
Jan Wilken Dörrie authored
This change adds a string16 overload for CanonicalizeUsername which will be useful for the Bulk Leak Check. In order to avoid duplicating code, the implementation is turned into a template, used by both the 8-bit and 16-bit version. Bug: 1047726 Change-Id: I03a3d7cd6d037f0c526d35e1f81080b1ce16503f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064548 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#743024}
-
Omar Morsi authored
Some NSS Certificate Database functions that return information about certificates are expensive and should not be called on the UI thread. This CL is part of the effort of normalizing the way of gathering this certificates information to make sure it is gathered on a worker thread. To call these functions on a worker thread, they should not depend on NSSCertDatabase instances, so if the instances goes out of scope, the code does not run into undefined behaviour. In this CL some NSS Certificate Database functions that does not depend on database instances are converted to static to be able to use them safely inside worker threads. 1- net_unittests --gtest_filter=NSSCertDatabase* 2- unittests --gtest_filter=CertificateManagerModel* Bug: chromium:1043083, chromium:1012430 Test: Change-Id: I63a1157c5d92b44f8d5252e9475104a1adfa8376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054090Reviewed-by:
-
Omer Katz authored
Bug: 821951 Change-Id: I1ad389c5092411f72d636fbdd5060d99d1be6fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023653 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#743022}
-
Anand K. Mistry authored
Bug: 634140 Change-Id: I4d8d051446f5797428b938b7d1ff773d637c4ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065690Reviewed-by:
-
Kent Tamura authored
Move HandlePopupOpenKeyboardEvent(), ShouldOpenPopupForKey*Event() of HTMLSelectElement to MenuListSelectType They are used only by MenuListSelectType. This CL has no behavior changes. Bug: 1052232 Change-Id: I0fe76842e2767c4f7a0d8ee6f1e1f3cf69cec4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065693Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#743020}
-
Joshua Bell authored
These tests cover 5 encodings (UTF-8, UTF-16LE/BE, Windows-1251/1252) and exercise many features (HTML, CSS, SVG, Workers, ...). They're currently all skipped in Chrome (and other browser CI systems), since something in that huge matrix fails or times out for everyone. https://github.com/web-platform-tests/wpt/issues/4934 suggests splitting these into separate files. As a stopgap, split them out using the WPT "variant" mechanism and provide expected failure files for subsets, which should make fixing the tests and/or browsers more actionable, and let us catch new regressions. Bug: 930297 Change-Id: I4813281f547216b2b5f377118a58a419f62cfbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063808 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#743019}
-
Clark DuVall authored
GetAutoApprovalOrigin() does not need the request parameter. Also removed some unnecessary namespace qualifications. Bug: 1025609 Change-Id: If40143d7c6b743328167afc5b95af3b6b49616cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066102 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#743018}
-
Colin Blundell authored
In advance of bringing up a factory for ChromeSSLHostStateDelegate in //weblayer, this CL simplifies the one in //chrome by making ChromeSSLHostStateDelegate a KeyedService directly rather than having a wrapper class inside the factory. This avoids the need to replicate the boilerplate in //weblayer's factory. Bug: 1030692 Change-Id: I5732f70c5180261c9bbbc385e38da623e01cab86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063172Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#743017}
-
Thomas Guilbert authored
Currently, video.requestAnimationFrame() callbacks execute as soon as possible on the main thread, disregarding the normal event loop processing model. This CL delays the execution of the video.rAF callbacks to the next time the rendering steps are run (e.g. right before the regular window.rAF callbacks). This makes video.rAF callback more consistent with what web authors would expect for a method of that name. Spec: https://wicg.github.io/video-raf/ Intent-to-prototype: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/LGPUCOCVQxs/IKVPne8wDQAJ Bug: 1012063 Change-Id: If16dc9b76df6c732ebdfa1d1582ea34278ee0d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040742 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#743016}
-
Josh Simmons authored
Extend this flag expiry until Chromium M85 Bug: 992818 Change-Id: Id56171d8eb9d969141943e1c9415e9f1da68465a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065694Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#743015}
-
Nico Weber authored
Except on iOS, CrOS, Chromecast for now. I did two full local non-goma builds with this off and on, and couldn't measure any slowdown from the warning. (`gn clean out/gn && time ninja -C out/gn content_shell`) Bug: 1031169 Change-Id: I91fe477f00cbef12bf48dcfb377ee83ed5a3fabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063736 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#743014}
-
Mohamed Amir Yosef authored
Bug: 1044365 Change-Id: Ie3d5246c24a046c18d6d2bfa6d92d1fdd46839db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063013Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#743013}
-
Viktor Semeniuk authored
Changed Reauth dialog message for Copy password into clipboard feature. Added new Reauth Purpose reason. Bug: 917337 Change-Id: If805234969a39a98b24af1816f33c88388a06b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061814 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
-
Luciano Pacheco authored
Change TreeItem classes to avoid doing a full rescan just to work out if we should show the expand icon or not. Instead, only scan down to the first sub-directory using the new method updateExpandIcon(). Replace calls to updateSubDirectories() with updateExpandIcon() where the content of sub-directories aren't needed. The most important call replaced is in SubDirectoryItem constructor, because this caused scanning of an additional level down from the folder that user was interacting with. This significantly improves the performance of navigating on folders that have large sub-folders. For example, the time to run integration test directoryTreeExpandFolder() cut down from ~40 secs to ~7 secs, where the most of time is spent expanding a sub-folder that contains 1k children. Test: browser_tests --gtest_filter="DirectoryTree/FilesAppBrowserTest.Test/directoryTreeExpandFolder" Bug: 1039820 Change-Id: Ib629601f2c795a6dedd80a04f85827fd33e96af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059729Reviewed-by:
-
Yoshifumi Inoue authored
Before this patch, |NGPhysicalTextFragment::ResolvedDirection()| takes long time for text ranges not having text shape result, e.g. force line break, tab, etc. Then selection painting for large plain text containing newline, e.g. <pre>. This patch changes |NGPhysicalTextFragment| to hold resolved direction known at inline formatting rather than finding |NGInlineItem| from inline formatting context. This means we scan |NGInlineItem| list for every newline. On sample page (having 20,000 newline in <pre>), rendering time is 4,689ms to 1,881ms (2.4 times faster). Bug: 1050397 Change-Id: I0cc2a7b9c4ac75232b70b41f7d97134bdc966eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063562 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c008fcb8cc0f..c12493ff69e2 git log c008fcb8cc0f..c12493ff69e2 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 johnkslang@users.noreply.github.com Merge pull request #2086 from samuelig/SPV_AMD_shader_image_load_store_lod Created with: gclient setdep -r src/third_party/glslang/src@c12493ff69e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Ib3b59c6f9b8f0569b948c485474ab8bbe2ac0291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066049Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743009}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/048075425abc..adeb0b9fdd32 Created with: gclient setdep -r src-internal@adeb0b9fdd32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ied8471d178b746b37434d41625797181ce370d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066048Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743008}
-
Kai Ninomiya authored
https://chromium.googlesource.com/external/github.com/gpuweb/cts/+log/ec18cc3262922e7dcdbe70243c6f40606f979144..02b62c256590b040d514ec15c0f12041be8d1575 Change-Id: I6db0043cf844a81d1ccdecb4e7c0a51de5430fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050036Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#743007}
-
Sean Kau authored
Some subsystems don't have access to a profile but need to observe CupsPrintersManager. Build a Proxy object that can be observed and will attach the primary user CupsPrintersManager when it's created. Change-Id: I6b52d51740e7d72359030c7ab6551541d8b2d30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057859Reviewed-by:
Luum Habtemariam <luum@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#743006}
-
Armando Miraglia authored
Bug: 1053255 Change-Id: Iac23a5c894030573013a92071ef31dbee9c938aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062398Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#743005}
-
