- 12 Jan, 2021 40 commits
-
-
Andrew Grieve authored
UMA currently shows that: Os.stat() fails .14% of the time Runtime.exec() fails 0.02% I suspect the heuristic for where the .odex files live might be wrong for some small portion of devices, so would like to collect these crashes. Bug: 1152970 Change-Id: I98d1a14ae670bb1be04de6a4564001b65a67a1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624808Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#842563}
-
Allen Bauer authored
Added ability for metadata to return a finite list of valid values for a given member, such as enums and bool. Bug: 938501 Change-Id: I1ca2d37b08122df832adff0c153c038a291f260d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065428 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#842562}
-
John Delaney authored
What: No longer parse impressiondata as hex, or use hex when sending conversion reports. Why: This causes needless conversions for developers, as raised on https://github.com/WICG/conversion-measurement-api/issues/60 Note that the conversions database stores imp and conversion data as strings currently because they are represented as hex. These can be converted to strings now, but this is left as a followup. Bug: 1163599 Change-Id: I5b164c380a97cb272c6a0ee698df8b744feb58ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611958Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#842561}
-
Lukasz Anforowicz authored
This CL adds an AbstractUrlTest test suite that covers both KURL and GURL. Having tests that are shared across Blink and //url will help 1) avoid code duplication and 2) ensure that Blink and //url behave in the same way (at least wrt things covered by the shared tests). Bug: 1164416 Change-Id: I6812c0230cc1ef91416aa9a8f967a5db15d4bf77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622736Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#842560}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2ce9752f..81b3d28a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I853bd6aec86fa0e23ad33d8cfaab4a2e44659552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624106Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842559}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610431066-60b154442ebb054827e182b9c834d6f36e05d2b3.profdata to chrome-win64-master-1610452567-3155f81fa9ef93aecd596b942169049fc68cadb1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I97ce263fa01f9313e6d0968199a29b9eccd0940b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624257Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842558}
-
Alice Wang authored
This CL removes the redundant check FirstRunUtils.canAllowSync() in ForcedSigninProcessor.signinAndEnableSync(), as this method is always called with an account from AccountManagerFacade, FirstRunUtils.canAllowSync() is always true in ForcedSigninProcessor.signinAndEnableSync(). Bug: 1045525 Change-Id: I6e7632b2b27de917497d9982cd7e95a4e76527c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623289 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842557}
-
Rainhard Findling authored
Bug: 1128901 Change-Id: I53dfcd0519a4d103032495f1dca2f0040bc3fc92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623927Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Auto-Submit: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#842556}
-
Titouan Rigoudy authored
Whereas in the embedded iframe tests, we exercise 7 different sources: - `about:blank` - the initial empty document - srcdoc - `data:` - `javascript:` - `blob:` - `filesystem:` For these tests only 4 of them are relevant, because: - srcdoc is not applicable to `window.open()` - a top-level frame cannot be navigated to a `data:` URL - a top-level frame cannot be navigated to a `filesystem:` URL This is also what the Web Platform tests do, see: third_party/blink/web_tests/external/wpt/secure-contexts/basic-popup-and-iframe-tests.https.js Bug: chromium:1126856, chromium:1154729 Change-Id: I3e89732b3f788c25e11064b9bc429c460e061fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595530 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842555}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e3e59aac750e..c60dda78e4ab 2021-01-12 treehugger-gerrit@google.com Merge "tp: fix sorting by id on thread state table" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6a1c36d049c6ded2fb6e5369cbb4f2c5b9dbbf7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624256Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101120600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/yhWN-sh7gopLrFlZSwV0PMt236wQVRnoOIc1ppByspUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021 Tbr: help-app@grotations.appspotmail.com Change-Id: I2e8fdb65ca12bf839eecc650a8e7a8058ed0ee27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623499Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842553}
-
Mustafa Emre Acer authored
Hostnames typed without a scheme but with a non-default port shouldn't be upgraded to HTTPS. In such a case, we can't simply change the scheme to https:// and expect the site to load since it's likely that the HTTPS version of the URL is also served from a non-default port. This CL also fixes handling of IP addresses when there is a port. Previously, we were checking whether the entered text was an IP address. This breaks down if the IP address has a port attached to it such as 127.0.0.1:8080. This CL instead checks the canonicalized_url. Bug: 1141691 Change-Id: Iffefa5c0ee939b361d8152c5cd417756841b5923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623683 Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#842552}
-
Daniel Hosseinian authored
Bug: 93619 Change-Id: Iabd045503b598b0469fedc37e99afd5fdb9620da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622001 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842551}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/04314b1d8edb..b577a78d937c 2021-01-12 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-12 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-12 dzigterman@chromium.org Dedede: Turn off AP flash select with c2d2 2021-01-12 saklein@chromium.org api/validate: add each_in validator 2021-01-11 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-11 liaoyuke@chromium.org Lacros: Fix a typo in cros_test 2021-01-11 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-11 vapier@chromium.org OWNERS.testplatform: remove historical entries 2021-01-11 pprabhu@chromium.org cbuildbot: Upload crashes detected during canary hwtests 2021-01-11 seanabraham@chromium.org OWNERS: add test platform team If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I3889c70eeba2767668f6e0c63e5cd6c170686481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622609Reviewed-by:
-
Kevin Ellis authored
Accommodate numerical precision errors when determining if an animation is finished. The finish method explicitly sets current time to be EffectEnd(); however, the value could be off by as much as 1.10155e-16 due to quantization error. The possibility for quantization error triggered a 0.5% flakiness of one of the tests in updating-the-finished-state.html. The test in question performed a seek after calling finish, which should have triggered a finished event even though the animation is no longer finished after the seek (finish is synchronous). The play state was still detected as running after finish was called. This patch accommodates fuzzy equality when calculating the play state. Performed 1000 runs of the test after the patch with 0 flakes, which gives 95% confidence that the probability of a failure has been reduced to less than 0.052% (a 100x reduction). Bug: 1139023 Change-Id: Ibf4104c3cb8fcacdc96abbb0cda8e7c05cc525c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621924Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#842549}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/019ddccc581e..81d005b6696c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rainhard@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1097080 Tbr: rainhard@google.com Change-Id: I2af8b70760e7e5291f38283a7067178a39398b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624028Reviewed-by:
-
Caroline Rising authored
Add a new histogram to track the option selected from the bookmark icon menu. Bug: 1163938 Change-Id: I9e644c447c9c5ac499db3ab58d70f17cb6ae153e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616139 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#842547}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2bd95f1cf454..7fae6cbf1d37 2021-01-12 cwallez@chromium.org Add new third-party dependencies to .gitignore 2021-01-12 bclayton@google.com ShaderModule: Enable the prettier tint diagnostic formatter 2021-01-12 cwoffenden@gmail.com Minor fix to build with MSVC: Removes switch with only default case 2021-01-12 bclayton@google.com ShaderModule: Refactor ParseWGSL() to take a File* If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I7215ffa4d8b623e5f1911904e2a188d463696052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624250Reviewed-by:
-
Christian Biesinger authored
Have to go through the replaced element intrinsic size function for correctness. Bug: 1163850 Change-Id: If08134c1a4d1b70c069459001774bc8ad09a21cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621929 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#842545}
-
Stepan Khapugin authored
Hides the setting when the policy is enabled. No need to do anything else, since when there's no Incognito mode, there's nothing to protect, and without any incognito tabs all other code is no-op. Bug: none Change-Id: Iaeb94ab9f9d78a09096d0bbf611a992a19df28b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617882Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Tina Wang <tinazwang@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842544}
-
Rune Lillesveen authored
Check containment on the layout object instead of ComputedStyle. If containment does not apply according to principal box, it should not act as a container for container queries. Bug: 1146097 Change-Id: I361242bdd23e389a2f390930af5945301a452ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623292 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#842543}
-
Clark DuVall authored
This is a simplified version of the fix for Chrome in crbug.com/1159608. This is not as big of an issue in WebLayer because it looks like the bug doesn't apply if the framework detects the split is used by another app (which should be the case in WebLayer). We still want the fix just in case, since there are still some situations we can get invalid dex, for example if a user opens a WebView app (not WebLayer), then bg-dexopt runs. Bug: 1105096 Change-Id: I72d105fd7de0a9a32331d1b394dec05f4bc35b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623118Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#842542}
-
Dominique Fauteux-Chapleau authored
This changes the following histograms' expiration to 2022-02-01: SafeBrowsing.DeepScan.Upload.* SafeBrowsing.DeepScan.Paste.* SafeBrowsing.DeepScan.DragAndDrop.* SafeBrowsing.DeepScan.Download.* Enterprise.OnBulkDataEntry.DataSize.* The volume of data for deep scans is expected to increase during 2021 so keeping these histograms for longer will acquire useful data. Change-Id: I2cbc3b678b065d6518a6009d0cad6eb211a8ff21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622279Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#842541}
-
Stephen McGruer authored
This is mostly a debugging change for crbug.com/1163615, as I don't *think* 'wpt manifest' should take >5 minutes anyway. However doubling the timeout for it should make it clear whether crbug.com/1163615 is a case of the wider crbug.com/1161274 . I also added some logging when we do kill a process due to timeout, as currently nothing says the ScriptError is caused by that, and passed '-v' to 'wpt manifest' as well to get verbose logging in the case of failures. Bug: 1163615 Change-Id: I04536f191cbb5f7f7aa32a314c8616173704354e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622336 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842540}
-
Fredrik Söderqvist authored
Move the logic from PaintNormalBoxShadow() into a helper function (ApplySpreadToShadowShape) and call that from PaintInsetBoxShadow() as well (with the specified spread negated). Bug: 1159514 Change-Id: I9cf91deaa998c5d1db23f0cad569697214fb493d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624209Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#842539}
-
Kenichi Ishibashi authored
We still want to preserve the following histograms: * ServiceWorker.InternalsPageAccessed * ServiceWorker.Storage.DeleteAndStartOverResult Bug: 1165179 Change-Id: I013479f239444055f312f4ac0c83e2d2469fef89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623369 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#842538}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101120600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/CahPFs6jLT-RYm6-kxrLmP917a316i02uOphMFmENT0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/168065258,b/172977755,b/174442020,b/174603791,b/176499357,b/177269239,b/177273874 Tbr: media-app@grotations.appspotmail.com Change-Id: I1f5493ed500e2118802fd20771321a54cab8df21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624105Reviewed-by:
-
Nohemi Fernandez authored
For the experiments related to ITP, Chrome will track how often the infobar is shown following a change in the google.com cookie state. Bug: 1157475, 1131027 Change-Id: Ibbf314e121a383f7e15b9791d34c5826bdc23c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621918 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#842536}
-
Sigurdur Asgeirsson authored
Bug: 1164947 Change-Id: I5a4cc3521ede1b8032cad26800c28efbf9a1fabd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621917 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#842535}
-
Michael Thiessen authored
These tests are not unit tests, because they initialize the browser process. Also they fail when unit tests reset ApplicationStatus. Change-Id: Iefbc335a8d30ff8aa2ae8b6f1ba40318e2863163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622331 Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#842534}
-
Alice Wang authored
This CL removes the redundant boolean argument in ProfileDownloader. Bug: 1151860 Change-Id: I1d8c366fb292f322ad51dddfef2ad2c3ef0a0457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620561Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842533}
-
Dave Tapuska authored
In https://crrev.com/2613151 we waited until the view was to send the message. Which when creating the view and the main frame is correct, but when it gets navigated it isn't what we want. A new scenario crept up with opening a preview image first, and then loading a preview page. This caused the RenderFrameCreated gets called before the main frame mojo channel is attached and the message is dropped. To mitigate this use a different callback (DocumentAvailableInMainFrame) which guarantees the main frame has been attached. BUG=1158712 Change-Id: I91f61ebec049690bc0fa8ef053612dd985c12443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622276Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#842532}
-
Evan Stade authored
Bug: 1164069 Change-Id: If37fa667ed69020a2104e4d82d63c161a06cfd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623531Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#842531}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7297ea89b095..9dd43ad51d98 2021-01-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-12 janscheffler@chromium.org Reland "[JSDOC2TS]: Migrate webauthn" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie5338fd26e714b5f1892d79ae56f616147cbf91c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624254Reviewed-by:
-
Robbie Gibson authored
Before, it was possible for two gesture recognizers to be simulatneously recognized. E.g. panning the toolbar while scrolling or panning both the tab strip and the toolbar. This caused lots of problems. This CL lets the ViewRevealingVerticalPanHandler track which gesture recognizer it is currently handling. While it is handling one, all other gestures are ignored. Bug: 1161209, 1163518 Change-Id: I3525cfd670a08a5b88166dd5d8c647b7a9b437f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618000Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#842529}
-
Aaron Leventhal authored
Add Blink a11y team to OWNERS for web_ax_object.h Add aleventhal to OWNERS for web_ax_enums.h Bug: None Change-Id: Ibebb187146e177bae68302731367026db9d6400a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623190Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#842528}
-
Brian Salomon authored
Bug: 1152901 Change-Id: I1dc79b0afc83a11d61fcd1ea56a3bbce3fe88f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623187Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#842527}
-
chrome://flagsPeter Beverloo authored
Bug: 1146450 Change-Id: Icbfa93cbb98446d191d6d674359add5da4c93ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623553 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#842526}
-
David Bienvenu authored
This reverts commit 12c756d2. Reason for revert: <fix compile failure caused by racy submit> Original change's description: > Revert "Fix flakiness in ChromeLabsButtonTest.ShowAndHideChromeLabsBubbleOnPress" > > This reverts commit 9cc64477. > > Reason for revert: Breaks ChromeOS builder. See https://crbug.com/1165349. > > Original change's description: > > Fix flakiness in ChromeLabsButtonTest.ShowAndHideChromeLabsBubbleOnPress > > > > This test is very flaky, I believe because it relies on global state, > > instead of explicitly setting up the LabInfo used to populate the labs > > button. For example, if there were no current labs in SetUpLabs, the > > test would fail. So this CL explicitly sets up the LabInfo for the labs > > button. It's a bit messy that it requires a change to the production > > code, but I didn't see any other way of plumbing that information > > through to the model. > > > > Bug: 956719 > > Change-Id: I8078c211e37fc1eeff50a44043eca760cdc4850a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618656 > > Reviewed-by: Collin Baker <collinbaker@chromium.org> > > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#842150} > > TBR=davidbienvenu@chromium.org,collinbaker@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I5cd05c29bb299b97fe8b491d865a9925c642a5f5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 956719 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622519 > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842174} TBR=sammiequon@chromium.org,davidbienvenu@chromium.org,collinbaker@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 956719 Change-Id: I0f96304d5fae80b203f69064f9f68f7765011d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623160Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842525}
-
Jordan Demeulenaere authored
This CL adds support for showing multiple details to the bottom sheet, instead of only a single one. Bug: b/174652960 Change-Id: I8b31f752b0d0cd81a9d7b7f5f3b9b0c8a8cf1b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604339 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#842524}
-
