GitLab

Part of the removal of PassRefPtr.

Replaces many of the calls to RefPtr::release with a std::move wrap,
which returns a RefPtr instead of a PassRefPtr. As the code currently
stands, most methods still expect a PassRefPtr and so the PassRefPtr
initialising constructor will be called passing in the RefPtr rvalue,
which calls RefPtr::release anyway.

Future patches will see these variables changed from PassRefPtr to
RefPtr type then RefPtr::release will not be used at all.

Does not handle RefPtr::release of non member variables in return
statements as these cases sometimes default to move (in the case of
returning a local variable). These will be handled in future patches.

BUG=494719

Review-Url: https://codereview.chromium.org/2628773002
Cr-Commit-Position: refs/heads/master@{#443416}

TEST=no functionality change

Review-Url: https://codereview.chromium.org/2623273008
Cr-Commit-Position: refs/heads/master@{#443415}

This is a skeleton of a Chrome Windows Debugger extension that will
provide convenience commands for developers using ntsd, cdb, or windbg.

BUG=

Review-Url: https://codereview.chromium.org/2612193002
Cr-Commit-Position: refs/heads/master@{#443414}

Merge internal change 143128776

BUG=

Review-Url: https://codereview.chromium.org/2611613003
Cr-Commit-Position: refs/heads/master@{#443413}

Add the support for the updateArgumentsPostValidate custom hook, and
add tests for the same.

BUG=653596

Review-Url: https://codereview.chromium.org/2617423003
Cr-Commit-Position: refs/heads/master@{#443412}

BUG=505177

Review-Url: https://codereview.chromium.org/2571713005
Cr-Commit-Position: refs/heads/master@{#443411}

Fixed text-align keywords in CSSProperties.in to match the values in
CSSValueKeywords.in. This will not actually change the generated values
at this time since "webkitLeft", and "-webkit-left" will both result
in the enum value "kWebkitLeft" being generated. However, long term
it is important that the values exactly match those in
CSSValueKeywords.in.

BUG=628043

Review-Url: https://codereview.chromium.org/2631473002
Cr-Commit-Position: refs/heads/master@{#443410}

Part of the removal of PassRefPtr.

Replaces many of the calls to RefPtr::release with a std::move wrap,
which returns a RefPtr instead of a PassRefPtr. As the code currently
stands, most methods still expect a PassRefPtr and so the PassRefPtr
initialising constructor will be called passing in the RefPtr rvalue,
which calls RefPtr::release anyway.

Future patches will see these variables changed from PassRefPtr to
RefPtr type then RefPtr::release will not be used at all.

Does not handle RefPtr::release of non member variables in return
statements as these cases sometimes default to move (in the case of
returning a local variable). These will be handled in future patches.

BUG=494719
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2622043003
Cr-Commit-Position: refs/heads/master@{#443409}

BUG=671246
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2629643002
Cr-Commit-Position: refs/heads/master@{#443408}

Move type, size, timeStampSeconds and modifiers to be private members.
This change will help harden the API so that we can place DCHECKS on
certain states.

Design: https://docs.google.com/document/d/1s4Lfy22CNU1OZ5Rec6Oano_5BvIhdK6uFVsVe7FphKI/edit

BUG=625684
TBR=jochen@chromium.org, wez@chromium.org, thestig@chromium.org, sadrul@chromium.org, rockot@chromium.org, dcheng@chromium.org, girard@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2573073003
Cr-Commit-Position: refs/heads/master@{#443407}

This implements the crash handler companion to the launcher in https://codereview.chromium.org/2596463002/. The handler parses the command line as created by the launcher. After this, it can write a minidump with MinidumpWriteDump, then augment it with Crashpad metadata and massage such that Crashpad can parse it.
After this, the dump is dropped into the Crashpad database for eventual upload.

BUG=678959

Review-Url: https://codereview.chromium.org/2611393002
Cr-Original-Commit-Position: refs/heads/master@{#443249}
Committed: https://chromium.googlesource.com/chromium/src/+/92651104e939dbe94378a607e7acd381ca394fd3
Review-Url: https://codereview.chromium.org/2611393002
Cr-Commit-Position: refs/heads/master@{#443406}

For some reason, some pages redefine window.Element, which breaks our previous
use of instanceof.

BUG=chromedriver:1388

Review-Url: https://codereview.chromium.org/2620803002
Cr-Commit-Position: refs/heads/master@{#443405}

Video track needs to be reenabled before the new renderer is
created so that the callbacks attach properly. For that, add
two new callbacks to PipelineController for when the pipeline
is about to resume and is resumed.

This adds a potential problem when the video is shown or hidden
in between the two events. So don't change the video track if
the pipeline is resuming or seeking but check for the necessary
conditions in the resumed callback.

BUG=678374
TEST=media_[blink_]unittests + manual testing

Review-Url: https://codereview.chromium.org/2618883002
Cr-Commit-Position: refs/heads/master@{#443404}

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2618393003
Cr-Commit-Position: refs/heads/master@{#443403}

Part of the removal of PassRefPtr.

Replaces call to RefPtr::release with a std::move wrap,
which returns a RefPtr instead of a PassRefPtr. As the code currently
stands, the method return type is still a PassRefPtr, and so the
PassRefPtr initialising constructor will be called passing in the
RefPtr rvalue, which calls RefPtr::release anyway.

Future patches will see these variables changed from PassRefPtr to
RefPtr type then RefPtr::release will not be used at all.

Does not handle RefPtr::release of non member variables in return
statements as these cases sometimes default to move (in the case of
returning a local variable). These will be handled in future patches.

BUG=494719

Review-Url: https://codereview.chromium.org/2628763002
Cr-Commit-Position: refs/heads/master@{#443402}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/679672b1..ad889a60

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2629663004
Cr-Commit-Position: refs/heads/master@{#443401}

Original CL got reverted due to 2 LayoutTests failing in a single bot:
(Mac Retina bot)
fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html

This bot compiles with no proprietary codecs. H264 was selected
as potentially accelerated by the platform (correct) but H264 was
not enabled in this platform, so we hit a DCHECK().

This CL makes sure that H264 is not considered if
#if BUILDFLAG(RTC_USE_H264
is false.

Original CL description ------------------------------------------------
MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available

This CL adds a static method to VTR to query which
one, if any, is the preferred video codec.

A new singleton Lazy Leaky class CodecEnumerator is
added to encapsulate poking the VEA to see which
codecs are supported, and to further query
a) the preferred codec id
b) if a given codec is supported
and wraps the previous CodecIdToVEAProfile()
functionality.

BUG=679946

Review-Url: https://codereview.chromium.org/2623353004
Cr-Commit-Position: refs/heads/master@{#443400}

In http://crrev.com/1785953002 I tied a setting to the
is_overriding_user_agent property of NavigationEntry, but I forgot to
keep the preference updated during arbitrary navigation entry changes
(e.g. back button).

BUG=671580
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2619063003
Cr-Commit-Position: refs/heads/master@{#443399}

This CL adds test cases for opening the media router dialog from the page
context menu and the app menu.

BUG=678472

Review-Url: https://codereview.chromium.org/2621723003
Cr-Commit-Position: refs/heads/master@{#443398}

BUG=679846

Review-Url: https://codereview.chromium.org/2629273002
Cr-Commit-Position: refs/heads/master@{#443397}

BUG=680720
TEST=Linux Intel HD 530 bot
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2629543006
Cr-Commit-Position: refs/heads/master@{#443396}

This CL removes the "deferred quit" from most of the touched helpers.

The exclusions are UrlCommitObserver and TestFrameNavigationObserver.
They were already using immediate quit mode, so there is no change in
their behavior, just cleanup.

Regarding title checks in browser_browsertest.cc: in these tests there
is no guarantee on when the new tab will start and stop loading. It
can start loading after WindowedNotificationObserver::Wait returns; also
it can stop loading while we're still inside it. We can explicitly wait
for the title to handle all these cases, and this makes the call to
WaitForLoadStop unnecessary.

BUG=668707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2601843002
Cr-Commit-Position: refs/heads/master@{#443395}

BUG=657012

Review-Url: https://codereview.chromium.org/2530043002
Cr-Commit-Position: refs/heads/master@{#443394}

We have written a Physical Web WebUI that we intend to be the de facto
view for browsing Physical Web URLs.  This change makes sure the user
goes there when they try to display URLs from:
* the diagnostics page and
* the settings fragment.

BUG=663842

Review-Url: https://codereview.chromium.org/2601273003
Cr-Commit-Position: refs/heads/master@{#443393}

Reverted https://codereview.chromium.org/2625933003 as the GPU drivers on the Intel GPU perf bots need updating first.

R=jmadill@chromium.org
TBR=dtu@chromium.org, eyaich1@chromium.org, jmadill@chromium.org

Review-Url: https://codereview.chromium.org/2626373002 .
Cr-Commit-Position: refs/heads/master@{#443392}

Now, after http://crrev.com/2580343003, HTML diffs are available on all platforms, and dependency on wdiff can be removed.

BUG=672651

Review-Url: https://codereview.chromium.org/2582293004
Cr-Commit-Position: refs/heads/master@{#443391}

In rare cases, devices time out on the first real command sent to them.
On swarming, the total time required for this timeout can exceed that
amount of time allotted for the containing task to finish. This is bad.

This change checks that the device is fully booted before attempting to
do anything else with it. The commands this runs should ensure that we
can run basic commands on the device and that the package manager is
running. This all runs with a relatively short timeout, so we should
be able to identify a potentially problematic device before hitting
the swarming timeout.

BUG=664308

Review-Url: https://codereview.chromium.org/2628953003
Cr-Commit-Position: refs/heads/master@{#443390}

This change enables the page loading indicator in the HTML UI by
plumbing status through the Android WebContentsDelegate. If future work
exposes this information via WebContentsObserver, most of this plumbing
can be removed.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2620383007
Cr-Commit-Position: refs/heads/master@{#443389}

This is a follow up for https://codereview.chromium.org/2625453002/

Animate() called after EXPECT_CALL(mock_input_handler_, ScrollBy(testing::_)).Times(0);
at the end of the test. The change is for making sure that last Animate()
won't call ScrollBy when the fling is over.

BUG=526463
TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled

Review-Url: https://codereview.chromium.org/2627793005
Cr-Commit-Position: refs/heads/master@{#443388}

Get rid of the functions to get each individual program type, and
replace them with calls to GetProgram with the appropriate key.

Move uniform tracking to ProgramBinding, and get rid of all of the
various "uniform cache" structures that were created to handle getting
uniforms from all of the different shader types.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2622243003
Cr-Commit-Position: refs/heads/master@{#443387}

https://pdfium.googlesource.com/pdfium.git/+log/db7647083d0a..98d00b230aa1

$ git log db7647083..98d00b230 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 dsinclair Remove used items from the CSS code.
2017-01-12 tsepez Don't put timers with ID == 0 into the global timer map.
2017-01-12 tsepez Custom toString() methods may delete annots.
2017-01-12 npm Fix leak in OJPEGReadHeaderInfoSecTablesAcTable when read fails.

BUG=679649,679643,680520

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2627073004
Cr-Commit-Position: refs/heads/master@{#443386}

BUG=680675,680684
TEST=Linux Intel HD 530 bots on GPU FYI waterfall
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2629653003
Cr-Commit-Position: refs/heads/master@{#443385}

This fixes a missing word typo ("won't to make" -> "won't need to
make"), fixes some stylistic inconsistencies (fenced code blocks), and
reformats the markdown to conform to mdformat.

BUG=

Review-Url: https://codereview.chromium.org/2627003006
Cr-Commit-Position: refs/heads/master@{#443384}

TODOs have been removed since we are no longer componentizing
SafeBrowsingService and are not yet supporting reporting in WebView.
Comments for the base class methods have been updated to indicate these
methods are no-ops, but describe how they should be overridden.

BUG=488675

Review-Url: https://codereview.chromium.org/2629203002
Cr-Commit-Position: refs/heads/master@{#443383}

BUG=303429
TEST=Manual test by the instruction described in the issue.

Review-Url: https://codereview.chromium.org/2620273002
Cr-Commit-Position: refs/heads/master@{#443382}

Review-Url: https://codereview.chromium.org/2627103004
Cr-Commit-Position: refs/heads/master@{#443381}

These files define test cases inside a dedicated `registerTests`
function. This no longer has any benefit for isolating tests, and just
reduces the amount of horizontal space available for test code.

This CL only removes these registerTests functions and deindents
the corresponding code -- there are no functional changes to any
tests.

BUG=647115

Review-Url: https://codereview.chromium.org/2627263002
Cr-Commit-Position: refs/heads/master@{#443380}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/290f611623b2..4bd0c43eba04

$ git log 290f61162..4bd0c43eb --date=short --no-merges --format='%ad %ae %s'
2017-01-12 hjd [dashboard] Remove console.log I added by accident
2017-01-12 aiolos TimelineTrackView Hoisting refactor: addKeyPressHotKey in TimelineTrackView.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2627113004
Cr-Commit-Position: refs/heads/master@{#443379}

Previously, these navigations were aborted due to this unfortunate
sequence of events:

1. A new provisional RenderFrame is created with a proxy_routing_id_
of the proxy that it would replace once it commits.

2. RFHM::UpdateStateForNavigate calls CommitPending early, because the
current RFH was not live (crashed).  This destroys the
RenderFrameProxy to which the RenderFrame's proxy_routing_id_ in step
(1) referred.

3. Next, when navigating the frame, RenderFrameImpl::OnNavigate
checks whether the proxy it's supposed to replace still exists, and
aborts the navigation because it doesn't.

This CL avoids this problem by sending a new IPC message,
FrameMsg_SwapIn, to the provisional frame when doing the early
CommitPending call in step (2).  This ensures that the renderer also
swaps the provisional frame into the tree, replacing its associated
proxy.

BUG=487872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2619123002
Cr-Commit-Position: refs/heads/master@{#443378}

BUG=596760

Review-Url: https://codereview.chromium.org/2623143006
Cr-Commit-Position: refs/heads/master@{#443377}