- 13 Mar, 2018 40 commits
-
-
Mike Reed authored
needed for https://skia-review.googlesource.com/c/skia/+/113940 Change-Id: I4db6feb9e518cdacbaba10fcbd3e790927f3d4a3 Reviewed-on: https://chromium-review.googlesource.com/959531Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#542723}
-
Trent Apted authored
Flaky. TBR=scottmg@chromium.org Bug: 819924 Change-Id: Id6a337392ec94bbc1b3ae2f83a914bc4d2565996 Reviewed-on: https://chromium-review.googlesource.com/958666Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#542722}
-
Nicolás Peña authored
This CL renames the classes as follows: * UserActivityLogger -> UserActivityManager * UserActivityLoggerDelegate -> UserActivityUkmLogger * UserActivityLoggerDelegateUkm -> UserActivityUkmLoggerImpl * UserActivityLoggingController -> UserActivityController Design doc: https://docs.google.com/document/d/1QXXnRFKiRDvXaxwNTc6djMDC-5e7SXk4i2FI3fpxMdA/edit?usp=sharing Change-Id: Id8a1b2e35c3bfde9e07ee47613510da5415f038a Reviewed-on: https://chromium-review.googlesource.com/956164 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542721}
-
Manu Cornet authored
Change-Id: I4578a80f4c49c381109efaddf326934b834978ec Reviewed-on: https://chromium-review.googlesource.com/953646 Commit-Queue: Manu Cornet <manucornet@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#542720}
-
chaopeng authored
In this patch, we covert the scale factor from Direct Manipulation to GesturePinch event. The ctrl+wheel will create by WebViewImpl:: HandleSyntheticWheelFromTouchpadPinchEvent. Bug: 647140 Change-Id: Ib041d7805daac7e71b2f43872c818a9f36b14abd Reviewed-on: https://chromium-review.googlesource.com/786348Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542719}
-
Koji Ishii authored
This patch cleans up an unused variable I happened to find while debugging. Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I4498954e510e0a64362b688fe20ea46014906f0e Reviewed-on: https://chromium-review.googlesource.com/958649Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#542718}
-
Trent Apted authored
TBR=ricea@chromium.org Bug: 820334 Change-Id: Ie25ebb66474e51cb87a2908e233ba8e0438720f9 Reviewed-on: https://chromium-review.googlesource.com/958944Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/8103ecae7b53..c25e2693ab00 $ git log 8103ecae7..c25e2693a --date=short --no-merges --format='%ad %ae %s' 2018-03-12 brianosman Fix several bugs in SkDebugCanvas/SkDrawCommand Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I7e4668f530ae3ab6a2416b13cbd37aa5fcff0714 Reviewed-on: https://chromium-review.googlesource.com/959534Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542716}
-
Kyle Horimoto authored
This CL breaks out the dialog-specific functionality of ui::WebDialogUI into a new class, ui::WebDialogUIBase. ui::WebDialogUI now derives from both WebDialogUIBase and content::WebUIController. The new ui::MojoWebDialogUI class integrates Mojo functionality into web dialogs via ui::MojoWebUIController. Classes deriving from ui::MojoWebDialogUI can produce dialogs that make Mojo calls in JS. Change-Id: Ie91ae935aba5d65f7bcde1c13dfd9ecdee28ffab Reviewed-on: https://chromium-review.googlesource.com/947048Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#542715}
-
Wenzhao Zang authored
Bug: 809756 Change-Id: I1a2fed0038ea40c0bae1781ae088f686b3a9e90b Reviewed-on: https://chromium-review.googlesource.com/959741Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542714}
-
Scott Violet authored
This reverts commit b4603176. Reason for revert: Reverting as one of the fixs for an interactive_ui_test failure got reverted. Original change's description: > Adds WindowService-ChromeOS fieldtrial > > I'm not sure on the name here. I went with WindowService-ChromeOS as > at some point we will launch the WindowService on other platforms, but > that won't be anytime soon and is likely to be very different. So, I'm > thinking later on we have the field trial WindowService-Desktop. > > BUG=814898 > TEST=none > > Change-Id: I5bf45c2a463de0fefaeb06939429977e36c3681e > Reviewed-on: https://chromium-review.googlesource.com/932821 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542680} TBR=sky@chromium.org,rkaplow@chromium.org Change-Id: Id63c00a90c6fd05ff74f0ffaa6ed738a98bd74e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 814898 Reviewed-on: https://chromium-review.googlesource.com/959763Reviewed-by:
-
Han Leon authored
This is to fix the 2 unit tests on CFI builds: ServiceWorkerHandleTest.DispatchExtendableMessageEvent_FromClient ServiceWorkerHandleTest.DispatchExtendableMessageEvent_Fail BUG=820620,772713,813749 Change-Id: Iaf4a6f4a464fe97a44f63bf2ca5a1a2e04400b9b Reviewed-on: https://chromium-review.googlesource.com/958126Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#542712}
-
Koji Ishii authored
Following bot results are included. 4164 4165 4166 4167 4168 4170 4172 4174 4177 4178 4180 4181 4183 233 lines were removed and 10 lines were deflaked by consecutive results since 4126. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I88db7f2b1bb88cc7fcb3c04aee0507b3b949bf19 Reviewed-on: https://chromium-review.googlesource.com/958362 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#542711}
-
Wez authored
This test is inherently flaky, so disable it pending a fix. TBR: rockot Bug: 821254 Change-Id: Ic9db63f5a66d1e775033e6e2c9fa029beb7c5e42 Reviewed-on: https://chromium-review.googlesource.com/959746Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#542710}
-
Trent Apted authored
Flaky. TBR=sky@chromium.org Bug: 820435 Change-Id: I32621c2152ef4b089c3990ccfb4f46e8fb1f5f29 Reviewed-on: https://chromium-review.googlesource.com/958892Reviewed-by:
-
David Tseng authored
This change takes the O(n^2) computation of a node's bounds down to O(n) by caching previously computed bounds. It also solves a crash which seemed to result from corruption of the incoming node data. This was observed while using NY Times with webviews containing many nodes and firing many events. Change-Id: I43c9295864fdcaf3775348eb17f55a4cf66da281 Reviewed-on: https://chromium-review.googlesource.com/956413 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#542708}
-
Xiaohan Wang authored
Pepper CDM support is being deprecated. This CL removes all CDM adapter (pepper plugin) registration/checking code. Bug: 772160 Change-Id: I5b6c538a0b96360c7c32a2d35d1dab41f0ed34c1 Reviewed-on: https://chromium-review.googlesource.com/956255Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542707}
-
Trent Apted authored
Flaky. TBR=mathp@chromium.org Bug: 821202, 516052 Change-Id: Ic697ed6f0c3ae27f9a8b6358071a584a6026d30d Reviewed-on: https://chromium-review.googlesource.com/958891Reviewed-by:
-
Trent Apted authored
This reverts commit c8c4c686. Reason for revert: Causes EventRewriterTest.EventRewriting to fail on Android/Linux CFI starting https://uberchromegw.corp.google.com/i/chromium.memory/builders/Android%20CFI/builds/241 error like ../../ui/events/event.cc:306:10: runtime error: control flow integrity check for type 'ui::LocatedEvent' failed during base-to-derived cast (vtable address 0x0000002689b0) 0x0000002689b0: note: vtable is of type 'ui::(anonymous namespace)::TestEvent' #0 0x62afb5 in ui::Event::AsLocatedEvent() const ./../../ui/events/event.cc:306:10 #1 0x63063a in ui::(anonymous namespace)::IsLocatedEventWithDifferentLocations(ui::Event const&) ./../../ui/events/event_source.cc:19:45 #2 0x630083 in ui::EventSource::SendEventToSink(ui::Event*) ./../../ui/events/event_source.cc:46:34 #3 0x4a23e2 in ui::(anonymous namespace)::TestEventRewriteSource::Send(ui::EventType) ./../../ui/events/event_rewriter_unittest.cc:69:5 #4 0x4a1fe4 in ui::EventRewriterTest_EventRewriting_Test::TestBody() ./../../ui/events/event_rewriter_unittest.cc:188:5 Original change's description: > chromeos: provide ability to supply event for rewriting > > EventRewriters don't honor the target, and so generally expect the > root_location and location to be the same. This patch changes EventSource::SendEventToSink() > to create a new Event if the existing has differing locations (and a target). > > BUG=817112 > TEST=covered by tests > > Change-Id: Iaabe019fed4350610306576a054b7d395def92ff > Reviewed-on: https://chromium-review.googlesource.com/956925 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542653} TBR=sadrul@chromium.org,sky@chromium.org Change-Id: I5ee070c74eba97a446c1a8e71e12f64b90b27401 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 817112 Reviewed-on: https://chromium-review.googlesource.com/958806Reviewed-by:
-
Robert Iannucci authored
TBR=jbudorick@chromium.org, tandrii@chromium.org Bug: 811974 Change-Id: I1cbeab2333cd9a243177cf9a4e1d1bd73b1efc19 Reviewed-on: https://chromium-review.googlesource.com/959745Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#542704}
-
Patti authored
VectorIcons currently have two representations - a version used at 100% scale (its |path_1x|) and a version used at all other scale factors (|path|). This isn't scaleable and can't support having more than two icon representations per VectorIcon, so add gfx::VectorIconRep to prepare for this. Bug: 647286 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iff59deb2064ce0f0995016fee9dcdeda16999605 Reviewed-on: https://chromium-review.googlesource.com/942647 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#542703}
-
Christopher Lam authored
The presubmit had the wrong file used as a test, and didn't trigger on unpack_pak.py changes. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia7125e6b034261c29a2acdb067896f2ac9c9f216 Reviewed-on: https://chromium-review.googlesource.com/956650Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#542702}
-
Kent Tamura authored
Apply snake_case to CSSPrimitiveValueUnit.json5, generated CSSPrimitiveValueUnitTrie.cpp, and generated CSSTokenizerCodepoints.cpp. This CL has no behavior changes. Bug: 770603 Change-Id: I41c913ec0dfa9e51d0ddc5f7a5b782c6c128e461 Reviewed-on: https://chromium-review.googlesource.com/958052Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#542701}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 770603 Change-Id: I1669bca88648ad866882a8dad7ae5b9137af7af3 Reviewed-on: https://chromium-review.googlesource.com/958650Reviewed-by:
-
Siddhartha authored
The unwind tables are stripped from release builds. This CL adds a script to extract the unwind table sections from unstripped binary and adds it as an asset file in the apk. This script is first used in the test apk, when add_unwind_tables_in_apk is specified. Will be used later added to chrome apk. BUG=819888 Change-Id: I68d2ea843ed0c7a7a3ee60c48f683e01809ff217 Reviewed-on: https://chromium-review.googlesource.com/954421Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#542699}
-
Findit authored
This reverts commit e9605182. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 542634 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U5NjA1MTgyNTE4Njc4NDVlZDIzYmYyYWI4ZjA0MmE3N2FmZTE4ODUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/8479 Sample Failed Step: mojo_unittests Original change's description: > Delay Channel::OnError() in case of kDisconnected during Write(). > > Write() operations to a Channel can fail due to the peer having closed > it, while there are still messages waiting to be read from it. We must > therefore defer notifying the caller of the Channel::Error until we > observe end-of-stream via a readable notification, otherwise those > messages may be dropped (depending on whether the posted OnError task > is processed before or after a pending Channel-readable event). > > Bug: 816620 > Change-Id: I75bd34a48edf4022809d27ce49f9cfba7a5d4daf > Reviewed-on: https://chromium-review.googlesource.com/956932 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542634} Change-Id: I9d212ecb8dde1e90422b60e950547e823357f0d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 816620 Reviewed-on: https://chromium-review.googlesource.com/959761 Cr-Commit-Position: refs/heads/master@{#542698}
-
Darren Shen authored
Currently, any CSS property in CSSProperties.json5 with keywords will implicitly accept keywords. This can cause crashes if the property doesn't actually store keywords as CSSIdenifierValues. We solved this by having a manual whitelist of properties we explicitly support. However, this is annoying to maintain. So we generate this whitelist from CSSProperties.json5 by explicitly specifying "Keyword" as a typedom_type. e.g. a property that doesn't have typedom_types will not be supported by Typed OM. A property that has "Keyword" in typedom_types will take CSSKeywordValues and reify as CSSKeywordValues. We also add support for scroll-padding-* because the JSON for that was already there and we just to write a test for it. Diff of generated files: https://gist.github.com/darrnshn/03cb617909abab7bf94aaaaad9874a15/revisions Bug: 820299 Change-Id: I6fa01c3623161e0778c5f8764009c6e0cdd6bbf3 Reviewed-on: https://chromium-review.googlesource.com/956903Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#542697}
-
Trent Apted authored
This reverts commit f35977d9. Reason for revert: causes TCPSocketTest.ReadAndWriteMultiple to flake (timeout) Bug: 821232 Original change's description: > Add TCP socket API to network service > > This CL adds TCP socket API to network service. > This is partly based on mandoline implementation > (https://codereview.chromium.org/1873463003/) > > Two TCP socket interfaces are added. > - TCPConnectedSocket > - TCPServerSocket > > TBR=miu@chromium.org > > Bug: 721401 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I56e2702c02b9c86a72eba68c85391c3b017a4d64 > Reviewed-on: https://chromium-review.googlesource.com/868711 > Reviewed-by: Helen Li <xunjieli@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542606} TBR=miu@chromium.org,mmenke@chromium.org,tsepez@chromium.org,xunjieli@chromium.org,rhalavati@chromium.org Change-Id: Id31caa2f5cc54993735586555e68bd3c345600bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/958943Reviewed-by:
-
Luciano Pacheco authored
CL #2 out of 5. Converted the following directories: - third_party/WebKit/Source/core/animation - third_party/WebKit/Source/core/html - third_party/WebKit/Source/core/layout When the ctor is private replaced to base::WrapUnique, otherwise used std::make_unique. Removed include of wtf/PtrUtil.h. Fixed missing includes pointed by git cl lint. Bug: 781645 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5e5a35de44df03d801a3553b56761126374402e4 Reviewed-on: https://chromium-review.googlesource.com/933882 Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#542695}
-
https://chromium.googlesource.com/catapult.git/+log/4b356c746683..548a5bc4b828 $ git log 4b356c746..548a5bc4b --date=short --no-merges --format='%ad %ae %s' 2018-03-12 pasko androidStartupMetric: add request_start_time Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I6ec5f05001dd5905ed2ebd45d804c1f9c0054b6a Reviewed-on: https://chromium-review.googlesource.com/959522Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542694}
-
Darren Shen authored
When we create a CSSUnitValue with '' as the unit, we hit a DCHECK in the unit trie code because the length is 0. This is because we don't correctly reject the empty string as an invalid unit. In this patch we fix this. Interestingly, we already have a test to assert that using an empty unit throws type error. However the test used an incorrect variable name, causing it to throw a TypeError anyway, so our tests would've passed no matter what. Bug: 820905 Change-Id: I72ab5e4010d892042b2cfddf1014ab79d04a846d Reviewed-on: https://chromium-review.googlesource.com/958624Reviewed-by:
-
Pawel Pluciennik authored
Moved most of the logic related to resolving paths to ResolvePath and ResolveRelative in filesystem_utils.cc. Improved SourceDir class to return std::string with resolved path for cases when returning SourceDir or SourceFile wasn't really needed. R=brettw@chromium.org, dpranke@chromium.org Bug: 819720 Change-Id: Ia59da00e83de45431762ebb19a9153471f7e91e3 Reviewed-on: https://chromium-review.googlesource.com/953422Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#542692}
-
Nick Harper authored
TBR=elawrence@chromium.org Change-Id: I2e0241863946192bef71c92d57be09de55237f30 Reviewed-on: https://chromium-review.googlesource.com/959635Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#542691}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/10c5b8fc..be58a3b3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6da4151977cf9bea4086d5ed64b5761a541eb0f5 Reviewed-on: https://chromium-review.googlesource.com/959614Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542690}
-
Nicolás Peña authored
This CL moves UpdateOpenTabsURLs() from the UserActivityLoggerDelegate to the UserActivityLogger. This is done in preparation for adding a predictor which will also use some of the URL features as well as other features calculated by the UserActivityLogger. This predictor will be called from UserActivityLogger. In a followup, some of these classes will be renamed. To allow testing UpdateOpenTabsURLs() in the UserActivityLoggerTest instead of UserActivityLoggerDelegateUkmTest, the unittests are refactored. Design doc: https://docs.google.com/document/d/1QXXnRFKiRDvXaxwNTc6djMDC-5e7SXk4i2FI3fpxMdA/edit#heading=h.gjgriz8s7dlc Change-Id: Icd8515437f0524bf56ad5d4c537814773aa247d7 Reviewed-on: https://chromium-review.googlesource.com/950602 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
-
Dominick Ng authored
https://crrev.com/c/915442 restructured the ownership of objects in app banner Java code. In particular, InstallerDelegate was moved from AppBannerInfoBarDelegateAndroid to AppBannerUiDelegate. For native apps, InstallerDelegate is given AppBannerInfoBarDelegateAndroid as an observer, and tells it about the progress of installation. Prior to https://crrev.com/c/915442, when AppBannerInfoBarDelegateAndroid was destroyed, it would also destroy the InstallerDelegate, ensuring that it could not be signalled after destruction. However, there is now the following potential for the following sequence of (racy) actions: 1. C++ AppBannerInfoBarDelegateAndroid is destroyed. In its destructor, destroy() is called on its Java counterpart, resetting the native pointer on the Java side. 2. Race: prior to the AppBannerUiDelegate owned by the C++ AppBannerInfoBarDelegateAndroid being destroyed, the InstallerDelegate owned by AppBannerUiDelegate calls onInstallFinished on the Java-side AppBannerInfoBarDelegateAndroid. This will eventually call OnInstallFinished. 3. Meanwhile, the C++ AppBannerInfoBarDelegateAndroid's destructor continues, clearing the |ui_delegate_| field. This destroys the AppBannerUiDelegate and its owned InstallerDelegate. 4. The C++ AppBannerInfoBarDelegateAndroid has OnInstallFinished called on it (from 2), which attempts to access |ui_delegate_| and crashes with a segmentation fault. This CL fixes the bug by moving 3 (clearing the |ui_delegate_| field) to happen before 1 (calling destroy() on the Java-side AppBannerInfoBarDelegateAndroid). This ensures the InstallerDelegate is destroyed before the native pointer on the Java-side AppBannerInfoBarDelegateAndroid is reset, so that any further progress in installation is not signalled as destruction continues. This prevents accessing |ui_delegate_| after it is cleared, and prevents the crash. BUG=819434 Change-Id: Iab0f7cb9044da332b6d4c6ab0a6f1d41a72195ca Reviewed-on: https://chromium-review.googlesource.com/959409 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#542688}
-
Kunihiko Sakamoto authored
After this refactoring, SignedExchangeHeader - Validates response header names and values, and - Constructs HttpResponseHeaders from the response header map. Bug: 803774 Change-Id: I25c91db1f07c4fcd0e6c62a9d4aa409838361349 Reviewed-on: https://chromium-review.googlesource.com/958647Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#542687}
-
Tetsui Ohkubo authored
This CL adds workaround to MessageView::SlideOut() for a bug that it did not work with MessagePopupCollection. If |by_user| of RemoveNotification is true in SlideOut(), IncrementDeferCounter() in MessagePopupCollection::OnNotificationRemoved is called but corresponding DecrementDeferCounter() won't be called. MessagePopupCollection will be completely rewritten. TEST=message_center_unittests BUG=805208 Change-Id: I1a637cef8bdcb25be45647f487f1d29ab3952583 Reviewed-on: https://chromium-review.googlesource.com/952822Reviewed-by:
-
Gordana Cmiljanovic authored
With these two merged: https://chromium-review.googlesource.com/c/chromium/src/+/904303 https://chromium-review.googlesource.com/c/chromium/src/+/909216 we can enable tcmalloc for mipsel. Bug: 810356 Change-Id: Idd63cb9a0e1a9582047ad203edf160b0c532f854 Reviewed-on: https://chromium-review.googlesource.com/947948Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
-
Malay Keshav authored
This patch adds the layout constants for the rounded corners in bookmark button ink drop highligh and ripple. It also adds the colors the ink drop animation. Bug: 810902 Change-Id: I96853d3c66eeca45881901a6d8b2053d2838c16e Component: Bookmarkbar, theme colors Reviewed-on: https://chromium-review.googlesource.com/954546 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#542684}
-
