GitLab

The --enable-filemanager-mtp is now on by default.
It can still be disabled by --enable-filemanager-mtp=false, or
choosing "disabled" in about:flags.

BUG=266939

Review URL: https://codereview.chromium.org/314033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275375 0039d316-1c4b-4281-b951-d872f2087c98

I'm tired of copy/pasting the wrong style :)

http://www.chromium.org/developers/coding-style#TOC-File-headers

BUG=

Review URL: https://codereview.chromium.org/319813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275374 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of https://codereview.chromium.org/306083005/.
That was reverted because it implicitly added a dependency on
content from athena_shell.

This is identical to the original CL but still safe because
the dependency issue has been fixed already.

BUG=370204
TBR=oshima@chromium.org, benwells@chromium.org, reed@google.com
TEST=manually

Review URL: https://codereview.chromium.org/317163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275373 0039d316-1c4b-4281-b951-d872f2087c98

_NET_ACTIVE_WINDOW events with a CurrentTime timestamp are ignored by Unity.

BUG=365450, 355667
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/317783012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275372 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/318983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275371 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275369 0039d316-1c4b-4281-b951-d872f2087c98

r1927 android: Handle inputs with spaces inside make functions.
r1926 Fix msvs-ninja OutputDirectory path.
r1925 msvs: Revert r1920 and add a test for excluded idl
r1924 Use relative path/dir msbuild variables to map $(InputDir) and
      $(InputPath)
r1923 Fix for some rules not being run if their trigger is also an
      action dependency
r1922 ninja win: filter 64 bit idl processing, and confirm in test

BUG=

Review URL: https://codereview.chromium.org/313243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275368 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
 - Update the copy of the string that describes giving Chrome access to the
 user's Address Book.
 - When the user selects the option to pull autofill suggestions from the
 Address Book, Chrome immediately prompts the user for permission to use the
 Address Book. I considered delaying the prompt until the option screen is
 dismissed, but that works less because there are too many ways to dismiss the
 screen that cause the prompt to appear contextless. (e.g. The user
 performs a history navigation).
 - Add a resource for the Contacts icon for the autofill entry.
 - Add metrics for the autofill entry that suggests that the user give Chrome
 access to the Address Book.
 - The pref for auxiliary profiles should default to NO on mac, and should not
 be syncable.
 - Update the logic in PersonalDataManagerMac to reflect the new default state
 of the pref.
 - Update layout logic of the autofill entry to move the text up by 1 pt, to
 better account for the weighting of the Contacts icon asset.
BUG=139154

Review URL: https://codereview.chromium.org/301343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275367 0039d316-1c4b-4281-b951-d872f2087c98

Also simplify the code generation for initializing default values.

BUG=320082

Review URL: https://codereview.chromium.org/317073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275366 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380813

Review URL: https://codereview.chromium.org/320483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275365 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380669

Review URL: https://codereview.chromium.org/319703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275364 0039d316-1c4b-4281-b951-d872f2087c98

This is a preparation of task parallelization in SyncFS backend.

BUG=380615

Review URL: https://codereview.chromium.org/302003013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275363 0039d316-1c4b-4281-b951-d872f2087c98

Full test name is PlatformAppBrowserTest.AppWindowAdjustBoundsToBeVisibleOnScreen

After launching an app, tests need to wait for the launch to be complete. If this isn't done the window will potentially be created after the system starts shutting down, causing the system to hang at shutdown.

BUG=377754

Review URL: https://codereview.chromium.org/310373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275362 0039d316-1c4b-4281-b951-d872f2087c98

We ran "python detect_host_arch.py" ~15 times from gyp. Run
detect_host_arch.py directly from from within gyp for faster execution
and since the path is no longer part of the command, the result will
also be cached more often.

The total gain is at best 0.3 seconds. For most people it will be less.

BUG=362075

Review URL: https://codereview.chromium.org/256303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275361 0039d316-1c4b-4281-b951-d872f2087c98

The only client of the interface was //chrome/browser/history for the
HistoryService but since it now uses a HistoryClient to abstract the
access to the bookmarks, the interface is obsolete.

BUG=364865
TBR=gab,zea,sky

Review URL: https://codereview.chromium.org/306143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275360 0039d316-1c4b-4281-b951-d872f2087c98

We want to change current directory if the active item on navigation list is changed.
But we don't want to change current directory when listed items are spliced or permuted.
In both cases, 'change' event is dispatched from selection model and we can't distinguish these cases from event itself.
currentActiveItem_ is introduced to detect change of actual active item.

BUG=375663
TEST=go through steps in Issue 375663 and 361047

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273601

Review URL: https://codereview.chromium.org/303503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275359 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381581

> Add authentication support to AttachmentUploaderImpl.
> 
> Update AUI to request an access token and send an Authorization header
> with each requests.  If the server responds with 401, AUI invalidates
> its token, but does not retry.  Retries will be implemented in a future
> CL, probably at a higher level.
> 
> BUG=371516
> 
> Review URL: https://codereview.chromium.org/304253010

TBR=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/316413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275357 0039d316-1c4b-4281-b951-d872f2087c98

We don't build browser_tests on official
> Include browser_tests.exe in output of official Chrome Windows builds.
> 
> 
> BUG=379986
> 
> Review URL: https://codereview.chromium.org/302403003

TBR=anandc@chromium.org

Review URL: https://codereview.chromium.org/314113007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275350 0039d316-1c4b-4281-b951-d872f2087c98

chrome://tracing uses TimeTicks::NowFromSystemTraceTime in
base/time/time_posix.cc.

The previous patch is reverted because it did not check this
test is running on Chrome OS.

TEST=nacl_loader_unittests  # on i686 and ARM Chrome OS
TEST=trybot (including linux_chromeos)
BUG=378063
R=jln@chromium.org

Review URL: https://codereview.chromium.org/317913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275347 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Other patches need to land before this. This broke bots.

Original issue's description:
> [Telemetry] Overhaul startup metric.
> 
> This focuses us on the user-perceived aspects of startup.
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275194

TBR=aiolos@chromium.org,jeremy@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/317743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275345 0039d316-1c4b-4281-b951-d872f2087c98

This version is likely less efficient, but doesn't require gin.

BUG=372065

Review URL: https://codereview.chromium.org/294123008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275342 0039d316-1c4b-4281-b951-d872f2087c98

1) BeginInteraction+EndInteraction becomes
    interaction = action_runner.BeginInteraction(...)
    interaction.End()

2) Add action_runner.ExecuteJavaScript.

3) Replaced all existing use cases.

Other cleanups:
1) s/JavascriptAction/JavaScriptAction/
2) s/GetJavascriptMarker/GetJavaScriptMarker/


BUG=361809

Review URL: https://codereview.chromium.org/313383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275341 0039d316-1c4b-4281-b951-d872f2087c98

WebTouchPoint has used floating point co-ordinate and radius values for awhile, but we've never allowed generating non-integer values via EventSender.

BUG=323935

Review URL: https://codereview.chromium.org/316303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275340 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373091

Review URL: https://codereview.chromium.org/321433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275339 0039d316-1c4b-4281-b951-d872f2087c98

This is when we expose DrawBuffers extension.

BUG=376951
TEST=the attached test case, webgl conformance
R=kbr@chromium.org,bajones@chromium.org

Review URL: https://codereview.chromium.org/315283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275338 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=oshima@chromium.org
TEST=None

Review URL: https://codereview.chromium.org/310243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275337 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357517

Review URL: https://codereview.chromium.org/281323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275336 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/316223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275335 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347825

Review URL: https://codereview.chromium.org/309593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275334 0039d316-1c4b-4281-b951-d872f2087c98

Focus a media source when it's view is tapped. Select it on double-tap.

BUG=380490

Review URL: https://codereview.chromium.org/317783007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275333 0039d316-1c4b-4281-b951-d872f2087c98

There's no reason to have this. It was originally because PermissionsData
didn't really belong on Extension (and was to be taken off), but now that
PermissionsData is refactored to only include active permissions, it belongs
on the extension object.

TBR=ben@chromium.org (c/b/ui - simple refactor, no functional changes)
TBR=thestig@chromium.org (c/b/media_galleries - simple refactor, no functional changes)
BUG=379356

Review URL: https://codereview.chromium.org/315573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275332 0039d316-1c4b-4281-b951-d872f2087c98

Added two JSON tree dumps to be loaded by the perftests

Same as issue 305063002 (https://codereview.chromium.org/305063002)

Review URL: https://codereview.chromium.org/312233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/314223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275330 0039d316-1c4b-4281-b951-d872f2087c98

This fixes an issue where a lazy require of app bindings (when unavailable) will not yield a properly constructed bindings export.

BUG=373179

Review URL: https://codereview.chromium.org/319783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275329 0039d316-1c4b-4281-b951-d872f2087c98

And with this patch, the error detail is shown in case of error.

BUG=355545
TEST=manually tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/315103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275328 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275327 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378911

Review URL: https://codereview.chromium.org/303123006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275326 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds the upstream libaddressinput strings into the Chrome
build inside of chrome/app/address_input.grdp to work well with the
translation tools.

TBR=estade@chromium.org
BUG=327046

Review URL: https://codereview.chromium.org/312883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275325 0039d316-1c4b-4281-b951-d872f2087c98

Only take a screenshot if the page id changes.

Looking at NavigationControllerImpl::ClassifyNavigation(), I think this is the
right check. If we could move the code for taking the screenshot post
controller_->RendererDidNavigate() call, we'd be able to use the NavigationType
calculated in that method, but based on the comments for the screenshot code,
this doesn't seem like a safe thing to do.


BUG=375921

Review URL: https://codereview.chromium.org/316553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275324 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/314583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275323 0039d316-1c4b-4281-b951-d872f2087c98