- 09 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3fd631b2397e..5df4a7a9dcb7 2020-06-09 skyostil@google.com Merge "tracing: Allow empty call to OnTraceData" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2cb064e76d7ddd38c1255ff060d49f8fac7dc211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238246Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776635}
-
Olesia Marukhno authored
It is used in the permission chip to get proper padding. Bug: 1019129 Change-Id: I33b5ed4599d65a3d32f3177c9b47d2ec35451604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235042 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#776634}
-
Dana Fried authored
Tabs.TabCountPerWindow was set to expire in M85. Bug: 1089573 Change-Id: I68801a5165a3e16b984045515f843ed992081fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236273Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#776633}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a01ec53bddbd..d3927e40f1de 2020-06-09 mtklein@google.com Revert "Reland "Add JavaInputStreamAdaptor files into third_party directory."" 2020-06-09 brianosman@google.com In GrColorInfo, compute color xform from sRGB at construction time 2020-06-09 michaelludwig@google.com Don't recompute clipped op bounds in setupDstProxyView 2020-06-09 mtklein@google.com ignore SK_DISABLE_READBUFFER 2020-06-09 brianosman@google.com Make SK_DISABLE_EFFECT_SERIALIZATION trim out more code 2020-06-09 mtklein@google.com use type name as identifier instead of factory 2020-06-09 johnstiles@google.com Reland "Add JavaInputStreamAdaptor files into third_party directory." 2020-06-09 mtklein@google.com Revert "remove unnecessary hsw opts" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I69022b2f710afd976feacf58c0a95a8f8b64fd24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237877Reviewed-by:
-
David Trainor authored
- Some external components use UiUtils: - #getDrawable() could go away and the app compat library could be used directly. - #dateToHeaderString() moved to browser_ui/util as it is used by DateDividerAdapter on multiple components. - DownloadActivity used Filters#goUrl() to start downloads home on the prefetch filter. Added a config setting to set this instead and hid the concept of Filters. - Pulled the reference of VrModeProviderImpl out of the download home component and passed in a VrModeProvider instead. Bug: 1062116 Change-Id: I572dce7f1b7ac48235412a20a71aace6def5c04a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229445Reviewed-by:Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#776631}
-
Xing Liu authored
Add a method in DownloadItem to get DownloadSchedule, this is needed to plumb the data to download level db. Bug: 1078454 Change-Id: Ifce1245a45a393d131901cb15257f74337146afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234131Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776630}
-
Akira Baruah authored
Refactors ScopedServiceBinding's publishing functionality into a separate class, allowing an embedder to manage its own fidl Binding or BindingSet instance, while benefitting from the scoped service registration lifetime. Bug: b/154042778 Test: base_unittests Change-Id: I959268b97d6c8d12487fb56db49ed8713f264169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231552 Commit-Queue: Akira Baruah <akirabaruah@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#776629}
-
Tomasz Wiszkowski authored
Bug: 1087700 Change-Id: I27e571a82048265f840db71493594cef2447e7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238014Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#776628}
-
Xida Chen authored
[sheriff] Mark external/wpt/html/rendering/replaced-elements/embedded-content/cross-domain-iframe.sub.html fail on Mac TBR=dimich@chromium.org NOTRY=true Bug: 1093003 Change-Id: I4e8a6e158ec9fb1cad83b5bc80ee5adedeac4cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238454Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776627}
-
Lei Zhang authored
The code that recorded the histogram was removed 3 years ago in crrev.com/480267. Bug: 734161,1089315 Change-Id: I16cd2bb5f125908505ffd0bf4650a1be765f767d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236676Reviewed-by:
-
Jonah Ryan-Davis authored
This experiment has been tested on 1% of stable users since Apr 7, 2020. The finch release process requires the feature to be enabled in ToT by default when it's launched so a max_version can be set for the finch trial. Bug: chromium:976283 Bug: chromium:882580 Change-Id: I2b25c20d8e229a1cb47bcf7f85f6bbf0fca44a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221434Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#776625}
-
Morten Stenshorne authored
Fragmentainers are a bit special, and they are also always block containers. Therefore, just deal with them completely on our own in NGBlockLayoutAlgorithm, instead of leaving the job to FinishFragmentation(). The background here is that I'm working on some changes in FinishFragmentation() where I'd otherwise have to make exceptions for fragmentainers. Better to just avoid it. No behavior changes. Change-Id: Ib18168497bbe4de29aa365beb0c2c3d40aaeccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236142Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#776624}
-
Dmitry Titov authored
TBR=dtrainor@chromium.org NOTRY=true Bug: 1092924 Change-Id: I37139d6a010ecd34793baeabe8bf899326900ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238024 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91286aa462fa..86d91fc0ded9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xidachen@google.com,dimich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:985590 Tbr: xidachen@google.com,dimich@google.com Change-Id: Ic10a610da4073eeed4b66014c855d4eab68ead84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237878Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776622}
-
Frank Liberato authored
Bug: 1088908, 1088910, 1075628, 1075627 Change-Id: I9fc93989bb727b37e08441fd0cd43a20fc1fd9a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236250 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Mikhail Khokhlov authored
Adds support for internal-only files in binary_deps_manager. Adds a script to convert device power profiles to SQL script and upload it to the internal cloud bucket. Bug: b/158459921 Change-Id: I9c3fd954bae350497cdf366ce856794b78835b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235617Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#776620}
-
Sergey Poromov authored
Update the Chrome OS-only strings according to https://docs.google.com/document/d/17ZQF59-5Quw542S9SlnCkFfp8a100ZU2Pn5NOZqyJrE/edit?usp=sharing Include 3 changes: 1) Show filename instead of "Scan complete, no issues identified" for the case of successful scans, so it looks like a normal download. 2) Change all the strings for notification while scanning, so it's: Scanning <filename> In progress Checking with your organization's security policies. https://drive.google.com/open?id=1S6J03NbR-3Uv6MDlRse5SwjmC-fi3rPT 3) Show reason for downloads blocked due to large size or being encrypted. Bug: 1081203 Bug: b/153456225 Change-Id: I3c7e59e3a0a7cae0ce2a105f3dfac422a2fc30a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230467Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#776619}
-
Nathan Zabriskie authored
In OOPR Canvas2D we no longer have access to Skia in the client process. We need to update CanvasResourceProvider::Clear to not access SkCanvas in the case of OOPR. A more ideal fix is tracked in https://crbug.com/1090081 but simply ignoring it is fine for now as OOPR automatically handles clearing the canvas during initialization. Bug: 1090083 Change-Id: I5fb75e4fac312ec00b8e5215d3756219672461ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236193 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#776618}
-
Xida Chen authored
TBR=dimich@chromium.org NOTRY=true Bug: 1073052 Change-Id: I69e19ecfe2edb3facfb5950585b3d754b71f58c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238586Reviewed-by:
-
Denis Kuznetsov authored
Fixed: 1071778 Bug: 856310 Change-Id: I3c4d0beb18a81edff017fc51159d05d214f4f1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195243 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776616}
-
evliu authored
This CL blocklists a hardcoded list of websites from the using the Live Caption feature because those frequently visited websites contain their own captions. This blocklist is temporary and is intended to reduce the usage of the feature while it is implemented using the Open Speech API behind a flag. The blocklist will be removed when the feature is officially launched with the Speech On-Device API. Bug: 1090862 Change-Id: Icc064a7dfd459a930afb5dadd5a52d488495094d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229149 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#776615}
-
Evan Stade authored
This CL severs all //chrome dependencies from 1. CookieControlsBridge (java and native) 2. CookieControlsController 3. CookieControlsView Moving these files to //components is TODO. Bug: 1071775 Change-Id: Ib67bfd74b69e5443fca721fd08b52d85b2872eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229423 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#776614}
-
Guido Urdaneta authored
Nested null callbacks can cause crashes. Bug: 1090007 Change-Id: I967b0f1365ce4df1f489b595344bf247e2fac9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237890 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#776613}
-
Vladimir Levin authored
This patch updates the tests with the spec draft link, and moves all of the relevant tests into WPT. Some tests remain internal due to reliance on functionality not available in WPT. R=chrishtr@chromium.org Fixed: 1090375 Change-Id: Ifbad2eabbe46c41a223d8b63c3ec92c6ab9ccee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236919 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#776612}
-
Clark DuVall authored
This implements site isolation for the preloaded origin list on Android, along with handling the memory threshold policy. The next step is to implement the dynamic detection of password sites. Bug: 1058364 Change-Id: I12b93c07bbb237a914f1f80704dbb049e5412db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236064 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#776611}
-
Qiran Gong authored
base::UnguessableToken. This avoids a CHECK failure that can cause the fuzzer to crash. Change-Id: I88a5a64f0c86abeaaa7216d3e4b61346d4ed9e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236337Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#776610}
-
Xida Chen authored
TBR=dimich@chromium.org NOTRY=true Bug: 1092977 Change-Id: I58a647812237f5c543a3a2a5d5af717b79bc103f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238446Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, CanMakePaymentQuery would stop its timers in the destructor, which is the second phase of browser shutdown, as opposed to the KeyedService::Shutdown() method, which is the first phase, where all references should be released. This may have caused a crash when closing the browser. This is a speculative patch to have CanMakePaymentQuery stop its timers during the first phase of browser shutdown. After this patch, CanMakePaymentQuery stops its timers in the KeyedService::Shutdown() method, which is the first phase of browser shutdown. Bug: 1092472 Change-Id: Ie0b0ebb5642a4d7d80bbaee3ad4c00e48b765b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236251 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#776608}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/08328fea5ab9..68b2e15ee016 2020-06-09 rharrison@google.com Use correct type for var storing returned value (#2263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I7e99e09590cf15d937e99265285bc509be521014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237873Reviewed-by:
-
Raphael Kubo da Costa authored
- Tuple parameter unpacking was removed in Python 3, so adjust type_order_priority() accordingly. - |cmp| as a parameter for list.sort() was removed in Python 3, use functools.cmp_to_key(). Bug: 941669 Change-Id: Icafb2024c77a335e5dd043be066f414a38f14b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236404 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#776606}
-
Thomas Anderson authored
This reverts commit 6ac4a0b6. Reason for revert: Build failure on official builder: https://ci.chromium.org/p/chrome/builders/official/linux64/1293 Original change's description: > Reland "Enable Snap package for official builds" > > This is a reland of d1bd3ffb > > Original change's description: > > Enable Snap package for official builds > > > > BUG=1055026,1090915 > > R=dpranke > > CC=goanuj > > > > Change-Id: I7009f67268fa5d35e9d41fca593248c36f6ef631 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232837 > > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#776165} > > TBR=dpranke > > Bug: 1055026, 1090915 > Change-Id: I80fd77b927b9a832b779bdb09b843016a9c3a93f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236069 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776202} TBR=dpranke@chromium.org,thomasanderson@chromium.org Change-Id: I1de497c89600c89eece335198c6fef3699422caa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055026, 1090915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238410Reviewed-by:
-
Amin Hassani authored
So system_api can be upreved. BUG=1071262 TEST=unittests Change-Id: I20eaf9671e9094eb9304eea161af6e530ab3e974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237393 Auto-Submit: Amin Hassani <ahassani@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Amin Hassani <ahassani@chromium.org> Cr-Commit-Position: refs/heads/master@{#776604}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 164 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-12-06. TBR=chromium-metrics-reviews@google.com Change-Id: Icf8bbe2d04dd2f4130faf6671cbbf1d960681a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238147Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#776603}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dffa944e0725..5ad16a50fcee 2020-06-09 danilchap@webrtc.org suppress 'Paramaterized test suite never instantiated' warning If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifb73ba9b4a59a2f69d9d64c9ec9e145ad9e23234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237871Reviewed-by:
-
Hans Wennborg authored
Since the destructor was not defined in the template definition, code referring to it would fail to link. This started happening in official windows builds when profile-guided-optimization performed virtual call promotion on a call to this function (see bug). Bug: 1092818 Change-Id: I9840e35dabc2d596b59ea5c315697ba15157542e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235826Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#776601}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2ad47493f833..2943cc478e46 2020-06-09 cbruni@chromium.org Avoid UpdateTrafficSettings when possible If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1092870 Tbr: oysteine@google.com Change-Id: I601a9acc77f90aba9e8e44b0fbe2ee619cfc5d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236728Reviewed-by:
-
Daniel Rubery authored
This reverts commit 0f871357. Reason for revert: Caused a spike in crash rate (see https://crbug.com/1092793) Original change's description: > Use IsVisualMatch in the PhishingClassifier > > This CL adds code to the PhishingClassifier to extract a screenshot of > the current page. It also sends this screenshot to the Scorer to > determine if the visual model matches the given screenshot. > > Bug: 1068617 > Change-Id: I9e4cb1ba8888fa76b116405611bf64280a87def0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226974 > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Bettina Dea <bdea@chromium.org> > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775835} TBR=vmpstr@chromium.org,bdea@chromium.org,drubery@chromium.org Bug: 1068617 Change-Id: Id0c5a638346a02bbdc33aab91b96a8e7b96ece48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237910Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#776599}
-
Anastasia Helfinstein authored
To allow Switch Access to automatically move the user's focus into the status tray when it's opened, an accessibility event must be fired when the status tray bubble is created. The event kShow was selected because, although the status tray is treated like a menu by Switch Access, ChromeVox expects that kMenuStart would only be fired on a menu item. AX-Relnotes: n/a. Bug: 866173 Change-Id: I5cd1ac908c6df473135ac2676e3ec5706577b2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231903 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#776598}
-
Hazim Mohamed authored
For drag&drop we'll need to factor out the method responsible for setting permissions for a NFSHandle. We'll also need to expose the method responsible for getting a FSURL from a path. This is done to deduplicate code responsible for and choosing permissions for SharedHandleStates, and to facilitate using the same logic when turning a NFSTransferToken into a Handle. Bug: 1080811 Change-Id: I783b6f1959e0fa03e0178466be4c07ee9d8776d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232879Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Cr-Commit-Position: refs/heads/master@{#776597}
-
Kevin Marshall authored
Mentions of `gclient runhooks` are replaced with `gclient sync`. The instructions previously stated that developers should run `gclient runhooks` after fetching. `runhooks` is not sufficient by itself for fetching all of the dependencies; some tools such as aemu are excluded by this step. Change-Id: I405e17018873fcb69d50e3ab9a49f5fb9503a6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237724 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
-
