GitLab

Bug: 1060971
Change-Id: I3deb3787a431c6d195eb948cd3c966588a9e3ec6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158197Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761005}

https://webrtc.googlesource.com/src.git/+log/146137adeebe..811efc06df3d

git log 146137adeebe..811efc06df3d --date=short --first-parent --format='%ad %ae %s'
2020-04-21 mbonadei@webrtc.org Trigger bots.

Created with:
  gclient setdep -r src/third_party/webrtc@811efc06df3d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I787933ffc0fea40c246c87672248ab0353c211d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159136Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#761004}

Turns out it uses a different setting for disabling hidden API access
from Q. hidden_api_policy_p_apps vs hidden_api_policy.

Bug: None
Change-Id: I25d603664da762f24d44f66bafb20fe641a2b935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159408
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761003}

K is deprecated after m81 so it is not needed any more.
android-cronet-kitkat-arm-rel is kept due to https://crbug.com/1032336#c25

Bug: 1032336
Change-Id: I4e93516375f79faf2b21ef5d7a9c5073b8df9908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157974Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#761002}

This reverts commit 3e1566b9.

Reason for revert: Landed by error

Original change's description:
> Reland "Enables kInfobarUIRebootOnlyiOS13 by default"
> 
> This reverts commit 920d8f93.
> 
> Reason for revert: Initial Patchset to Reland this change. 
> Original change's description:
> > Revert "Enables kInfobarUIRebootOnlyiOS13 by default"
> > 
> > This reverts commit b7db0ccb.
> > 
> > Reason for revert: This causes code to dereference nullptr on iOS 12, thus causing consistent crashed.
> > 
> > Original change's description:
> > > Enables kInfobarUIRebootOnlyiOS13 by default
> > > 
> > > This is now needed in order to enable this locally and not via a finch
> > > config which might not land before the re-sping gets to users.
> > > 
> > > Bug: 1071853
> > > Change-Id: I71b42ca95e54197ddf76b4301616be36c37ad1ca
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157505
> > > Commit-Queue: Sergio Collazos <sczs@chromium.org>
> > > Reviewed-by: Eugene But <eugenebut@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#760756}
> > 
> > TBR=eugenebut@chromium.org,sczs@chromium.org
> > 
> > Change-Id: I534ea0a7d177a3a5452d91ea4bf945375cd2f606
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1071853, 1073091
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159469
> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#760984}
> 
> TBR=sdefresne@chromium.org,eugenebut@chromium.org,sczs@chromium.org
> 
> Change-Id: I2d3fc20cf74f8082b928c1bbef7a1fd51f86704d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1071853, 1073091
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159249
> Reviewed-by: Sergio Collazos <sczs@chromium.org>
> Commit-Queue: Sergio Collazos <sczs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#760999}

TBR=sdefresne@chromium.org,eugenebut@chromium.org,sczs@chromium.org

Change-Id: Id605aba1c85df624862ef46ce9776dedffdb8e37
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1071853, 1073091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159250Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761001}

Only trust the URLWhitelist policy for external protocol handlers if the
computer is part of an AD or AAD domain.

BUG=1052093

Change-Id: Ie0d3ecb24ae6117248ff4e00e875a9104255ef41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152585Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761000}

This reverts commit 920d8f93.

Reason for revert: Initial Patchset to Reland this change. 
Original change's description:
> Revert "Enables kInfobarUIRebootOnlyiOS13 by default"
> 
> This reverts commit b7db0ccb.
> 
> Reason for revert: This causes code to dereference nullptr on iOS 12, thus causing consistent crashed.
> 
> Original change's description:
> > Enables kInfobarUIRebootOnlyiOS13 by default
> > 
> > This is now needed in order to enable this locally and not via a finch
> > config which might not land before the re-sping gets to users.
> > 
> > Bug: 1071853
> > Change-Id: I71b42ca95e54197ddf76b4301616be36c37ad1ca
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157505
> > Commit-Queue: Sergio Collazos <sczs@chromium.org>
> > Reviewed-by: Eugene But <eugenebut@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#760756}
> 
> TBR=eugenebut@chromium.org,sczs@chromium.org
> 
> Change-Id: I534ea0a7d177a3a5452d91ea4bf945375cd2f606
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1071853, 1073091
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159469
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#760984}

TBR=sdefresne@chromium.org,eugenebut@chromium.org,sczs@chromium.org

Change-Id: I2d3fc20cf74f8082b928c1bbef7a1fd51f86704d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1071853, 1073091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159249Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760999}

R=dmazzoni@chromium.org

Change-Id: I78f5c5274ef665b844e4f85648a77b74f9b953de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157991Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760998}

Since the PIN view is not focusable anymore, this is dead code.

Bug: 1043194
Change-Id: Ifd3e4cd8427abaca2bebd76187bba488bd2b4ef5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153441Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Thomas Tellier <tellier@google.com>
Cr-Commit-Position: refs/heads/master@{#760997}

https://skia.googlesource.com/skia.git/+log/24ea293cd25b..e59f718fc277

git log 24ea293cd25b..e59f718fc277 --date=short --first-parent --format='%ad %ae %s'
2020-04-21 lepton@chromium.org SkQP: Fix document about running as native executable

Created with:
  gclient setdep -r src/third_party/skia@e59f718fc277

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jcgregorio@google.com
Change-Id: I5311557aa29aa308f3ca86e2278a3811164c78cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159134Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#760996}

Fuchsia tests are always run by a host system matching the target's CPU
(which may differ from the _build_ host CPU), so simplify the |data|
dependencies of generated runner scripts to use |target_cpu|, allowing
there to be a single list of required tools.

Bug: 1024086
Change-Id: I6346b237f8b87646634d5691f1ceeedc79140639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152445Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760995}

Add a flag to save MetricKit payloads.
Saving the payload will require
- a compilation flag that will be enabled only on canary.
- setting an experimental setting

JSON representation of MetricKit payload will be saved in Documents
directory.

Collecting this data will help developing MetricKit
support in Chrome.

Bug: 1017434
Change-Id: I5db5d7112859eb873ee68e8f7159f7ab9fe3dbfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156905
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760994}

Bug: 839389
Change-Id: I3c27f7f4296ee71257be110aad31bbe69bdf024f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158429Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760993}

This CL adds the controller scaffold of the bubble that proposes to
users to move their local credential to the account-storage.

See the linked bug for mocks.

Bug: 1060128
Change-Id: Idb53ef749d0ad18ee4dcb5af5f98cfedecfc7f8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159220
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760992}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3f4e5c456306..c9b28b9f3388

git log 3f4e5c456306..c9b28b9f3388 --date=short --first-parent --format='%ad %ae %s'
2020-04-21 mennovink20@hotmail.com xcode warnings fix (#2188)

Created with:
  gclient setdep -r src/third_party/glslang/src@c9b28b9f3388

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Bug: None
Tbr: radial-bots+chrome-roll@google.com,tobine@google.com
Change-Id: I8ea0edd0b6e4deb8ec838994a743817104d98a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159267Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#760991}

Hide the example combo-box selector if there is only one example to show.

Part of Views Documentation effort.

Change-Id: I9019148e54d7162bfb8b95a88c515504f130e7d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153307
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760990}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/269ac5675039..56bc9f5a573c


Created with:
  gclient setdep -r src-internal@56bc9f5a573c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC rakina@google.com,pmarko@google.com,ellyjones@google.com,collinbaker@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: rakina@google.com,pmarko@google.com,ellyjones@google.com,collinbaker@google.com
Change-Id: Id87ac1ca628089e935c014c28c63396fd7f376b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159130Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#760989}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1f9465beae14..150d04851644

git log 1f9465beae14..150d04851644 --date=short --first-parent --format='%ad %ae %s'
2020-04-21 vapier@chromium.org cgroups: move NoOpContextManager API here
2020-04-21 vapier@chromium.org kernel_cmdline: convert to python3 only
2020-04-21 lamontjones@chromium.org toolchain_util: prepare even for POINTLESS builds.
2020-04-21 lamontjones@chromium.org toolchain_util: AFDO generation artifact cleanup.
2020-04-21 lamontjones@chromium.org toolchain: additional_args => profile_info
2020-04-21 shaochuan@google.com Cleanup chell-chrome-pre-flight-branch
2020-04-21 vapier@chromium.org dslib/iter_utils: convert to python3 only
2020-04-21 vapier@chromium.org git_unittest: untangle cbuildbot dep
2020-04-20 vapier@chromium.org upload_prebuilts: migrate to python3 only
2020-04-20 cjmcdonald@chromium.org pytest: Clean up & remove 'leaks_process' marker
2020-04-20 cjmcdonald@chromium.org pytest: Clean up & remove 'output_test' marker
2020-04-20 cjmcdonald@chromium.org pytest: Fix up some unittests to succeed when run in one process
2020-04-20 cjmcdonald@chromium.org pytest: Create fixture to prevent leakage of Manager processes
2020-04-20 davidmunro@google.com xbuddy: Fix cros flash to work with python 3.
2020-04-20 vapier@chromium.org paygen_build_lib: migrate to python3 only
2020-04-20 vapier@chromium.org cbuildbot: constants: finish migration to lib

Created with:
  gclient setdep -r src/third_party/chromite@150d04851644

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: Iccf46ca1a32cd31a759d850c8c6c0b3c9ac96e3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159135Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#760988}

Temp steps were only needed when transitioning downstream targets
to androidx.


Bug: 1067070
Change-Id: I0501e21fe4586d146645ac68fb10774c71a69d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157683
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760987}

This CL adds back the entry in histograms.xml for
ThreadPool.NumTasksInSequenceOnPush. This revert
https://chromium-review.googlesource.com/c/chromium/src/+/2159312
removed the definition of the histogram, but we still need it since
it was emitted in 84.0.4121.0.

R=gab@chromium.org, bcwhite@chromium.org
TBR=bcwhite@chromium.org

No-Try: true
Bug: 1071862, 1072977
Change-Id: I317056ceabc057d99273471d17e4a0c1bad8a731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159565Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760986}

This reverts commit 54aa10ad.

Reason for revert: crbug.com/1073010

Original change's description:
> [BrowserSwitcher] Deflake BrowserSwitcherServiceTest
> 
> Previously, the tests waited for action_timeout(), to wait for LBS to
> load the rules and write some files. As expected, this is fairly flaky,
> and it slows down the tests.
> 
> Now, `BrowserSwitcherService' exposes a new event for testing, which
> fires once LBS has loaded the rules. This should reduce flakes by
> listening for the event instead of using an unreliable timeout.
> 
> Also rewrote some tests in a synchronous style, which improves
> readability.
> 
> Bug: 1044619, 1070400
> Change-Id: If1a2093cfe3bface73a46896ff2bc95b80ab2f2e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152885
> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#760531}

TBR=pastarmovj@chromium.org,nicolaso@chromium.org

Change-Id: If573be05ce1a3d4a34449bd6038f16129cb4d1fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1044619, 1070400
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159313Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760985}

This reverts commit b7db0ccb.

Reason for revert: This causes code to dereference nullptr on iOS 12, thus causing consistent crashed.

Original change's description:
> Enables kInfobarUIRebootOnlyiOS13 by default
> 
> This is now needed in order to enable this locally and not via a finch
> config which might not land before the re-sping gets to users.
> 
> Bug: 1071853
> Change-Id: I71b42ca95e54197ddf76b4301616be36c37ad1ca
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157505
> Commit-Queue: Sergio Collazos <sczs@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#760756}

TBR=eugenebut@chromium.org,sczs@chromium.org

Change-Id: I534ea0a7d177a3a5452d91ea4bf945375cd2f606
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1071853, 1073091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159469Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760984}

Bug: b:153361703
Change-Id: I68934bd618382637a41dc3780009e5784269f147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147870Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760983}

The data reported is not useful and there are plans to revamp
this information with something more actionable.

Bug: 1072801
Change-Id: I21bbf56dd8d221fb795824eb432fea7f122059bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157835Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760982}

This patch moves the processing of the keyframes rule into a separate
method as a preliminary step in aligning the keyframe generate process
for CSS animations with the spec
(https://drafts.csswg.org/css-animations-2/#keyframes).  Once this
change is in, further refinement to align the algorithm with the spec
should be easier to follow.


Bug: 1070627
Change-Id: I04c558afa8f3aa9db85c8c473e4fbc5577633da8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154824Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760981}

The UMAs
SameSiteDifferentSchemeResponse
SameSiteDifferentSchemeRequest

and the UKMs
SameSiteDifferentSchemeReqsponse
SameSiteDifferentSchemeRequest

do not capture the complete/correct information relating to cookies
that would be affected by schemeful same-site.

This CL obsoletes and removes the metrics logging code along with the
necessary framework code used to capture the metrics.


Bug: 1066231
Change-Id: Ia4c952626ac8fbdf19e6da348ea9f6ca61ee043e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151481Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760980}

This CL is doing the following:
- Update the BUILD.gn correspondingly with the latest changes
- Adding new patch for using absl optional instead of std
- Update the Support-SHELL-in-chromium patch

Bug: 1072286
Change-Id: Id3c4bc2da5183f92345440eb887f5391f8d7b2e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153443Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Amr Aboelkher <amraboelkher@google.com>
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Cr-Commit-Position: refs/heads/master@{#760979}

Bug: 1073062
Change-Id: I0f1895ebcf4a6169197ee6bb0b8a8fc05e6748eb
Tbr: collinbaker@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158972Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760978}

* Defines a separate visibility for safety check.
* Hides safety check in guest mode.

Bug: 1015841,1073023
Change-Id: I07990d36b90de2a0798499ee1098cb72325287ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159241Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760977}

While migrating ExecutionContext to LocalDOMWindow, several helpers
were introduced on Document (From(), DynamicFrom(),
ToExecutionContext()). This CL removes usage of these types from this
directory.

From() and DynamicFrom() are replaced with the standard
downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced
with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(),
or Document::GetExecutionContext(), whichever is most direct from the
callsite.

Bug: 1029822
Change-Id: I2a7ca6f4df896588a29eacf8beed05f11720145d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108820Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760976}

Bug: 1044417
Change-Id: Iab0333296dfb31dbd4e402f2e06a7ccd5c038ab8
Tbr: apotapchuk@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159310Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760975}

This CL fixes timeout on client-navigate.https.html, and removes unused
code in testharness.js.

This change is a follow-up for:
[1] https://github.com/web-platform-tests/wpt/pull/21162
[2] https://github.com/web-platform-tests/wpt/pull/22086

After the change [1], fetch_tests_from_workers() helper uses
ExtendableMessageEvent.source instead of MessageChannel to communicate
between a window and a service worker. This change works well for most
of cases, but fails some tests.

The fetch_tests_from_workers() helper takes a service worker object to
post a "connect" message to the worker, and then passes the worker
object to RemoteContext in testharness.js. RemoteContext adds an
onmessage event handler on self.navigator.serviceWorker. This works well
as long as the given worker object is associated with `self`. However,
these failing tests pass the worker object associated with the inner
frame to the helper. In this case, the helper uses an inner frame's
service worker object for postMessage(), while the helper waits on the
main frame's navigator.serviceWorker.onmessage. Consequently
event.source is the inner frame, and a reply from the service worker is
dispatched on the inner frame's navigator.serviceWorker.onmessage. This
results in timeout.

To fix this, this CL makes the main frame pass its own service worker
object instead of the inner frame's service worker object. Those
objects should be equal other than associated contexts, and this change
doesn't affect what the tests verify.

Bug: 1057682
Change-Id: I0f30f1fe9c54c3de1006276f3445c5e2b92ea5a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155760Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760974}

The tests have been failing on the 12.4 bots since the recent refactor:
https://chromium-review.googlesource.com/c/chromium/src/+/2147778

isActive was changed to use the presentation state of the
ViewController.
Apparently, this state is not reliable in unit tests on iOS 12. I
switched the tests to use the existing Presentation callbacks instead.

Sample failure:
https://ci.chromium.org/p/chrome/builders/ci/iphone-device/8012

Bug: 1068606
Change-Id: I3e80de5e77d788da56b984b942e554c5022a98e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158975Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760973}

Remove unused local histogram
NQE.CongestionAnalyzer.CountInflightRequestsForPeakQueueingDelay.*
in NQE.

It's also using the local macro incorrectly
causing crashes. Macro histograms are expected to
use static name (and not a runtime generated name).

Change-Id: I196449d759cff2eeb1919f1bfb39af66e7225c1a
TBR: ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159405
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760972}

This reverts commit a4c66592.

Reason for revert: https://crbug.com/1072977

Original change's description:
> [threadpool] Record sequence size to histogram on task push.
> 
> This is recorded to determine how often the size of a sequence grows
> above 10000 tasks, and whether it is reasonable to upload a process
> dump when that happens.
> 
> Bug: 1071862
> Change-Id: Ia0e7ea5a48d5086bfd4c7aa9c121fa3ccb381ad8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154845
> Auto-Submit: François Doray <fdoray@chromium.org>
> Commit-Queue: Brian White <bcwhite@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#760528}

TBR=gab@chromium.org,fdoray@chromium.org,bcwhite@chromium.org

Change-Id: Ida7a3c7124902b3f5027679c87889dea2d1a405b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1071862, 1072977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159312Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760971}

I found the way we were updating surfaces for the additional
slices was bug-prone, so I changed how it works. SurfaceUpdater
was starting to get larger, so I went ahead and moved it to
its own file. SurfaceUpdater improvements:
- Building the slice list is always done in a single function,
which helps ensure we're sending slices consistently.
- SurfaceUpdater manages its own observer list, giving it better
control over sent updates.
- It sends a load-more spinner.

Bug: 1044139
Change-Id: I3ab0c45390c19db7852c0d4750060ab78ce6c880
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150769
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760970}

All //chrome dependencies have been removed from PageInfoController, and
it can now be moved to //components so that WebLayer can build Page Info
UI using it.

Bug: 1052375
Change-Id: Ide78e32c7b83385d5cb30bc667827674e469bf0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153053Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760969}

Corresponding Chrome code was removed in https://crrev.com/i/2854162.
Metrics obsoleted in this CL:
SB2.RemoteCall.LocalBlacklistsAgeInMs
SB2.RemoteCall.LocalBlacklistsLookupResult
SB2.RemoteCall.LocalBlacklistsUpdateSucceeded
SB2.RemoteCall.CanUseLocalBlacklists

Bug: 1037224,1037226
Change-Id: Ib8f40d365f82524f7de0bde4ce161f72f551598d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158052
Auto-Submit: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760968}

Currently, we use TabUiTestHelper#isShowingPopupTabList to verify if
TabGridDialog is showing or hidden. However, even if this call is
good enough to verify that the dialog is completely hidden, passing
this check doesn't ensure that the dialog showing animation has ended.
This is a problem exposed by extra checks introduced in
http://crrev.com/c/2143671. This CL fixes this issue by separating the
logics of checking dialog showing and hiding into two methods with
different criteria.

Bug: 10723760, 1072374
Change-Id: Iabb1e9488a8f94ced36988b90b08ec90df2ba911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158054Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760967}

Bug: 1073052
Change-Id: If3b28d0c2370b8d34aeaa5ff7ad9abb48a231318
Tbr: karandeepb@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159308Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760966}