GitLab

Navigations to about:version should either be blocked by
RenderProcessHostImpl::FilterURL or rewritten to navigations to
chrome://version/ by url_formatter::FixupURL.  This CL tries to help
catch cases that violate this assumption, by adding an early
NOTREACHED and DumpWithoutCrashing calls.

Bug: 1145717
Change-Id: Icbae9530ca851ae55d44947ac2f8efb754beec90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519861
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825012}

Bug: 1146141
Change-Id: I9d3a6dcb37f0435e29ee506bb0c7c2d678435332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522632Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Yulun Wu <yulunwu@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825011}

This CL makes sure PictureInPictureWindowControllerBrowserTest
SurfaceIdChangeDoesNotMoveWindow test is disabled on Linux while we're
investigating the reason why.

Bug: 1146047
Change-Id: I4b0579109f2ebfe71ba786df471b86237d027384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521613Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825010}

https://android.googlesource.com/platform/external/perfetto.git/+log/1e9cf1a8e1bd..31623e15a8a0

2020-11-06 fmayer@google.com Increase maximum frame limit.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ic366e379d1f7990e29f593c745266385b7bb381a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523431Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825009}

This change enables errorprone basic null checking.
The new flag will raise an error when a @Nullable
argument or variable is not checked before being used.

The code updates all sites that declared parameters as
@Nullable without subsequently checking their values to
@NonNull.

The change should help push forward the effort to enable
the NullAway errorprone extension

Bug: 1022427

Change-Id: I6c1e87d87fad98252c3cc3916e3a1034cf4eb8cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521294
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825008}

This converts to using the skia::mojom::Bitmap serialize functions to
turn an SkBitmap into a string and back for putting into a base::Value
and sending over IPC.

TBR=senorblanco

Bug: 1144462
Change-Id: I10f28bff10aed703e59c500e7f4668f557b51785
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521203
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825007}

This CL makes the following changes:
1. Modified layout so that the title/artist text will have more spaces
to the left border when artwork is hidden.
2. Hide artist label and center title label vertically if artist
is empty.
3. Modify artwork image so that it will always appear as a square. (If
the artwork is not a perfect square, we will scale it up/down and clip
the center square of the artwork.)
4. Fix drop down arrow layout bug.

Bug: 1144309
Change-Id: If0c7b0af690483644dede6866f54cde4e3beb2ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522675Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825006}

One of the histograms was expiring soon, and they all had different
expiry dates. Use the same expiry date for all BrowserSwitcher.*
histograms, to reduce maintenance burden.

Bug: 1138384
Change-Id: I8713ce8519e90faf1c690d0c83c7cf67910f87ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514620
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825005}

Without default return value GCC produces a lot of warnings like:
../../base/bind_internal.h:773:1: warning:
control reaches end of non-void function [-Wreturn-type]

Added return false by default to suppress the warnings.

Bug: 819294
Change-Id: I593cd48bf336cb5e7614592a507451a67e0ec1d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520819
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825004}

Bug: 1145861
Change-Id: Ibfde85a2832ee6a5124ea417a54acc94b2ea57b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522880Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Chong Gu <chonggu@google.com>
Cr-Commit-Position: refs/heads/master@{#825003}

This CL removes the FrameData class entirely, favoring small subclasses
AggregateFrameData and FrameTreeData that do the various types of
computations and repeating some of the high-level functionality to call
those subclasses correctly in each class.

It organizes all of the data into a FrameData namespace for easily
containing/referencing it and not having it pollute the namespace and
most/many of the enums are moved out of the classes to sit in that
namespace for general referencing.  It also removes main_frame_data
from the APLMO, in favor of storing the portions of it we wish to
know about in aggregate_frame_data as computational components using
the subclasses.  It also moves the collection of current memory usage
for individual frames to sit under APLMO, much like the resource
tracking information already does, to make memory collection more
generic and so we don't store multiple maps, some of which contain
only one entry.

After this, there are still a few more minor clean-ups that could
potentially be done:
1) Uniformity around naming accessors and updaters, as right now we
use some combination of GetValueType/value_type and UpdateValueType/
set_value_type.  I've done some fixing of this in this CL, but more
could be done.
2) Migration of Heavy Ads logic out of FrameData.  This should really
be performed as part of APLMO, but it sits in FrameData right now.
3) Migration of UKM reporting out of FrameData.  We report all UMA in
APLMO but report UKM as part of FrameData, and they should both be
done at the same level, presumably in APLMO.
4) Remove kAnyVisibility in favor of accessors that just add the two
visibilities together, as this would simplify the logic in many areas
where we loop over two visibilities ("any" and the appropriate one)
setting them both, rather than just setting one.

Bug: 1136068
Change-Id: Id65950726064b5a52ff08db21bf4e988339427a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496201
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825002}

This class is implemented as a KeyedService and provides an interface
that the SecureChannel service can use to make connection requests over
the Nearby Connections library. It will be used by SecureChannel to make
connection requests on behalf of Phone Hub.

Bug: 1106937
Change-Id: Ie624c874ef4eeff65f417b89d6d48a90a63ae1cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496289
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825001}

This code assumed texture unit 0 was active. In fact, sometimes the
current texture unit is different; in this case, the active texture unit
was 2, because Skia set it here:

gpu::gles2::GLES2Implementation::ActiveTexture(unsigned int)
skia_bindings::GLES2ImplementationWithGrContextSupport::ActiveTexture(unsigned int)
GrGLFunction<void (unsigned int)>::GrGLFunction<GrGLFunction<void (unsigned int)> (anonymous namespace)::gles_bind<void, unsigned int>(void (gpu::gles2::GLES2Interface::*)(unsigned int), gpu::gles2::GLES2Interface*, gpu::ContextSupport*)::'lambda'(unsigned int)>(void)::'lambda'(void const*, unsigned int)::__invoke(void const*, unsigned int)
GrGLGpu::setTextureUnit(int)
GrGLGpu::bindTexture(int, GrSamplerState, GrSwizzle const&, GrGLTexture*)
_ZNSt4__Cr10__function16__policy_invokerIFvRK15GrTextureEffectEE11__call_implINS0_20__default_alloc_funcIZN11GrGLProgram12bindTexturesERK20GrPrimitiveProcessorPKPK14GrSurfaceProxyRK10GrPipelineE3$_1S5_EEEEvPKNS0_16__policy_storageES4_
GrFragmentProcessor::visitTextureEffects(std::__Cr::function<void (GrTextureEffect const&)> const&) const
GrFragmentProcessor::visitTextureEffects(std::__Cr::function<void (GrTextureEffect const&)> const&) const
GrFragmentProcessor::visitTextureEffects(std::__Cr::function<void (GrTextureEffect const&)> const&) const
GrPipeline::visitTextureEffects(std::__Cr::function<void (GrTextureEffect const&)> const&) const
GrGLProgram::bindTextures(GrPrimitiveProcessor const&, GrSurfaceProxy const* const*, GrPipeline const&)
GrGLOpsRenderPass::onBindTextures(GrPrimitiveProcessor const&, GrSurfaceProxy const* const*, GrPipeline const&)
GrOpsRenderPass::bindTextures(GrPrimitiveProcessor const&, GrSurfaceProxy const* const*, GrPipeline const&)
(anonymous namespace)::FillRectOp::onExecute(GrOpFlushState*, SkRect const&)
GrOp::execute(GrOpFlushState*, SkRect const&)
GrOpsTask::onExecute(GrOpFlushState*)
GrDrawingManager::executeRenderTasks(int, int, GrOpFlushState*, int*)
GrDrawingManager::flush(GrSurfaceProxy**, int, SkSurface::BackendSurfaceAccess, GrFlushInfo const&, GrBackendSurfaceMutableState const*)
GrDirectContext::flush(GrFlushInfo const&)
media::VideoFrameYUVConverter::ConvertFromVideoFrameYUVSkia(media::VideoFrame const*, viz::RasterContextProvider*, unsigned int, unsigned int)
media::VideoFrameYUVConverter::ConvertFromVideoFrameYUVWithGrContext(media::VideoFrame const*, viz::RasterContextProvider*, gpu::MailboxHolder const&)
media::VideoFrameYUVConverter::ConvertYUVVideoFrame(media::VideoFrame const*, viz::RasterContextProvider*, gpu::MailboxHolder const&)
media::PaintCanvasVideoRenderer::CopyVideoFrameYUVDataToGLTexture(viz::RasterContextProvider*, gpu::gles2::GLES2Interface*, media::VideoFrame const&, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, int, bool, bool)
blink::WebMediaPlayerMS::CopyVideoYUVDataToPlatformTexture(gpu::gles2::GLES2Interface*, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, int, bool, bool, int, blink::WebMediaPlayer::VideoFrameUploadMetadata*)
non-virtual thunk to blink::WebMediaPlayerMS::CopyVideoYUVDataToPlatformTexture(gpu::gles2::GLES2Interface*, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, int, bool, bool, int, blink::WebMediaPlayer::VideoFrameUploadMetadata*)
blink::WebGLRenderingContextBase::TexImageHelperHTMLVideoElement(blink::SecurityOrigin const*, blink::WebGLRenderingContextBase::TexImageFunctionID, unsigned int, int, int, unsigned int, unsigned int, int, int, int, blink::HTMLVideoElement*, blink::IntRect const&, int, int, blink::ExceptionState&)
blink::WebGLRenderingContextBase::texImage2D(blink::ExecutionContext*, unsigned int, int, int, unsigned int, unsigned int, blink::HTMLVideoElement*, blink::ExceptionState&)
blink::WebGL2RenderingContextBase::texImage2D(blink::ExecutionContext*, unsigned int, int, int, unsigned int, unsigned int, blink::HTMLVideoElement*, blink::ExceptionState&)

Bug: 1103385
Change-Id: I3a4bdd41613de448effcaa676870b60d7190cb64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522119
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825000}

This patch migrates SceneOverlay and its dependencies to the new
layouts module. The moved classes include:
 - EventFilter
 - SceneLayer
 - SceneOverlay
 - SceneOverlayLayer
 - VirtualView

Bug: 1070281
Change-Id: I58936d2e50b7e83c38109b9c3cc9c82b5d41a926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518727Reviewed-by: Mei Liang <meiliang@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824999}

Change-Id: If69f63281c1117aacc79cae163bb1ee609b255cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522238Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824998}

This class creates an out-of-band Nearby connection using a pre-sycned
Bluetooth address. It will be used by the SecureChannel service to
implement connections for Phone Hub.

Bug: 1106937
Change-Id: I5dec7c8edc58b1188e423f1368d47727cd48eb1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499361
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824997}

Roll Chrome Win64 PGO profile from chrome-win64-master-1604653017-42c23ccace2f0081edeac3e89e9dffaf10021d96.profdata to chrome-win64-master-1604674173-719d34785101ea4ac0ebaa67a34ad987e0ccbedb.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I97c5b17df9874581e65292b2f53b1ba1448997d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522623Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824996}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5bce781f..8f12ca50

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6cba6f8aeb3ca308d77e753d97897e4cc3709886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523060Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824995}

Roll Chrome Win32 PGO profile from chrome-win32-master-1604642156-7d0afa322bb4bb6abbaa9b475fb0ac5b24eae09a.profdata to chrome-win32-master-1604663931-7a2d7b98907b04e6d9b6de8fee6e41b8e6822477.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I05caaca8deff30105cc95e1c1047468dd869833b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523292Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824994}

This reverts commit 583d40a8.

Reason for revert: Test still flaky

Original change's description:
> Re-enable TwoClientWebAppsBMOSyncTest.DoubleInstallWithUninstall
>
> Let's attempt to re-enable the test.
>
> Bug: 1111533
> Change-Id: If091b686e3ba64395587ec029dbd82df61559466
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498691
> Commit-Queue: Victor Vianna <victorvianna@google.com>
> Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> Auto-Submit: Victor Vianna <victorvianna@google.com>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#820891}

TBR=dmurph@chromium.org,victorvianna@google.com

Bug: 1111533
NoTry: True
Change-Id: I9775dabc0f1f388d711c700ccea81534977c66c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523650
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824993}

This class is responsible for discovering endpoints via the Nearby
Connections library. It uses an out-of-band Bluetooth discovery
mechanism since SecureChannel already has access to a Bluetooth MAC
address for the device we're aiming to connect to.

This CL also adds a nearby_connector.mojom file which contains the
service ID to use for SecureChannel connections over Nearby Connections.
Follow-up CLs will add additional interfaces to this file.

Bug: 1106937
Change-Id: I66b20d960823bf3e8429dbfa863e84b123e29deb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506551
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#824992}

The toolchain we rolled in on Wednesday fixes the underlying bugs.

1. Stop explicitly passing -mcpu=apple-a12. clang now passes this
   implicitly when handing it `-march arm64 -mmacosx-version=min=...`.
   (Note: Xcode clang also uses a `arm64-apple-macos` triple and hence
   apple-a12 with just `-march arm64`. Open-source clang currently
   defaults to `arm64-apple-ios` and hence apple-a7 with `-march arm64`.
   I asked about this at https://reviews.llvm.org/D82699#2379434 ).

2. Re-enable fatal linker warnings in arm64 component builds. The
   symbols that new clang emits no longer trigger ld64 warnings.

No intended behavior change (except fewer build warnings in arm64
component builds).

Bug: 1119249,1107955
Cq-Include-Trybots: luci.chromium.try:mac-arm64-rel
Change-Id: If6a866456461613e46ade36da436991c9d617bc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521213Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824991}

This function invokes the InjectEndpoint() API from the Nearby
Connections library using the Bluetooth medium. It will be used by Phone
Hub to inject a Bluetooth address synced via the DeviceSync v2 protocol.

Bug: 1106937
Change-Id: I6f0cd533d2d0ed87df5d52394a3135b920329de7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494445
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#824990}

Bug: 1135847
Change-Id: I62aa52b043558bea86d8b3e481d34a4190dc96e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521697Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#824989}

Bug: 1146543
Change-Id: Ibdc22d9244779fc2318121ab8910d7984453eb4d
NoTry: True
Tbr: vecore@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523537Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824988}

chrome://settings/cloudPrinters is deprecated as of M88.

In crrev.com/c/2520081 Print Preview's "Manage" button is being
redirected to open the OS printer settings dialog, so keeping the
link to that dialog in browser settings also is no longer necessary.

Bug: 1144931
Change-Id: I7e84c82124077bd2ca71aea4c4293b633a579a86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520331
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824987}

Removes the header status view on top for the onboarding dismiss prompt
per spec.

Screenshot: https://screenshot.googleplex.com/9a6EphBjLrfBRyP

BUG=1106937

Change-Id: Icc66d781f2df91e7fb74cac1cbbd573225def2bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522117Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824986}

Change-Id: I4ce4044cc2b8b6d45d67c549f03ebbd863b17730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523394Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Auto-Submit: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824985}

Otherwise, listener methods can be called on the destroyed new tab page
handler object, which could lead to crashes.

Bug: 1144317
Change-Id: Ibfc50c3e903377494be804dac2b05fdb57e3344d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522129
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824984}

This string is a duplicate of IDS_SIGN_OUT_AND_TURN_OFF_SYNC. This cl
removes it.

Bug: 1120581
Change-Id: If797b2a876d51298e856a7ff0f82b22897150aa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507810Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824983}

Bug: 1144931
Change-Id: Ia5822311a43935e2086613c5b2ff0470d342544e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520081
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824982}

Original Icon
Vector
https://drive.google.com/file/d/1YXJbfbBgAlgiEYjNOZFapVcW3GJVbMzh/view?usp=sharing

In context
https://drive.google.com/file/d/1vlcuejXNc8J3cA3eWuycTL4KpI-QM_KB/view?usp=sharing


Updated icon
Vector
https://drive.google.com/file/d/1lrQBPxEajaW-s8DdGjytduDvFMhrVmsc/view?usp=sharing

In context
https://drive.google.com/file/d/1I_Ot-Y720ARb37-WjAG70LTayxLyYpSV/view?usp=sharing

Bug: 1145643
Change-Id: I07a697a1b7b4f8eec4eba638292501e769637db1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518859
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824981}

Bug: 971272
Change-Id: I9fcde3434c76f8c5529e5be8cca639207cca9eda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519765
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824980}

This patch adds a check for |locally_installed| in the post-finalize
step of the WebAppInstallTask callback chain. Instead of calling
InstallOsHooks, it skips that (as the web app is not locally installed).

This also updates the TestOsIntegrationManager to store a little more
data, and make the TestWebAppProviderCreator take a RepeatingCallback
to support multiple profiles.

TBR: loyso@chromium.org
Bug: 1143023
Change-Id: I18f3864e909980a892f6f669fa4029b098b43d01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505685
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824979}

Bug: 1142082
Change-Id: I87d4970e5e20e3f8950e6e5f25b843e9c8fa096c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511857Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824978}

Bug: 1146526
Change-Id: I336c6989e35b3b25cd9706a843b0d007152d647a
NoTry: True
Tbr: dominickn@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523480
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824977}

Bug: 1007635
Change-Id: I1664b1ae0e67df52b0553a13e310ea5d42c5d1dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520623Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#824976}

|PerfMember::Init| accepts an instance of |base::RepeatingClosure| as
its last parameter. Call sites should use |base::BindRepeating|.

Bug: 1007635
Change-Id: I7be18e3614984c74767950b0239457be87499328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521777Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#824975}

Create a function for simulating changing a select element in tests.

Bug: 1059779
Change-Id: Ia67242113682c12860a2b59bbf370ad0ebbcc21c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522120
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824974}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2cfcb1c1ee9a..876499b090ec

2020-11-06 jacktfranklin@chromium.org Fix triggering search when clearing box with enter key

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I4b344b8ff1ae71a81eaa65bb6fc54e064133a310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523393Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824973}