- 23 Sep, 2019 40 commits
-
-
Andreea Costinas authored
This CL fixes WPAD with DHCP by creating a DHCP PAC file fetcher in //net that delegates fetching the URL to an interface. This interface is set at the service level to an object that does a mojo call to the browser process to retrieve the URL. The browser process then gets the web proxy auto-discovery URL from the NetworkHandler::DefaultNetwork which mirrors the network state of the Shill default network. Bug:991867 Test: manually tested on ChromeOS content_unittests --gtest_filter=ProxyServiceMojoWithDhcpPacFileFetcherMojoTest.ResolveProxySuccess browser_tests -gtest_filter=WPADHttpProxyScriptBrowserTest.Verify Change-Id: Ibf1ec1a6d8e69dcaf4a113b68b17151329d26308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790886Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#698841}
-
danakj authored
The EmulationHandler only enables touch or device emulation on the main frame. Currently the touch handler is explicit about this, which was added a few months after the check for being a local root. That change should obsolete the local root check (main frame is a subset of local root frames), though both remain in the code. Remove the local root comparison. The device emulation path still only checks for local root, but could be changed to main frame also for more clarity. The GetWebContents() method returns null only if the host_ is null, so instead of checking both of these for null, only call GetWebContents() when |host_| is not null, and change methods to check for |host_| in places that they checked for GetWebContents(). The GetRenderWidgetHost() on RenderFrameHostImpl never returns null, as per its comment: // Returns the RenderWidgetHostImpl attached to this frame or the nearest // ancestor frame, which could potentially be the root. For most input // and rendering related purposes, GetView() should be preferred and // RenderWidgetHostViewBase methods used. GetRenderWidgetHost() will not // return a nullptr, whereas GetView() potentially will (for instance, // after a renderer crash). // // This method crashes if this RenderFrameHostImpl does not own a // a RenderWidgetHost and nor does any of its ancestors. That would // typically mean that the frame has been detached from the frame tree. virtual RenderWidgetHostImpl* GetRenderWidgetHost(); R=yangguo@chromium.org Bug: 1006052 Change-Id: Ia43c2fb04de343f7c6e2c7cd1600a9bdc1a14908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815735 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698840}
-
Lowell Manners authored
This prevents tests that expect frames to be evicted from the cache from incorrectly passing (due to timed expiration). Change-Id: I41507b8fa808b1d5019bd1777706919a53c38407 Bug: 987187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813335 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#698839}
-
Olivia Flynn authored
Addresses a bug where CodeMirror's update view process, which deletes non-visible nodes, causes Widget.js to throw many errors and crash the source code frame because Widgets have been inserted into CodeMirror lines, but cannot be removed by regular DOM operations. This occurs when scrolling with an edit breakpoint dialog open. This solution introduces a function to mark a widget as externally managed, which excludes it from its ancestor's __widgetCounter. Before and after gifs: https://imgur.com/a/CIFNO8Y Bug: 984762 Change-Id: Id569d201569461c863e53fe07b22f81683b4862e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705174Reviewed-by:
-
Peter Kasting authored
Bug: 82078 Change-Id: Ib001f3b8064dbcd99a7149623a62397109be9305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818298 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Jason Lin authored
Enums |InstallationState| and |Error| in class |CrostiniInstallerUIDelegate| are moved to file crostini_installer_types.mojom and renamed to `InstallerState` and `InstallerError`. All other changes to .h and .cc files are just simple replacement to migrate to the new types. The purpose of this CL is to allow the js code of the new Crostini WebUI installer to use the same enums. Bug: 929571 Change-Id: I185bb94b79187db98850dba4d23a7ba221e1d1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815797Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#698836}
-
Yao Xiao authored
Use originating_contents when initiator origin is opaque Bug: 1005218 Change-Id: I4ea659b5ea1a233ee122c6fe5d48d00d6bbe9dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814624Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#698835}
-
Tomasz Moniuszko authored
Includes are redundant as safe browsing calls has been removed in https://chromium-review.googlesource.com/1233115 Change-Id: Icb8fd04ddd445f96218d674c7055967a9451e2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796351Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#698834}
-
Alex Danilo authored
Panel items can be created and attached to a a display panel by calling createPanelItem() followed by attachPanelItem() and they can be removed by calling removePanelItem(). Change the API surface for attaching panel items to ignore panel items that have already been removed using removePanelItem(). Bug: 1006124 Tests: Updated browser_tests --gtest_filter="FileManagerJsTest.FilesDisplayPanel" Change-Id: Id7dce8496f4a5cf2090b9071404bd45b5033ae07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819078Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698833}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5b4c0ee19b74..776d81525e7c git log 5b4c0ee19b74..776d81525e7c --date=short --no-merges --format='%ad %ae %s' 2019-09-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3243c3b1..82de2e61 (463 commits) Created with: gclient setdep -r src/third_party/skia@776d81525e7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:None Change-Id: I5f91e282075740a46c8d167a5315c5242036dcfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818293Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698832}
-
Gyuyoung Kim authored
As a step to remove all uses of WebLocalizedString::kFooBar, this CL replaces below ones with matched IDS_FOO. - WebLocalizedString::kFileButtonChooseFileLabel - WebLocalizedString::kFileButtonChooseMultipleFilesLabel This CL keeps ToMessageID() and makes ToMessageID() returns |resource_id| as is if it doesn't match to any of WebLocalizedString::kFoo to replace WebLocalizedString::kFoo gradually. Bug: 995644 Change-Id: Ia56045df0b854f2da4cdfef167644ced277d8ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768500Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#698831}
-
Pavol Marko authored
Now that the underlying flakes in https://crbug.com/1005082 and https://crbug.com/1005723 have been fixed, re-enable the auto enrollment test suite. Bug: 992022 Change-Id: I7e4adb637a7a56d9b161d9d89aa31ffcdceaad23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817597 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#698830}
-
Bao-Duy Tran authored
test data for Chrome OS. These test data are tightly coupled with the actual manifest of the IME extension in use. There are separate and independent manifests defined for Chromium OS and Chrome OS. Chromium OS: https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/input_method/xkb_manifest.json Chrome OS: https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json Current test data are based on the Chromium OS manifest and thus some tests are failing on Chrome OS build in cases where the two manifests differ. We should completely isolate test data for the two OSes and fix them for Chrome OS. Bug: 977170 Change-Id: Ibf47068264e20aa6028b32b60b5d98791c7f49eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808980Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#698829}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/510fd3c3..5f6491d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iea21b33e5723afba9a1d17fb48e5c2b9846f25ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819057Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698828}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I5db070b8ce14beaf140c20b8ca3dc3c99714755f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815989 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#698827}
-
Pavol Marko authored
Now that the underlying flakes in https://crbug.com/1005082 and https://crbug.com/1005723 have been fixed, re-enable the test suite. Bug: 1005697, 1005450, 1005451, 1005452, 1005453, 1005454, 1005455 Change-Id: I12935cd3e80d569168769709b273d748b04b0573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814920 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11e2cbc5cca3..66e6e12e7e7a Created with: gclient setdep -r src-internal@66e6e12e7e7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I97676e08c2a27278a3c90c6478cf298ebd62fd1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819001Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698825}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4854b9f8047e..3c5f91b74871 git log 4854b9f8047e..3c5f91b74871 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e74d6b59..82de2e61 (698711:698813) 2019-09-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5cbf4ebd..e74d6b59 (698593:698711) Created with: gclient setdep -r src/third_party/webrtc@3c5f91b74871 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: Id8a59b70eca32bb37fbcecb8b72666e9bd2475b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819003Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b4d60b5eda31..5b4c0ee19b74 git log b4d60b5eda31..5b4c0ee19b74 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b6fa949c4539..1f89f58faeb8 (5 commits) Created with: gclient setdep -r src/third_party/skia@5b4c0ee19b74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:None Change-Id: I73c6ae54ec1c248059f721f1ccca7febb16732d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819000Reviewed-by:
-
Alan Cutter authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=media%2Fvideo-played-reset.html TBR=steimel@chromium.org Bug: 1006659 Change-Id: I23cba878f2ad2f993f946c6f11d8af49703580e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817869Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#698822}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If8ebf2941057e20541961a6b5099f07c93a484dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818999Reviewed-by:
-
Alan Cutter authored
Mark external/wpt/html/cross-origin-embedder-policy/require-corp.https.html as flaky on debug builds https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fhtml%2Fcross-origin-embedder-policy%2Frequire-corp.https.html TBR=pbos@chromium.org Bug: 626703 Change-Id: I48c678b89e40109b65967691143872e21b86bb7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816062Reviewed-by:
-
Wei Lee authored
This CL supports the data chunk mechanism so that we could record long-length video via camera intents. Bug: 980812, 967611, b/131809655, b/134635999 Test: am start -a android.media.action.VIDEO_CAPTURE Change-Id: Ieb18c614d942fb1f59743a37eb5cfa9cbab40128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722167 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#698819}
-
Darren Shen authored
We'll be doing some work on IMF so let's clean up the code a bit. I ran clang-tidy with: modernize-use-auto,modernize-use-equals-default,modernize-loop-convert, modernize-raw-string-literal,llvm-namespace-comment, modernize-use-emplace,modernize-use-using,modernize-raw-string-literal on //chrome/browser/chromeos/input_method/* //chrome/browser/extensions/api/input_ime/* Bug: 1005619 Change-Id: I1634591833f82e352d268bedb08516d0528b66c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815805 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#698818}
-
Peter Kasting authored
Testing to see if this route avoids breaking the Linux Deterministic bot. TBR=bbudge Bug: 82078 Change-Id: I1512141cc886dafa6683f5ff38c6a50f35be067a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818998Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#698817}
-
Raul Tambre authored
Conversion performed automatically using '2to3 -w -f has_key .'. This is backwards compatible with Python 2. Bug: 941669 Change-Id: I8e681b7ef8cc78b94c14b0c97101a3a0a32459bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816414 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#698816}
-
Alan Cutter authored
fast/canvas/OffscreenCanvas-copyImage.html and virtual/gpu/fast/canvas/OffscreenCanvas-copyImage.html are flaking on all debug bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=OffscreenCanvas-copyImage.html TBR=mstensho@chromium.org Bug: 974652 Change-Id: I841ef1902b831dbb5302efaec60d353ee1b5edb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817868Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4f789591c8f2..11e2cbc5cca3 Created with: gclient setdep -r src-internal@11e2cbc5cca3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ife871c6aece7e9c1565eb658e26eea5913bc9d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818640Reviewed-by:
-
Jinsuk Kim authored
This CL moves bookmark-related API's in Tab class out to chrome/browser/bookmarks (specifically BookmarkBridge) which seems to be a better fit for the task. Also moves the invalid bookmark ID definition to BookmarkId. The new methods find the bookmarkid of the passed Tab by getting the URL and the profile from its WebContents. Thought BookmarkBridge is always up-to-date to use the selected Tab's profile, so the methods could use the bridge's |profile_| but I guess I was wrong - many tests fail at DCHECK https://crrev.com/c/1809289/4/chrome/browser/android/bookmarks/bookmark_bridge.cc#1093 hence switched to static methods. Bug: 925242 Change-Id: Iff38f45159c64b0d0a2cba9d602809ab0e0f7b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809289Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#698813}
-
Glen Robertson authored
Fixes issue where CanBookmarkAppHandleUrl could correctly be false for a PWA but then its launch URL would be checked anyway as if it was a Shortcut App. Bug: 1006054 Change-Id: I5d5e58bd01f214f8cd42641f06afecb7fef2ab69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815803 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Maggie Cai authored
The CL fetches the scope field for PWAs and convert it to App Service intent filter struct. BUG=853604 Change-Id: I44928b2d1ef771f7edc7ce2c1f14188249872693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816489 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
-
Darren Shen authored
Currently, sendKeyEvents needs to send keyData, which has a compulsory requestID field. However, this field is not used by IMF at all. We make two backwards-compatible changes to the public API: 1) Make KeyboardEvent.requestId optional. Then, |sendKeyEvents| can omit the requestId. All existing code will still work as IMF will still populate the requestId field for onKeyEvent. 2) Make onKeyEvent have a third parameter, which is the requestId. This is not strictly necessary, but makes a better API since |requestId| is not part of the KeyboardEvent, but rather the onKeyEvent event. Change-Id: I562ed7ecb27a660c862e12e2032a7066d2b15a39 Bug: 1005996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808666 Commit-Queue: Darren Shen <shend@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#698810}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: Idaa704425ae24b233e09189d4f8bb1a39bb628be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818820Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698809}
-
Jeonghee Ahn authored
broken links. - ... [Running Web Tests Using the Content Shell](web_tests_in_content_shell.md) - ... [docs/web_tests_linux.md](./web_tests_linux.md). Change-Id: I5dd681d21e2f6e340f0907581d67f1fbfcd647fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817863Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#698808}
-
Alan Cutter authored
This reverts commit bf29e54a. Reason for revert: Broke Deterministic Linux (dbg) bot. https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/11261 Output: Unexpected files with diffs: nacl_test_data/extension_vcache_test/glibc/extension_validation_cache_libs/lib64/libppapi_cpp_lib.so nacl_test_data/glibc/pm_exit_status_test_libs/lib64/libppapi_cpp_lib.so nacl_test_data/glibc/simple_libs/lib64/libppapi_cpp_lib.so nacl_test_data/glibc/sysconf_nprocessors_onln_test_libs/lib64/libppapi_cpp_lib.so ppapi_nacl_tests_libs/lib64/glibc_x64/libppapi_cpp_lib.so Bug: 1006638 Original change's description: > Remove using directives ("using namespace x") from ppapi/. > > Bug: 82078 > Change-Id: I5acb5fde43a747f319709222a6cdbb7a414df070 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816293 > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698766} TBR=pkasting@chromium.org,bbudge@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 82078 Change-Id: I6d28134d3fbabac5e243123201af795692b9d8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817865Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts ProxyResolverRequestClient and ProxyResolverFactoryRequestClient from ProxyResolverFactoryMojoTest to new Mojo types. Bug: 955171 Change-Id: If23e54b4c2bdbc0ab43d84de7c5abb4fe268be3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812937 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#698806}
-
Jinsuk Kim authored
This CL replaces NavigationPopup with NavigationSheet for the history popup menu impl triggered by long press on back button. This allows the gesture navigation sheet and navigation popup to have same UI. The only difference between them is that, on long press on back, the sheet fully expands to show all the items. Now NavigationPopup class is used by back/forward button on tablet only. Bug: 999377 Change-Id: Ib68de11f0e5ac5357723ffbd1401c7859393a4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792687 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Trent Apted authored
E.g. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/6932 Test times out. Possibly related to recent change in r696987. TBR=yigu@chromium.org Bug: 1006635 Change-Id: I72f0a17f94932e7d197e4a90f99d81769e6299a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818878Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#698804}
-
Trent Apted authored
This reverts commit a42225db. Reason for revert: Test consistently fails on Linux Chromium OS ASan LSan Tests (1) e.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/35424 errors like [12262:12262:0922/152157.497151:FATAL:compositor_frame_sink_support.cc(336)] Check failed: result == SubmitResult::ACCEPTED (5 vs. 0) Details in BUG=1006633 Original change's description: > Portals: Add chrome/ browser test for activation > > Bug: 927056 > Change-Id: Ief5a22cf86cd6bdeeae4361e616f66487f589c9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809115 > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698129} TBR=avi@chromium.org,adithyas@chromium.org,lfg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 927056 Change-Id: Ib245b7d25b719d791ef6aeefa044200d90a64d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818877Reviewed-by:
-
Trent Apted authored
E.g. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/6929 [1756:1756:0922/124740.991289:ERROR:browser_context.cc(300)] Ignoring request for unknown per-browser-context service:multidevice_setup ../../chrome/browser/chromeos/login/session/chrome_session_manager_browsertest.cc:295: Failure Expected equality of these values: expected_brand Which is: "" google_brand::chromeos::GetBrand() Which is: "TEST" Stack trace: [1756:1756:0922/124741.053454:INFO:rlz_tracker.cc(306)] RLZ is disabled [ FAILED ] GuestSessionRlzTest/GuestSessionRlzTest.DeviceIsLocked/0, where GetParam() = false (664 ms) TBR=rogerta@chromium.org Bug: 997360 Change-Id: I020c643d74107e0ee811f829bfea3a8f75400d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817864Reviewed-by:
-
