GitLab

ScreenRotationTest test cases have been disabled due to flakiness,
but they are resolved by:
* not running on sanitizer builds (crrev.com/r/749747)
* fix of WindowAnimationWaiter (crrev.com/r/750605)

As I tested locally, they pass all of 20 runs on debug build, so
I think this isn't flaky anymore.

Bug: 1017206, 1060667, 1057868
Test: interactive_ui_tests --gtest_repeat=20
Change-Id: Ia8128e04d49833d8d06d7430bd23d78348fc0823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109023Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751504}

Bug: 1056762
Change-Id: I81b58b6408712b8eb0293448a20b1f9f7164a629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095443
Commit-Queue: Sam Bowen <sgbowen@google.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751503}

Note: This CL enables feature BlinkHeapConcurrentMarking to get
the desired behavior. However, we should land enabling
BlinkHeapConcurrentMarking on its own first.

active_markers + GlobalPoolSize() is used to determine
the desired number of workers.

NotifyConcurrencyIncrease() is called periodically from
ConcurrentMarkingStep() if GlobalPoolSize() > 0,
to make sure enough workers are scheduled.

CancelableTaskScheduler is no longer used and deleted in this CL.

Benchmark v8.browsing_desktop on win-10-perf browse:news:cnn:2018:
blink-gc-atomic-pause-mark-transitive-closure: 13% improvement
blink-gc-atomic-pause-sweep-and-compact: 5% improvement
blink-gc-complete-sweep: 34% improvement
blink-gc-total: 2% improvement
https://pinpoint-dot-chromeperf.appspot.com/job/136a60ce620000

Bug: 1046343
Change-Id: Ie2957abf200037ccacc017b1e38dc41f47811ee0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029609
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751502}

Change-Id: Ic9e7222d268da4c7eb1b402f66550f290092371c
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108505
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751501}

Passes |frame| by const reference rather than const pointer, to be
consistent with style.

Bug: 1035855
Change-Id: I783441fcfcbca46147bffc428a838a3920856f0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091650
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Mike Wittman <wittman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751500}

Bug: 1061144
Change-Id: I9f84dd6a381fb32624826f58a24e6aca8a2059a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108089
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751499}

Reader mode should have the (i) icon for security indicator
along with the text "reader mode". When clicked, it should
explain that you are viewing the source of a webpage.

Bug: 840191
Change-Id: I431a50447ea7efc6f854ac944f8db131d8241414
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072471
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751498}

https://webrtc.googlesource.com/src.git/+log/fc29b0ad4658..560e87aa8193

git log fc29b0ad4658..560e87aa8193 --date=short --first-parent --format='%ad %ae %s'
2020-03-18 danilchap@webrtc.org Reenable libaom decoder by default

Created with:
  gclient setdep -r src/third_party/webrtc@560e87aa8193

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I8c419dc82756c5065e0ebe46e540eaab3ff4ce63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108890Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751497}

This reverts commit d1337c0f.

Reason for revert: <INSERT REASONING HERE>

It looks like this CL break build
https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/11952

Original change's description:
> Revert "Propagation of main frame document intersections through page load metrics."
> 
> This reverts commit e5c21760.
> 
> Reason for revert: Crash on Chrome OS with LTO enabled (crbug/1062006).
> 
> Original change's description:
> > Propagation of main frame document intersections through page load metrics.
> > 
> > This CL leverages the existing page load metrics communication to
> > pass main frame document intersections from render frame observers to
> > page load metrics observers. Done via adding frame intersection to the
> > PageLoadMetadata struct (renamed to FrameMetadata) as it stores
> > frame-level intersection information.
> > 
> > There is existing intersection state being passed from RemoteFrameView
> > to LocalFrameView's in the cross process connector but this is only sent
> > for cross process frames. The main frame document intersections here
> > are sent for all frames.
> > 
> > This CL exposes each frame's main frame intersection rect and respective
> > render frame host to a page load metrics observer callback. Future work
> > will leverage this to track the intersections and calculate page ad
> > density in the ads page load metrics observer.
> > 
> > BUG=993453
> > 
> > Change-Id: I5005fcd66c923212b7e73fdc6b46fa484cfb5f13
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982622
> > Commit-Queue: Justin Miron <justinmiron@google.com>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: John Delaney <johnidel@chromium.org>
> > Reviewed-by: Stefan Zager <szager@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#750146}
> 
> TBR=sky@chromium.org,dcheng@chromium.org,szager@chromium.org,bmcquade@chromium.org,johnidel@chromium.org,justinmiron@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 993453
> Change-Id: Id0340c52a4551a4a2a140e1b10e1f635004d5cbd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108622
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: John Delaney <johnidel@chromium.org>
> Commit-Queue: Justin Miron <justinmiron@google.com>
> Cr-Commit-Position: refs/heads/master@{#751494}

TBR=stevenjb@chromium.org,sky@chromium.org,dcheng@chromium.org,szager@chromium.org,bmcquade@chromium.org,johnidel@chromium.org,justinmiron@google.com

Change-Id: I1ce5b10a4c5889eabc9ffdb96a4d55c9e387ab75
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 993453
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108407Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751496}

ChromeDriverTest.testActionsMultiTouchPoint fails on Pixel 3 because
there is a rounding error,

ChromeDriver log file shows that the touch action was dispatched to
coordinate (60,60):
[03-16-2020 15:03:49.094928][DEBUG]: DevTools WebSocket Command:
Input.dispatchTouchEvent (id=29) 0 {
   "timestamp": -446703130,
   "touchPoints": [ {
      "force": 1.0,
      "id": 1,
      "radiusX": 1.0,
      "radiusY": 1.0,
      "rotationAngle": 0.0,
      "x": 60,
      "y": 60
   } ],
   "type": "touchEnd"
}

But the resulting event had a slightly different coordinate:
[03-16-2020 15:03:50.145445][DEBUG]: DevTools WebSocket Response:
 Runtime.evaluate (id=32) 0 {
   "result": {
      "type": "object",
      "value": {
         "status": 0,
         "value": [ {
            "type": "touchstart",
            "x": 50,
            "y": 50
         }, {
            "type": "touchstart",
            "x": 60.00000762939453,
            "y": 60.00000762939453
         }, {
            "type": "touchend"
         }, {
            "type": "touchend"
         } ]
      }
   }
}
We should use assertAlmostEqual instead of assertEqual to just compare
the integer part. The decimal part is because the coordinates
transformation and conversion through the code pipeline.


Bug chromedriver:3397

Change-Id: I3820338e94a9bcff6b5f4d4d180af01569915bfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108903Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751495}

This reverts commit e5c21760.

Reason for revert: Crash on Chrome OS with LTO enabled (crbug/1062006).

Original change's description:
> Propagation of main frame document intersections through page load metrics.
> 
> This CL leverages the existing page load metrics communication to
> pass main frame document intersections from render frame observers to
> page load metrics observers. Done via adding frame intersection to the
> PageLoadMetadata struct (renamed to FrameMetadata) as it stores
> frame-level intersection information.
> 
> There is existing intersection state being passed from RemoteFrameView
> to LocalFrameView's in the cross process connector but this is only sent
> for cross process frames. The main frame document intersections here
> are sent for all frames.
> 
> This CL exposes each frame's main frame intersection rect and respective
> render frame host to a page load metrics observer callback. Future work
> will leverage this to track the intersections and calculate page ad
> density in the ads page load metrics observer.
> 
> BUG=993453
> 
> Change-Id: I5005fcd66c923212b7e73fdc6b46fa484cfb5f13
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982622
> Commit-Queue: Justin Miron <justinmiron@google.com>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: John Delaney <johnidel@chromium.org>
> Reviewed-by: Stefan Zager <szager@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#750146}

TBR=sky@chromium.org,dcheng@chromium.org,szager@chromium.org,bmcquade@chromium.org,johnidel@chromium.org,justinmiron@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 993453
Change-Id: Id0340c52a4551a4a2a140e1b10e1f635004d5cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108622Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Commit-Queue: Justin Miron <justinmiron@google.com>
Cr-Commit-Position: refs/heads/master@{#751494}

https://skia.googlesource.com/skia.git/+log/d7e0131c7edc..d3b92b910ce0

git log d7e0131c7edc..d3b92b910ce0 --date=short --first-parent --format='%ad %ae %s'
2020-03-18 kjlubick@google.com [canvaskit] Add tests for gradients
2020-03-18 reed@google.com hide bitmap virtuals
2020-03-18 kjlubick@google.com [canvaskit] Update to 0.14.0
2020-03-18 kjlubick@google.com [canvaskit] Add tests for patheffects
2020-03-18 kjlubick@google.com [canvaskit] Make codec inclusion configurable
2020-03-18 jvanverth@google.com Reland "Set up eGPU/discrete support for MacOS."
2020-03-18 brianosman@google.com Add a custom GP for GrDrawVerticesOp
2020-03-18 bsalomon@google.com Revert "Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots""
2020-03-18 reed@google.com Revert "remove uncalled virtuals"
2020-03-18 robertphillips@google.com Make GrOp::onPrePrepare be pure virtual
2020-03-18 fmalita@chromium.org [skottie] VectorValue specialization
2020-03-18 kjlubick@google.com Add fiddle example for MakeLinear
2020-03-18 bsalomon@google.com Add SkBudgeted parameter to SkImage::makeTextureImage().
2020-03-18 brianosman@google.com Remove GrGLSLUtil
2020-03-18 jvanverth@google.com Revert "Reland "Clear out atlases if they haven't been used in a while.""
2020-03-18 reed@google.com remove uncalled virtuals
2020-03-18 borenet@google.com [infra] Run recipe and python unittests unbuffered
2020-03-18 bsalomon@google.com Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots"
2020-03-18 robertphillips@google.com Update AAHairlineOp to surface its programInfos at record time
2020-03-18 bsalomon@google.com Don't build GL on Metal, Vulkan, Dawn, Direct3D bots
2020-03-18 borenet@google.com [infra] gen_task: follow-ups from http://review.skia.org/275076

Created with:
  gclient setdep -r src/third_party/skia@d3b92b910ce0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC egdaniel@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1058905
Tbr: egdaniel@google.com
Change-Id: Ie039b2a3a091483b11a1e45c00b727daf7b995ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108886Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751493}

- introduce DeviceEmulator, make it navigation-associated
- move WebDeviceEmulationParams to blink/public/common/devtools
- use base::Optional<WebDeviceEmulationParams> to represent emulation
    enabled/disabled state through most interfaces.

Change-Id: Ic743a1af02019610149e1c4a765696c9d8711e5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092938
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751492}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/1ccecb74b36f..362becca1ff2

git log 1ccecb74b36f..362becca1ff2 --date=short --first-parent --format='%ad %ae %s'
2020-03-18 rharrison@google.com Add support for storage texture format reflection (#1005)

Created with:
  gclient setdep -r src/third_party/shaderc/src@362becca1ff2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: I1132f6c81433abc3e83668b76df66130f023ca90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108887Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751491}

Bug: 1062667
Change-Id: I739add59d11c3017390700069c8a586605f29178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108913
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Auto-Submit: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751490}

Bug: 973674
Change-Id: I9827d8849edf8b6ae8ac42ed6547e81af9f5b17f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107793Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751489}

For all callers of FontBuilder::CreateFont() and CreateFontForDocument()
the value of |font_selector| is always equal to the FontSelector of the
current document.

Hence, this patch removes it. It also eases the elimination of the
deprecated function Font::Update().

Bug: 1049295
Change-Id: I1e5521c00191a9af0f670cc985c1de198734bece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107696Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751488}

Remove creation of new ChromeDriver when testing Cookie retrieval for
frames to enable test to run on Android.

Bug: chromedriver:3396
Change-Id: If611001e2e72af95d96529872962703157563d7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108904Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751487}

Defining focus: the parent view's active descendant

Problem: An active virtual view reports itself as having keyboard focus even if keyboard focus is somewhere else. This leads to more than 1 virtual view reporting that they have keyboard focus when only 1 virtual view should be.

Bug: 811277
Change-Id: I8985129ad4eafffa658159b1b73993cff2f01b96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095466
Commit-Queue: John Pham <johnp@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751486}

Partial revert of crrev.com/c/2097516, which accidentally dropped
'is_chrome_branded' from the bots. Will reland once crrev.com/c/2107709
lands.

Bug: 937821
Change-Id: Ia7d84b99aac9b04deb2861f06a34643eba8cc05d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108826Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751485}

https://webrtc.googlesource.com/src.git/+log/ebf739be7bab..fc29b0ad4658

git log ebf739be7bab..fc29b0ad4658 --date=short --first-parent --format='%ad %ae %s'
2020-03-18 hbos@webrtc.org [Stats] Include RTX retransmissions in the VideoSenderInfo.

Created with:
  gclient setdep -r src/third_party/webrtc@fc29b0ad4658

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I4aa3144226c2fcbf42820c7fa4782d77a7aed825
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108884Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751484}

Bug: 1062659
Change-Id: Ief6a51aa7a38132d442a794652f83b11467d068c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108528Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751483}

https://quiche.googlesource.com/quiche.git/+log/5efb965c1b4d..c400416ee6a2

$ git log 5efb965c1..c400416ee --date=short --no-merges --format='%ad %ae %s'
2020-03-17 renjietang Removed QuicStreamIdManager::set_largest_peer_created_stream_id().
2020-03-17 bnc Inline QuicSpdySession::supports_push_promise().
2020-03-17 nharper Populate sni and uaid in GfeTlsServerStream

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

R=zhongyi@chromium.org

Change-Id: If42215369f2ca64fc04d1b5d7b87cf3408e389ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108625
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751482}

This change makes the HID, serial, and usb device chooser APIs no
longer depend on ChooserBubbleDelegate; instead they use the new
chrome::ShowDeviceChooserDialog to display their dialogs. This leaves
ChooserBubbleDelegate, ChromeBubbleManager, and ultimately all of the
BubbleUi/BubbleDelegate framework as dead code; removal of that code
will come in a followup CL.

Bug: 496955
Change-Id: I1f1d6318967a79c8c84e4c7d4168b926e2b00b31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106481
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751481}

Safety check: fixed browser crash due to a WebUI update check callback after OnJavascriptDisallowed()

Bug: 1062566, 1015841
Change-Id: I8990125168e05ec9a04ee8b282a46214c48f7de8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107548Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Andrey Zaytsev <andzaytsev@google.com>
Auto-Submit: Andrey Zaytsev <andzaytsev@google.com>
Cr-Commit-Position: refs/heads/master@{#751480}

The MAYBE_EME macro was previously added when we added MojoRenderer
version of PipelineIntegrationTest which doesn't support encrypted
media.

Since we use AesDecryptor in the tests, which can work with
DecryptingRenderer to wrap any Renderer, we should always be able to use
this path to enable EME tests for any Renderer. Thus, we don't really
need the MAYBE_EME macro anymore.

Note that RendererImpl natively supports using DecryptingDemuxerStream
to support decrypt-only and thus doesn't need to use DecryptingRenderer.

Bug: 1062130
Change-Id: I76dafa23bd7c5199402a3ce3e6c106bf0a882750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108614Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751479}

This CL makes sure that reports of bad mojo messages are preserving the
callstack and the crash keys.  This is done by making sure that
DumpWithoutCrashing is called synchronously from
BrowserChildProcessHostImpl::OnMojoError.

The CL also opportunitically reduces code duplication related to
actually terminating a child process.  The duplicated code is extracted
into a new TerminateProcessForBadMessage private method and reused both
from OnMojoError and from TerminateOnBadMessageReceived.

Bug: 1062418
Change-Id: I8f5bf802e9aabec4d92ee9fd37c1c55012f1250f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106806Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751478}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38a7906eeb00..855b1a3f2a02


Created with:
  gclient setdep -r src-internal@855b1a3f2a02

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1062609
Tbr: jbudorick@google.com
Change-Id: If0e8c741c8cb11d78a9a184765d8ab1d70e76b86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108676Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751477}

Issue:
The base::SplitStringUsingSubstr does not handle the case when the
delimiter is empty. The code goes into an infinite loop in that case
as begin_index and end_index always stay 0 and we keep on adding empty
string pieces to the result. This causes a memory overflow.

Fix:
This change adds a check for the delimiter size and returns the
original input string if the size is 0.

Bug: 1062612
Change-Id: I29c184bf18df1bcc50fdb6205a7ff5fa6920148b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108213
Commit-Queue: Siddharth Sharma <siddhash@microsoft.com>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751476}

This Cl corrects an issue where WebTimeLimitEnforcer
is not notified when time limit is reached. This happens
at the beginning of the session.

Bug: 1062012
Change-Id: I7a14e618dbd5b74b5adcaa1c588d64aea088533c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105619
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751475}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0609f5a4e533..3b0c540211ca

git log 0609f5a4e533..3b0c540211ca --date=short --first-parent --format='%ad %ae %s'
2020-03-18 szuend@chromium.org Rename front_end/protocol to front_end/protocol_client
2020-03-18 tvanderlippe@chromium.org Add filesystem TypeScript types
2020-03-18 kahinds@microsoft.com High contrast support for Animation Panel
2020-03-18 szuend@chromium.org Enable asynchronous rawLocationToUILocation mapping

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@3b0c540211ca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1011811,chromium:1032016,chromium:1048378
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I6469f3339aee3b5f6d069c0f01e351126a53a941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108882Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751474}

This change fixes all of the wake lock tests in WPT by making two major
changes.

1) Grant wake lock permission at the beginning of the test using the new
   set_permission method on test_runner.
2) Hook up the Mojo interface binder for the wake lock service in
   dedicated worker contexts.

Bug: 257511
Change-Id: I136a2f90bc0c595a35ba707b5ab5200b4c42281a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089966
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751473}

TBR=benmason@chromium.org

Change-Id: I1deeceaaeb1013d42504fe7054143ff044fce4ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108618
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751472}

This CL introduces new metrics about profile representation state that
get recorded on session start:
 - Profile.State.Avatar
 - Profile.State.LastUsed
 - Profile.State.Name
 - Profile.State.UnconsentedPrimaryAccountType
all with 6 suffixes that zoom into particular subpopulations of users.

TBR=alexilin

Bug: 1060113
Change-Id: Id428015fbed9cb473822a4b19fbd7710bd5707ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102656Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751471}

This reverts commit 0724e945.

Reason for revert: https://crbug.com/1056949 (RBS) and https://crbug.com/1059218

Original change's description:
> |request_initiator_site_lock| enforcement - attempt #2.
> 
> This CL starts treating |request_initiator| that doesn't match
> |request_initiator_site_lock| as a bad IPC message and ignoring such
> malformed resource requests.
> 
> NetworkService.URLLoader.RequestInitiatorOriginLockCompatibility UMA is
> non-zero in recent Canary releases.  Therefore it is possible
> that this CL will get reverted after gathering sufficient number of
> DumpWithoutCrashing reports to understand why the lock doesn't match the
> initiator in some real world scenarios.
> 
> Bug: 920634
> Change-Id: If4fbdb6336703f53784c036ca5d9e408ff223d78
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006113
> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739359}

TBR=yhirano@chromium.org,lukasza@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 920634
Change-Id: Ief1019a74abf8e70364ad2f6aadc2d2216488910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108783Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751470}

Build.gn file was locally modified. This restores
 cursoradapter, customview, coordinatorlayout,
swiperefreshlayout, viewpager, gridlayout, transition,
leanback, and preference_leanback

Bug: 1052460
Change-Id: Ibe8b1612b1d1b3af83784ff49cbacbbccc811e5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108900
Commit-Queue: benjamin joyce <bjoyce@google.com>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: benjamin joyce <bjoyce@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751469}

This is a reland of 57098dce

Original change was crashing asan tests because drag handle was trying
to remove itself from overview controller observers in it's destructor
during shell shutdown, and it was getting destructed after the overview
controller.
This adds a shell observer, and resets the overview observer sooner,
when the shell destruction begins.

Original change's description:
> Better coordinate swipe to home gesture and drag handle nudge
>
> Manages the drag handle nudge during window drag from shelf to home or
> overview (which may end up in a gesture the nudge is describing).
>
> If the contextual nudge is shown when the window drag starts, the nudge
> will not be hidden until the gesture completes (end it will get hidden
> when the gesture completes, even if the user does not end up going
> home).
>
> If the contextual nudge is scheduled to be shown when the gesture
> starts, the show request will be canceled.
>
> Adds logic that prevents drag handle nudge from showing up, unless it's
> a result of an explicit user action - tapping the drag handle.
>
> BUG=1058617
>
> Change-Id: I96fa2748308143ec42295dbfb472dc564da5bd03
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107135
> Commit-Queue: Toni Baržić <tbarzic@chromium.org>
> Reviewed-by: Manu Cornet <manucornet@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751200}

Bug: 1058617
Change-Id: I80222105bda946113248f17a93758cec20387ef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108629
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751468}

This reverts commit 55ab173a.

Reason for revert: Suspect breaking coverage bots:
https://bugs.chromium.org/p/chromium/issues/detail?id=1062704

Original change's description:
> Android: Use turbine to generate java headers
>
> See go/faster-javac for a detailed analysis of why turbine was chosen to
> speed up our java builds. The current implementation is an initial
> implementation that can be further optimized. It already gives savings
> of 10-30% of our java incremental builds depending on the target in
> question (see go/project-turbo for timing details).
>
> This implementation does remove some of the benefits of the previous way
> that java_library_impl was implemented, namely when a target's
> .interface.jar file changes, it no longer short-circuits dependent
> targets from being built since we now use group(target_name). This is
> arguably more correct as prebuilts depend on javac jars directly. In the
> future (after the androidx migration and other build improvements) this
> can be improved by having prebuilts depend on the interface jars
> instead.
>
> Bug: 1056299
> Change-Id: I49d18604203749cf447ce77c54a8f8469c83eae1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105415
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Auto-Submit: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#750651}

TBR=wnwen@chromium.org,agrieve@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1056299, 1062704
Change-Id: Ib3ad0b0a40a25c949775fdef786ad6d776c2c684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108791Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751467}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6325afac..e14702b1

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iad718f62c6a0416131aa8eaafb497f05e7e6b5b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108840Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751466}

This fixs a number of cases and enables strict mode in tests. Hopefully
that helps prevent any other access from being added.

The trickier cases are jacoco injects code that accesses the disk, and
LayoutInflater may trigger loading classes, which triggers disk
access.

The addition since first patch is SelectFileDialog may trigger reading
from disk. That file has been updated.

BUG=1059770,1062561
TEST=covered by tests now

Change-Id: Ie8262ae4e018055049115fcefc6a29bf97acbe9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108603Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751465}