- 10 Jun, 2020 40 commits
-
-
Dominic Farolino authored
It is no longer needed. This reverts the mojo traits changes from https://crrev.com/c/2229205. TBR=kinuko@chromium.org Bug: 1090391,1091711 Change-Id: I93a38bc2351bbc1e5dffda040c7944271e01cde3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238901Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#776840}
-
Kunihiko Sakamoto authored
This reverts commit b47e683b. Reason for revert: The revert didn't fix the issue. Relanding. Original change's description: > Revert "Ignore CanvasResourceProvider::Clear in OOPR Mode" > > This reverts commit 84c360e5. > > Reason for revert: Suspect this CL causes OOPBrowserTest.Basic failure on linux-trusty-rel > > https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/12426 > > Original change's description: > > Ignore CanvasResourceProvider::Clear in OOPR Mode > > > > In OOPR Canvas2D we no longer have access to Skia in the client process. > > We need to update CanvasResourceProvider::Clear to not access SkCanvas > > in the case of OOPR. A more ideal fix is tracked in > > https://crbug.com/1090081 but simply ignoring it is fine for now as > > OOPR automatically handles clearing the canvas during initialization. > > > > Bug: 1090083 > > Change-Id: I5fb75e4fac312ec00b8e5215d3756219672461ee > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236193 > > Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> > > Reviewed-by: Khushal <khushalsagar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#776618} > > TBR=khushalsagar@chromium.org,nazabris@microsoft.com > > Change-Id: Ib906f07089a6b48eaf3e4b1f13fcfeae9d9b0896 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1090083 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237572 > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776782} TBR=ksakamoto@chromium.org,khushalsagar@chromium.org,nazabris@microsoft.com # Not skipping CQ checks because this is a reland. Bug: 1090083 Change-Id: Ie523abd0820a9a7d02c47bda13d778e5c6f177df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237502Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#776839}
-
Jinsuk Kim authored
The CL was reverted due to a bug when used in Tablet which was fixed by https://crrev.com/c/2237012. Now can be landed again as is. This reverts commit c90c90f1. TBR=twellington@chromium.org Bug: 966272, 1092390 Change-Id: I4a6c671afa6544ccc2846214e1e841200e0083c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237536Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#776838}
-
Naoki Fukino authored
I'd like to move LocationLine.PathComponent class and LocationLine.getComponents_() method out of LocationLine to share the logic in LocationLine and QuickView. Bug: 1092950 Test: Existing test passes / closure compiles Change-Id: I394a4a99815f9d6d8f60aefb7fd76cf0d8e423d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237570 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#776837}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/750036ef9035..2234a98502c3 2020-06-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I15dd2aa64c1534b07085accb7951cef3dcd34f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239346Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776836}
-
Nektarios Paisios authored
On Windows, moving forward by one word should move to the start of the next word, punctuation or line break. On other platforms, it should first try to move to the end of the current word. This patch clarifies the attached accessibility event intents to specify whether we are moving to the end of the current word or to the start of the next one when selecting forward. Also, this patch fixes the "sentence/line/paragraphboundary" granularities to expose more information on the boundary they move to, depending on the selection direction. It fixes the "sentence/line/paragraph" granularities to always indicate that they move to the start of the next / previous boundary. AX-Relnotes: n/a. R=dmazzoni@chromium.org Change-Id: I3298f0d73b6bb5d123a15be34fc8c6c587d9594c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238186Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#776835}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/14f20b0ab38d..527080ff03ce 2020-06-10 xinghua.cao@intel.com Check FP16 support on Metal backend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I9986ebcffab0690aff3824e8b2eaeaa27e8064ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239347Reviewed-by:
-
Guido Urdaneta authored
*Mark Media.Audio.Capture.StreamBrokerDisconnectReason as obsolete. Fixed: 881833 Change-Id: Id7737541212853b73a4090250adbf77026131eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237967Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#776833}
-
Kunihiko Sakamoto authored
Bug: 1093166 Change-Id: I28af0f945dca0b357e837587948429abff6728da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239426Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#776832}
-
Nigel Tao authored
Together with similar programs in other repositories, this helps find disagreements between Chromium's, Skia's and Wuffs' image decoders. Change-Id: I80c1386f23273263222474dfa39a5e329e6ebb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210331Reviewed-by:
Leon Scroggins <scroggo@google.com> Reviewed-by:
-
Mario Bianucci authored
Continuing to propagate the required metadata for a delegated ink trail further down the pipeline into viz via the compositor frame metadata and storing it on the display, for now. This CL also transforms the metadata (specifically, the point and presentation area) into the root target space. This is done so that they are in the correct coordinate space for when they are eventually drawn onto the buffer prior to being swapped onto the screen. Bug: 1052145 Change-Id: I18544ee0f8b1d808669ab7ea5aa4e97792e43e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183328 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#776830}
-
Regan Hsu authored
Previously, if a query word is slightly misspelled, the result word that most closely matches the query word won't have any bolding. This CL causes the longest common substring between the query word and the result text word to be bolded. Bug: 1091063 Change-Id: I09441cc78e2cb2d55e81f526ea7baec2b5458d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236898 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#776829}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I660151081b42ffa9c1535c7a14baf6a4967344c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238784Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f43da14878ea..1c3a77ed8e33 2020-06-10 csmartdalton@google.com Re-enable GrCaps::fSampleLocationsSupport in Vulkan 2020-06-10 michaelludwig@google.com Remove unnecessary GrFixedClip includes/declarations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I45844eb71a34bd5de68038b3894dfc5ab7c58dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239101Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie8ad59ea2c8846d27e3dfa6b41477c74583c879a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238783Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f9b11251a19b..586eee4d1066 2020-06-10 jophba@chromium.org Remove IPAddress, IPEndpoint static initializers 2020-06-09 jophba@chromium.org Omit empty "optional" arrays in ANSWER 2020-06-09 jophba@chromium.org Add ability to set kAnyV6 on Cast Environment 2020-06-09 jophba@chromium.org Update SimpleFraction to use abseil, improve tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I2147f531a1aa5a9e9dfa0946a43fa89866fe9005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239098Reviewed-by:
-
Jimmy Xu authored
Virtual devices will have meaningful sys info. Bug: b/157480110 Change-Id: I440922cb551b8b4342e1781d43fe18bfef5392a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231904Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Jimmy Xu <jimmyxu@google.com> Cr-Commit-Position: refs/heads/master@{#776824}
-
Joel Hockey authored
I noticed these when I was having some failures in FileManagerPathUtilTest. These were not actually causing any issues, but it is still better to revoke any registered system mount points at the end of tests. Change-Id: Ic58ff6c560de35a4839d58483d5f1d0dde13152d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237434 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#776823}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ia5b40a2ffa60dcbd9c3ef64dc9690d4a9c51b264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237754Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776822}
-
alanlxl authored
Adding config before experiment/rollout to Beta in M84. Bug: 1067048 Change-Id: I4544f4d65b413926b039b8896ac100711c53614e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235579Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#776821}
-
David Bertoni authored
DeclarativeContentApiTest.Overview was flaky because it did not properly wait for page action icon visibility changes before checking the visibility state. Bug: 606574 Change-Id: Iaffc72868df454ceabb3c5d6447c9aa37820a5b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229581Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776820}
-
Fergal Daly authored
SVGs don't render in gerrit or on git links, so switch the PNG for a better user experience. Update reference in code and delete second redundant reference. Change-Id: I595cc5a5403d7b6741e22bcdb47447f3aad27bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237533Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#776819}
-
Dominic Farolino authored
We're seeing a spike of DumpWithoutCrashes() from NetworkServiceNetworkDelegate in crbug.com/1090391. This indicates a request's referrer violates its policy. From debugging Windows minidups, I found that all or most of the DWCs are coming from the following scenario: - A site is loaded over HTTP and is not upgraded - It is sent with the following Response Headers: - Content-Security-Policy: `upgrade-insecure-requests` - Referrer-Policy: `origin-when-cross-origin` - All subresource requests on the page are requested as relative URLs, which are necessarily upgraded to HTTPs - These upgraded URLs are of course cross-origin with the HTTP main resource, so their referrer is restricted to the origin. - However, for iframe navigations, the browser process upgrades the request to HTTPs, but does not re-compute the referrer. This CL fixes that, and adds two tests: - HTTP page with origin-when-cross-origin policy requesting an upgraded iframe - Assert that the `Referer` is correctly redacted - HTTPs page requests an HTTP iframe that gets upgraded to HTTPs to be same-origin - Assert that the `Referer` is not redacted R=jochen@chromium.org,kinuko@chromium.org Bug: 1090391, 1093160 Change-Id: Ib4e0da6e68850ae478020643d4c0fabca4e87e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236900 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: -
Kunihiko Sakamoto authored
This reverts commit 743cd579. Reason for revert: LocationIconViewTest.ActivateFirstInactiveBubbleForAccessibility on Win7 Tests (dbg)(1) hits LOG(DFATAL) at ax_platform_node_win.cc:650 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/82839 Original change's description: > Add some debugging code to understand strange Views focus bugs > > R=dmazzoni > > Bug: 1039422 > Change-Id: I443859ce61d6ab73967b226b85a90b14f07e2a1a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236457 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776753} TBR=dmazzoni@chromium.org,aleventhal@chromium.org Change-Id: I805e68c105605bd502669c6fa59a3a1c2aac0e32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1039422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237499Reviewed-by:
-
Luciano Pacheco authored
Change SMB add share dialog to comply with the new styles for Files app. Remove close button/icon from the dialog. Adjust the padding and spacing in the dialog, which changed the total height for the dialog from 564px to 515px. See crbug.com/992827#c38 for screenshots of before and after. Bug: 992827 Change-Id: Ia19c97c784b67bcca68ae2e042f02cdd689c1525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235146 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Xing Liu authored
DownloadDialogBridge currently holds the location dialog UI logic. This CL moves the location dialog UI logic to its own class. DownloadDialogBridge will be the place to glue the download later dialog and location dialog. Bug: 1078454 Change-Id: Ieafda28ec6feb2a4f7afcaf098ea34b789d33abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236135 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776815}
-
Alexander Dunaev authored
This CL follows up CLs [1] and [2] and makes the drag and drop client updating the mouse pointer shape according to the operation that is currently negotiated. [1] https://crrev.com/c/2195245 [2] https://crrev.com/c/2209132 Bug: 1014860 Change-Id: I0dba191442bf63c3508cf565bb77cbd107515109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216071Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#776814}
-
Thanh Nguyen authored
Previously FuzzyTokenizedStringMatch uses its own way to calculate prefix match score. This CL uses PrefixMatcher class to calculate prefix match score to be consistent with TokenizedStringMatch. Bug: 1086841 Change-Id: I8fcf37b27e2345dca03498788303ac2287324997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237492 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#776813}
-
Lukasz Anforowicz authored
The same header file may be included in multiple compilation units. When the rewriter emits replacement/edit directives for such header file, then the replacements may be emitted multiple times - once for each compilation unit that includes the header. There is a risk that the replacements will refer to the file using different paths. If apply_edits.py doesn't consistently normalize file paths, then it won't deduplicate replacement/edit directives applying to a given file. This will mean that edits using the first filename will shift offsets within the file and cause edits using the second filename to be applied to random chunks of the file. It is not well understood what may lead the rewriter to use different paths when emitting replacements for the same file (from different compilation units). One hypothesis is that include paths passed to the compiler may differ (e.g. use absolute VS relative paths). Whatever the root cause, varying file paths do happen in the wild - for example: $ grep gl_bindings.h rewriter.out | \ sed -e 's/[^:]*::://' | sed -e 's/:::.*//' | sort | uniq ../../ui/gl/gl_bindings.h /usr/local/google/home/bartekn/chromium3/src/out/rewrite/../../ui/gl/gl_bindings.h Bug: 1069567 Change-Id: Ie67cfaaeaa5c958875733634826c9bb46782c73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222542 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: -
Koji Ishii authored
This patch has no behavior changes. Bug: 982194 Change-Id: Id4318d42c90bc4aee277c8ca167067664cabe6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154629 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Koji Ishii authored
It turned out that |{Logical,Physical}Rect| versions of |ConvertTo{Logical,Physical}| are not working properly, and lacks tests. This patch moves tests for |{Logical,Physical}Offset| to prepare adding those tests. Bug: 1091797 Change-Id: I1d98adaf11ac2742a619904332231c619c97f6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237569Reviewed-by: -
Koji Ishii authored
This patch ensures that |CalculateSizeBasedLayoutCacheStatus| can downgrade |kHit| to |kNeedsSimplifiedLayout|, but not to upgrade |kCanReuseLines|. Upgrading can run simplified layout even when previously we determined changes in inline content cannot run the simplified layout. This fixes |PrintPreviewPagesSettingsTest.InvalidPageRanges|. Bug: 982194 Change-Id: Ie9fe75a64f7c24cc0bedc8647b38a8c33d8529bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237433Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#776809}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/437c78593cb5..f43da14878ea 2020-06-10 jvanverth@google.com Add D3D descriptor tables and bind to command list. 2020-06-10 reed@google.com Revert "Switch persistent cache to use SkReadBuffer/SkWriteBuffer" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I388fe1c4ec27b29758fa95ee1b7c356ea6c900c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239096Reviewed-by:
-
Prashant Nevase authored
DarkModeImageClassifier class does primary classification based on blink::Image derived classes. For this it calls CheckTypeSpecificConditionsForDarkMode() function on image and every derived class needs to override this method. This requires writing dark mode code in derived classes of blink::Image. This is simplified by creating different element roles for different image types and creating different image classifiers for those. The image classifiers do the initial classification based on image type and further classification is done common for all classifiers. Bug: 1091095 Change-Id: I67137f6a44802c833d380be93bf568943ece493c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172149Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#776807}
-
Arthur Eubanks authored
Change-Id: Id2f645e869506c8a5870131cdb3b9921e37bace2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238889Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#776806}
-
dpapad authored
Instead use the auto-generated bookmarks.js externs file. Bug: 1081815 Change-Id: I626971c485237bd9668665b4774d6adb6a182903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229016Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#776805}
-
Wei Lee authored
This is a reland of c027dce3 Original change's description: > [CCA WebUI] Move CCA and its WebUI to chromeos/components > > In this CL, we move some CCA related components to > //chromeos/components/camera_app_ui > > to make it consistent to Help app and Media app. > > 1. CCA resources > From: //chrome/browser/resources/chromeos/camera/ > To: //chromeos/components/camera_app_ui/resources/ > > 2. CCA WebUI > From: //chrome/browser/ui/webui/chromeos/camera/ > To: //chromeos/components/camera_app_ui/ > > 3. Camera App Helper Implementation > From: //components/chromeos_camera/ > To: //chromeos/components/camera_app_ui/ > > Bug: 980846 > Test: Launch CCA and CCA works normally as a platform app > Test: tast run [DUT] camera.CCAUI* > Change-Id: Ic70bd54b35194e3c3398e9f3de9af200346491d4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131542 > Commit-Queue: Wei Lee <wtlee@chromium.org> > Reviewed-by: Shik Chen <shik@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: calamity <calamity@chromium.org> > Auto-Submit: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775987} Bug: 980846 Change-Id: If8421c04573c567c2f2e7d8842f022609fab2a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235263 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#776804}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8d477f73bf8b..a7858e6eb347 2020-06-10 tsepez@chromium.org Pass v8::Platform across public APIs. 2020-06-09 thestig@chromium.org Make length parameter in FPDFAttachment_SetFile() non-const. 2020-06-09 nigi@chromium.org Add expected results for Skia in 2 embedder tests. 2020-06-09 nigi@chromium.org Consolidate repetitive constants in fpdf_edit_embeddertest.cpp. 2020-06-08 tsepez@chromium.org Pump V8 foreground tasks queued to platform message loop. 2020-06-08 awscreen@chromium.org Roll third_party/zlib/ 21c6af6f1..a68151fd9 (11 commits) 2020-06-08 thestig@chromium.org Simplify more code in CFDE_TextOut. 2020-06-08 awscreen@chromium.org Roll v8/ 6a91312c4..9912e35d5 (629 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I0dbf90a8f944b883564935cb2d962dcb4e878e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239095Reviewed-by:
-
Daniel Rubery authored
This metric is expired and not expected to be useful in the near future. Fixed: 1037229 Change-Id: I2e83b9f4cd8b652c4b9b4c0f8f70e216a3b96bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238965 Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#776802}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2911cba7a7a2..60cf022c0223 2020-06-09 taylori@google.com Merge "perfetto-ui: Roll catapult version" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1a986af5ae60b24cd880d3fc15efe1945e5d1349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238701Reviewed-by:
-
