GitLab

Covers chrome/app* and chrome/browser/* through e.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/819133004

Cr-Commit-Position: refs/heads/master@{#309476}

Covers cloud_print/ and components/.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/818103002

Cr-Commit-Position: refs/heads/master@{#309475}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/792343004

Cr-Commit-Position: refs/heads/master@{#309474}

* Moves various classes upstream.
* Changes ActivityDelegate to use the DocumentUtils to access
  the task's baseIntent instead of calling getTaskInfo() directly.
* Findbugs file changed for fields that are only read downstream.

Submitting with NOTRY as true to get around findbugs submission issues.

BUG=443773
NOTRY=true

Review URL: https://codereview.chromium.org/821063002

Cr-Commit-Position: refs/heads/master@{#309473}

We added a flag in Blink to decide if Ctrl-wheel-scroll should scroll or zoom, and now we use this flag in chromium code.

This patch is part of a series:

patch #1: https://codereview.chromium.org/759073002
patch #2: This CL
patch #3: https://codereview.chromium.org/768443002

BUG=397027, 378755

Review URL: https://codereview.chromium.org/739013008

Cr-Commit-Position: refs/heads/master@{#309472}

Adds cast_media_load_dererrer to prevent unwanted media from being
played in web_contents that are not currently visible.

R=gunsch@chromium.org
BUG=

Review URL: https://codereview.chromium.org/824733002

Cr-Commit-Position: refs/heads/master@{#309471}

BUG=444655
TEST=TrayKeyboardLockTest.HiddenOnCreation, TrayKeyboardLockTest.HidesOnA11yEnabled, TrayKeyboardLockTest.PerformActionOnDefaultView

Review URL: https://codereview.chromium.org/818083002

Cr-Commit-Position: refs/heads/master@{#309470}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0edb76a..6e7a766

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/790243004

Cr-Commit-Position: refs/heads/master@{#309469}

LayerSorterMainTest.LayerSorterRubik, and possibly other cc_perftests are failing in
LayerTreeHostCommon::CalculateDrawProperties, the difference in width and height of
visible_content_rect() and visible_rect_from_property_trees() is 2, and the tolerance
is 1.  CHECK(!failed) is hit.

Until the issue is resolved, set verify_property_trees to false

BUG=444219

Review URL: https://codereview.chromium.org/802343007

Cr-Commit-Position: refs/heads/master@{#309468}

PrintingMessageFilter does not know if ProfileIOData is destroyed. Instead of
ProfileIOData filter can create onw BooleanPrefMember.

BUG=428829

Review URL: https://codereview.chromium.org/816143002

Cr-Commit-Position: refs/heads/master@{#309467}

Pepper drops its global lock and reacquires it during synchronous IPCs, so these can turn into deadlocks.

BUG=418651

Review URL: https://codereview.chromium.org/796543007

Cr-Commit-Position: refs/heads/master@{#309466}

This was recently introduced by https://codereview.chromium.org/465853004/

BUG=444629

Review URL: https://codereview.chromium.org/821743003

Cr-Commit-Position: refs/heads/master@{#309465}

BUG=442514

Review URL: https://codereview.chromium.org/794683005

Cr-Commit-Position: refs/heads/master@{#309464}

BUG=444471

Review URL: https://codereview.chromium.org/812753004

Cr-Commit-Position: refs/heads/master@{#309463}

Make the overflow menu for the extensions toolbar on mac work with drag-and-
drop across multiple menu rows.
Also adjust the visibility criteria for the overflow menu in the wrench menu model.

TBR=sky@chromium.org (small wrench menu model change)

BUG=429810

Review URL: https://codereview.chromium.org/820713008

Cr-Commit-Position: refs/heads/master@{#309462}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dd080bd..0edb76a

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/817363002

Cr-Commit-Position: refs/heads/master@{#309461}

This fixes a few cases in which ChromeVox gets stuck when entering or exiting an iframe:
- during continuous reading, multiple inter frame messages get sent
- on some iframes, even though there's a valid src, ChromeVox isn't injected; this results in the outer ChromeVox continuously messaging into an iframe with out ChromeVox running. This occurs typically with dymaically loaded iframes.

TEST=manual; create a page with an iframe src='http://www.google.com'; previously, ChromeVox gets stuck trying to enter the iframe. Now, it should skip it. On MacRumors.com, attempt to enter one of the iframes containing YouTube content; perform continuous read immediately before the content. Should no longer get stuck.

Review URL: https://codereview.chromium.org/816343004

Cr-Commit-Position: refs/heads/master@{#309460}

Covers android_webview/, ash/, athena/, chromeos/.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/825473002

Cr-Commit-Position: refs/heads/master@{#309459}

This patch does two things:

a) Prevent right-click from unthrottling plugins. Always passes it straight to the plugin, so the plugin-native context menu can show. This is useful for verifying whether or not something on the page is Flash, for instance.

b) Prevents middle-click from unthrottling plugins. Continues to consume middle-clicks while the plugin is throttled.

BUG=443406, 403800

Review URL: https://codereview.chromium.org/802453004

Cr-Commit-Position: refs/heads/master@{#309458}

Prior instrumentations didn't catch the jank, i.e. most jank is inside "440919 <<MessagePumpForUI::ProcessNextWindowsMessage>>", but outside of other instrumentations.
This means that the places I suspected are sources of jank actually aren't.

Widening the search.

BUG=440919

Review URL: https://codereview.chromium.org/816113003

Cr-Commit-Position: refs/heads/master@{#309457}

The ToolbarActionsBar wouldn't resize properly in the case of an incognito
extension being added.

BUG=443564

Review URL: https://codereview.chromium.org/798323005

Cr-Commit-Position: refs/heads/master@{#309456}

BUG=408189

Review URL: https://codereview.chromium.org/814403002

Cr-Commit-Position: refs/heads/master@{#309455}

This swallows all hover events that are unhandled by an infobar before
they reach the ContentView. This prevents a bug in accessibility mode
where if the user clicked on an empty space in the infobar then an
element from the webpage behind the infobar would be selected.

BUG=430701

Review URL: https://codereview.chromium.org/824763002

Cr-Commit-Position: refs/heads/master@{#309454}

With this change, display list 2D canvas will become enabled by
default in Chrome. Content shell with --dump-render-tree will
continue to have display lists disabled by default.
Currently, having display lists enabled in blink means
that display lists will be used whenever 2d canvases would
not be GPU-accelerated.

BUG=386601

Review URL: https://codereview.chromium.org/818443002

Cr-Commit-Position: refs/heads/master@{#309453}

BUG=415526

Review URL: https://codereview.chromium.org/817273003

Cr-Commit-Position: refs/heads/master@{#309452}

The DefaultCdmFactory is the default CdmFactory provided by media/.

BUG=422730,441957

Review URL: https://codereview.chromium.org/814143004

Cr-Commit-Position: refs/heads/master@{#309451}

If SHELL is not set then make will search PATH for sh.exe. If it is found, it
will use that instead of cmd.exe. If the sh.exe exists in a path with a space,
the command will fail to run.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/806283003

Cr-Commit-Position: refs/heads/master@{#309450}

BUG=444563
TBR=creis@chromium.org

Review URL: https://codereview.chromium.org/804923003

Cr-Commit-Position: refs/heads/master@{#309449}

BUG=444596
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/802473003

Cr-Commit-Position: refs/heads/master@{#309448}

* ActivityDelegate takes in classes instead of Strings
  so that you can do isInstance on them.

* TabDelegate introduces a new function for creating Tabs
  in a specific case.

BUG=443773

Review URL: https://codereview.chromium.org/819743002

Cr-Commit-Position: refs/heads/master@{#309447}

This is a preliminary CL for upcoming Polymer update.

BUG=440039
TEST=manually, hotrod pairing works

Review URL: https://codereview.chromium.org/819633002

Cr-Commit-Position: refs/heads/master@{#309446}

BUG=444578
TEST=none
R=nasko@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/818833004

Cr-Commit-Position: refs/heads/master@{#309445}

BUG=443377

Review URL: https://codereview.chromium.org/820583002

Cr-Commit-Position: refs/heads/master@{#309444}

It tests device list updating mechanism mocking GCD server. Test code loads into a dummy page and
interacts with instance of DevToolsBridgeClient via dedicated command handler.

It also adds infrastacture for testing establishing sessions in future (ability to handle commands
sent from background_worker.html and create PeerConnection will help with it).

BUG=383418

Review URL: https://codereview.chromium.org/791083005

Cr-Commit-Position: refs/heads/master@{#309443}

BUG=148383, 242503, 170739, 166857
TBR=earthdok@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/791033005

Cr-Commit-Position: refs/heads/master@{#309442}

BUG=440675
TEST=no change
R=mdempsky@chromium.org, thakis@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/821453003

Cr-Commit-Position: refs/heads/master@{#309441}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cfaac60..dd080bd

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/823623002

Cr-Commit-Position: refs/heads/master@{#309440}

When we're profiling methods, we get back the address of the methods.  ICF
aliases several methods to the same address, which makes the order profile less
correct for other configurations which might make different ICF decisions.

Review URL: https://codereview.chromium.org/802583004

Cr-Commit-Position: refs/heads/master@{#309439}

For input type attribute in radio state with menu as parent is '?'.
A '?' in a cell indicates the data has yet to be provided.

ARIA role menuitemradio: A checkable menuitem in a set of elements with role menuitemradio,
only one of which can be checked at a time.

The behavior of input type in radio state with menu as parent seems similar with ARIA role menuitemradio.

A spec bug has been filed for this https://www.w3.org/Bugs/Public/show_bug.cgi?id=27041

This CL depends on https://codereview.chromium.org/651893002/

This CL also depends on https://codereview.chromium.org/634533002/ for fix related to android.view.MenuItem

BUG=422879

Review URL: https://codereview.chromium.org/652103002

Cr-Commit-Position: refs/heads/master@{#309438}

Add a virtual method InfoBarManager::CreateConfirmInfoBar that allow the
embedder to use UI specific implementation of ConfirmInfoBar. Port all
client code to use this virtual method instead of the static method
ConfirmInfoBarDelegate::CreateInfoBar.

Implements the InfoBarService::CreateConfirmInfoBar method for the
different UI (views, android, cocoa) and for TestInfoBarManager.

BUG=386171
TBR=jam@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/812823002

Cr-Commit-Position: refs/heads/master@{#309437}