- 07 Jun, 2019 40 commits
-
-
Erik Chen authored
RecordMemoryStats(RECORD_MEMORY_STATS_TAB_DISCARDED) is only called in one location, and the author indicated that it is unnecessary. Change-Id: I8ecd64337cacbf279e148dd80a4dbbcac872d187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639040Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667192}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=piman@chromium.org Change-Id: Ida93c455e32bf058063b6bf48800b289c972823b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649326 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#667191}
-
Etienne Pierre-doray authored
MessageLoopCurrent::task_runner() is depecated. This CL replaces it with with ThreadTaskRunnerHandle::Get(). A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1631693 Please CQ if LGTY! This CL was uploaded by git cl split. R=penghuang@chromium.org Bug: 616447 Change-Id: I42fb5b8d372a39dfe0493d49e09caeea571bd59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637458 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#667190}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=braveyao@chromium.org Change-Id: I574c959c6ab245e188386d0cbad5d8b3c2b4c789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649512 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#667189}
-
Robert Ogden authored
Removes: * feature * previews type * assoc params * triggering logic PreviewsState bit will come in the next CL. Bug: 944286 Change-Id: I65410f30d1efa574a391d61723fd6788b2d2d66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642018 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#667188}
-
Etienne Pierre-doray authored
Change-Id: I4f5b8ba6150924d7ae7a33c4aed9b8ee764b442c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647891Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#667187}
-
Josh Nohle authored
Children of the base CryptAuthDeviceSyncer class will implement the CryptAuth v2 DeviceSync flow, which includes uploading local device metadata, receiving remote device metadata, receiving device feature statuses--supported/unsupported and enabled/disabled--for multidevice (BetterTogether) features, and sharing the group private key with remote devices. The metadata and group private key exchanges are end-to-end encrypted. The analogous class for v2 Enrollment is CryptAuthV2Enroller. See design at https://go/cros-devicesync-v2-syncer. Bug: 951969 Change-Id: Ie069759d72f096ce97ef081a43b7f118ed9ea574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648837 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#667186}
-
Sam Maier authored
Bug: 972070 Change-Id: I34eb7fb23bc11c2136413414b00192760ba13282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649718 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#667185}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. Bug: 965663 Change-Id: I07a61658d730c0982e52f7e496d05cb274c9ef2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648695Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667184}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=proberge@chromium.org Change-Id: I05cc6ca56595f4cd8f9ba6887e5a3fa93a6927f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649365 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#667183}
-
Xianzhu Wang authored
Bug: 967281 Change-Id: I17b4ff95c2d31b0af0d3e7eb230cb70aae5532a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648802Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#667182}
-
Vladimir Levin authored
When locking a composited element, we may skip gathering its graphics layer as a foreign layer in local frame view. If we do, we need to ensure to invalidate the root paint artifact when we unlock, so that we can rerun the collection step to discover the unlocked graphics layer R=chrishtr@chromium.org, pdr@chromium.org Bug: 966760 Change-Id: I4a8ca9e08300eed05563fa0e9a08e65f4ea3094e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647752 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
-
Carlos Caballero authored
https://crrev.com/c/1649369 introduced a transitive dependency on //base/test:test_support, I guess presubmit checks do not run here so the submit did not fail on that patch. Change-Id: I30291b3d192041339179e9599bec097ef87c27c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649585Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#667180}
-
Ian Swett authored
Roll src/net/third_party/quiche/src/ 68d15a821..028931750 (16 commits) https://quiche.googlesource.com/quiche.git/+log/68d15a821c88..028931750c1a $ git log 68d15a821..028931750 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 danzh gfe-relnote: n/a(code cleanup) add #include <vector> to quic_hkdf.h 2019-06-05 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_enable_version_46 . 2019-06-05 fayang Enable more QuicConnectionTest for multiple packet number spaces. 2019-06-05 nharper gfe-relnote: Remove more dead Token Binding code in QUIC. Not flag protected. 2019-06-05 fayang gfe-relnote: In QUIC, add connected_ check in OnCanWrite and flusher's destructor. Protected by gfe2_reloadable_flag_quic_check_connected_before_flush. 2019-06-05 wub gfe-relnote: Cleanup stateless reject related stuff from QuicCryptoServerConfig::ProcessClientHello and QuicCryptoServerHandshaker::GenerateConnectionIdForReject. No behavior change, not protected. 2019-06-05 dschinazi Fix flag counts for quic_do_not_override_connection_id 2019-06-05 dschinazi Support QUIC Client connection IDs 2019-06-04 nharper gfe-relnote: QUIC_BUG instead of LOG(ERROR) in CreateQuicVersionLabel if the HandshakeProtocol is unknown 2019-06-04 fayang gfe-relnote: In QUIC, add code counts for RTT status when cwnd gets bootstrapped. Not protected. 2019-06-04 fayang gfe-relnote: In QUIC cwnd bootstrapping experiment, protect decreasing cwnd gain and pacing gain by gfe2_reloadable_flag_quic_conservative_cwnd_and_pacing_gains. 2019-06-03 nharper gfe-relnote: Fix appending padding in QuicPacketCreator::CreateAndSerializeStreamFrame. Protected by QUIC_VERSION_99 2019-06-03 quiche-dev Cleanup: remove unused serialized crypto config from QuartcDispatcher. 2019-06-03 renjietang Allow HttpDecoder visitor to return bool upon receiving HTTP/3 frames. 2019-06-03 fayang gfe-relnote: In QUIC, make QUIC_TOO_MANY_OUTSTANDING_SENT_PACKETS connection close detail more informative. Not protected. 2019-05-31 nharper gfe-relnote: Remove version negotiation packet tests from QuicConnectionTest; test-only change Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: Icda8576a47045ae4514f0ea1733c5e76232605a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648280 Commit-Queue: Ian Swett <ianswett@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#667179}
-
Nicolás Peña Moreno authored
Bug: 942033 Change-Id: Id45597527c69c84296b67b84b26228d1207b59ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648896Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#667178}
-
Erik Chen authored
Bug: 971452 Change-Id: I980b4113a011d37af3ba2582883604cc40b87fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648736Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=lazyboy@chromium.org Change-Id: I235f4f603407ea113d949297e550d4c75dbf94ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649580 Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#667176}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=lazyboy@chromium.org Change-Id: I9696c08d614a0842e494e7fd40566d72235d85fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649509 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
Matt Simmons authored
R=yusufo@chromium.org Bug: 970585 Change-Id: I790264b9fab0e7d88da12c737405130d6dd9f28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647960 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#667174}
-
Jan Wilken Dörrie authored
This change introduces a couple of small fixes to the Touch To Fill feature. In particular, it breaks a circular dependency between the constructors of the TouchToFillController and the ManualFillingController and exposes the Touch to Fill feature flag to Android. Bug: 957532 Change-Id: Id1c9f227139d7b5273d1db6b0ca13a5004addf52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649513 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#667173}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=marq@chromium.org Change-Id: I7db229e812286e0b9f67eafbd2a34756006c3591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649167 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#667172}
-
Ramin Halavati authored
Some minor updated regarding incognito and off the record in profile classes. Bug: 968028 Change-Id: I2e842f43a89f113f615d7c691a26a1326a7ccab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649321Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#667171}
-
Matthew Jones authored
This reverts commit d2d3af26. Reason for revert: Suspected cause of reliable non_network_service_content_browsertests failure on KitKat Phone Tester: https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20%28dbg%29 Will reland if issues persist. Original change's description: > Fix flakly content_browsertests > > Looks like BrowserTaskExecutor is being deleted while the IO thread is > still running and thus capable of posting tasks. Also browser tests are > like prod, we shouldn't manually shut down pools and schedulers. > > Bug: 963702 > Change-Id: I1cb953acc4b495631fe269af9e06b94fbe5f2a52 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628748 > Commit-Queue: Carlos Caballero <carlscab@google.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#667097} TBR=sky@chromium.org,gab@chromium.org,alexclarke@chromium.org,carlscab@google.com Change-Id: I7102aa3311368724320e6490fc329c4f99f9b2d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649064Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#667170}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=piman@chromium.org Change-Id: I5c322f7c0139d2afa0da7741840e58049940a8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649577 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=rockot@google.com Change-Id: Id5a57e02b84f50ed28caa406711ecc64c81f8d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649363 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#667168}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/120f5d906283..2b82eb290220 git log 120f5d906283..2b82eb290220 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 cwallez@chromium.org Fix incorrect ASSERT in vertex validation. 2019-06-07 cwallez@chromium.org Split off the reusable part of the code generator Created with: gclient setdep -r src/third_party/dawn@2b82eb290220 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I54e644d8dba57262e1a11d37f7ddbfe05a9918a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649715Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667167}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/74e63b8abbbf..24cf2606e421 git log 74e63b8abbbf..24cf2606e421 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 srte@webrtc.org Adds TCP fairness test to receive side congestion controller. 2019-06-07 srte@webrtc.org Revert "Reland "Cleanup of video packet overhead calculation."" 2019-06-07 srte@webrtc.org Reland "Cleanup of video packet overhead calculation." 2019-06-07 srte@webrtc.org Adds TCP fairness test to GoogCC. 2019-06-07 srte@webrtc.org Adds Frequency unit type. 2019-06-07 mhoro@webrtc.org Control rtt_mult addition cap via experiment. 2019-06-07 jonasolsson@webrtc.org Make interval budget use ratio instead of percent 2019-06-07 mbonadei@webrtc.org Replace calls to deprecated googletest APIs. 2019-06-07 mellem@webrtc.org Revert "Implement true negotiation for DatagramTransport with fallback to RTP." 2019-06-07 mellem@webrtc.org Revert "Remove an over-zealous DCHECK in jsep_transport.h" 2019-06-07 mellem@webrtc.org Revert "Remove another DCHECK that fails during renegotiation." 2019-06-07 mellem@webrtc.org Remove another DCHECK that fails during renegotiation. 2019-06-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9cc11952..add4dabf (666915:667020) 2019-06-07 mellem@webrtc.org Remove an over-zealous DCHECK in jsep_transport.h 2019-06-07 mellem@webrtc.org Implement true negotiation for DatagramTransport with fallback to RTP. 2019-06-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e9da1759..9cc11952 (666811:666915) 2019-06-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 209e3dbd..e9da1759 (666685:666811) 2019-06-06 elrello@microsoft.com Reland "Added OnIceCandidateError to API and implementation" 2019-06-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3ab0cb19..209e3dbd (666328:666685) 2019-06-06 yvesg@google.com Revert "Added OnIceCandidateError to API and implementation" 2019-06-05 steveanton@webrtc.org Remove pthatcher@webrtc.org from OWNERS 2019-06-05 steveanton@webrtc.org Remove jiayl@webrtc.org from OWNERS 2019-06-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5a40f118..3ab0cb19 (666217:666328) 2019-06-05 elrello@microsoft.com Added OnIceCandidateError to API and implementation 2019-06-05 ilnik@webrtc.org Don't copy video frame metadata in each encoder/decoder 2019-06-05 srte@webrtc.org Adds srte@ as OWNER of units. 2019-06-05 ilnik@webrtc.org Cleanup video frame metadata copying 2019-06-05 eladalon@webrtc.org Add retransmission_allowed flag to encoder output 2019-06-05 philipel@webrtc.org Added functions to control the VideoStreamDecoder playout delay. 2019-06-05 eladalon@webrtc.org Remove some leftover TODOs for webrtc:10336 2019-06-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fd17362e..5a40f118 (666098:666217) 2019-06-05 eladalon@webrtc.org FecControllerDefault nits (missing empty lines) Created with: gclient setdep -r src/third_party/webrtc@24cf2606e421 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:none,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iae503d5588f8eb224cfe0bba8a4d29c32cc1646a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649460Reviewed-by:
-
John Budorick authored
Bug: 959905 Change-Id: I7847c7437709258f18b78c227811f5d3a8026582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639050 Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#667165}
-
arthursonzogni authored
Remove use of the deprecated class SharedMemory. Instead use the new classes: {Write,ReadOnly}SharedMemory{Region,Mapping}. The previous code was wrapping the shared memory inside a mojo handle. Instead, pass directly the ReadOnlySharedMemory to mojo, this is the preferred way. See Chromium Shared Memory Refactor design doc for more details: https://docs.google.com/document/d/1lk2-7W7Cy7FDqG-6lgS8LRkzXABYTOytf6VUsWNf8-0/edit#heading=h.7nki9mck5t64 Bug: 795291 Change-Id: I7ee031baf80533dac064fc779e31c40fc0eb202f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566307 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#667164}
-
Xida Chen authored
This reverts commit a0992a5e. Reason for revert: didn't fix the problem Original change's description: > Pass virtual/scalefactor200/css3/filters/effect-reference-subregion-hw.html > > It appears that this expected.txt is causing the failure on Mac: > https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/23664 > https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/12244 > > Deleting this should work. > > Bug: 968791 > Change-Id: I6134b3c67fa38a316b66ab97be2eb7a46525d364 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645378 > Reviewed-by: Robert Ma <robertma@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666315} TBR=xidachen@chromium.org,robertma@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 968791 Change-Id: Id0e09cfff6c6255e3bffac93034733b4d0ba1e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648853Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667163}
-
Erik Chen authored
This reverts commit f279df09. Reason for revert: I'm seeing perfetto compile errors on Windows that occur right around the time this CL landed. Prematurely reverting, apologies in advance if this is some type of flake: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8911297141304317280/+/steps/compile__with_patch_/0/stdout Original change's description: > Roll src/third_party/perfetto c63be46c5020..55879e5b68b0 (4 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/c63be46c5020..55879e5b68b0 > > > git log c63be46c5020..55879e5b68b0 --date=short --no-merges --format='%ad %ae %s' > 2019-06-07 rsavitski@google.com Merge "userdebug: support perfetto traces as a section in incident reports" > 2019-06-07 fmayer@google.com Merge "Revert "Revert "Add docs for idle page tracking.""" > 2019-06-07 fmayer@google.com Merge "Explain /dev/socket/heapprofd SELinux domain issue." > 2019-06-07 fmayer@google.com Merge "Refactor listening socket out of heapprofd producer." > > > Created with: > gclient setdep -r src/third_party/perfetto@55879e5b68b0 > > The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > TBR=perfetto-bugs@google.com > > Change-Id: I9b0ba39ec50923130f4ab8ad285152782c724ffa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649518 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#667150} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: If3593b1fa36ec3f52302920189f0bfc8c99b4736 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649150Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667162}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=dcastagna@chromium.org Change-Id: I92a1b8c3530059938c9300774d0a9f3e007b49c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649324 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#667161}
-
Jan Wilken Dörrie authored
This change replaces usages of base::ContainsKey() and base::ContainsValue() with base::Contains() in //content/browser. Reproduction: - sed -i 's/\bbase::ContainsKey\b/base::Contains/g' - sed -i 's/\bbase::ContainsValue\b/base::Contains/g' - git cl format This CL was uploaded by git cl split. R=boliu@chromium.org, tsepez@chromium.org Bug: 970209 Change-Id: I97d7648a2be582b1bb5a40937a4c9832b895b236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648227 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#667160}
-
Keishi Hattori authored
We want to allow cooperative scheduling for <script src="..."> Especially external parser-blocking scripts. To do so we need to repost the script execution part to a task so the stack will be simple. This CL adds the ContinueScriptLoading task queue to be used for this task. Bug: 966728 Change-Id: I8227a2fdfe0ee773a3f9d5140cdc4e5e18e4b9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614651 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#667159}
-
Xianzhu Wang authored
The test was actually passing on Mac, but a 1px difference caused the test to report a failure on difference between -0 and 0. The test started to fail after https://chromium-review.googlesource.com/c/chromium/src/+/1614448 which fixed some vertical-rl issues. Before that, the 1px difference was added in a wrong direction and didn't trigger the -0 vs 0 issue. Add + 1 - 1 to convert -0 to 0. Bug: 968033 Change-Id: Idfd6c047f77193be571219459629c10439004de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648710Reviewed-by:
-
Etienne Pierre-doray authored
MessageLoopCurrent::task_runner() is depecated. This CL replaces it with with ThreadTaskRunnerHandle::Get(). A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1631693 Please CQ if LGTY! This CL was uploaded by git cl split. R=tguilbert@chromium.org Bug: 616447 Change-Id: I9e8a2af5a34d40605169ad71fdbdeb939522d518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635626 Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#667157}
-
Michael Thiessen authored
When we get to the last non-submit-button element of a form the IME action should change from Next to Submit. Bug: 968557 Change-Id: I5e61f184d30e6088fa80f3cdf95bbed1c344f46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648464Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#667156}
-
Mohamed Heikal authored
Currently browsertests that require native, load it using ChromeTabbedActivityTestRule#startMainActivityOnBlankPage() which loads the native library in full browser mode as well as load the chrome tabbed UI. ReducedModeNativeTestRule is a reduced mode counterpart to that. It only loads native in reduced mode and without UI. Bug: 959957 Change-Id: I76dabc8f4fc4cc702e9193bf69486198ba8dfd3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615984 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#667155}
-
Erik Chen authored
Linking on macOS is invoked via clang++. If clang++ cannot find ld on the default search path, clang++ will invoke xcrun to search for ld. This CL explicitly passes the path to ld if we're using hermetic xcode. This way clang++ will not invoke xcrun. Bug: 971452 Change-Id: I5bcaa577d9ccc6d3ceca6e2524482e299b371e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649179Reviewed-by:
-
Erik Chen authored
Both binaries show up in the default macOS search path, but as minimal wrappers around xcrun. By specifying the paths explicitly, we avoid calls to xcrun. Bug: 971452 Change-Id: Ia852f4b9991fd548f3c83bc04fdda7389e44a72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649223Reviewed-by:
-
