GitLab

When forking a child process, one often wants to move existing file
descriptors to well known locations (stdout, stderr etc). However,
this is a process bedeviled with corner cases. Consider the case where
you open two file descriptors, get assigned fds 1 and 0 for them and
wish to shuffle them so that they end up in slots 0 and 1. Our current
code fails in this case.

We also have a problem where we're currently trying to mark file
descriptors as close-on-exec rather than closing them in the child
process. This is inherently broken in a multithreaded process where
another thread can open a file descriptor and race the loop which is
trying to mark them.

Thus, on Linux we switch to close-after-fork where we known that no
other threads exist in the process. On Mac, the code is sufficiently
different that this simple fix isn't applicable and one of the Mac
folks will need to take a look.

http://codereview.chromium.org/100127
BUG=11174


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14978 0039d316-1c4b-4281-b951-d872f2087c98

This uses FSEvents and supports both recursive and non-recursive modes.

TEST=Make sure that tests matching DirectoryWatcherTest.* from base_unittests pass on Mac.

http://crbug.com/10967

Review URL: http://codereview.chromium.org/99057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14977 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11200
R=erikkay

Review URL: http://codereview.chromium.org/100213

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14976 0039d316-1c4b-4281-b951-d872f2087c98

This needs to be merged with 2.0 (172.x) branch.

TBR=mal
BUG=11198
Review URL: http://codereview.chromium.org/100218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14975 0039d316-1c4b-4281-b951-d872f2087c98

Xiaomei, I just applied the code that you suggested in your email and it worked.


Review URL: http://codereview.chromium.org/99237

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11190

Review URL: http://codereview.chromium.org/99243

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14973 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 11175
R= sidchat
TEST= See bug. Also check that the dictionary under Chrome\Application\Dictionaries
is lt-lt-1-3.bdic.
Review URL: http://codereview.chromium.org/99241

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14972 0039d316-1c4b-4281-b951-d872f2087c98

Used for gears file drag & drop in chrome, define the values of
the drop effect overrides to match the gears definitions.

BUG=7995

Original patch by Noel Gordon via:
http://codereview.chromium.org/99231

Review URL: http://codereview.chromium.org/102016


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14971 0039d316-1c4b-4281-b951-d872f2087c98

- Add a new target to build just what's needed for the webkit layout bots.
- Roll deps for the needed GYP change.
Review URL: http://codereview.chromium.org/100208

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14969 0039d316-1c4b-4281-b951-d872f2087c98

of Windows file & string manipulation, enable plugin tests on the Mac.
Review URL: http://codereview.chromium.org/102014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14968 0039d316-1c4b-4281-b951-d872f2087c98

Add notification (and unit test) for closing prefs window so it can be cleaned up properly in the app controller. Make the prefs window controller the window's delegate so it gets close notifications.
Review URL: http://codereview.chromium.org/99238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14967 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99219

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14966 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14964 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100212

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14960 0039d316-1c4b-4281-b951-d872f2087c98

Add a very basic preferences window controller with unit test. Fix the prefs nib to know the FileOwner is a NSWindowController and hook them together.
Review URL: http://codereview.chromium.org/102015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14958 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14955 0039d316-1c4b-4281-b951-d872f2087c98

by a crash.

Review URL: http://codereview.chromium.org/99220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14954 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100190


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14953 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben

Closing the last tab with a download in-progress would cause the tab to be
closed and become unusable if the user decides not to proceed with the browser
shutdown.
This is because we check for in-progress downloads when the browser is closed,
and the tab is closed before that, leaving the tab-strip in a bad state.

This CL ensures we also bring-up the confirmation dialog when the last tab is
closed.

BUG=10680
TEST=Start downloading a big file. While the file is downloading, close all
tabs. When closing the last tab, the in-progress download dialog should be
shown. Select the 'Wait for downloads', the download tab should be shown and
the previous tab should still be displayed and functional.
Close all tabs again, this time select the 'Close and cancel downloads'
option, the browser should be closed.
Review URL: http://codereview.chromium.org/100210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14952 0039d316-1c4b-4281-b951-d872f2087c98

using the unit_test executable rather than chrome.exe.  This patch repurposes
the --renderer-path switch to be --browser-subprocess-path for both plugins and
renderers.  

BUG=11006
TEST=Any InProcessBrowserTest (they all will start at least one renderer). Use
NavigateToURL to a URL containing flash, we shouldn't crash.


Review URL: http://codereview.chromium.org/99011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14951 0039d316-1c4b-4281-b951-d872f2087c98

Broke the Mac build.

TBR=ben
Review URL: http://codereview.chromium.org/99224

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14949 0039d316-1c4b-4281-b951-d872f2087c98

closed and become unusable if the user decides not to proceed with the browser
shutdown.
This is because we check for in-progress downloads when the browser is closed,
and the tab is closed before that, leaving the tab-strip in a bad state.

This CL ensures we also bring-up the confirmation dialog when the last tab is
closed.

BUG=10680
TEST=Start downloading a big file. While the file is downloading, close all
tabs. When closing the last tab, the in-progress download dialog should be
shown. Select the 'Wait for downloads', the download tab should be shown and
the previous tab should still be displayed and functional.
Close all tabs again, this time select the 'Close and cancel downloads'
option, the browser should be closed.


Review URL: http://codereview.chromium.org/99195

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14948 0039d316-1c4b-4281-b951-d872f2087c98

* Fix action execution with no specified target output files.
* Handle duplicate --mode= values.
Review URL: http://codereview.chromium.org/99210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14946 0039d316-1c4b-4281-b951-d872f2087c98

Initial prefs window xib from Cole. Hook the menu up to (empty) code. Use scoped pointers to manage memory.
Review URL: http://codereview.chromium.org/100206

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14945 0039d316-1c4b-4281-b951-d872f2087c98

This is used for Linux, where we're currently not doing inverse selection.

Review URL: http://codereview.chromium.org/100207


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14944 0039d316-1c4b-4281-b951-d872f2087c98

This wasn't actually a bug in that everything worked fine.  It just meant we
were calling the default handler twice, and returning from what should have
been a void function.

Review URL: http://codereview.chromium.org/99218


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14943 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100200


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14942 0039d316-1c4b-4281-b951-d872f2087c98

This ended up being implemented as a toplevel instead of a popup, to handle
things like virtual desktop switching.  I imagine there are some other problems
we might hit, like the window getting decorated, etc.  Although I think the
shape mask might prevent decorations from being visible.  This is not pixel
perfect with Windows, since we're not anti-aliasing the frame border.

Review URL: http://codereview.chromium.org/100203


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14941 0039d316-1c4b-4281-b951-d872f2087c98

does resolve the location bar not being focused bug on the mac build.

Patch by Sean Bryant (sean@cyberwang.net).

BUG=9419

Review URL: http://codereview.chromium.org/100140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14939 0039d316-1c4b-4281-b951-d872f2087c98

This is a cherry-pick of the following change:

http://code.google.com/p/skia/source/detail?r=159

We introduce this change for the 'lighter' composite operation. We need kAdd_Mode, which is introduced in this change for the operation.

Patch by Shinichiro Hamaji.

BUG=1619

Review URL: http://codereview.chromium.org/93093


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14938 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14936 0039d316-1c4b-4281-b951-d872f2087c98

2. Function actual parameters are not shown in the call stack panel because they are alredy displayed in the scopes panel.
Review URL: http://codereview.chromium.org/99185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14935 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Make sure that the task manager isn't obviously broken on Windows.

Review URL: http://codereview.chromium.org/93067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14934 0039d316-1c4b-4281-b951-d872f2087c98

It seems the AutocompleteResultView::DrawString() function calls the AutocompleteResultView::DrawStringFragment() function even when |text_start| is greater than |text_end|, i.e. there are not matching characters.
This change filters out the above case and fixes a couple of lint errors.
Review URL: http://codereview.chromium.org/100196

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14933 0039d316-1c4b-4281-b951-d872f2087c98

On Windows, "Alt" key will set both alt and meta is on (issue 2215).
But Alt-Gr is used to insert alternate character.

BUG=10846

Review URL: http://codereview.chromium.org/99216

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14932 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14927 0039d316-1c4b-4281-b951-d872f2087c98

BUG=10863

Review URL: http://codereview.chromium.org/100178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14926 0039d316-1c4b-4281-b951-d872f2087c98

On translate.google.com, it fails to show balloon, because of JavaScript
exception in following code:
  p=a.getClientRects(); ... p[0].top  // p[0] is undefined!

Current v8 binding misses indexed access method in ClientRectList.

CSSOM View Module draft says
 http://dev.w3.org/csswg/cssom-view/#clientrectlist
 In ECMAScript implimentations, objects that implement the ClientRectList
 interface must also have a [[GET]] method that, when invoked with a number,
 acts like the item() method would when invoked with that argument.

BUG=10697


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14925 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11200
R=aa

Review URL: http://codereview.chromium.org/100164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14924 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14922 0039d316-1c4b-4281-b951-d872f2087c98