- 09 Dec, 2019 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/84d0f7cbbb9b..7a15cef26d94 git log 84d0f7cbbb9b..7a15cef26d94 --date=short --first-parent --format='%ad %ae %s' 2019-12-09 sugoi@google.com Cubemap array support Created with: gclient setdep -r src/third_party/swiftshader@7a15cef26d94 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ibdc74ecce9815113066e54ee7e7c98f212bf8e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958237Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723065}
-
Erik Chen authored
This CL fixes a longstanding implementation bug in poisson sampling allocator. The poisson sampling allocator consistently oversampled allocations, particularly small ones. The root cause is that muted allocations continue to affect g_accumulated_bytes_tls. If muted allocations were randomly distributed with normal allocations, this would have no net effect. However, muted allocations always happen right after g_accumulated_bytes_tls is reset. This non-randomness means that muted allocations are almost never sampled, but cause other allocations to be over-sampled. This CL fixes it by resetting g_accumulated_bytes_tls back to its original value after we unmute. This CL also fixes a test bug. To pick up the test-specified sampling rate, we make several large allocations, flushing the TLS variables which were still keyed to the old sampling rate. Bug: 843467 Change-Id: Idea9fab3dfadc014375a3428a7839c76fc635556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956266 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#723064}
-
Becca Hughes authored
This reverts commit c50865f6. Reason for revert: Suspected failure for Chrome OS browser_tests: BUG=1029957 Original change's description: > Use proper localization mechanism for throbber-notice element. > > Bug: 955194 > Change-Id: Ib6ac3fcbe446c047bd846a0c775210fda7763b9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953626 > Reviewed-by: Roman Aleksandrov <raleksandrov@google.com> > Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723023} TBR=antrim@chromium.org,rsorokin@chromium.org,raleksandrov@google.com Change-Id: I65c1717fe30d0aee33801d31971ee516099f7de5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958709Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#723063}
-
Christopher Grant authored
When Chromium changed to use Clang, the secondary ABI output directory changed names. Support that name, but also, return to using library size as a means of matching up libraries. This didn't work prior to using lld, but does work now. Preserve the original matching system as a fallback. Bug: 986622 Change-Id: Ia469eed5b0b69d8a4fe2840526ba817df362099d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955821 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#723062}
-
Mike Wasserman authored
Update code to better match the latest Screen Enumeration proposal: https://github.com/spark008/screen-enumeration/blob/master/EXPLAINER.md Move getScreens() off a constructable IDL class and Navigator interface. See discussion in https://github.com/spark008/screen-enumeration/issues/9 Only expose getScreens() to Window-accessible execution contexts for now. We can support Worker execution contexts later, as use cases arise. (mfoltz@ recommended this limited/incremental approach) Test with chrome://flags#enable-experimental-web-platform-features or --enable-blink-features=ScreenEnumeration Bug: 994889 Test: Automated; window.getScreens() works as expected with the flag. Change-Id: I955e21bd0691d36ddb9d8f667d86863004e20091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952023 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#723061}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I8b0aba8561ea8b857906a4d0d425c0d66d395f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955099Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#723060}
-
Pavel Yatsuk authored
Currently id/snackbar is setup to align to parent bottom within RelativeLayout. This combination leads to RelativeLayout taking up the whole screen and pushing its children at the bottom. This affects animation in SnackbarView#show(): getYPositionForMoveAnimation() returns screen height instead of snackbar height. As a result the animation is only visible for a short moment at the end of animation interval. I'm adjusting layout to anchor it/snackbar_shadow_top to the top of its parent. id/snackbar is anchored below it/snackbar_shadow_top. R=mdjones@chromium.org Change-Id: I4fc57728098596212b17aefa17f6e7f5be212482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958609Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#723059}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/dc3317da6cd5..792ff476ce66 git log dc3317da6cd5..792ff476ce66 --date=short --first-parent --format='%ad %ae %s' 2019-12-09 natlee@microsoft.com Validate texture max size Created with: gclient setdep -r src/third_party/dawn@792ff476ce66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I30d3f49b3307e18b8e0ddacc50bb7b29faaffe67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958238Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e87c0ece2871..0ce8425f0e01 Created with: gclient setdep -r src-internal@0ce8425f0e01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1013386,chromium:1024588,chromium:986990 Tbr: jbudorick@google.com Change-Id: Id9e3c1371bad36ba2ca23927172b77e9868794c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958607Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723057}
-
Alan Screen authored
From review [1] it was noted that there are spots with usage of DCHECK() which are unnecessary, since nearby code would crash quickly anyway upon use of a null pointer. Simplify by just getting rid of those checks. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1935946/1/printing/printed_document_win.cc#83 Change-Id: Ief379fb73a9c956c2a2b69cfdce123ab24bba9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956503 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#723056}
-
danakj authored
The GpuFeatureChecker callback is only called once, so convert to a OnceCallback. R=avi@chromium.org, reillyg@chromium.org Bug: 1007763 Change-Id: I396324c692681f26e715bdd800153fbf8e38202b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958187 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#723055}
-
Mingjing Zhang authored
This CL adds HistoryService API to query the number of unique domains visited during a given range of dates. This API is a prerequisite for the domain diversity metric. Bug: 1015494 Change-Id: Ic5f49adfeae5f8b9f18f23b97a7eab02ba89c6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869755 Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#723054}
-
Erik Chen authored
Change-Id: I1d4fa87a14e9e37a07e5d5446e2b3379a8b27d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958688Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#723053}
-
Peter Wen authored
These VR tests do not use VrTestRuleUtils to wrap their rules. Thus they need to use BundleTestRule explicitly. Bug: 1031603 Change-Id: I56c369c38d84a82c7f8ba7a4f532f84fd7ba840e Fixed: 1031603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958445 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#723052}
-
Abhijeet Kandalkar authored
The goal of this CL is to clean the element.h file and remove DEFINE_ELEMENT_TYPE_CASTS to adopt new downcast helpers. This CL removes DEFINE_ELEMENT_TYPE_CASTS for SVG,Html and MathML element. Bug: 891908 Change-Id: I3f1ef7357780d49381e486dc01a09557c17ce39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958426Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#723051}
-
Esmael El-Moslimany authored
This implementation of most-visited is functionally the same of the most-visited on the current NTP. The differences in UI are going to be discussed with @bklmn after this CL lands. - Show up to 10 most-visited tiles. - Toast is shown with undo and restore to defaults buttons when certain tile actions are performed. - Action menu displays options to edit and remove tile. - Show add shortcut tile if space allows. - Supports light and dark mode. Bug: 997229 Change-Id: Ie22220e2f866ba1ba485daf504265e9d868f9050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924702Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#723050}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=hta@chromium.org Bug: 1023677 Change-Id: If63f21859fdea280d20fa5b0793309b003dba404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957496 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#723049}
-
Nektarios Paisios authored
On Mac, all AXPositions are checked via their IsValid method before being deserialized from the text marker opaque data structure passed to Chromium by the operating system. However, for some reason, the text offset in CreatePositionAfterCharacter ends up being larger than the actual position's text. This patch introduces a workaround until we are able to figure out the true cause of this issue. TBR=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1022601 Change-Id: I08b79c384796c8cb2823d7c2d6eec96d311a1f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958235Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#723048}
-
Avery Musbach authored
Bug: 1029181 Change-Id: Idfac16aca747417802c478f8472aa5d0b470be66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958162Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#723047}
-
Dan Harrington authored
This required adding some deps that were in chrome/android/java Change-Id: I12f33d177fc2af89373052e5529e665f47f82c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953755Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#723046}
-
Victor Fei authored
MacOS VoiceOver is not announcing the number of rows correctly for table like elements when the table rows are nested in elements such as <div>. This change fixes this issue by: - exposing AXTableInfo::row_nodes which tracks a list of ax nodes that represents the rows of the table - BrowserAccessibilityCocoa::rows() to utilize AXTableInfo::row_nodes to correctly retrieve table row information. Example: rootWebArea(#1) ++grid(#2) ++++row(#3) ++++++columnHeader(#4) ++++++columnHeader(#5) ++++genericContainer(#6) ++++++row(#7) ++++++++cell(#8) ++++++++cell(#9) ++++++row(#10) ++++++++cell(#11) ++++++++cell(#12) BEFORE: VoiceOver would announce 2 columns, 1 row. This is because BrowserA11yCocoa::rows() only looked at the first level children of grid(#2) therefore cannot find row(#7), row(#10) which are nested in genericContainer(#6) AFTER: VoiceOver would announce 2 columns, 3 rows. This is because now we call AXNode::GetTableRowNodes() which fetches row information from AXTableInfo::row_nodes. Bug: 1031629 Change-Id: I72536b8dce0657ca970019409220e8d9ac874821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948920 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#723045}
-
Ken Rockot authored
This new interface is analogous to a service_manager::Connector, but is intended strictly for use with Cast-related services. The purpose of adding this interface is twofold: 1. This makes it possible to migrate Media Service off of Service Manager. Instead of passing a Connector into CastRenderer, CastRenderer now acquires a ServiceConnector binding from Cast browser code via the InterfaceProvider held by Media Service. 2. Uses of Connector in the internal cast repo can start to use this interface in place of a Connector to help them transition off Service Manager without significant refactoring effort. One of the explicit goals of this CL is also to make it so that the ServiceConnector implementation in the browser is immediately and easily extensible within the internal repository: CastContentBrowserClient creates the impl instance, and its creation can be overridden with an an internal subclass. The internal implementation can connect directly to internal services without bouncing through Service Manager, and it can introduce new values for ServiceConnectorClientId to identify internal clients. Bug: 977637 Change-Id: I013325512fef6624b435b47509a64a15ffd7d39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954769Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#723044}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2bca61df7746..bbddcc4a938a git log 2bca61df7746..bbddcc4a938a --date=short --first-parent --format='%ad %ae %s' 2019-12-09 jalyn@microsoft.com Enable keyboard navigation of threads pane 2019-12-09 sigurds@chromium.org [network] Add empty protocol message handler Created with: gclient setdep -r src/third_party/devtools-frontend/src@bbddcc4a938a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032063,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id8bf4c0babf299c834273d8a1e5a318540b07c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958416Reviewed-by:
-
Jeffrey Kardatzke authored
This adds a new colorspace protocol to Wayland that allows setting the colorspace for a surface. It also integrates it into Exo and adds a client for testing colorspace rendering. Bug: None Test: wayland_colorspace_client shows differences on kohaku Change-Id: If71566bf193c01fae52fb4ee8b7875d55a429a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934076 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#723042}
-
Xinghui Lu authored
This is a CL to prepare for supporting real time url cache. No functional change in this CL. Bug: 1030989 Change-Id: Ib65ee66efc9c4250076976a6c25afbf5747357b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956565Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#723041}
-
Ayu Ishii authored
Bug: 1027394 Change-Id: Ife6c3b001253d5fec64c3b6e9d4b5b9d6a7ba2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956076 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#723040}
-
Hans Wennborg authored
Ran `tools/clang/scripts/upload_revision.py a38396939c548f9ad8e94c9baa7198fdb26dedc2`. Bug: 1030664 Change-Id: I75c3a43c4f66fe8d850902c60eead4ff6991fba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958044 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#723039}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=pbos@chromium.org Bug: 1023677 Change-Id: I589c3c908fa6a5f3c77b4d07fc73831f8a13af93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955081 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#723038}
-
Aaron Tagliaboschi authored
Mobile is a boolean client hint that informs whether a "mobile" or "desktop" user experience should be supplied. Relevant changes to the spec can be found here: https://github.com/WICG/ua-client-hints/pull/8 That was manually added via this commit: https://github.com/WICG/ua-client-hints/commit/db6fab2569b78666c40e84e4d0458dbdf59d336b Bug: 928669 Change-Id: Ia983cfa516c28b6a747b270abcc44e71ed39e1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829793 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#723037}
-
Thomas Lukaszewicz authored
Fixed the issue with a stuck inkdrop on drag of a download item due to incorrect handling of the button's OnMouseDragged() and OnMouseCaptureLost() handlers. Prior to this change DownloadItemView attempted to intervene in the button's inkdrop display logic. Removed inheritance from InkDropHost for DownloadItemView as it is unnecessary due to the use of a transparent button overlay for the button effects. Bug: 1026384 Change-Id: I2436fab35f5334ca0bd947189c831f932ba1f0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955657 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Aaron Tagliaboschi authored
A smidge of refactoring for the user agent string code as well. (Relanding crrev.com/c/1951446 after fixing MacOSX cpuinfo) Bug: 1001125 Change-Id: I237011f3d85bde2cfe8bcf40731b442df27fe481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955958Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#723035}
-
Daniel Murphy authored
TBR: rockot@chromium.org Bug: 1027737 Change-Id: Idcd669f2f91a542ced570beda300aad715055868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956066Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#723034}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/62836903bcc7..63be47c488aa git log 62836903bcc7..63be47c488aa --date=short --first-parent --format='%ad %ae %s' 2019-12-09 bsalomon@google.com Add testCompile function to SkRuntimeColorFilterFactory for Chrome test 2019-12-09 fmalita@chromium.org [skottie] Explicit seek(0) in tools 2019-12-09 bsalomon@google.com Support mirror-repeat in GrTextureDomain 2019-12-09 mtklein@google.com lift Wno-class-memaccess 2019-12-09 mtklein@google.com mark SkMD5->SkUUID copy as sane Created with: gclient setdep -r src/third_party/skia@63be47c488aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Ib8b8fb217755aaa50a69a27b3edb6ea2c73a121b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957403Reviewed-by:
-
Tim van der Lippe authored
Necessary for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1953583 Follow-up on https://chromium-review.googlesource.com/c/chromium/src/+/1958116 TBR=mathias@chromium.org Bug: 1006759 Change-Id: Id6ae5e47b836443ccb7bdf83bc789cca786484ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953742Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#723032}
-
Asanka Herath authored
Bug: None Change-Id: Id6e91bdedc8015ec2b0fb451f53ba2ca30ba7d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957210Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e9bf0dc..18d58583 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icb3a89e0588c0e572a8b23eb736ddbdd7133747f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956054Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723030}
-
Koji Ishii authored
This patch fixes inline offset in hit-testing when |FragmentItem| is enabled. |NGPaintFragment| has two kinds of offsets; one to the parent, another to the containing block. |FragmentItem| reduces this only to the containing block, the same as the legacy |InlineBox|. The hit-testing in |NGBoxFragmentPainter| uses the offsets to the parent, and that part needs to change to support |FragmentItem|. Hit-testing functions in |NGBoxFragmentPainter| already carry 3 arguments that do not change. Instead of adding the 4th argument that does not change, this patch adds |HitTestContext| and pass it by reference. 7 failures, ~180 passes. Bug: 982194 Change-Id: I840b0b3c63b2b1b58f10c8bf493e473d988ae0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954980 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#723029}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3cc87023. With Chromium commits locally applied on WPT: a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." eb00b4d6 "LazyLoad: move invisible-image.html test to WPT" c78acd51 "Expose support for (X)HTML in requiredExtensions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I61ee0cb824fe2b658557dd8118fb413c641529d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956055Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723028}
-
Ryan Hamilton authored
and to explicilty initialize the cache instead of calling InitializeBackend with the cache directory (thus removing a layer of indirection for test expectations). Change-Id: Icd528007dbd7d26d2eed119272d7acbf080b774f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958566Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#723027}
-
Chase Phillips authored
This CL adds scope manifest override tests. It also extends upgrade test cases to cover manifest data and scope data changes, which allows us to verify that scope changes result in differing cached manifests. While here, this changes override handling so relative paths are allowed. Bug: 999001 Change-Id: Ia3efef020432708c7546df88bcd12b41f9d0ccf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957385 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
-
