- 02 Nov, 2020 40 commits
-
-
Mikel Astiz authored
This patch deprecates metric Bookmarks.Count.OnProfileLoad.DuplicateUrl in favor of the new similar metric Bookmarks.Count.OnProfileLoad.DuplicateUrl2. Differences include: 1. Among bookmarks with the same URL, one of them is now excluded as duplicate (to distinguish the authoritative copy from duplicates). 2. A higher max bucket is used, now 100K instead of 10K, in consistency with metric Bookmarks.Count.OnProfileLoad.DuplicateUrl. 3. The implementation doesn't use hashing of URLs, since there's a simple and efficient way to implement the same logic in UrlIndex. This may influence slightly the recorded metrics, if users ran into hash collisions. 4. Because the implementation is trivially efficient, the feature toggle is cleaned up (was enabled by default anyway). Change-Id: If736305846f3deac74439834b546cb5b9d0601f4 Bug: 1068378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510401Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#823196}
-
Jeroen Dhollander authored
The code to initialize the |AssistantManager| was quite complex because it had to handle the fact that |AssistantManager| was created on a background thread, and that this background task could be triggered multiple times before it ever finished. To simplify this the |AssistantManager| (and its related classes) is now owned by an |AssistantManagerController| that will: * Ensure the |done_callback| is invoked only once, even if multiple controllers are created (we achieve this by storing the controller in a unique_ptr and ensuring it only calls the callback if the controller was not deleted, meaning only the last controller will call the callback). * Not access the |assistant_manager_| field from the background thread, meaning it can always safely be accessed from the main thread. This simplification will make it easier to move the Libassistant process to a sandbox. Bug: b/171748795 Test: chromeos_unittest --gtest_filter="AssistantManagerServiceTest.*" Change-Id: Icfce1163d5253713094145b5d7e7c637057527c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500452 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#823195}
-
Jesse McKenna authored
This change fixes an issue where PWA custom icons were not showing up in the Open With menu on Windows when a PWA is registered as a file handler on Windows. A PWA's custom icon is located at: <user data>/<profile>/Web Applications/<app ID>/<app name>.ico Currently, the value of DefaultIcon as registered with Windows is: <user data>/<profile>/Web Applications/<app ID>/<app name>.exe/<app name>.ico Windows fails to find the icon file and instead displays a generic icon. This is caused by GetIconFilePath() being passed |app_launcher_path| (which has value <app name>.exe) as its |web_app_path| parameter. This change replaces that argument with the path to <user data>/<profile>/Web Applications/<app ID>. Bug: 1143966 Change-Id: I4744b9866c85f570c3e9bd794d83a6abb6cd97eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508648Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#823194}
-
Jordan Oroshiba authored
Replacing the URL with the text for preview UI message text, replacing favicon with the lite page logo. Screenshot: https://crbug.com/1077766#c82 Bug: 1077766 Change-Id: Ic236e12ac678881b6bace346bbaf5d89b7c7052b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503577 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#823193}
-
Jan Wilken Dörrie authored
This reverts commit f55e9981. Reason for revert: https://crbug.com/1144431 Bug: 1144431 Original change's description: > [base] Use NO_UNIQUE_ADDRESS in flat_tree > > This change makes use of NO_UNIQUE_ADDRESS in flat_tree, allowing the > removal of an internal class which just existed to make use of the empty > base optimization. > > Bug: 682254 > Change-Id: Iabf91d4acee95c7ba4e929d23528d95b0ced1612 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509757 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822948} TBR=dcheng@chromium.org,jdoerrie@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 682254 Change-Id: If3b15e15241e8f8b5d99b80caadbb25153648f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514147Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#823192}
-
Zach Trudo authored
In ExtensionInstallLogUploader the ReportQueueConfig wasn't correctly building the ReportQueueConfig. Bug: chromium:1078512 Change-Id: Ifd0b495536b3b5b5153193a4e9d29e3a1b66b0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505682 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#823191}
-
Rohit Agarwal authored
This CL removes the deprecated Profile#getOffTheRecordProfile method which invoked Profile#getPrimaryOTRProfile internally. The remaining callers of getOffTheRecordProfile are updated to directly call getPrimaryOTRProfile instead. The code requiring primary OTR profile would rely on invoking the method Profile#getPrimaryOTRProfile explicitly instead. Bug: 1060940 Change-Id: I72301c22b48e51262678673cbd4066a835c76089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513650 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#823190}
-
Matt Jones authored
This patch migrates all of the layout/compositor-specific animation classes and tests to the new "layouts" module. Bug: 1070281 Change-Id: If9fb504933f1e0adcc38a2e4b34800f7193a572d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503830 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#823189}
-
Tanmoy Mollik authored
This cl creates a version of the SigninPromo Test when MOBILE_IDENTITY_CONSISTENCY is enabled. Bug: 1142467 Change-Id: I5c7d6503c5e6c2867a43713a0ba2f957f541513e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505811Reviewed-by:
-
Leo Lai authored
Now we are using AttestationClient directly instead of passing through CryptohomeClient. BUG=b:158955123 TEST=build ok. Change-Id: I02646e7e9b7428a5f9ad41a07e80ef00ca5ef2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505394 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#823187}
-
Andre Le authored
Update battery icon in phone status to indicate phone's battery saver mode. This includes: - Moving BatteryImageSource in ash/system/power to a public class so that Phone Hub can extends. - Creating PhoneHubBatteryImageSource and showing battery saver mode. Bug: 1106937,1126208 Change-Id: I93bbf244148c1dc51fe5d5ee18293da2fff9c0ea Fixed: 1143374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507384Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#823186}
-
Dominique Fauteux-Chapleau authored
This is to better represent what the function actually does. This is only a rename and doesn't change any existing behaviour. Bug: 1098437 Change-Id: I06888a8e6994dcaf327c48e14681b953a8cd5dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510194 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#823185}
-
Nicolas Ouellet-Payeur authored
This is needed to enable DestroyProfileOnBrowserClose by default in automated tests (crrev.com/c/2503629). ConfigurationRefresher did not clean up its SyncObserver properly when it received the OnSyncShutdown() event, causing a failed DCHECK() in browser tests. Bug: 88586 Change-Id: Ib37846afd26470563d58639e9fddff4928ffe907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510797Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#823184}
-
Dave Tapuska authored
The response from CreatePopupWidget is no longer used. So this method can be async. The browser will still allocate routing IDs for popup widgets though because there are a few global tables that it uses to track widgets based on the routing ID. BUG=1097816 Change-Id: I4a2dea41e7c796423d7072a72753b4e168f8261d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510790Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#823183}
-
Mirko Bonadei authored
Without this, the test fails to run because the filter file doesn't get isolated. Bug: 1143697 Change-Id: I810319036b68e5cd073652c1abc800f9f6eee1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514150Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#823182}
-
Francois Doray authored
My team is working on power consumption at least for the next year. This CL extends the expiry of histograms that we'll use to track our efforts. Fixed: 1138308 Change-Id: Ie4c59081f3cac36b99b952ec5c88bdabbe16aa87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510780 Auto-Submit: François Doray <fdoray@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#823181}
-
Leo Lai authored
FakeCryptohomeClient doesn't have any exsiting test items after re remove TpmAttestationSignSimpleChallenge. BUG=b:158955123 TEST=build ok. Change-Id: Ib533e261d1733f4449e2b3a783757279a35eefdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504011 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/5bee67fced90..74023424daa4 2020-11-02 dneto@google.com Remove stale TODO If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sarahmashay@google.com Change-Id: If9b9664e8b9de096024f38efc3df20bf37d7bbde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514234Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823179}
-
Nicolas Ouellet-Payeur authored
This is needed to enable DestroyProfileOnBrowserClose by default in automated tests (crrev.com/c/2503629). This caused issues during shutdown in browser tests, because TestSyncService behaved differently than ProfileSyncService. Bug: 88586 Change-Id: Ie3c6f202d251411eb316edd77180855ec0e9bc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511072Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This CL refactors tests in deep_scanning_browsertest.cc to use Connector policies directly instead of the indirect helpers that map to legacy policies. It also removes now unused DeepScanningClient{Request|Response} references from those tests. Bug: 1109242 Change-Id: I39f7d0cb1231d8f494ac7c58460eafee91691a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510239Reviewed-by: -
Jérôme Lebel authored
When the sign-in is successful in add_account_signin_coordinator.mm, an identity is needed. Change-Id: Ie1c930a7f07f4b1c14ae1a48c638df7c4644aa0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514398 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#823176}
-
Jan Krcal authored
This is a reland of d42167eb Compared to the original CL, this CL minimizes the changes in the test that was failing on Win7. Original change's description: > [Dice sync delegate] Split sync confirmation and sync disabled > > This CL splits the ShowSyncConfirmation() function of the dice turn on > sync helper delegate into one that shows the normal sync confirmation > and one that shows a error message that sync is disabled by the admin. > > Since both the dialogs are implemented by the same webUI page, there > is not much behavioral change. The only change is for the delegate > for the signed-in profile creation flow which opens a new browser > window and shows the dialog in this window instead of showing it in > the creation flow window. > > In follow-up CLs, the variant of the UI will be passed as a param > to the WebUI page replacing the logic to decide which variant to show. > > Bug: 1126913 > Change-Id: Ibac9a339c4fb071f960f15864482c818247f5719 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487100 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820222} Bug: 1126913 Change-Id: I741140df31b8ca91fe5eb1a05a643fc0d2401f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495069 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#823175}
-
Glenn Hartmann authored
BUG=1140066 Change-Id: I68726e9d31bf935e1bba04a8b07f8e86057b3e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510529 Auto-Submit: Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ic782c3df395360cc3c6c01540edcabb68a8bcbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514173Reviewed-by:
-
Peter Kasting authored
Bug: 772945 Change-Id: I0d5e8a37d2c24c165737359db6f7c4af85ea0774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507638 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#823172}
-
Javier Ernesto Flores Robles authored
- Wires the widget commands to the respective actions - Logs start action for widget - Adds TODOs in the places where specific action metrics will go Bug: 1138719 Change-Id: I2a10d029b0f0b8b1b100cc37b7a93274c939a33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511850 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#823171}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604307096-e67db33a1b3e023c027e084a5a169d3ae943db07.profdata to chrome-win64-master-1604318145-d42776d1d9d08b6fa8d7b373c065b46395fc90ba.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I07d11bb48f96087a5fc7dfede876022d3583352c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514196Reviewed-by:
-
Justin Cohen authored
Bug: 1144212 Change-Id: Ifd5e3be45c8e2d9c9fb6195681a00657e28bc0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510238Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ab23b358. With Chromium commits locally applied on WPT: 074062ef "css-pseudo: :first-line should not affect inline-blocks" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bajones@chromium.org: external/wpt/gamepad foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I50231f90bb7bdd274320f8a2d1cb955934f36d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512597Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823168}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011020600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/NDZtDGoSjqh7JHOfYKjuAocve7OHond9WDS2YlbZUgEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/165720635,b/170271605 Tbr: media-app@grotations.appspotmail.com Change-Id: I0f2505cbb3c0d8867dcd18ec46293b6bed061b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514231Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823167}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ba009e8ab84..5a41e47b6f39 2020-11-02 jobay@google.com Use Puppeteer's built-in `pierce/` handler 2020-11-02 alexrudenko@chromium.org Enable TypeScript for BackgroundServiceView.js 2020-11-02 yangguo@chromium.org [ts] Typecheck ExecutionContextSelector.js 2020-11-02 yangguo@chromium.org [ts] Typecheck CSSShadowModel.js 2020-11-02 jobay@google.com Roll Puppeteer from 5.3.1 to 5.4.1 2020-11-02 mathias@chromium.org Fix service worker capitalization 2020-11-02 yangguo@chromium.org [ts] Typecheck IsolatedFileSystemManager.js 2020-11-02 yangguo@chromium.org [ts] Typecheck BezierEditor.js 2020-11-02 changhaohan@chromium.org TypeScriptify elements/StylesSidebarPane.js part 2 2020-11-02 sigurds@chromium.org Refactor setColumnsVisiblity to use a set of string If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093296 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2d8f3249f371366d710a546c12ad1afef13d6a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514230Reviewed-by:
-
Mark Yacoub authored
1. Change is_disabled variables in CRTC Controller and Hardware Display Controller to positive connotation(is_enabled). 2. HDC doesn't have its own enable state now; instead, it checks the states of all CRTC controllers it manages. BUG=b/172069469 TEST=ozone_unittests, modesetting and disabling an external monitor Change-Id: I0f613616ef4dd219298432904c4acabf5f5335ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510690 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#823165}
-
Rob Clark authored
Different tracepoint, but on the kernel side, it intentially re-uses the intel_gpu_freq_change format. TEST=Locally, confirm chrome://arc-overview-tracing shows GPU freq on snapdragon devices BUG=b:145579089 Change-Id: I70aae6397736d14a0f59db9b41614aeefbc0bf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451649Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: Rob Clark <robdclark@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#823164}
-
Matthias Körber authored
Change-Id: I4a0afe4bfc41a2ab18514953a2be4fe61e11c2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508589 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#823163}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 88-4296.0-1603709458-benchmark-88.0.4305.0-r1 to 88-4296.0-1603709458-benchmark-88.0.4307.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I15c9e25df7b1ba23145d15d4419bc07b44e44538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514167Reviewed-by:
-
Anders Hartvoll Ruud authored
Until now we've only supported a single compound selector as an argument to :not(). This CL adds support for complex selectors, based on the recent work on :is() and :where(). Parsing ------- Note that unlike :is() and :where(), :not() does not use the forgiving selector list behavior, but instead fails parsing the normal way. CSSSelectorParser now has both ConsumeNestedSelectorList and ConsumeForgivingNestedSelectorList for the two behaviors. Our ShadowDOMv0-disabling logic should apply to complex :not() as well, but for backwards compatibility, we need to allow it whenever :not() _doesn't_ have a complex argument. The TreatAsNonComplexArgumentToNot() was added to detect this, which replaces the previous function CSSParserSelector::IsSimple. (When v0 is removed, we can remove this mess as well). Invalidation ------------ There was a bug in ExtractInvalidationSetFeaturesFromSelectorList: we're supposed to ignore any extracted features inside a :not(). For example, for ".a :not(.b)", we should not add ".b" to the invalidation set for ".a". In ExtractInvalidationSetFeaturesFrom- SelectorList there was code that attempted to block the inner features from "crossing" the :not()-boundary, but it incorrectly used the *outer* pseudo-type. In other words, when considering ":not(.b)", the pseudo-type would be kUnknown, since we are not (yet) inside the :not(). Instead what we need to do is check the pseudo-type of of the currently held simple selector. Now that we "block" inner features correctly at the :not() boundary, the check in ExtractInvalidationSetFeaturesFromCompound is not needed anymore. This in turns means we can remove several PseudoType params, which is nice. Matching -------- Now traverses a CSSSelectorList and uses MatchSelector. Beyond that it just works. Bug: 1139865 Change-Id: Iea5513445e54303ba0685cffc3b52dabc115b7f1 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0alTkXvDCL8/m/-ClOGvOJBAAJ Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507549Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#823161}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Iba66ea8f88598ce5de73405d7f7ccbc90ad8dc79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514457Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#823160}
-
Ben Mason authored
This reverts commit e859a79a. Reason for revert: IDS_NEARBY_CONTACT_VISIBILITY_OWN_SOME.png.sha1 is not a sha file. Original change's description: > [Nearby] Strings updates on contact visibility page. > > Removes the "Contacts" title and updates strings in the description for > each visibility mode to match the latest specs. > > Screenshots: > https://screenshot.googleplex.com/An6Ta8EDzfS3KZU.png > https://screenshot.googleplex.com/C5WwqifMeCnLhkH.png > https://screenshot.googleplex.com/C48HQVfgouJrhHF.png > > Strings spec: > https://docs.google.com/document/d/1s-KjC1mM4ZPYeYAO7oI8lXltS_1FaYYfMMnNDdbfRag > > Bug: b:168841167 > Change-Id: I5facb117242e22b838266c2fa5e2629b221e6794 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511852 > Reviewed-by: James Vecore <vecore@google.com> > Commit-Queue: Michael Hansen <hansenmichael@google.com> > Cr-Commit-Position: refs/heads/master@{#822914} TBR=vecore@google.com,hansenmichael@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:168841167 Change-Id: Ie19aa888c3914ac3e65fb330000199023e2a3b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514420Reviewed-by:
-
Yuki Shiino authored
Includes appropriate headers in case of not only typed arrays but also array buffer views, instead of using forward declarations. Change-Id: Ib214732bc8bbceab476cca78a9d6327919c1d4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512501Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#823158}
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. BUG=b:158955123 TEST=unit_tests. Change-Id: Ied7f9642ed3eb8d0c2fa1607468b31f8e139b7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505393 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
