- 21 Jan, 2020 40 commits
-
-
Stepan Khapugin authored
Removes HL feature flags and cleans up call sites. Since HL flag was used for EG2 launcher to verify that it can run Chrome with a feature flag, and the flag is removed, I add a new kTestFeature flag that we won't need to replace in the future because it doesn't actually correspond to any feature. Bug: 945334 Test: none Change-Id: Iec29898214e8bf9d46a8e39e1cce5db5abd7dba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007688 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733758}
-
Steve Becker authored
Both the sandboxed and native versions of the NativeFileSystem postMessage() test are flaky due to timeouts in the CI. Looking at recent results, these tests take 5 or more seconds to complete successfully. This amount of time is dangerously close to the 7 second timeout, which sometimes occurs, causing the flakiness. This change adds "meta timeout=long" to both test variants to extend the 7 second timeout to a longer value, which gives these tests enough time to pass. Bug: 1043435 Bug: 1043028 Change-Id: I73eab928bce53a36be8c33e4b6e5746e7195f16a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013580Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Steve Becker <stevebe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#733757}
-
rbpotter authored
These tests aren't run on any bots, so failures were not discovered until running them locally. Bug: 967861 Change-Id: Ic8070f375db4db94703ef24f0e9e36e04ed03ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008773 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#733756}
-
Paul Moy authored
Add a new mojo method, GetCrosHealthdDiagnosticsService, to wilco_dtc_supportd. This will allow the Chrome OS daemon to request an implementation of the CrosHealthdDiagnosticsService interface, which it will use to process diagnostics-related requests. running 'diag --action=get_routines' on a sarien board Bug: chromium:1040161 Test: manual testing by reverting crrev.com/c/1947112 and Change-Id: I055f16521caecc70da77c3e04c8a8b1e07613ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999106 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#733755}
-
Gang Wu authored
Implement copying image to android clipboard via context menu. UI review is https://docs.google.com/presentation/d/1YCYsjDRgqzfUklLLN_h1EtmQTTHUY89mC0lRmacvFLc/edit?ts=5e1d5808#slide=id.g7c8d36d508_1_0 Bug: 1043221 Change-Id: I3b1438e2dc6abae5934c33b8952038b7264a7b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008319Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#733754}
-
Charlene Yan authored
This reverts commit 3accf2ce. Reason for revert: I think this currently broke the build https://ci.chromium.org/p/chromium/builders/ci/GPU%20Linux%20Builder/194027 Original change's description: > Add code to generate PROMPT_FOR_SCANNING verdicts > > This CL adds the code needed to generate PROMPT_FOR_SCANNING danger > types. This danger type is used when an Advanced Protection user > downloads a file that is marked as UNCOMMON. It causes the user to be > prompted to send this file to Google for deep scanning. The generation > of these verdicts is guarded by a Finch flag as well as the user's > Advanced Protection enrollment status. > > It also removes the old Finch flag related to Safe Browsing performing > additional download scanning for Advanced Protection users, to > minimize confusion. > > Bug: 1020418 > Change-Id: I506c1ff5fd3d923f8817f4db16563996d937a418 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007984 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733747} TBR=mek@chromium.org,tedchoc@chromium.org,vakh@chromium.org,xingliu@chromium.org,drubery@chromium.org Change-Id: I45841a077b35c1383aee6f83471bdbe7dc4270da No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1020418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013645Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#733753}
-
Charlene Yan authored
This has started failing intermittently https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44040 https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44022 https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44014 TBR=karandeepb@chromium.org Bug: 1044265 Change-Id: Id21d3fb149a4df20652b6781d2fb9f1cd0b7ffa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013025 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
-
Charlene Yan authored
This has failed recently https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81325 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81301 TBR=tommi@chromium.org Bug: 1044271 Change-Id: I669538712db5618926e16bbecc22ba1cb96792a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013350Reviewed-by:
-
yilkal authored
This CL makes sure that SupervisedUserNavigationObserver is created only for supervised user accounts. This saves memory and processing time. Bug: 1043232 Change-Id: I5d13ce0261d07c29384f5ba5dc83e420ed3138dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008315Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#733750}
-
Azeem Arshad authored
This CL removes the use_messages_google_com_domain flag. This flag was used as part of migrating users of Android Messages integration in ChromeOS to the new google.com subdomain. This migration is complete and the flag is not required anymore. Bug: 1043416 Change-Id: Ic797c5f57c7355734d2c44ce913928745bd755c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008771Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#733749}
-
Brandon Wylie authored
As a follow-up to reparenting the current Tab when the theme is changed, this CL reparents the entire TabModel. When the theme is swapped, first the foreground tab is detached, then all other tabs are detached in tab index order. When the app restarts, the tabs are reattched in reverse tab index order (attaching the last, second to last), added as the first tab with the exception of the foreground tab, which is left out. After the tabs are stacked, restoring the original ordering, the original foreground tab is added at the correct index. Bug: 944302,1031332 Change-Id: I7eb1465157500e7f1f6c1da79240c96f38c9b6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974992 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#733748}
-
Daniel Rubery authored
This CL adds the code needed to generate PROMPT_FOR_SCANNING danger types. This danger type is used when an Advanced Protection user downloads a file that is marked as UNCOMMON. It causes the user to be prompted to send this file to Google for deep scanning. The generation of these verdicts is guarded by a Finch flag as well as the user's Advanced Protection enrollment status. It also removes the old Finch flag related to Safe Browsing performing additional download scanning for Advanced Protection users, to minimize confusion. Bug: 1020418 Change-Id: I506c1ff5fd3d923f8817f4db16563996d937a418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007984 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#733747}
-
Saman Sami authored
Don't keep track of owned planes directly in HardwareDisplayController. We already know the set of owned CRTCs and we can ask the plane manager to find the planes corresponding to those CRTCs. By removing |owned_hardware_planes_| from HardwareDisplayController, we reduce the amount of state that has to be protected by a lock if we wish to perform pageflip testing on another thread (see the bug for more context). TEST=Built and ran on eve and chell. Connected and disconnected an external monitor. There is also plenty of existing unit tests that cover this code. Bug: 1034559 Change-Id: I16fccc549c272c8659d392996a163877ac7bd7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003561 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#733746}
-
Natalie Chouinard authored
Following the naming conventions decided in go/clank-preferences-refactor, this change replaces the "Preferences" suffix with "Settings". Skip presubmit to avoid AlertDialog checks for existing usages. NOPRESUBMIT=true Bug: 1030446 Change-Id: I86ee42fd63fb808840306bee99cdc762c5a86444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003757 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#733745}
-
Manuel Rego Casasnovas authored
This patch adds two tests related to transforming the root element background, to avoid regressions in the future. First is a static test that was passing in Chromium but failing on Firefox. Now it's also failing in Chromium after r733661. The other one is a dynamic change that has been fixed recently in Chromium (see crbug.com/898293). BUG=988446 Change-Id: Id33bdd07c8911f4eba419dc553ece24b7ad40300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007692 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#733744}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8effa4d0637c..d339e36642df git log 8effa4d0637c..d339e36642df --date=short --first-parent --format='%ad %ae %s' 2020-01-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d339e36642df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ic7d7df1b0b48daaeccc3e6e2877c63df1807c65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013305Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733743}
-
Kurt Horimoto authored
This interaction handler is a subclass of InfobarModalInteractionHandler that exposes functionality handling the dispatch callbacks that can be sent for the InfobarPasswordModalDelegate. Additionally, this CL adds a callback installer subclass that handles setting up the callbacks to handle these dispatched comments and forward them to the interaction handler. Bug: 1030357 Change-Id: I07e5b872ebd1c8998333a1ad9369529942bf5fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001525 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#733742}
-
George Burgess IV authored
Bug: None Change-Id: I732bc38f4a541cbafb85501d3b6e72dafa36762e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994103 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#733741}
-
Garrett Beaty authored
Change-Id: I79ceaba42d5ad5440f03e58ac493f8a14c148da0 Bug: 1011908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013581 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#733740}
-
Albert Chaulk authored
This reverts commit 8985ccdc. Reason for revert: not needed, already plumbed through different path Original change's description: > Add CastContentWindow::SetCanGoBackQuery > > This allows querying the CanGoBack status of the underlying app > > Bug: b/145762033 > Test: None > Change-Id: I330d7124dd7817db69f5ff41bfa58f6059971113 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008066 > Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org> > Commit-Queue: Albert Chaulk <achaulk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733446} TBR=achaulk@chromium.org,dnicoara@chromium.org,halliwell@chromium.org,seantopping@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/145762033 Change-Id: I668bc87b91d7e70d70c04b995a98d6d756ad5808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013464Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#733739}
-
Alex Ilin authored
This CL implements display of the remote consent dialog for the new consent flow. As before, the consent page is opened in a separate window within the IdentityApiUiApp. The new dialog, however, doesn't wait until the page is redirected or the page title changed. The consent page passes the consent result via private JS api that is yet to be implemented in the next CL. For now, the browser never gets the result back. After the consent result is get, the browser should send a request to IssueToken endpoint. This part hasn't been implemented yet. (see NOTIMPLEMENTED() in IdentityGetAuthTokenFunction::OnGaiaRemoteConsentFlowCompleted()). Bug: 1026237 Change-Id: I105f4036a4b2ae85eed4b29d810b9fe3bea2c6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997303 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#733738}
-
Daniel Rubery authored
Now that the enhanced warnings for Advanced Protection users is rolled out, and the flag has been removed, there is no need to have separate methods "RequestsAPVerdicts" and "is_under_advanced_protection". Combine these into one method, "IsUnderAdvancedProtection", and allow that to be overridden by a command-line flag, for testing purposes. Bug: 1020418 Change-Id: Id97147d0874b662a2065b06a9dafc0471d232505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003909 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#733737}
-
Anastasia Helfinstein authored
This CL updates Switch Access nodes to respond to childrenChanged events to update the cached tree structure, as needed. Bug: 1023035 Change-Id: Id24d489424caabbfc04f4a3e4f3d16eca05c8069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003397Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#733736}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 1042208 Change-Id: I67735b8ba1959215dadfc02be8e6c24306aac059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007424 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#733735}
-
Robbie McElrath authored
This CL adds the following flags which will allow developers to change the behavior of WebView's finch seed download implementation without needing to modify any code. * finch-seed-expiration-age * finch-seed-ignore-pending-download * finch-seed-min-download-period * finch-seed-min-update-period These flags will allow us to more easily test that seeds are being downloaded correctly. This also moves AwSwitches to a common package so it can be read from the service as well. Test: Set the flags and verify they work as expected. Bug: 1035235 Change-Id: Ia0f179a6370218f7284e89634a637544ceb247c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002897 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#733734}
-
Sylvain Defresne authored
[ios] Use chrome_browser_state_forward.h in /ios/chrome/browser/ui/browser_view/browser_view_controller.h Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=edchin@chromium.org Bug: 1042208 Change-Id: I688fe5a45fa2fccf07e3e5688003857f71963a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007465 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733733}
-
Henrique Nakashima authored
A build target :java is preemptively created to add a downstream dependency before moving ChromeFeatureFlags into it. In the near future, ChromeSwitches and FeatureUtilities will be moved here as well. This is CL 1/3 to move ChromeFeatureList to chrome/browser/flags:java Bug: 1041468 Change-Id: Ifa8ba170a44f61769f57650b405d4e5302c37107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013344Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=edchin@chromium.org Bug: 1042208 Change-Id: Ic72a6611ab418566180ee72608e1115b1d1e9db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007816 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=edchin@chromium.org Bug: 1042208 Change-Id: Ie97c0f54434c8cb5aaa030e0fa54b05b5466032a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007466 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Greg Daniel authored
This reverts commit 9feadb9f. Reason for revert: Fix has landed in chrome Original change's description: > Suprress failing tests Pixel_WebGL (vulkan_pixel_skia_gold_test) > > Skip failing tests of vulkan_pixel_skia_gold_test: > Pixel_WebGLGreenTriangle_AA_NoAlpha > Pixel_WebGLTransparentGreenTriangle_NoAlpha_ImplicitClear > Pixel_WebGLGreenTriangle_NoAA_NoAlpha > > TBR=bsheedy@chromium.org > > Bug: chromium:1042693 > Change-Id: I9dc03d61a9e28a6b035a33058acff27697f23df0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003557 > Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org> > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732444} TBR=bsheedy@chromium.org,behdadb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1042693 Change-Id: I0195d6c320cecacb91420a40fe695235e4a95cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012906Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#733729}
-
Shakti Sahu authored
This CL handles some histograms that are reaching expirations. Removed histograms : Download.Service.Files.Cleanup.Attempts.* Android.DownloadManager.Chips.Enabled Extended histograms : Android.ThumbnailDiskStorage.* Android.DownloadManager.Thumbnail.MaxRequiredStretch.* Android.ThumbnailProvider.BitmapCache.Size.* Android.ThumbnailProvider.CachedBitmap.Found.* Download.Service.Upload.HasUploadData.* Download.Start.ContentType.NormalProfile.* Bug: 1037057, 1037482, 1037054, 1034594, 1034593, 1034592, 1034586, 1034584 Change-Id: I5d7e42d98e79e3cd2cde0b90b5b831b915d86b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000970 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#733728}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/804b4adfa9e9..8f5aa560c98d Created with: gclient setdep -r src-internal@8f5aa560c98d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042208 Tbr: jbudorick@google.com Change-Id: I2cc09b2c6573d03f7bf3ed2327ed3cdfdcf83044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013207Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733727}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=edchin@chromium.org Bug: 1042208 Change-Id: I21c2b6e63b6b329eb215bef2dc87b15f4fb872b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007580 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Marc Treib authored
Bug: 983940 Change-Id: Ie46727c855e23f5c8f4b33767275fd2c97ea436c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010798 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#733725}
-
Brandon Wylie authored
When focusing/unfocusing the omnibox with the search engine logo feature enabled, there are some bad looking omnibox transitions where it will go from padlock -> globe -> search loupe when focusing, and search loupe -> globe -> padlock when unfocusing. Adding in logic to smooth out these transitions and adding some unit tests along the way. Bug: 1031232 Change-Id: I03f9a97a0900e9ddcef95bd9f80bc5572750b567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990208Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#733724}
-
Anastasia Helfinstein authored
This change removes code that sets the role of the above icons to button. Having this annotation prevented Switch Access from opening the status tray, and did not provide useful semantic information for ChromeVox or other accessibility features. Bug: 1023006 Change-Id: Ieb8e5389bbd9444617f3fbcdf1a6d08e805803bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005815Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#733723}
-
Julian Pastarmov authored
The histograms still deliver useful metrics about the usage and health state of the feature. Bug: 1037331 Change-Id: Id7d8cf148bcf3e933674de03202cc236e6f76404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011802 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#733722}
-
Bettina authored
Use signon_realm as std::string instead of GURL because the signon_realm in Android is a string in password_specifics. To make it compatible for all platforms and easier to maintain, use a std::string all around. The only method that isn't touched here is RemoveRowsByUrlAndTimea as it uses a filter that needs a GURL. Bug: 1042117 Change-Id: I7c63981d4dd608ea22da8906a2d4144c08e8787c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001346 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
-
Alex Cooper authored
Shows the status of the AR/VR permissions on the Android PageInfo bubble and in site settings. Strings are placeholders Bug: 1033592 Change-Id: I694ff1f8af812acdafd4be3446e9f31751a8d3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994304 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 30 histograms that show frequent access in the past 90 days. These are the 86% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-07-19. Change-Id: If175be9590842bf9db2d73e696c2830615afbd11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012828 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
