GitLab

* Depends on https://codereview.chromium.org/394903005/ which makes the shell kill app threads on exit.
* Adds tests that verify basic functionality and termination of NetworkService by the shell.

BUG=378155, 394477
R=darin@chromium.org

Review URL: https://codereview.chromium.org/397733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285396 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Telemetry: Initialize smoothness and thread_times metrics before page load, not after. (https://codereview.chromium.org/392613002/)

Reason for revert:
Breaks smoothness tests on N4 (at least) with no frames error. Possible this is a legit perf regression? But reverting anyway to green things up.

http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf/builds/1115

Original issue's description:
> Telemetry: Initialize smoothness and thread_times metrics before page load, not after.
> 
> Currently both smoothness and thread_times initialize their metrics after page
> load. This leads to a gap between the page load and the page actions starting.
> This patch moves the initialization before the page load, thus eliminating the
> gap. It is safe to do so because smoothness and thread_times require a page load
> before each run (even when repeating the same page).
> 
> Note to perf sheriffs:
> This patch is likely to cause performance numbers to worsen, because the browser is often more busy immediately after page load. If you get alerts related to this CL, feel free to ignore them. If there is a reference build for the bot, the number for the reference build should also change accordingly.
> 
> BUG=392895
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285297

TBR=skyostil@chromium.org,picksi@google.com,dominikg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392895

Review URL: https://codereview.chromium.org/419623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285395 0039d316-1c4b-4281-b951-d872f2087c98

Bug introduced in Issue 407303003

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/417013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285394 0039d316-1c4b-4281-b951-d872f2087c98

This has the side effect of fixing the crash in 396368

BUG=396368
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/411813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285393 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396169

Review URL: https://codereview.chromium.org/416113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285392 0039d316-1c4b-4281-b951-d872f2087c98

transition-entering-stylesheet is parsed out from the response header of the incoming page and passed to the Java side.

Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit#
Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5

BUG=370696

Review URL: https://codereview.chromium.org/387703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285391 0039d316-1c4b-4281-b951-d872f2087c98

In 2010 safe-browsing storage was rewritten to use a binary format
instead of SQLite, with support for SQLite removed in 2011 (r74253).
Remove the code which detects and histograms this, as there is no
possibility that anything will be done with that data.

Additionally, remove code to delete even older SQLite files left from
the original safe-browsing implementation.  This code is firing a few
thousand times per month, but it is hard to imagine any scenario where
profiles that continue to contain this data are not horribly broken.

BUG=none
R=asvitkine@chromium.org, feng@chromium.org

Review URL: https://codereview.chromium.org/404803006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285389 0039d316-1c4b-4281-b951-d872f2087c98

This is causing mysterious output failures on the bots

TBR=phajdan.jr

Review URL: https://codereview.chromium.org/412263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285388 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE

Review URL: https://codereview.chromium.org/413133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285385 0039d316-1c4b-4281-b951-d872f2087c98

These seem to be unused.

R=kbr@chromium.org

Review URL: https://codereview.chromium.org/419543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285384 0039d316-1c4b-4281-b951-d872f2087c98

An example HID gadget implementing the standard HID mouse protocol.

BUG=396682

Review URL: https://codereview.chromium.org/418603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285383 0039d316-1c4b-4281-b951-d872f2087c98

They both had implementations of RealNode.

Also update examples/tutorial/testing so that it shuts down
the NaCl module correctly.

TEST=trybots
R=binji@chromium.org

Review URL: https://codereview.chromium.org/414993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285382 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/418063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TBR=piman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/412383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285380 0039d316-1c4b-4281-b951-d872f2087c98

deps in common section above.
configs in executable section below (and shouldn't be in libs anyway).

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/416183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285379 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397137,396244
TEST=chrome_elf_unittests
NOTRY=true

Review URL: https://codereview.chromium.org/418033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285377 0039d316-1c4b-4281-b951-d872f2087c98

This gets rid of most of the non-webrtc/jingle linker errors for webkit_tests.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/419613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285375 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285374 0039d316-1c4b-4281-b951-d872f2087c98

2f5469c Export include directories to dependents in GN.
493daf5 Update the format table to check support for filtering and rendering.
4836d22 Fix ASSERT when rewriting else-if blocks with no else.

TBR=jmadill@chromium.org

Review URL: https://codereview.chromium.org/420463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285373 0039d316-1c4b-4281-b951-d872f2087c98

It turns out that a few bots have psutils 0.4.1 and the set_cpu_affinity API was
introduced in 0.5. I'm investigating why bots have differing versions, but for
now this patch makes us robust to any psutil version.

BUG=395228

Review URL: https://codereview.chromium.org/407303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285372 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395655
R=oshima@chromium.org
TEST=athena_unittests

Review URL: https://codereview.chromium.org/414903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285371 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396388

Review URL: https://codereview.chromium.org/419463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285370 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285368 0039d316-1c4b-4281-b951-d872f2087c98

Previously an identifier used as the list in a feoreach statement would not count as "using" the identifier, which would give unused variable errors. Added a unit test.

Checks for unused identifiers in component(). Previously these were not checked. This checking turned up a misspelling in the cc build. Added a unit test.

Fixes for the ozone media build (turned up when testing).

R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/420443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242216

Review URL: https://codereview.chromium.org/414023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285366 0039d316-1c4b-4281-b951-d872f2087c98

Instead of just the small white-bar, allow dragging the entire width of the
minimized home-card to get into the overview mode.

BUG=396867
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/416963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285365 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364612

Review URL: https://codereview.chromium.org/416833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285364 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the GN build for the ui/ozone component (and tests). The
following build should work going forward:

 gn gen out_gn_ozone --args="use_ozone=true"
 ninja -C out_gn_ozone -j1000 -k50 ozone_egl_demo ozone_unittests

BUG=396316
TEST=compile & run ozone_egl_demo, ozone_unittests
TBR=darin

Review URL: https://codereview.chromium.org/409163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285362 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/418983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285361 0039d316-1c4b-4281-b951-d872f2087c98

chrome/app/generated_resources.grd: added messages for
DOWNLOAD_INTERRUPT_REASON_SERVER_UNAUTHORIZED
content/browser/download: handling of
DOWNLOAD_INTERRUPT_REASON_SERVER_UNAUTHORIZED

BUG=386146

Review URL: https://codereview.chromium.org/351863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285359 0039d316-1c4b-4281-b951-d872f2087c98

Additional compile time checks are being added to Skia and since
MSVS compilers don't support querying the compiler for support we
must manually set the values. This mirrors what has already been
done in the main Skia repo.

Review URL: https://codereview.chromium.org/416833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285358 0039d316-1c4b-4281-b951-d872f2087c98

bootstrap.py:
+ Fixed build (missing/wrong compile flags)
+ Added -s option to stop before trying to rebuild GN with GN
+ -v option passes -v to ninja
+ Use env vars CC, CXX, CXXFLAGS
+ Added mac support

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/403463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285356 0039d316-1c4b-4281-b951-d872f2087c98

This patch just renames some variables to be more consistent with
each other.

The new pattern is:
current_<type of rect>_rect_

R=reveman

Review URL: https://codereview.chromium.org/413863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285355 0039d316-1c4b-4281-b951-d872f2087c98

This is failing on our new 64-bit devices:
https://uberchromegw.corp.google.com/i/clank/builders/volantis-official-perf-clankium-lmp/builds/15/steps/dromaeo.jslibeventjquery/logs/stdio

BUG=392153

Review URL: https://codereview.chromium.org/400493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285354 0039d316-1c4b-4281-b951-d872f2087c98

To avoid false-positive reports from UBsan's vptr instrumented Chrome,
sources/functions/types are blacklisted. The reasons for each blacklisting is
accordingly commented.

BUG=174801
R=aarya@google.com

Review URL: https://codereview.chromium.org/405643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285353 0039d316-1c4b-4281-b951-d872f2087c98

R=wfh@chromium.org
BUG=51909
TEST=Verify that chrome still runs on Windows Server 2008

Review URL: https://codereview.chromium.org/417923006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285352 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/415143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285351 0039d316-1c4b-4281-b951-d872f2087c98

This changes the semantics of the public system API: instead of
(attempting) to returning "invalid argument" (e.g., when you pass a null
pointer for a required argument), we'll crash/trap/kill you.

The reason for this is that it's not really sensible to check pointers
up front in the face of threads doing different things (e.g., memory
that is valid to read to/write from at the beginning of a call may not
be valid later).

As such, we wrap "user" pointers in a (new) |UserPointer<>| class, and
provide ways of accessing the memory that they refer to. We should never
pass around user pointers as plain pointers. (This careful treatment
will probably already be needed to properly support NaCl, for example.)

Still to do (but this change is already too big):
* Update comments (in mojo/public/c/system).
* Properly convert the remaining user pointers being passed around as
  plain pointers. This includes:
  * Getting rid of |GetPointerUnsafe()| and also the existing
    |VerifyUserPointer...()| functions.
  * Changing how we handle the various options structs.
  * Changing some of the |Dispatcher| interface.
* Write tests for |UserPointer<>|, etc.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/418033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285350 0039d316-1c4b-4281-b951-d872f2087c98

The data referenced by c_str() is only valid as long as the
std::string is still live, so hold std::string values
on the stack.

This was causing tests to fail on my Trusty laptop.

BUG=
R=binji@chromium.org

Review URL: https://codereview.chromium.org/414843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285346 0039d316-1c4b-4281-b951-d872f2087c98

First off, create a new window manager app (wm_flow_wm) which uses the core_window_manager_lib static lib to implement a basic WM.

Second, create a new demo launcher (wm_flow_init) that starts the view manager, embeds wm_flow_wm, and starts an additional app (wm_flow_app).

Thirdly, creates an additional app (wm_flow_app) that also connects to the view manager init service and asks it to embed it somewhere, thus giving it a connection to the view manager (and a top-level window).

I had to change ViewManagerInitService to have some shared state so that it was possible to connect to it > 1 time.

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/400113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285345 0039d316-1c4b-4281-b951-d872f2087c98