- 16 Sep, 2020 40 commits
-
-
Peter Wen authored
New API related checks are some of our most valuable lint checks, as triggering an error causes a crash directly. This CL adds compile test targets to ensure that code with API level errors trigger lint warnings. This prevents lint being accidentally turned off. Also delete now obsolete //build/android/lint directory and remove some already-fixed suppressions from lint-suppressions.xml. Bug: 1108309 Change-Id: I87e68c85ae6670b1c8a1f0691600e021477c2ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412808 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807625}
-
Dale Curtis authored
TBR=timvolodine Bug: 1128184 Change-Id: I6706ce9037397f745a96925898aa48196f40273e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414840Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807624}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I0bd3fe7701e87e03395214ba2f16a2cf9743e86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415011Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807623}
-
chinsenj authored
With the InteractiveWindowCycleList flag enabled, hovering an item in the window cycle list scrolls the list to that item and moves the selector over it. This causes an issue if the window cycle list extends past the screen and a user hovers over an item on one of the ends of the list. To address this issue, this CL makes it so hovering an item only moves the selector. Test: Manual Bug: 1067327 Change-Id: Iaba916d7e24391ea8cff6d82c4a405c1e89ccd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409604 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#807622}
-
Adam Langley authored
This change mostly updates FidoTunnelDevice to add support for state-assisted (i.e. paired) transactions. That also involves some handshaking updates because the state information signs the claimed public key and so the handshake needs to export a binding value to sign over. BUG=1002262 Change-Id: Ib84886baacef24a8f55014b1a9b33617d0122d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406834 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#807621}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1592361414e0..7b1620f36648 2020-09-16 mtklein@google.com refactor skvx min/max 2020-09-16 ethannicholas@google.com moved BinaryExpression's data into IRNode 2020-09-16 michaelludwig@google.com Revert "Enable novel GrClipStack on bots, disable elsewhere" 2020-09-16 mtklein@google.com in fm_bot, use -foo to remove a source 2020-09-16 michaelludwig@google.com Enable novel GrClipStack on bots, disable elsewhere 2020-09-16 mtklein@google.com add another q14x2 test 2020-09-16 robertphillips@google.com Add initial GrThreadSafeUniquelyKeyedProxyViewCache implementation 2020-09-16 nifong@google.com Add a method of returning the list of commands that use an image 2020-09-16 brianosman@google.com Move constant swizzle handling into the IR generator 2020-09-16 johnstiles@google.com Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 csmartdalton@google.com Add a quadratic cusp to trickycubicstrokes 2020-09-16 johnstiles@google.com Add support for ShaderCapsFactory to skslc. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: scroggo@google.com Change-Id: Icb58fcc9b4dbb5aed522480400d9fc189238a4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414854Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807620}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/78e9acd96726..804db2dde3f1 2020-09-16 kwiberg@webrtc.org UntypedFunction: Eliminate an unnecessary indirection in the implementation 2020-09-16 hta@webrtc.org Test for negotiating pre-stopped M-sections. 2020-09-16 peah@webrtc.org Allow the SwapQueue to utilize user-define swap capability 2020-09-16 hta@webrtc.org Don't expect a transceiver for stopped m-sections If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1127625 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib273380e67f4ec6b635087f301fd64ea343d4371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807619}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b14a3f7cf6d0..3504e85b742c 2020-09-16 fmayer@google.com Merge changes I26d1c6e5,I9ceaa1ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie23dc2b1a791138130c08f5892abc42299b010cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807618}
-
zhaoyangli authored
Make code and comments inclusive. Bug: None Change-Id: I4d22a5c1213681e52371f194170f4831f1aa0171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411406 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807617}
-
Dale Curtis authored
This reverts commit fdcd8d21. Reason for revert: Broke the win32-official build: https://ci.chromium.org/p/chromium/builders/ci/win32-official/546 Original change's description: > Roll DevTools Frontend from f5ee7c40c31b to 4f6dfcfe8801 (4 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f5ee7c40c31b..4f6dfcfe8801 > > 2020-09-16 jegarc@microsoft.com Normalize ShadowSwatchPopover behavior > 2020-09-16 jacktfranklin@chromium.org Fix loading images in components server > 2020-09-16 andoli@chromium.org Disables flaky e2e test on the Issues tab > 2020-09-16 jacktfranklin@chromium.org Migrate heap snapshot multiple retainers layout test > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1110817,chromium:1126496,chromium:1128534 > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: Ib42c838d72f264996cfbb6b399266edb0d401dce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414609 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#807561} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I045001716536fcbebc8847c5c62d1e6e296bdd38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1110817 Bug: chromium:1126496 Bug: chromium:1128534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414626Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807616}
-
David Bienvenu authored
A few cpp lint fixes, no functional changes. Bug: 1010217 Change-Id: Ia08f6fe65e937d0155e3b25184d061d7bd736f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412748Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807615}
-
Haiyang Pan authored
Bug: 1099916 Change-Id: I76e4473a95e9273283fa39cdd62a9c51404444c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414830 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#807614}
-
Elly Fong-Jones authored
Instead of overriding GetWindow{Title,Icon}, use the explicit setters for these values, and don't store the title/icon locally. Bug: 1075649 Change-Id: Ic69156fa8c5265bb2b421e9a56470ad5812c84be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412987Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#807613}
-
Garrett Beaty authored
Bug: 1128877 Change-Id: I28384ff12cb87aa62d4bed9e83ef6163aef25de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414835 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#807612}
-
Rakib M. Hasan authored
android, wpt: Add chromium side changes to add optional try bot that will run WPT on all Android browsers This try job can be manually triggered for a CL. It will the full WPT suite on all Android browsers. Follow up to crrev.com/c/2411482. Bug: 1050760 Change-Id: I4ebdcf122ab3c01758fd9724e3543a9b3bec84bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412759Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#807611}
-
Leonard Grey authored
No actual WebUI code added yet; this is just the layer that sets everything up and handles communication. Bug: 1014639 Change-Id: Ie121d6c02d4d92b84eb24d3412291f93b40de09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380670Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#807610}
-
Christopher Cameron authored
Allow GpuMemoryBuffer handles to be provided even when they weren't requested. There is precedent for this already, for texture mailboxes. This becomes an "upgrade" of a shared memory buffer. Bug: 1125879 Change-Id: I2abdaf0d0331899d3463c0f9cb8afc2519cbeed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408880Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#807609}
-
zhaoyangli authored
This change makes DeviceTestRunner also run target as XCTest by checking xctest arg. Before this change, DeviceTestRunner uses solely the existence of ".xctest" to determine if the target should run as XCTest. This can cause trouble when targets build .xctest in but do not wish to run as it. The goal is to only use xctest arg to determine if it should run as XCTest. These follow up CLs are needed to achieve the goal: - Change device XCTest unit test configs in multiple repos. - Remove the logic of using xctest_path to determine if run with xctest, add a check to ensure xctest path is there when xctest is true. Bug: 1085603 Change-Id: I07e5f21467791295e8ecc5f6246e58fd696d5e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412970 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807608}
-
David Gilhooley authored
Fuchsia threads will no longer be killable. Replace the death tests that kill threads with code that causes the thread to exit itself. Change-Id: I551dbbe454b4ca0b803f73c8295c55e9888f1ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413533 Commit-Queue: David Gilhooley <dgilhooley@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#807607}
-
Tom Anderson authored
BUG=1066670 R=sky Change-Id: I143ec40265e7b9787c948be67f3695fce79634d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412472 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#807606}
-
David Bertoni authored
These tests were disabled for flakiness many years ago. They passed 3000 iterations on the bots without failures. Bug: 68287, 128412 Change-Id: I4196dbd345aebbacbe3d378fd76a21990234b930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404406Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807605}
-
Matthias Körber authored
Currently the AutofillProfile::Compare() method ignores the new address tokens since those are not actively used by the profile. This results in sync updates containing the enhanced address tokens not being propagated to the local store. With this CL the new address tokens are checked by AutofillProfile::Compare(). For mergeabibility, the changes are entirely guarded by a finch flag. Change-Id: Id1fac25642d32bfca4c484aa54655c57a3e851fe Bug: 1129006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414272 Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#807604}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1a6e1152b10b..cb190dce089b 2020-09-16 sadrul@chromium.org [rendering benchmark] Remove a noisy metric. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:894287 Tbr: oysteine@google.com Change-Id: Iddc3d08b3eb5b116dab46d3fefec83e55c1b4329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414547Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807603}
-
David Bertoni authored
This test was disabled a long time ago and it's no longer flaky on Mac. Bug: 70511 Change-Id: I3590a976477cdd094973582b50d1f1df08dcca12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410617Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807602}
-
Danan S authored
Bug: 1128446 Change-Id: I6f6616186fd2cb4bf5e6e7a5c422b3b2f052967b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411653 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#807601}
-
David Bertoni authored
These tests are no longer flaky. Bug: 238705 Change-Id: I1e0b84122a2cc7d2581a9dff8007a5f31d7b00f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411470Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807600}
-
John Williams authored
This change also moves generation of the notification ID to the notification item itself. Bug: 1107164, b/161612881 Change-Id: Ie043c8810878ff357027076205f45b7f194da43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414311Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#807599}
-
Bryan Bernhart authored
Call to RequestAdapterAsync() left the properties struct uninitialized, which leads to failure should the GPU not support ALL extensions. This fix ensures the device properties struct is always initialized to zero. Change-Id: I013df8e4434485d6ef79161fea3c81ed86260437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411407Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Cr-Commit-Position: refs/heads/master@{#807598}
-
Arnaud Mandy authored
Origin Trial feedback was that webNFC is better without filtering. NDEFScanOptions now does not need to carry information like recordType or mediaType as we are not matching them against active watchers anymore. Spec changes: https://github.com/w3c/web-nfc/issues/560 https://github.com/w3c/web-nfc/pull/565 Bug: 520391 Change-Id: I642cff9e72745728f41ad74e803d971a3126ddad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401020Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#807597}
-
Matthew Crabill authored
This change adds a MissedDeadlineFrames UMA that tracks frames that miss the vsync deadline during scroll/animations. Bug: 1092938 Change-Id: I044985583193d94c90485f1308be5645d553af7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343642 Commit-Queue: Matthew Crabill <macrabil@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#807596}
-
Robert Liao authored
Change-Id: Id5e17a6efcfe809f18efc0c0346e939e45dc5993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414620 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#807595}
-
Darwin Huang authored
render_process_id is a much more common name for this process identifier variable. Refactoring change only. No functional changes intended. Change-Id: Iefe4ce12ab1583031a031d1789ceafff4204b9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413018 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#807594}
-
Rohit Agarwal authored
This CL adds unit tests for LocationBarModel#getProfile and revert the changes in javatests/*/LocationBarModelTest before crrev/c/2409298 Bug: 1128073 Change-Id: Ib41b443bd9d40ec2559aaff972bda642d999dcda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410482 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#807593}
-
Li Lin authored
Expose ShowWidget through ParentAccessController interface. Bug: 1123722 Test: Manual Test Change-Id: Id1ba3232dfeb54977647389e0c03b086b4f9dbc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391500Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807592}
-
danakj authored
The code has moved, so update the includes. TBR=avi@chromium.org Bug: 1091083 Change-Id: Idabdf8500519fd08befb76911b494f3a62ed350f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412367 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#807591}
-
Miguel Casas authored
crrev.com/c/2268540 and crrev.com/c/2268600 started changing the names of the flag sent from ChromeOS command line builder to Chrome, namely from: --force-disable-new-accelerated-video-decoder to: --platform-disallows-chromeos-direct-video-decoder Previous CLs essentially made both be set or not at the same time [1], and this CL continues that refactoring chain by making Chrome aware of the new name. The next CL will finally remove the "old" name. This should have happened earlier but somehow I got sidetracked... [1] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/platform2/libchromeos-ui/chromeos/ui/chromium_command_builder.cc;l=534-537 Bug: b/159825227 Change-Id: I2a9a8527fc66c114ccad37197c5cfdad39e21f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398905Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#807590}
-
Charlie Hu authored
This CL splits font-display tests into smaller individual tests. The split has following benefits: - Clear obstable for implementation of violation report deduplication - Make the tests stricter. Before the test can verify there are 4 violation reports generated, but cannot tell which 4 cases generate violation reports. Previously there was an attempt on isolating tests into subframes (https://chromium-review.googlesource.com/c/chromium/src/+/2227863), but failed due to flaky crash in network cache (crbug.com/1087277). Bug: 1087277 Change-Id: Ifad35b40d112956fb00fd680b329e539a8762ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405916 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#807589}
-
Joshua Pawlicki authored
This script will be uploaded along with the updater artifacts to the signing infrastructure, where it will be run to produce signed builds of the updater. It is also possible to run it locally, provided the developer has all the necessary dependencies. Bug: 926234 Change-Id: I75ff5989b7e1fe3732b5ec43709ff13bfa67029e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393063 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807588}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b33e0b36a08c..fe878dedd5ad 2020-09-16 hidehiko@google.com Expand is_linux to is_linux || is_chromeos. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1110266 Tbr: swiftshader-team+autoroll@google.com Change-Id: I9cb19f5a8b2125f3ab39df66d4fb09f56ca1735c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414532Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807587}
-
Ken MacKay authored
Fix a bug where the default volumes were not loaded correctly. Also add more logging. Bug: internal b/167692705 Change-Id: I0e580422d3473f05ca9f4939407138f1e57aea3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414833 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Auto-Submit: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807586}
-