GitLab

Permission bubbles on Mac would not re-display for new permissions after
dismissing a bubble with ESC.

The root cause is that ESC would close the bubble, but not clean out the
pending requests. This change ensures pending requests are removed when
a bubble closes, for whatever reason.

BUG=385088
TEST= 1) Navigate to adrifelt.github.io/demos/all-permissions.html
      2) Click on location, observer permission bubble popping up.
      3) Click in permission bubble to give focus to bubble - DO NOT
         click on any UI elements in the bubble, just the text.
      4) Press ESC, observe bubble being dismissed.
      5) Click on "notifications" on the web page. With the change,
         observe a new bubble. Without, no new bubble.

Review URL: https://codereview.chromium.org/1137543004

Cr-Commit-Position: refs/heads/master@{#330950}

Revert of First pass BackgroundTracingManager. (patchset #15 id:450001 of https://codereview.chromium.org/1089253003/)

Reason for revert:
Failed TSan Tests.

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20TSan%20Tests/builds/4795

Original issue's description:
> Skeleton for BackgroundTracingManager.
>
> This version mostly just directs the TracingController using the specified BackgroundTracingConfig and pushes the compressed trace out to the BackgroundTracingUploadSink.
>
> Specifically, we implement the PREEMPTIVE_TRACING_MODE for the rule MONITOR_AND_DUMP_WHEN_TRIGGER_NAMED, which should allow us to get an experiment going on desktop with a simple trigger and upload.
>
> We can then follow up with additional CL's implementing the rest of the functionality from the clientside doc below.
>
> Needs to land first: https://codereview.chromium.org/1088673003/
>
> Slow Reports Clientside: https://docs.google.com/document/d/1qZmXmodxOKmsTRO27z2WlH2h9Kpf-kjV-k-1pJIogIE/edit?pli=1
>
> go/slow-reports
>
> Committed: https://crrev.com/c9cd43c8963301a6b1ebfb74c4eb03b8c733e9f9
> Cr-Commit-Position: refs/heads/master@{#330942}

TBR=dsinclair@chromium.org,nduca@chromium.org,oysteine@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1147383002

Cr-Commit-Position: refs/heads/master@{#330949}

This change enhances the tests for TabletEventConverterEvdev to support
different device characteristics by loading the device properties from a
DeviceCapabilities structure. Unfortunately I no longer have the device
for which the original test was written from so this change switches the
data used over to a different Wacom Tablet.

This work is in preparation for tests for on-screen active stylus
devices which will have different device properties.

The new data highlighted a bug in TabletEventConverterEvdev where we
were failing to zero the initial absolute position.

TEST=events_unittests passes.
BUG=448467
R=spang@chromium.org

Review URL: https://codereview.chromium.org/1155543002

Cr-Commit-Position: refs/heads/master@{#330948}

Cr-Commit-Position: refs/heads/master@{#330947}

This will be useful when hosting mojo services in the utility process where the process can go away after being idle for a certain period of time. When that happens, the ServiceRegistryImpl will not be bound and needs to be reconnected before it can be used again. For background, please see http://goo.gl/sMpZ0g.

BUG=479935
TEST=Tested by manually killing the process hosting the other side of the ServiceRegistryImpl.

Review URL: https://codereview.chromium.org/1128493002

Cr-Commit-Position: refs/heads/master@{#330946}

BUG=481595

Review URL: https://codereview.chromium.org/1140653006

Cr-Commit-Position: refs/heads/master@{#330945}

Add details of C++ registration, build file modifications.

Review URL: https://codereview.chromium.org/1123343005

Cr-Commit-Position: refs/heads/master@{#330944}

BUG=489613
TEST=None

Review URL: https://codereview.chromium.org/1152433002

Cr-Commit-Position: refs/heads/master@{#330943}

This version mostly just directs the TracingController using the specified BackgroundTracingConfig and pushes the compressed trace out to the BackgroundTracingUploadSink.

Specifically, we implement the PREEMPTIVE_TRACING_MODE for the rule MONITOR_AND_DUMP_WHEN_TRIGGER_NAMED, which should allow us to get an experiment going on desktop with a simple trigger and upload.

We can then follow up with additional CL's implementing the rest of the functionality from the clientside doc below.

Needs to land first: https://codereview.chromium.org/1088673003/

Slow Reports Clientside: https://docs.google.com/document/d/1qZmXmodxOKmsTRO27z2WlH2h9Kpf-kjV-k-1pJIogIE/edit?pli=1

go/slow-reports

Review URL: https://codereview.chromium.org/1089253003

Cr-Commit-Position: refs/heads/master@{#330942}

BUG=486471

Review URL: https://codereview.chromium.org/1145653002

Cr-Commit-Position: refs/heads/master@{#330941}

Previously we would extract all necessary files every time we ran the
app. This is obviously unnecessary for any bundled apps. Now we
extract only as necessary.

R=ben@chromium.org, jcivelli@chromium.org
BUG=none
TEST=none

Committed: https://crrev.com/128f7a0181634a89a35f681baab1d086d100e377
Cr-Commit-Position: refs/heads/master@{#330824}

Review URL: https://codereview.chromium.org/1149813002

Cr-Commit-Position: refs/heads/master@{#330940}

This patch was mostly autogenerated with
https://codereview.chromium.org/1010073002/.

BUG=465354
TBR=jochen@chromium.org,raymes@chromium.org

Review URL: https://codereview.chromium.org/1142063003

Cr-Commit-Position: refs/heads/master@{#330939}

When a layer with an animation is removed from the tree but later
re-added (this can happen, for example, when an iframe containing
an animation is set to display:none and later set back to
display:block), the animation should continue. Currently, the
animation is prevented from getting re-pushed to the compositor
thread since it already has a start time. This logic used to be
needed to prevent incorrectly re-pushing an animation that had
already been deleted  on the compositor thread, but is no longer
needed for that purpose since we now always delete animations on
the main thread before deleting them on the compositor thread.
This CL removes this logic.

BUG=409649

Review URL: https://codereview.chromium.org/1148333002

Cr-Commit-Position: refs/heads/master@{#330938}

Add "about" popup menu to the "mini-browser" WebViewBrowserActivity of WebViewShell.
Clicking on the menu item results in information about WebView and current webview
settings to be printed using reflection.

BUG=481508

Review URL: https://codereview.chromium.org/1128573002

Cr-Commit-Position: refs/heads/master@{#330937}

BUG=
TBR=fmalita@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/1144423003

Cr-Commit-Position: refs/heads/master@{#330936}

SkDrawPictureCallback is deprecated. Convert existing clients to the
equivalent SkPicture::AbortCallback.

R=reed@google.com,enne@chromium.org,danakj@chromium.org

Review URL: https://codereview.chromium.org/1138923005

Cr-Commit-Position: refs/heads/master@{#330935}

BUG=315202
NOTRY=true

Review URL: https://codereview.chromium.org/1147153003

Cr-Commit-Position: refs/heads/master@{#330934}

This uses even less memory (a few hundred bytes) by sacrificing some
worst case performance (in the order of a microsecond per query) and
maintainability.

Estimated memory savings will be 9-12 KB. (3 KB per QuerySyncManager).

BUG=485536
R=reveman@chromium.org,jbauman@chromium.org

Review URL: https://codereview.chromium.org/1129253006

Cr-Commit-Position: refs/heads/master@{#330933}

This CL lands server changes 92291593 and 92349257 by bnc.

BUG=488484

Review URL: https://codereview.chromium.org/1130053007

Cr-Commit-Position: refs/heads/master@{#330932}

This reverts commit 4394f60e.

Now that we've merged this revert to M43, I'll be landing a more
nuanced blacklist change that we can merge to M44.

TBR=sievers@chromium.org,kbr@chromium.org
BUG=490379

Review URL: https://codereview.chromium.org/1145923003

Cr-Commit-Position: refs/heads/master@{#330931}

High memory usage is forced by duplicate tabs in the same process.

BUG=
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1145173002

Cr-Commit-Position: refs/heads/master@{#330930}

Formerly the product id for the DisplaySnapshot was generated with a
combination of the manufacturer code combined with a hash of the product
display name. However as the product display name can vary based on
display connector it is more appropriate to use the product code.

TEST=display_unittests passes.
BUG=471749

Review URL: https://codereview.chromium.org/1151583002

Cr-Commit-Position: refs/heads/master@{#330929}

This includes:
- new types of controlled-setting-indicator for children/supervised users
- corresponding new "controlled-by" strings
- passing the strings through the developerPrivate API, and removing the now-unnecessary installedByCustodian field

BUG=397951

Review URL: https://codereview.chromium.org/1051273002

Cr-Commit-Position: refs/heads/master@{#330928}

This build flag used to be set from a repository that's going away, so
enabling this flag for official builds has to be moved here.

BUG=482123
R=kjellander@chromium.org,jochen@chromium.org,tommi@chromium.org

Review URL: https://codereview.chromium.org/1147013002

Cr-Commit-Position: refs/heads/master@{#330927}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/048c4866..581e1243

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1143293004

Cr-Commit-Position: refs/heads/master@{#330926}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f2539d5..070e010

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1155463002

Cr-Commit-Position: refs/heads/master@{#330925}

Allows MemoryDumpProvider(s) with dump-time constraints (mostly GC
allocators) to create out-of-band MemoryAllocatorDump(s) and merge
them during the onMemoryDump callback.

So far, the architecture of MemoryDumpProvider expected to never
instantiate ProcessMemoryDump(s) directly, but just fill up the
one passed as argument to the onMemoryDump(ProcessMemoryDump*)
callback.
This, however, doesn't cover the cases of dumpers that cannot dump
at arbitrary times (i.e. during onMemoryDump callback) and
need to pre-fill the dump stats before the actual callback
comes.
A concrete case of this are dump providers for garbage-collected
allocators (specifically BlinkGC) where some of the stats can be
collected only during the GC.

BUG=466141

Review URL: https://codereview.chromium.org/1151603004

Cr-Commit-Position: refs/heads/master@{#330924}

Revert of Enable more benchmark_smoke_unittest coverage (patchset #4 id:100001 of https://codereview.chromium.org/1144193002/)

Reason for revert:
Reverting due to flaky perf tests (see crbug.com/490130 for details).

Original issue's description:
> Enable more benchmark_smoke_unittest coverage
>
> Previously, benchmark_smoke_unittest has a heuristic to pick
> a benchmark for smoke testing if the benchmark uses a test
> in measurement directory.
> This patch removes that check, and instead provide a black
> list of benchmarks module that we exclude the
> benchmark_smoke_unittest to avoid high CQ time.
>
> This helped increases benchmark smoke coverage from 14 benchmarks -> 33 benchmarks (one in each benchmark module).
>
> On my local linux machine, this increases the cycle time of
> benchmark_smoke_unittest from 20s -> 1m7s.
>
> BUG=490130
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
>
> Committed: https://crrev.com/65014162e48a7f5881e8b282dd9e8dc17c5aa7c4
> Cr-Commit-Position: refs/heads/master@{#330909}

TBR=sullivan@chromium.org,dtu@chromium.org,nednguyen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=490130

Review URL: https://codereview.chromium.org/1143363006

Cr-Commit-Position: refs/heads/master@{#330923}

They are intended to be FYI checks. If they are ignored at upload
time, submitting should still work.

BUG=

Review URL: https://codereview.chromium.org/1147103002

Cr-Commit-Position: refs/heads/master@{#330922}

Do *not* grant permissions to extensions that come in via Sync disabled due to a permission increase.

Follow-up to http://crrev.com/1136543003

BUG=484214

Review URL: https://codereview.chromium.org/1150573002

Cr-Commit-Position: refs/heads/master@{#330921}

Reason for this when build with Memory Sanitizer it causes delay between CallJS('...') and actual JS execution. In this particular case Chrome tries to CallJS('doReload') due to frame loading error. After that it loads offline Gaia and then function |doReload| starts to execute which causes hiding offline Gaia;

BUG=475516

Review URL: https://codereview.chromium.org/1151513002

Cr-Commit-Position: refs/heads/master@{#330920}

Increased the spacing between oauth-enroll-attribute-prompt-message and gaia-input-card.

Review URL: https://codereview.chromium.org/1148113002

Cr-Commit-Position: refs/heads/master@{#330919}

Adds unit tests for the proximity_auth::BluetoothLowEnergyConnectionFinder
class.

BUG=485123

Review URL: https://codereview.chromium.org/1129983004

Cr-Commit-Position: refs/heads/master@{#330918}

Enterprise admins would liked to control apps that will be installed for their users.
To allow admins to don't track and block OEM apps one by one disable OEM apps installation.

BUG=486862
TEST=manual

Review URL: https://codereview.chromium.org/1144033003

Cr-Commit-Position: refs/heads/master@{#330917}

Disable DomSerializerTests.SerializeHTMLDOMWithNoMetaCharsetInOriginalDoc on
Mac because it fails in a CHECK of
sequence_checker_.CalledOnValidSequencedThread() (see crbug.com/488495)

TBR=ellyjones@chromium.org,jam@chromium.org
BUG=488495

Review URL: https://codereview.chromium.org/1145303005

Cr-Commit-Position: refs/heads/master@{#330916}

This matches downstream, where we build a universal binary, and then run tests on the 64-bit iPhone 5s simulator and the 32-bit iPad Retina simulator.

BUG=490189

Review URL: https://codereview.chromium.org/1150753002

Cr-Commit-Position: refs/heads/master@{#330915}

WebRTC 9229:9238
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/ead3df8..b7c7010

Libjingle 9227:9240
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/88eeffa..dd7a408

R=kjellander@chromium.org

Review URL: https://codereview.chromium.org/1151683002

Cr-Commit-Position: refs/heads/master@{#330914}

On iOS when user chaneg the device locale, we update the list of search
engines keeping the currently selected search engine unchanged. This is
done by removing all other search engines, and then adding the new ones.

BUG=None

Review URL: https://codereview.chromium.org/1149623002

Cr-Commit-Position: refs/heads/master@{#330913}

This CL fixes an issue where shadows were larger than
ShadowValue::GetMargin(). This caused certain shadows to clip to the
view boundaries which looks bad.

BUG=489533

Review URL: https://codereview.chromium.org/1123393007

Cr-Commit-Position: refs/heads/master@{#330912}

Changes in the src/cc directory can often affect the layout tests in Blink
however Chromium commit queue doesn't run these tests by default. This leads to
breakages being discovered only when the Blink dep is rolled into Chromium.

By adding the following line to the CL's description the Blink tests will be
run in addition to the normal Chromium tests;
 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

BUG=483372
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1142393002

Cr-Commit-Position: refs/heads/master@{#330911}