GitLab

This change modifies BrowserInterfaceBrokerImpl::GetInterface() to
trigger a bad message error on its host's receiver.
Browser test added to verify the behaviour.
Empty binders added for interfaces requested by blink but
not bound by content (will mostly be called in tests).

Bug: 1047680
Change-Id: I242cb11fff56666b6b6bd29e49c2180954aa1227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062696Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747877}

Bug: 1052460
Change-Id: I28410d27a23d4491b13070f7377018249cc58a98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087872
Commit-Queue: benjamin joyce <bjoyce@google.com>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747876}

Take the Windows parental controls logic in IncognitoModePrefs and
generalize it for use by other code in chrome/browser.  Move it to its
own file in chrome/browser/win, and allow checking some additional
properties besides just logging_required.

Additional minor changes to the moved logic:
*Remove expired histograms.
*Convert banned ComPtr::GetAddressOf() to operator&.

Bug: 1037961
Change-Id: I31a247a0f571177507ea561002dea6c67bd749b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090032
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747875}

Properties of PageNode that are tabs.

This class will be used for background page loading policy.

Bug: 1059341
Change-Id: Ic25aa92d06f6690a91d8e2de310478427ca97964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085633
Commit-Queue: Hailey Wang <haileywang@google.com>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747874}

This reverts commit 57d362b5.

Reason for revert: test failures on https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests?limit=100, several of which seem related to OOBE

Original change's description:
> Turn on Polymer v2 on OOBE by default
> 
> Bug: 955194
> Change-Id: I6581822689118b554107689e3cbca29b16d240df
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080427
> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745923}

TBR=sky@chromium.org,antrim@chromium.org,rsorokin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 955194
Change-Id: I46cd070a5162d18ce8ff41cf892ccebfe11340b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090801Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747873}

Refactor ActivityStorage and its derivatives to use IntervalMap for handling activity periods. Modify unittest to no longer expect activity resubmitted after the successful submit.

Bug: b/144279234

Change-Id: Ia929371ef06dd7ff185d7ad9e27075b6c2825607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080821
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747872}

When the layout_shift.debug trace category is enabled, the LayoutShift
trace event includes an impacted_nodes property containing the node ID
and the old and new visual rects for up to 5 shifted elements, selected
on the basis of their contribution to the impact region.

Bug: 1046212
Change-Id: I5d1833fbf831f0894b7036b73fa3c242b695ed64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042674Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747871}

Chromium already drops fullscreen when a dialog is first displayed.
Extend that behavior so that a WebContents may not enter fullscreen
for the duration of a dialog's display.

This is part 1: Extend the fullscreen IPC so that the browser can
decline a renderer's request to enter fullscreen.

Bug: 1042210, 1020026, 1037730
Change-Id: Iafba087b22c51bf3c8fb6f9a4ce02921d51f0044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041871Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747870}

Update scoping comment to reflect the types of reviews/changes I've
been making.

Change-Id: Ida49c4e23401e6f37b1215181b263d6992e7418d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091723
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747869}

Bug: 1043316
Change-Id: I3793008f9ad26e36e1d73ca9d299e905cf31821e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036889
Commit-Queue: Connie Wan <connily@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747868}

Audit uses of base::Unretained for Paint Preview related code. This
removes possibly unsafe cases by passing IDs or weak pointers instead.

Bug: 1059347
Change-Id: I1ba1d10e9b39e14cbdcd4c2acacba6feb91607ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091936
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747867}

Separate large if-block into a single statement for easier readability.
No change in functionality is expected.

Change-Id: Ieb7476e51d245cc2a0b97cdd0c158e3d0272a823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079161
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747866}

It's been failing because of breaking threading preconditions
when creating the configurator.

Bug: 1059138
Change-Id: I021c8bbf000d1c7372d3cbf9b821e57ea188a0b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091941Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747865}

This CL introduces a TabService which provides an interface by which to
capture Paint Previews and hooks to call on tab closure and startup. It
is largely a wrapper around PaintPreviewBaseService, but handles file
management for per-tab storage.

Follow-up work is
- Add a factory for this service.
- Hook this service up to observers for the events it handles.

Bug: 1058093
Change-Id: Ic1d7e880052090b5150ee5e63e21def374a20f92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087994
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747864}

This reverts commit 22339214.

Reason for revert: This is still flaky.

Original change's description:
> Re-Enable testEditTextOnSingleURL on EG2
> 
> At the time there were various failures on iOS12. I can't repro locally now
> I'll re-enable and monitor since I'm sheriffing.
> 
> Bug: 1049972
> Change-Id: I0345fd704dcef24285d461ca07244baafb06c163
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090608
> Auto-Submit: Sergio Collazos <sczs@chromium.org>
> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
> Commit-Queue: Sergio Collazos <sczs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747487}

TBR=kkhorimoto@chromium.org,sczs@chromium.org

Change-Id: I49c6d7b605c7cbe01f0a31a84e084168d8d1dcba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1049972
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091945Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747863}

https://dawn.googlesource.com/dawn.git/+log/e3f3e9a80d5f..7d20b4450182

git log e3f3e9a80d5f..7d20b4450182 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 natlee@microsoft.com Respect external clear status for Textures
2020-03-06 cwallez@chromium.org Roll third_party/swiftshader/ bdfcfe9cf..51b2800bb (23 commits)

Created with:
  gclient setdep -r src/third_party/dawn@7d20b4450182

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:1036080
Tbr: cwallez@google.com
Change-Id: Ia6babb2cac3e785db8a20bdc4cbaad96f87c3209
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091681Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747862}

This CL expands on our work of improving the performance of
accessibility features on Android.

Here we create a SparseArray<AccessibilityNodeInfo> to store
a mapping of view ids to their corresponding
AccessibilityNodeInfo objects. When the system asks us to create
a new object for that view, we leverage the object stored
in our array (cache) rather than constructing one from scratch.

There are helper methods so the native code can drive clearing
the cache at appropriate times. We are clearing the cache on a
given node during OnDataChanged or during OnNodeWillBeDeleted.

Change-Id: Iaf817886b8d7038d268d4b459d135c46f60cbfff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080857
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747861}

A previous fix introduced a top domain list to prevent phishing
attempts using IDN. That fix compares a domain against a top domain,
removes a label, and checks again until only a single label is left.
This is problematic because it assumes subdomains of top domains
cannot be IDN. As a result, subdomains of top domains are not decoded
as unicode.

This CL fixes this problem by adding an extra test to check if the
hostname is a top domain itself or a subdomain of a top domain. If true,
it's not treated as a lookalike and decoded as unicode.

Bug: 769547
Change-Id: Id3b0589128bce974f6789c4151738ad74ca0ba6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1320813Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747860}

https://webrtc.googlesource.com/src.git/+log/d14525eb59b9..04f7bfc4192f

git log d14525eb59b9..04f7bfc4192f --date=short --first-parent --format='%ad %ae %s'
2020-03-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4dc8a310..599bebd3 (747587:747722)
2020-03-06 hbos@webrtc.org [Overuse] Make EffectiveDegradationPreference() private.
2020-03-06 jakobi@webrtc.org Add minimum overhead to configured priorty bitrate instead of maximum.
2020-03-06 minyue@webrtc.org Feed the clock skew to AbsoluteCaptureTimeReceiver.
2020-03-06 srte@webrtc.org Cleanup: Improving readability in AimdRateControl
2020-03-06 minyue@chromium.org Refactor TimestampAligner for more general use.

Created with:
  gclient setdep -r src/third_party/webrtc@04f7bfc4192f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1054403
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Id1fc6365013f6006d676d9558494a6839e189a1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091679Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747859}

The blackbox shows up when ending a drag which creates a folder.
The folder view should be painted to a layer with set bounds
opaquely=false, so that the following animation (which will create
a layer with set bounds opaquely=true) will not create a blackbox.

Test: manual
Bug: 1057955
Change-Id: Ida8ea89e131e64dc2ed8d34465e82ba6a5745318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086261Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747858}

This is not currently compatible with --enforce-vulkan-protected-memory.
which forces all shared images to be protected, including canvas
resources.

Bug: 766360

Change-Id: I172c873d239a7e2da2012cf308d74198e615355e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090455
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747857}

gambard@ decided to disable for now since there were some issues like
https://crrev.com/c/2090804

TBR = gambard@chromium.org

Bug: 1038034
Change-Id: Id6e6c0be0f907efe9765c873f48f1a21583c34d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091898Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747856}

This reverts commit 2bd9927b.

Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/2087971 was relanded.

Original change's description:
> Revert "Remove unused headers in task_runner_util.h after fixing IWYU"
> 
> This reverts commit a65d1637.
> 
> Reason for revert:
> https://chromium-review.googlesource.com/c/chromium/src/+/2087971
> was reverted.
> 
> Original change's description:
> > Remove unused headers in task_runner_util.h after fixing IWYU
> > 
> > Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2076423
> > After https://chromium-review.googlesource.com/c/chromium/src/+/2087971
> > and https://chromium-review.googlesource.com/c/chromium/src/+/2087892
> > 
> > R=​ajwong@chromium.org
> > 
> > Bug: 1026641
> > Change-Id: Ia2c180759677a51502c5c1c04508d165f7c35856
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087893
> > Commit-Queue: Gabriel Charette <gab@chromium.org>
> > Reviewed-by: Albert J. Wong <ajwong@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#747707}
> 
> TBR=ajwong@chromium.org,gab@chromium.org
> 
> Change-Id: Id2b54936ec594834407e3e78e9affee53fca8f19
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1026641
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092036
> Reviewed-by: Hans Wennborg <hans@chromium.org>
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747817}

TBR=ajwong@chromium.org,gab@chromium.org,hans@chromium.org

Change-Id: I978fd2362ca8ea881ed056050971885007b7111b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1026641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090514Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747855}

This change registers the PluralStringHandler as a MessageHandler for
the SettingsUI and adds PluralStringProxy as a thin JavaScript wrapper
around it.

Bug: 1047726
Change-Id: I4c53eed726711635adb29e63435dd9da697d0635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090425Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747854}

This actually changes the structure, so that LocalDOMWindow inherits
ExecutionContext, rather than Document.

I left as much logic as I could on Document, and had LocalDOMWindow
call in to it. A few things needed to move for consistency, and I moved
anything where the Document override of a ExecutionContext function
was only called through the ExecutionContext interface.

Added null-checks and updated code to final format where it was necessary
to keep tests passing, otherwise left transitional code/helpers intact.

Updated many unit tests that needed an ExecutionContext to use
DummyPageHolder instead of just a standalone Document.

Bug: 1029822
Change-Id: I6a94442382b2eed6d682c4993821718daf7797ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090148Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747853}

Description:
This CL removes the WebPaymentIntentHelper dependency on some Chromium
types, e.g., PaymentDetailsModifier, PaymentItem.

Before Change:
WebPaymentIntentHelper depends on Chromium types.

After Change:
WebPaymentIntentHelper doesn't depend on Chromium types.

Change:
* Create new types mirroring those in org.chromium.payments.mojom.
* Create converter to convert the mojom types to the new types.
* Convert types before passing them into WebPaymentIntentHelper.

Bug: 1057488

Change-Id: I5dd9fbdbc91ae38f5cd78ec48288ecfcf10c75ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088236
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747852}

Replace TBR= with Tbr:, BUG= with Bug:, TEST= with Test:, NOTRY= with
No-Try: and CC= with CC:.

Most of the footers are available here:
https://www.chromium.org/developers/contributing-code/-bug-syntax.

Bug: None
Change-Id: I79ad7cd84ceac8a1f5a08b9e87f1581c0efb31ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089477Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#747851}

https://skia.googlesource.com/skia.git/+log/491df6ba72d3..7e46b14d8494

git log 491df6ba72d3..7e46b14d8494 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 nifong@google.com Replace red line skp with a prettier example
2020-03-06 kjlubick@google.com [canvaskit] Fix shadow bugs
2020-03-06 jlavrova@google.com Cache resolved typefaces by Unichar + SkFontStyle + locale
2020-03-06 mtklein@google.com fix comment
2020-03-06 mtklein@google.com move dither in SkVMBlitter
2020-03-06 mtklein@google.com set up interpreter after llvm

Created with:
  gclient setdep -r src/third_party/skia@7e46b14d8494

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: herb@google.com
Change-Id: I5342ff70935a6406ad9cb2849801e726816b7a9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091668Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747850}

- Added ProfildCardCoordinatorFactory to internal directory
- Auto generate ProfileCardCoordinatorFactory to public directory
- Added factory build target
- Added dependency to higher level target
- More info refer to go/chrome-hoa

Bug: 1058408
Change-Id: Ie6c31e716fd86b0febdf405f7db516ae4dae9c79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087695
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747849}

The build flag |generate_linker_map| is useful for SuperSize. There is
an assert in toolchain.gni to limit it to {android, linux}, but it's
unclear whether this should be for current_os or target_os. Attempts to
change this led to some past churn, e.g.:

  https://chromium-review.googlesource.com/c/chromium/src/+/1038430
  https://chromium-review.googlesource.com/c/chromium/src/+/1715024

This CL relaxes the check to allow all combos of
  {current_os, target_os} * {android, linux},
in hope to put the problem to rest.

Fixed: 986842
Change-Id: Id44bd76a900f0f55e10efc8bc25d75ac52e92f44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089787
Commit-Queue: Samuel Huang <huangs@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747848}

Before:
1 PH UI on opening sometimes have a gap beneath ThinWebView.
2 PH UI set ThinWebView height after the toolbar is laid out
3 PH UI doesn't have half state.

Cause:
For 1, 2, PH UI initialize the height for ThinWebView only when the tab
layout changes. Although tab layout change callback is called the
when PH UI opens, sometimes the toolbar is not laid out yet so the
toolbar height is unknown
For 3, BottomSheet's half state is disabled when PH UI set WRAP_CONTENT
to fullHeightRatio.

Change:
* Set height for ThinWebView when tab layout changes and in PH's
constructor.
* Rather than getting toolbar height from toolbar's layout, get the
toolbar height from dimen const directly.
* Remove onToolbarLaidOut logic.

After:
* the gap is gone.
* reduced complexity to get toolbar height.
* PH UI supports half state.

Bug: 1059066, 1059269

Change-Id: I52435a9ec15f87369486ec0551af67878bb6a755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090836Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747847}

Tbr: xidachen@chromium.org
Bug: 1059262
Change-Id: I80177cfb9b9c99ae419c350f670a9bb9d7c45b26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090209Reviewed-by: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747846}

This is a follow up CL for crrev.com/c/2068204

Bug: 1055246
Change-Id: I4b8427f3a5a158e44cef8cb42f8ac77780c77db8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081529
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747845}

This reverts commit 7a13e264.

Reason for revert: same as original % tools/clang

Original change's description:
> Revert "IWYU for bind/callback_helpers.h and ptr_util.h"
> 
> This reverts commit b8ffaf4c.
> 
> Reason for revert:
> This broke the build of the blink_gc_plugin, which does not use base/
> (see bug). Please don't commit to tools/clang/ without review.
> 
> Original change's description:
> > IWYU for bind/callback_helpers.h and ptr_util.h
> > 
> > These missing includes are preventing removal of unused headers from
> > task_runner_util.h and consequently migration from task_runner_util.h to
> > task_runner.h's new PostTaskAndReplyWithResult member method.
> > 
> > The following script was run on every file in the codebase, prioritizing
> > .h over matching .cc to best enforce the rule of not include a header
> > included by your .h :
> > 
> > def Fix(file_path):
> >   content = refactor_lib.ReadFile(file_path)
> > 
> >   # Assume fwd-decls are correct in first pass.
> >   fwd_decls_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*class (NullCallback|DoNothing|ScopedClosureRunner);', re.DOTALL).findall(content)
> >   if fwd_decls_match:
> >     print 'fwd_decls_match in %s' % (file_path)
> >     return False
> > 
> >   bind_helpers_match = re.compile(
> >       # Doesn't begin with a comment.
> >       r'\n *[^/\n][^/\n]'
> >       # Anything else after a non-comment start (and don't allow this to capture a comment start either)
> >       r'[^/\n]*'
> >       # Anything before but an open angle-bracket to avoid cases like unique_ptr<Foo> where you don't need the full definition of Foo.
> >       r'[^<]'
> >       # Only match with base:: prefix; more precise, can manually fix missing includes in //base proper in a follow-up pass if needed.
> >       r'base::(NullCallback|DoNothing|DeletePointer)\b[^*]', re.DOTALL).findall(content)
> > 
> >   callback_helpers_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::(IsBaseCallback|EnableIfIsBaseCallback|AdaptCallbackForRepeating|ScopedClosureRunner)\b[^*]', re.DOTALL).findall(content)
> > 
> >   ptr_util_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::WrapUnique\b[^*]', re.DOTALL).findall(content)
> > 
> >   if not bind_helpers_match and not callback_helpers_match and not ptr_util_match:
> >     return False
> > 
> >   updated_content = content
> >   if bind_helpers_match:
> >     updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/bind_helpers.h")
> >   if callback_helpers_match:
> >     updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/callback_helpers.h")
> >   if ptr_util_match:
> >     updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/memory/ptr_util.h")
> > 
> >   if updated_content == content:
> >     return False
> > 
> >   # Write updated file
> >   refactor_lib.WriteFile(file_path, updated_content)
> > 
> >   return True
> > 
> > TBR=danakj@chromium.org
> > (mechanical change for //base API)
> > 
> > Bug: 1026641
> > Change-Id: Ic88585c62dd2f74d34c59c708faeddb231aee47f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087971
> > Reviewed-by: Gabriel Charette <gab@chromium.org>
> > Reviewed-by: danakj <danakj@chromium.org>
> > Commit-Queue: Gabriel Charette <gab@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#747685}
> 
> TBR=danakj@chromium.org,gab@chromium.org
> 
> Change-Id: I59d6cd69bd898e9f6d10922c67d8c24ba582bf7f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1026641, 1059359
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091356
> Reviewed-by: Hans Wennborg <hans@chromium.org>
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747804}

TBR=danakj@chromium.org,gab@chromium.org,hans@chromium.org

Change-Id: I721391eba68ea55830dca4f1ac34ff633f714f72
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1026641, 1059359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090509
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747844}

Using this static setter to stabilize the test conditions we want.
Enabling duet feature flag does not necessary mean we enables the
bottom toolbar & home button variance (as it checks some other
conditions)

Also change the base junit runner to get benefits for chrome specific
test settings.

A simple fix addressing missing of managed label in pre-conversion
HomepageSettings.

Bug: 1051213, 1057873, 1059311
Change-Id: I9d296c587f5d3c328273fd1883397b2ac5fa22a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090199
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747843}

The bug they were added for has been fixed.

Fixed: 1022304
Change-Id: Id971939e7dbf19a469e015c795e652c0bd3e534d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090144
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747842}

Bug: 1052874
Change-Id: I2696746cc5925d63afc2f86ec306beb8c2b43dee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090196Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747841}

Use the new element to create a new control for safebrowsing that includes their enhanced mode.

Bug: 1032584
Change-Id: Ife6184d1ed7d427eed64c2a65484e1c3af21588a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074300
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747840}

Change-Id: Idfd11ab30ffed491feffc1c1dbab8d233f319865
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091527Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747839}

This CL adds support to enable default DACL lockdown on GPU processes as
well as enabling the random restricted SID feature to limit cross process access.

Bug: 1057218
Change-Id: I669e0d32a5eb2cd3724a876a5cef5f306d7db8a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091901Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747838}