- 30 Nov, 2018 40 commits
-
-
Etienne Pierre-Doray authored
Under this experiment, scheduler workers are only detached if the pool is above its initial capacity (threads that are created to replace blocked threads). 2 options were considered: Option A: Detach only when over initial capacity. Option B: Detach only when over current capacity (includes currently blocked threads in capacity). This might better handle the following case: At any given time, there is at least 1 blocked thread. On top of that, some periodic work uses all worker every 30s or so. The current capacity will encompass for the blocked thread and avoid detaching it periodically. Option A was picked because it is more conservative. Initial capacity is smaller or equal to current capacity, so detaching is closer to current behavior. We want to avoid having too many threads that aren't used. Bug: 847501 Change-Id: I0b116db54095767768b158d92f5f146249720b45 Reviewed-on: https://chromium-review.googlesource.com/c/1348863 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#612698}
-
Jonathan Metzman authored
Fix integer overflow in data_size caused by attacker controlled value (win_certificate->dwLength) by using CheckSub from base/numerics. The overflow causes the program to read past the end of win_certificate. The amount read is also attacker controlled and seems essentially unbounded. Change-Id: I006cb4f8ce6c64421ca0bb66df3ce49a72aba839 Bug: 910480, 910522 Reviewed-on: https://chromium-review.googlesource.com/c/1357011Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#612697}
-
Georges Khalil authored
This CL adds the serial number to cloud reporting, as a step to transition to using that as the client ID. Bug: 910594 Change-Id: I7b336da99f2f7304b3e03b7a3a25aa07715749d2 Reviewed-on: https://chromium-review.googlesource.com/c/1354342 Commit-Queue: Georges Khalil <georgesak@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#612696}
-
Eric Robinson authored
See also go/chromerulesetservicemerge. This change is the final step in the RulesetService change. Rather than merging the two classes, we've chosen to more appropriately name ContentRulesetService to reflect what it does (RulesetPublisherImpl). In addition, the visibility of that class has been reduced, and it is now only referenced in/visible to the RulesetService class as well as tests. This change reflects splitting up the content of the .cc files, as the splitting of the headers was done in a previous CL. Change-Id: I2937ba2e2838669d3bf6a2f646acfefcd71f5f94 Reviewed-on: https://chromium-review.googlesource.com/c/1354272 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#612695}
-
agrieve authored
Bug: 908997 Change-Id: Iac24d68050cbf7331da37c45a5fe617b94c0d81f Reviewed-on: https://chromium-review.googlesource.com/c/1355908Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#612694}
-
Min Chen authored
Bug: 900758 Change-Id: Idb6e22aa144d290f21c5af6139e0d168905e5ff6 Reviewed-on: https://chromium-review.googlesource.com/c/1352526 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#612693}
-
Wenzhao Zang authored
Bug: 910409 Change-Id: I7c9a65ccb5e6eb11e2e3f600cef3ba13fe37ee82 Reviewed-on: https://chromium-review.googlesource.com/c/1356240Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612692}
-
Aaron Leventhal authored
Address whitespace-related flakiness by removing whitespace which is irrelevant to what is being tested. TBR=aboxhall@chromium.org Bug: 900532 Change-Id: I0b5a31b4ead65ce9b40658704b5ca8c0ff3f20dd Reviewed-on: https://chromium-review.googlesource.com/c/1356866Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#612691}
-
Xianzhu Wang authored
to increase test coverage. Directories with >= 4 failures are still skipped, and will be updated in later CLs. Change-Id: I02683ee1a33926e312867aa8057215ddc86d9671 Reviewed-on: https://chromium-review.googlesource.com/c/1356125Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612690}
-
Tina Wang authored
Added span tag inside title div to ensure: - the minimum height of title will be 24px, - the theme pills won't shrink size when font size is small Deleted the height and line-height properties in md-title style to: - let the span keep the min height - let the line-height increase automatically when choosing huge font size Bug: 908792 Change-Id: I75f5ab0b39ddc760115b2dfa8ea013adee490e2b Reviewed-on: https://chromium-review.googlesource.com/c/1354356 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#612689}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b51eb09fb5bb..317a9ebdb019 git log b51eb09fb5bb..317a9ebdb019 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 tobine@google.com Vulkan: Roll VK deps forward Created with: gclient setdep -r src/third_party/angle@317a9ebdb019 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:845519 TBR=fjhenigman@chromium.org Change-Id: I6c7a2da32e78a857475f89b720cd3d05e04b1b70 Reviewed-on: https://chromium-review.googlesource.com/c/1356632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612688}
-
Hiroshige Hayashizaki authored
This reverts commit 0bdd3c25. Reason for revert: Suspected to cause compile failure on the Google Chrome Linux x64 bot crbug.com/910644 Original change's description: > Roll clang 346388:347933. > > Bug: 904337 > Change-Id: I8fad51cde2b93b83dfa1a14c61a992f659d827be > Reviewed-on: https://chromium-review.googlesource.com/c/1356710 > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612660} TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org Change-Id: Ia95868dd39daaa60e204a6ec64df6eabfafacb94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904337, 910644 Reviewed-on: https://chromium-review.googlesource.com/c/1357012Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#612687}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/327406e12cba..207cb0177f05 git log 327406e12cba..207cb0177f05 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 treehugger-gerrit@google.com Merge "Only run SIGINT handler once." 2018-11-30 lalitm@google.com trace_processor: add tests for new args table 2018-11-30 lalitm@google.com Merge "trace_processor: refactor to an ever present id approach" Created with: gclient setdep -r src/third_party/perfetto@207cb0177f05 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7109941366ef1f61bfd206410556dd74cd114dca Reviewed-on: https://chromium-review.googlesource.com/c/1356630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612686}
-
Andrey Kosyakov authored
Same as https://chromium-review.googlesource.com/c/chromium/src/+/821410/, but now for the network service. Bug: 898306, 793692, 721408 Change-Id: I96a2a25e66f4ff528d84baf03d600e4f1c89dd30 Reviewed-on: https://chromium-review.googlesource.com/c/1313739Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#612685}
-
Peter Beverloo authored
The spec defines it to be an unsigned long long (uint64_t in Chromium), so let's make sure all the plumbing agrees with that. Change-Id: I9c22d4a197d726c276b3e69818276a4d149c68c8 Reviewed-on: https://chromium-review.googlesource.com/c/1356709Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#612684}
-
Philip Rogers authored
This patch switches web tests to use --enable-blink-features=BlinkGenPropertyTrees instead of --enable-blink-gen-property-trees. This will let us remove the BGPT-specific command line flag in the future. To run web tests (formerly layout tests) with BlinkGenPropertyTrees, use: [run_web_tests] --additional-driver-flag=--enable-blink-features=BlinkGenPropertyTrees Bug: 836884 Change-Id: Ie4fa7d4f8ed8b7c027d6c34308230a4735d77972 Reviewed-on: https://chromium-review.googlesource.com/c/1355610Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612683}
-
Dave Tapuska authored
Apply casts where necessary. These are all safe. BUG=879657 Change-Id: Ia0a79b09796ed065a06e60ef880248cadcef3490 Reviewed-on: https://chromium-review.googlesource.com/c/1355775 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#612682}
-
Michael Lippautz authored
Bug: 843903 Change-Id: I24d73949caec0b2ea55cf6cfa058cbf5f7d2826a Reviewed-on: https://chromium-review.googlesource.com/c/1355941Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#612681}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9bd7b090dcae..f2f731d6ce85 Created with: gclient setdep -r src-internal@f2f731d6ce85 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I41e73f5c923c48f0598d80922386a18013ff1491 Reviewed-on: https://chromium-review.googlesource.com/c/1356629Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612680}
-
Nate Chapin authored
Rather than propagating the values set by testRunner.addOriginAccessWhtielistEntry, have the iframe used by the tests call it. Specify which test case to perform by creating the iframe with a different src hash component Bug: 585188 Change-Id: I04c1f647306c3e5675b641b47858aff1d25bfd07 Reviewed-on: https://chromium-review.googlesource.com/c/1354504Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#612679}
-
Thomas Tangl authored
The unified consent feature was not enabled in UnifiedConsentBrowserTest for official tests. This is fixed now. Bug: 910523, 888527 Change-Id: Ied1223b008f83c8c92cf471f90e8021606e25fda Reviewed-on: https://chromium-review.googlesource.com/c/1356960 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#612678}
-
Paul Jensen authored
If we hit https://github.com/netty/netty/issues/2616, then retry starting the Netty server. Change-Id: I700ededc47b9ddbc6c2602942128c92757f883c6 Reviewed-on: https://chromium-review.googlesource.com/c/1356864Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#612677}
-
Takuto Ikuta authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/157bec8a25cc..0e3e1c4dc4e7 $ git log 157bec8a2..0e3e1c4dc --date=short --no-merges --format='%ad %ae %s' 2018-11-29 tikuta [client] do not convert json format from new api to old api 2018-11-28 maruel [client] Further use generator during enumeration 2018-11-28 maruel [client] Make TaskChannel usable as a generator 2018-11-28 maruel [client] Convert the upload to be pipelined; various performance tuning 2018-11-28 maruel [client] reduce the duplication of logic in isolateserver.py 2018-11-27 maruel [client] check upfront for 'pool' dimension to be specified Created with: roll-dep src/tools/swarming_client Change-Id: I8970b10732ca8dfa8d7ef34e356e24e6acb25a68 Reviewed-on: https://chromium-review.googlesource.com/c/1355300Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#612676}
-
John Chen authored
Test case ChromeDriverSiteIsolation.testCanClickOOPIF, which was already disabled on Mac, has been observed to cause flakiness on Linux as well. Disabling it on all platforms. TBR=crouleau@chromium.org Bug: 904061 Change-Id: I2fa2eee25c356f802b57a95c0fcc96cf7eb2e64a Reviewed-on: https://chromium-review.googlesource.com/c/1357004Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#612675}
-
Alex Clarke authored
This works around one issue with overriding now while there are other SequenceManager threads around. Specifically the MessageLoop didn't sample Now unless there where delayed tasks, and the IO thread where this problem crops up in tests does not use DelayedTasks. The SequenceManager however does sample now due to heuristics in the LazilyDeallocatedDeque. Overriding time isn't thread safe and this patch does not change that. Further work may be needded to make that safe, Bug: 910524, 863341, 891670 Change-Id: I816247b8640f178e00cbd40ac85cd76e5139320a Reviewed-on: https://chromium-review.googlesource.com/c/1356586Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#612674}
-
Tatiana Buldina authored
This is part one of strictFileInteractability implementation, including parsing of this capability and passing its value to the session. Updating Element Send Keys command to handle this capability will be done in a separate CL. Bug: chromedriver:2654 Change-Id: I65f5e0c9530f24f0dc699a8156495ac305117f3e Reviewed-on: https://chromium-review.googlesource.com/c/1329785 Commit-Queue: Tatiana Buldina <buldina@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#612673}
-
Sebastien Seguin-Gagnon authored
This reverts commit 44fcad8b. Reason for revert: Possibly causing Linux x64 tree closing issue https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/38102 Original change's description: > Fix Shared Buffer 64 bit truncations > > Segments are always 4k and indexed by a WTF::Vector > > BUG=879657 > > Change-Id: Ibe922cc6736fed0ba04e99aee0f04eb470f7fecf > Reviewed-on: https://chromium-review.googlesource.com/c/1355884 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612659} TBR=haraken@chromium.org,dtapuska@chromium.org Change-Id: Id069b9258d53267ec504fabe3adbd4b28148345e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 879657 Reviewed-on: https://chromium-review.googlesource.com/c/1356883Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612672}
-
Boris Sazonov authored
This CL fixes an unlikely race condition and a NullPointerException that were happening in AccountSigninView.recordConsent because of simultaneous unsynchronized accesses to mSelectedAccountName field. This CL also adds conditions to ignore taps on confirmation button and Settings link if there's no account selected. This is necessary because UI events are delivered asynchronously. Bug: 891508 Change-Id: I366122a927e2c0b4683cfc85eb461cbfd6485b30 Reviewed-on: https://chromium-review.googlesource.com/c/1356802Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#612671}
-
Mason Freed authored
This optimization was the cause of at least one bug (crbug.com/812166), and will hopefully not be needed once Composite After Paint is implemented. Bug: 812166 Change-Id: I2024b887949904bad5515d76b2fa29607dae3ff9 Reviewed-on: https://chromium-review.googlesource.com/c/1354572 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612670}
-
Alex Clarke authored
This test doesn't unregister the service worker unlike others in the same file and is likely working by accident. This becomes a problem when we migrate from MessageLoop to the SequenceManager. Bug: 863341, 891670 Change-Id: I658ce56f244d1beda44f02e53cceaf0a7ea7b45b Reviewed-on: https://chromium-review.googlesource.com/c/1356940Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#612669}
-
Ramin Halavati authored
To investigate a crash on ChromeOS, fail safe code and reporting are added to EventRouter dispatcher. Bug: 870838 Change-Id: I536a581c142d3b760f5a564507d4251b2b881c0e Reviewed-on: https://chromium-review.googlesource.com/c/1356587Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#612668}
-
Mathias Carlen authored
Before this patch the batch_element_checker was very frequently trying to find an element in the page which resulted in draining resources from the UI thread for page processing and rendering. This patch increases the elment check period to a second. The result is a 30 to 40 percent improvement in scipt execution velocity on less powerful phones. Making perceived velocity faster on those devices is good enough at this point. More latency analysis and improvements will be done in the future. Bug: 806868 Change-Id: I90680c31fd872c1da44b95f46443773a05f63dba Reviewed-on: https://chromium-review.googlesource.com/c/1350923 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#612667}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/457b44f3cd29..016601cc2146 git log 457b44f3cd29..016601cc2146 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 erikchen@chromium.org Add mechanism for telling CQ to avoid retrying builds. Created with: gclient setdep -r src/third_party/depot_tools@016601cc2146 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:910193 TBR=agable@chromium.org Change-Id: Ic44677f54fcd3344cc549da175e6eccb90018bbf Reviewed-on: https://chromium-review.googlesource.com/c/1356628Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612666}
-
Lily Chen authored
Add blank implementations for TestConnectJob and WebSocketTransportConnectJob (for which priority doesn't matter anyway). Bug: 166689 Change-Id: I2c5b0e6a2720a642ac154d22ae8ba97bbc13e16f Reviewed-on: https://chromium-review.googlesource.com/c/1355538Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#612665}
-
Xi Han authored
This is a follow for CL (https://crrev.com/c/1318362) which changes "AllowStartingServiceManagerOnly" from commandline flag to a feature. Update the ServicificationBackgroundServiceTest accordingly which has this flag turned on. Bug: 899225 Change-Id: Ia1256af793cf6a49c7b6aaa88b4fa95bf619b657 Reviewed-on: https://chromium-review.googlesource.com/c/1357000Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612664}
-
Elad Alon authored
Use batches of 5 seconds instead of immediate log emission. (An upcoming CL should make this configurable from JS.) Bug: 910576 Change-Id: Ib2b804e1e8c7798b744548fb343776fa8a315a65 Reviewed-on: https://chromium-review.googlesource.com/c/1356800Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#612663}
-
Dominic Farolino authored
From "OK" => "", as per the spec change https://github.com/whatwg/fetch/pull/836. R=yhirano@chromium.org, yoav@yoav.ws Bug: 907441 Change-Id: Id58718ecdba49432078358c20d62df5ff0eda8f8 Reviewed-on: https://chromium-review.googlesource.com/c/1348739 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#612662}
-
Peter Kotwicz authored
This CL is in preparation for making SplashActivity more complicated and overriding SplashActivity#onResume(). This CL: - Makes SplashActivity no longer inherit from HostBrowserLauncherActivity - Changes TransparentLauncherActivity to call finish() after the call to onHostBrowserSelected() BUG=901954 Change-Id: I2577031db9f132fc61757126ef9ffbe5c64d46cd Reviewed-on: https://chromium-review.googlesource.com/c/1319342 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612661}
-
Hans Wennborg authored
Bug: 904337 Change-Id: I8fad51cde2b93b83dfa1a14c61a992f659d827be Reviewed-on: https://chromium-review.googlesource.com/c/1356710Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#612660}
-
Dave Tapuska authored
Segments are always 4k and indexed by a WTF::Vector BUG=879657 Change-Id: Ibe922cc6736fed0ba04e99aee0f04eb470f7fecf Reviewed-on: https://chromium-review.googlesource.com/c/1355884Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#612659}
-