- 29 May, 2019 40 commits
-
-
Tomasz Wiszkowski authored
The change currently has no effect on our users. It requires backends to start serving entity suggestions to be active. We use InMemoryImageFetcher (instead of BitmapFetcher) to - avoid paying price of exchanging data blobs between C++ and Java, - avoid caching same object twice, - get better control over object lifecycle. This change introduces image fetching and presenting for entity suggestions. We cannot start clearing cache until crrev/c/1599741 is merged. Mocks: http://gallery/projects/MCHbtQVoQ2HCZc-__giWyM2E/files/MCHtA7U1iMGr68n3lpUTe2KsSFwQKW8sMVc Slides: http://slides/1uB8QFlhYqQetxNgJxucpKn-Eolx7CiqL88jGES_sjFk#slide=id.g5546bf599a_5_6 Doc: https://docs.google.com/document/d/1vq_9mAU8-bg2M3iWoPWN196Y6jwmh-QIg3dWgwVDRy0 Bug: 930349 Change-Id: I6857bf90243082aa0e073940534baefc173efe02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600867 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664409}
-
Joe Mason authored
Move safe_browsing/chrome_cleaner into its own target. Add deps to //chrome/browser/extensions and //chrome/browser/ui to that target. Rename chrome_cleaner_types target to chrome_cleaner/public. Bug: 920223 Change-Id: I95dd33b5e7ecb9881436169861d4186506e942fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625325Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#664408}
-
Katie D authored
Change-Id: I1015510c4704a090c0c5b9659d543abc939d7382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635436Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#664407}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f051812343eb..1b71e4533842 git log f051812343eb..1b71e4533842 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 afdx@google.com Add "split block" transformation. (#2633) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@1b71e4533842 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I93b4386e008d7da5343643c0da54cc32a54163ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635192Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664406}
-
Ken Rockot authored
Bug: 955171 Change-Id: I66e911a8444621a4342ecfd77787704a63529672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632895Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#664405}
-
Jordan Bayles authored
This patch adds classes to implement the mDNS interfaces that Open Screen expects, using the discovery system inside of Chromium. Change-Id: I450b757241ff99a59ec59f5352a0b604f729b9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590536 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#664404}
-
Maksym Onufriienko authored
Bug: 922813 Change-Id: I8d2abc2c56678eee4f7060e5169a0ed535cf08c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632915 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#664403}
-
jongkwon.lee authored
Merges the temporary type LINE_BREAK_MULTILINE to LINE_BREAK and introduces new type FIELD_BREAK for edge selection. As LineSelectionModel returns EdgeSelectionModel for a single line text, there is no behavioral change. Adds some tests for FIELD_BREAK. Change-Id: I7636852f13e61a6e0b8a70ca59d4f925c1c68ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626845 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#664402}
-
Ted Choc authored
BUG=966393 Change-Id: If8e1a066d327f32f7922cd7694a296ff7e2e3b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635203 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#664401}
-
Bill Orr authored
When tracking is regained, we should go back to the original origin. This means we should use an anchor rather than a SpatialStationaryFrameOfReference. Bug: 965528 Change-Id: I8183b141cf4f9931a50866da4f2f97b54d43289e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633990Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#664400}
-
Jun Cai authored
This CL implements the permission storage for Bluetooth Scanning API on desktop: 1. Implements permission storage suggested on the design docs listed below. The default permission setting for a site is "Ask". Permission storage is only needed for the current active tab by adding a |allowed_scan_filters_| to the WebBluetoothServiceImpl class. 2. If user blocks a site to use the Bluetooth scanning API, this permission preference is stored in the content settings and can be used in other tabs. 3. Adds two functions to ContentBrowserClient to store and retrieve permission setting from content settings. Permission in tab switching will be handled in a follow-up CL. Design docs: https://docs.google.com/document/d/18Rqg1HRGeDngPv60DAGoMnIwRB-Zjh5gOWmANmH8lTo/edit https://docs.google.com/document/d/1k4WM56Dx7sCu2k2MjvOdXArNz2Dy8BA1vt2VYHA6v7A/edit Bug: 953075 Change-Id: Ie3339981584f219baa43a42d7522acce79a62197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610221 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#664399}
-
Jenny Zhang authored
Bug: 967818 Change-Id: I009a0edfd3b5f644fefe8e722556848b5c996b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633029Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#664398}
-
rbpotter authored
The identity manager creates a browser crash if AddObserver is called in incognito. Check that either mirror or dice is enabled before getting the manager and adding the observer. Bug: 968084 Change-Id: I4017eeada1732172cd7a731b64e9d8d1f69cf9a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635634Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#664397}
-
Raymond Toy authored
Previously, an AudioContext object would be constructed, and then the sample rate would be tested for validity and an error is thrown if invalid. The invalid sample rate would get passed to FFTFRame::Initialize which causes an out-of-bounds access. This is backwards. We should verify that the supplied sample rate is valid before contructing the AudioContext object. Bug: 967117 Change-Id: Ifba65666f09d823f1e84d561252ce97d5225db02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635204 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#664396}
-
David Maunder authored
Task IDs track navigations and relationships between navigations. The new implementation allows cross-Tab navigations to be tracked in addition to enabling better separation of concerns (moving Task ID book keeping code out of sync). Bug: 961356 Change-Id: I5ce0f970a35fc7f5f6f201452517c87be410eaca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625651 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#664395}
-
Johannes Henkel authored
TBR=caseq New revision: e8ba1a7665bdcd8336915d5ca4b390e0cf6b1f6f Change-Id: Id83a3a1c49bb3a4baafd22500b07c9ced8c58a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635851Reviewed-by:
Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#664394}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cf6037f4a320..566314b3ea6d git log cf6037f4a320..566314b3ea6d --date=short --no-merges --format='%ad %ae %s' 2019-05-29 samans@chromium.org Fix alignment of VkWrapper Created with: gclient setdep -r src/third_party/swiftshader@566314b3ea6d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:967831 TBR=swiftshader-team+autoroll@google.com Change-Id: I545ebd9c7530f593505c2e557643f6886e7fbd58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664393}
-
Nina Satragno authored
Add a DevTools Domain that allows enabling and disabling the WebAuthn Virtual Authenticator Environment. Eventually the domain will have a set of methods to add and interact with authenticators. This patch also removes a race condition from the devtools/agents-enable-disable.js web test that was made apparent by adding this domain. Domains' `.disable` methods are no longer assumed to be finish in the same order as their `.enable` methods. For an overview of the overall design, please see https://docs.google.com/document/d/1bp2cMgjm2HSpvL9-WsJoIQMsBi1oKGQY6CvWD-9WmIQ/edit?usp=sharing Bug: 922572 Change-Id: Id43c184e5830de72736410049fdacba9a965a6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617550 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#664392}
-
Miguel Casas authored
crrev.com/c/1612041 landed the enumeration of supported BufferFormats on Ozone and wired it to a GpuInfo field; however, for the purpose of using this information in gpu::gles2::FeatureInfo::FeatureFlags, it's better to store it in GpuFeatureInfo. This CL moves it to there. Bug: 967905, 911754 Change-Id: I1279e36af7b2fb2d680b6916f364db71d99e26f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632597Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#664391}
-
Ben Pastene authored
I don't think anyone can doubt tikuta's familiarity and proficiency with infra code/configs. And he should definitely be an owner if he's taking on the daunting crbug.com/954450 :-) R=jbudorick, dpranke, tikuta Change-Id: I41928a34029d2d790089e4ca7e4a80d026253f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634348Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#664390}
-
Behdad Bakhshinategh authored
This reverts commit 53855e57. Reason for revert: Does not filter the failure of run_benchmark. Original change's description: > Disabled cc_poster_circle from rep perf test > > Currently map fyi bots which run rendering_representative_perf_tests fail as a result of: > > DevtoolsTargetCrashException: Devtools target crashed > (/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py:539 _AddDebuggingInformation) Received a socket error in the browser connection and the tab no longer exists. The tab probably crashed. > > While investigating this issue, this test can be disabled. > TBR=kbr@chromium.org > > Bug: chromium:968119 > Change-Id: I71fbb8f3e296203a9b556544ce2a8fc6345a9566 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634385 > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664305} TBR=kbr@chromium.org,jonross@chromium.org,crouleau@chromium.org,behdadb@chromium.org Change-Id: I4d886c3d96fb87eeadf1298d2a59fb3e9ddcd7e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:968119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635219Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#664389}
-
Aaron Gable authored
This reverts commit 0882bebe. Reason for revert: Causing flaky failures of external/wpt/webrtc/RTCPeerConnection-iceConnectionState.https.html on Linux Tests and WebKit Linux Trusty Leak https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/78387 https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak/34892 Original change's description: > Change ICE connection state on transceiver changes > > This ensures that if the PC iceConnectionState should change > because unused transports are discarded, the state is updated. > > Bug: chromium:966798 > > Change-Id: I09d945f5e70eec813f33c3131fbe889825613652 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632254 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664206} TBR=hta@chromium.org,hbos@chromium.org Change-Id: I2cbae9f1327e7aacb7022d2a823ce1e954c91b62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:966798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635208Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#664388}
-
Alexander Hendrich authored
This CL adds a handler for calls to the chrome.loginScreenUi API. It observes session state and displays the supplied contents on the login and lock screen. Bug: 957573 Change-Id: Iad727587e4f76298b0c6927947218f431b492610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588237 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#664387}
-
Kuo Jen Wei authored
This CL does following changes and fixes following a11y bugs: 1. Fix focus blue border pushing out layout of sibling in mode selector. 2. Fix losing focus when enter/leave setting menus. 3. Relayout the a11y navigation in clockwise order. Bug: 966755 Change-Id: I175583a032b9309d92516e89f73611e930958cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634571 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#664386}
-
Kuo Jen Wei authored
Bug: None Change-Id: Ief14134de1d944229fede4e975f5f07c11c4eb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631236Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#664385}
-
Justin Cohen authored
Although the bot is named iOS13, since the rest of the waterfall is still running Xcode 10.1, put the latest Xcode 10.2 here for completeness. This will be rolled to the first iOS13 beta once it's available. Change-Id: I4a6f3ebde9af1c5308b5cd428db6ff364610ed7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618804 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#664384}
-
Bill Orr authored
The service_ pointer was getting nulled-out asynchronously, so we'd sometimes reject early based on the service_ being null and sometimes pass that check and reject with no user gesture. The fix makes things consistent but not yet spec compliant - issue 962991 will make things spec compliant. Bug: 962685 Change-Id: I69bae46f02e0027ef69365c1c8c47d72af0dee3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630719Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#664383}
-
Adrienne Walker authored
Previously CommandBuffer sizes accurately captured the amount of gpu memory used by Chrome. However, recent changes like OOPR and shared images have spread this memory over multiple categories. Add a single UMA/UKM to report this memory so that we can accurately track it in the wild. Bug: 960499 Change-Id: I9aea6bd93dffc2d226f2e3f5c72696ad37942960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611862 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#664382}
-
Mattias Nissler authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/ad9db8abe4e8..a67d91d30a5a $ git log ad9db8abe..a67d91d30 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 mnissler debugd: Add GetU2fFlags method. Created with: roll-dep src/third_party/cros_system_api Change-Id: I06277702bed9951b04413b041c300b776ceb53fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634704 Auto-Submit: Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#664381}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/85a9d91cd4cf..740cc35145c0 git log 85a9d91cd4cf..740cc35145c0 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d4906ebd..8891f34d (664184:664289) 2019-05-29 emilio@mozilla.com Fix build with recent linux kernel. Created with: gclient setdep -r src/third_party/webrtc@740cc35145c0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie85f17e3a87026e739f474f550a62024c9dd27dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634715Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664380}
-
Olya Kalitova authored
Adds PluginVm.SetupResult UMA metric histogram. Records a setup result at each PluginVm setup attempt being finished which includes user cancellations, errors and successful setup. Test: browser_tests --gtest_filter="PluginVmLauncherViewBrowserTest.*" Bug: 962952 Change-Id: I3cf47f08f3ec8e86f2b844c09d5d36215b9f956c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621127Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#664379}
-
Wei-Yin Chen (陳威尹) authored
Only call Resource#getBitmap once per onResourceLoaded(), and assert DynamicResource#getBitmap is only called when dirty. This makes it possible to release the local Bitmap copy in BitmapDynamicResource when it is passed to the native side. The only user of BitmapDynamicResource is LayerTitleCache, which releases resources explicitly itself, so this CL doesn't reduce memory usage. However, this should make memory leak less likely for the next user. Bug: 965580 Change-Id: I00c3032f05dbe0cd66881cd99063ed4fb82cb0fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626992 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#664378}
-
Daniel Nicoara authored
Allows the fullscreen client to be executed with a custom transform. (Valid values are 0, 90, 180, 270). This means the client will allocate buffers in the native display space (useful for overlay support). The transform hint is used to inform the compositor of the correct rendering orientation of the client surface. Bug: None Test: wayland_fullscreen_client --transform="90" Change-Id: I6be91c8f6d3a027466581f680c186614fcbd25d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631728 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#664377}
-
Chris Palmer authored
Support for HPKP has now been removed since M72. Also, it was never widely adopted (part of the reason for deprecating and removing it). This warning likely serves no purpose now. Bug: 941776 Change-Id: I76d5d5673099600f80078fc7b5d41d3d050a13a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632307Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#664376}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3afdede03f34..9d4f217992f9 Created with: gclient setdep -r src-internal@9d4f217992f9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I963a440333a0d7d229331c4f45c04036bbea9b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634714Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664375}
-
Michael Thiessen authored
Also added some general guidance on which reviewers to add for which changes. Change-Id: Idb8f908ff044e82e40e13dc561f0263c2965bb7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634558Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#664374}
-
Vasilii Sukhanov authored
They are PasswordManager.PasswordDropdownShown and PasswordManager.PasswordDropdownItemSelected. The data can be useful for other platforms. Bug: 967497 Change-Id: Id834e8096ecf321440a6fde2c4a3bca064e09e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634870 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#664373}
-
Matt Simmons authored
If the omnibox is showing in tab switcher mode, fade out the tab switcher toolbar when the url bar gains focus. Ideally, this would be done on text change (!isEmpty) but the TopToolbarCoordinator has no observer for text changes. R=yusufo@chromium.org Bug: 967961 Change-Id: I962f51d3247bf2cc936343988e2ff497b5a74fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635352Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#664372}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=isherman@chromium.org Bug: 887407 Change-Id: Ifa246b5010783a683b041675dcd5422783bac3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631703Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#664371}
-
Avery Musbach authored
overview: Avoid ending overview because of window activation change while an overview item is being dragged The present CL aims to address a problem similar to [1]. [2] addresses [1] by modifying OverviewSession:OnWindowActivating() to avoid ending overview while there exists a window in a dragged state. That solution is fine for workflows where a window is dragged from the top in tablet mode, but there is a similar problem (possibly introduced by [3], which I have reverted but would like to reland) involving overview item dragging, which is handled by OverviewWindowDragController and does not put any window in a dragged state. [1] https://crbug.com/955814 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1626542 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1627562 Bug: 961170, 967196 Change-Id: I059127b88b343ea56a995bd7b815d5f434877064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633109Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#664370}
-