- 21 Jan, 2021 40 commits
-
-
Michael Crouse authored
This is a reland of a4df03d0 This addresses the revert by removing neon from the TFLite build for chromeos. Original change's description: > [TFLite] Enable tflite in build for android and desktop. > > Bug: 1165517 > Binary-Size: Expected increase due to inclusion of TFLite in binary. > Change-Id: I1c4c7b26f257c152d9477855ad32a77c0d30b85f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616241 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845026} Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Bug: 1165517 Binary-Size: Expected increase due to inclusion of TFLite in binary. TBR: Andrew Grieve <agrieve@chromium.org> TBR: Tarun Bansal <tbansal@chromium.org> Change-Id: I4b6b21b4a23a0c6978bfbb57150e9bf81300059f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639648 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#845478}
-
Will Cassella authored
The previous logic for what intrinsic size to give to a video element was based on outdated spec text, this CL updates it to prevent the poster image from resizing between starting playback and the first video frame being rendered. Bug: 1154296 Change-Id: I41a91f6672d8ccf4e3069afe581fac39f1a58820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617870 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845477}
-
Martin Kreichgauer authored
This changes the ChromeOS platform authenticator to be available in Incognito mode (but not Guest modes), same as the macOS platform authenticator already behaves. During makeCredential requests, an extra interstitial is shown that prompts the user to confirm that the credential will outlive the Incognito session. Strings in that dialog are changed to be platform agnostic. (They also outdatedly referred to the macOS platform authenticator as "Touch ID"). UXW doc: https://docs.google.com/document/d/19zW_FbD8mLBMc-Tfvg6GT632UQaC9IGn2kqQkI_FaxM/edit Bug: 1157651,1111095 Change-Id: I3aca0e7e16fd763e39190536d63bcfcc0cb5dc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587789 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#845476}
-
Josh Nohle authored
Log whether or not a remote device is able to be discovered from a given advertisement. We also log the candidate remote device's device ID and beacon seeds to ensure that the remote device record is not stale. We log times in human-readable format. Bug: 1157278 Change-Id: I202f9f1a13deba998ddff06dd9ca82b92737abae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639649 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#845475}
-
Alison Maher authored
When investigating CL:2627779, I had noticed a few other color properties we weren't adjusting for in forced colors mode: stop-color, flood-color, and lighting-color. In most cases, this shouldn't make a difference since SVG elements are set to 'forced-color-adjust: none' by default, but I figured these would be good to include for consistency. Bug: 1166911 Change-Id: I47d16b20309565d28e24e1410115b5a36f22a662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633944Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#845474}
-
Olivier Yiptong authored
This change restricts the fonts displayed to the user when a chooser is shown. This constraint to the list is implemented as an exact-match with items supplied in a list with the postscript names of the available fonts. Fixed: 1164077 Change-Id: If3e3e0cba91de83bc0a39ffe382f13cb38f7be35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626117 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845473}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/124f532d052d..ec4d81245d2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC harringtond@google.com,keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150968 Tbr: harringtond@google.com,keishi@google.com Change-Id: Idc72ac2fe7dd1d1710b431a0327a487b6790e6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641274Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845472}
-
Peter Kasting authored
Bug: 1159562 Change-Id: Iff9c81a9b640255d4e5c22c0a42cfc44c37607d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634011 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#845471}
-
David Black authored
Insets and child spacing were off by a little. Bug: 1168813 Change-Id: I5b0d80d5d255aeda6ba103d43645465cc4125864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641337Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#845470}
-
Aaron Krajeski authored
(Hopefully) the final part of the greater effort to migrate the paint_op_buffer away from SkMatrix, which is 3x3 and relatively slow, towards to SkM44. Two functions were added to paint op buffer in previous Cls, Concat44 https://chromium-review.googlesource.com/c/chromium/src/+/2577704 SetMatrix44 https://chromium-review.googlesource.com/c/chromium/src/+/2562783 Each of these take an SkM44 as an argument instead of an SkMatrix. This CL changes the implementation of RecordPaintCanvas::setMatrix so that it always ends up sending an SkM44 to the paint op buffer and removes the older implementation of SetMatrixOp (that used an SkMatrix). Now there is only one setMatrix operation in the paint op buffer. Bug: 1155544, 1167153, 1140535 Change-Id: I1112bf9a4e429a80c9f5c4265959c84aaf1633d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640814Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#845469}
-
Victor Costan authored
* Fix potential data races while accessing the `QuotaManagerProxy::manager_` pointer. Also add GUARDED_BY_CONTEXT() annotations to prevent similar issues in the future. * Remove the friendship between QuotaManager and QuotaManagerProxy. This was needed for direct access to the `QuotaManagerProxy::manager_` pointer, which is replaced with an explicit API restricted to QuotaManager via base::PassKey. * Replace the browser-specific `io_thread_` member name with the more semantically useful `quota_manager_task_runner_`. * Reduce the space of possible states by requiring that the TaskRunner member is always non-null. No functional changes are introduced, asides from the data race fixes. Bug: 1168597 Change-Id: Ia0831a9c68a215084a65013296e5749948081d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637953 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#845468}
-
Harvey Yang authored
As IIO Service won't close Mojo connections without a valid reason, the code should assume IIO Service crashes on Mojo disconnects instead of trying to reconnect. BUG=b:172414302 TEST=unit tests and run on kohaku Change-Id: I12b6a6ed7d0b044196505116acd662b6de330cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599682Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#845467}
-
Jan Krcal authored
This is a reland of bedb24da Original change's description: > [Profile creation] Add {back,reload} accelerators for navigation > > This CL adds two accelerators into the profile creation flow to improve > accessibility and usability: > - the back action for screens that actually show the back button > - the reload action for the sign-in flow that happens over the internet > and thus loading of the page can fail. > > Bug: 1126913, 1167675 > Change-Id: I3c197dea2859c0136db62249064249e0569a93da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627403 > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844695} Bug: 1126913 Bug: 1167675 Change-Id: I1763dcd1663cddcfce901a6954381a40142c705e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637475 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#845466}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cc0d6b82f912..beb8370c49f2 2021-01-21 fancl@chromium.org E-Divisive: Improve permutation test and Estimator If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: Id3b347011455a9473a7d1ff098b265cc656886b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640835Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845465}
-
David Tseng authored
Do this to address possible issues with document.body availability. R=katie@chromium.org Test: manual. Change-Id: I42a727829a8552de1609bdc8b3af2f10503c4121 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640730Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#845464}
-
Kelvin Jiang authored
declarative extension user scripts (from RequestContentScript/dynamic content scripts API/webview) will all be moved into ExtensionUserScriptManager. This rename is the first step of that process. Bug: 1168627 Change-Id: I4e69dde79210bc87d13fb620106fd513082a7f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639867Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#845463}
-
Takumi Fujimoto authored
The extension is being deprecated soon so the histograms should no longer be necessary by this time next year, but we'll keep them around until then in case we need them during the turndown. Bug: 1160947 Change-Id: Iebc7f139b22dd4759c626bb9692b752e42f1e6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637959Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#845462}
-
David Schinazi authored
This should have been done as part of crrev.com/c/2636880 yesterday, and will allow us to launch the change. R=renjietang@chromium.org Bug: 1134205 Change-Id: Ie05c602d83bb9bbf84c9cb7ec3baaea816377b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641168 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#845461}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/f8f35c95550e6796ab8b2c0f8e37e7ce4bc67302..c47bfce062cc5a1b462176be626338224ae2a346 The following commits have update notes: c1e156ae1 Add DH_compute_key_padded. c47bfce06 Define TLSEXT_TYPE_quic_transport_parameters to the old code point for now. Bug: none Change-Id: I6de44c6146ee4b045cba1c2396d23767f5d8b303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639863 Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#845460}
-
Ossama Mahmoud authored
Remove extra divs to eliminate the OobeDialogHostBehavior. Bug: 1159461 Change-Id: I91349988eb89e840e5e460ce909a87ba5378f216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605559 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845459}
-
Bartek Nowierski authored
FromSlot(Start|Inner)Ptr & To SlotSpanStartPtr better describe the intention. While renaming, it became obvious that some of those functions can and should be converted to the stricter version FromSlotStartPtr. Updated variable names while at it, mostly |ptr|->|slot_start|, but not only. Change-Id: Ia1fb172f2d064e4806ec8e5b37c93316db34696f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636733Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#845458}
-
Josh Nohle authored
Chrome OS currently requires Bluetooth to establish the initial Nearby connection. Until, other mediums are supported, we require that a Bluetooth MAC address is included in the private certificate metadata. If the MAC address is not available at the time of private certificate creation, the attempt will fail, and retries will be attempted on an exponential backoff schedule. Note: Metrics currently show that 5-10% of private certificates are missing a Bluetooth MAC address. Fixed: 1122641 Change-Id: I5cf28225180529f08b5e5a1c310f9499ee15582e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631931Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
-
rbpotter authored
This is in preparation for converting net internals to JS modules and autogenerating the grd file. Bug: 1132403,1152343 Change-Id: Ie6cb09197f71b0b18de3e9b252161de8c064b601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639274Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#845456}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/80d2a97665e9..3195d3ea0758 2021-01-20 jalyn@microsoft.com Settings: Allow shortcut link to wrap properly If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1164887 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1d26a230437a72ec6df59758ec4bef04b2e1ada6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641177Reviewed-by:
-
Henrique Ferreiro authored
This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1101837, 1164001 Change-Id: Iad2ee2eee89b8b483543896abb9ed123c826281f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640114Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#845454}
-
Joel Hockey authored
Refactor only change. Now that EndpointType exists, we will use it rather than passing a source or target aura::Window* for functions in exo::DataExchangeDelegate. Removed (inlined) 1-liner function SetSourceOnOSExchangeData which does not relate to DataExchangeDelegate. Bug: b/162602338 Change-Id: I20e7aa0c3702155bdafcc15a101c22668a62f621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639719Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#845453}
-
Ryan Hansberry authored
The method calling ServerSocket::Disconnect() is expected to be called multiple times. This CL ensures ServerSocket::Disconnect() is only once, to prevent calling on an invalid ServerSocket reference. Fixed: 1168778 Change-Id: Icddfd96cf71329a9599e082752dfc2956e4e2c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639147 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Filip Gorski authored
When #setCustomSelectionActionModeCallback is set to null on a view for certain devices running O, it can cause an NPE. This fixes the issue and prevents setting it to null, unless it is already set, which we don't do at this point. Bug: 1168441 Change-Id: I0ab5ea9ea7ca3bab624af087264d75694fb9ec5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641055 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#845451}
-
Siyu An authored
Approval @ crbug.com/1123804 This also puts some to-be-deprecated tests under flag protection. Those along with the experiment branching logic will be cleaned up later Bug: 1070799 Change-Id: I24b35699a2f0e76ccf12467759fa8583534602ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600041Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#845450}
-
Kenneth Russell authored
In this scenario, the WebGL canvas's ResourceProvider holds a copy of the rendered content. This ResourceProvider is purged when the tab is backgrounded, so ensure it is repopulated even if the canvas thinks its state has not changed. Thanks to Xing Xu from Intel for the original CL and test case. Bug: 736969 Change-Id: Ib57a65f1fee2ab95099b335171034d83ce9ec29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639295 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#845449}
-
chrome://flagsSam Goto authored
WebID is currently enabled via running the binary with --enable-features=WebID. That's harder to find than it needs to be, for example, on a Mac. In this CL, we tie WebID to the set of experimental web platform features flag, which is available to be toggled via chrome://flags. Bug: 1141125 Change-Id: Ib08426b6b04283d2b5780623532456d9eec0b2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630429 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Auto-Submit: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#845448}
-
Esmael El-Moslimany authored
When a user opens multiple New Tabs rapidly, it's possible for multiple callbacks to await a single OGB response. When multiple callbacks have been collected, the OGB response should be sent to each callback. Due to a bug uncovered when disabling caching, only the first callback was getting the correct OGB response. All the rest of the callbacks would get an empty string. Bug: 1167526 Change-Id: I0d57aeb844251b222166bbc4d6236d7df73d9bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638928 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845447}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/base. Bug: 1148570 Change-Id: I5274cd0bf20a8567ca96d5271273cbc11b385854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641319 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#845446}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0fc3eb77. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I9cc3c4319073afc530029dcf5b1627b29eb8a7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640197Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845445}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3253a1deca58..13ea7423612a 2021-01-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Id01ab5141f94106d320b4cdb9cd0bf5b07a705d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641393Reviewed-by:
-
dpapad authored
For example target names like "print_preview_resources" or "tab_strip_resources" made sense when those targets did not reside in print_preview/ and tab_strip/ respectively. The prefixes can now be removed as the context is already obvious by the parent folder. Bug: 1132403 Change-Id: I9e5628b510337073de7687a409e16b7eb75d5666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639803 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#845443}
-
Andrew Grieve authored
Bug: 1168298 Change-Id: I4ddebb5e7e2c21b88b0b98877b1f2e802b58bd63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639154Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#845442}
-
Tal Pressman authored
This is no longer the recommended style and, in fact, https://abseil.io/tips/141 recommends against relying on implicit conversions to boolean in conditions. Change-Id: I42c2ea59e23deb6f97ac187bef13d32861873444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636975Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#845441}
-
Charlie Reis authored
The reload detection in NavigationEntryCommitted depends on stale code that is being removed, and using a NavigationHandle in DidFinishNavigation is a more modern approach. This CL updates the check accordingly so that we can remove NAVIGATION_TYPE_SAME_ENTRY. Some duplication occurs due to https://crbug.com/1064974. Bug: 536102, 1064974 Change-Id: I7b908770cfceebc696bff9e900da78c28d1b2f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628652Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#845440}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/extensions. Bug: 1148570 Change-Id: I1e7b85a60ee05d8859fc1d507742a4c08fb6c5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638568 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
