- 26 Aug, 2018 13 commits
-
-
Haeun Kim authored
Use ContainsValue() instead of std::find() in chrome/browser Bug: 561800 Change-Id: I6c2af9884029644de51bbf19507edac55b8f57b9 Reviewed-on: https://chromium-review.googlesource.com/1188723 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#586168}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/471a946cf126..b5729c94f9a7 git log 471a946cf126..b5729c94f9a7 --date=short --no-merges --format='%ad %ae %s' 2018-08-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@b5729c94f9a7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I106e8e100ae89da4358649cb9cfdc2e660724209 Reviewed-on: https://chromium-review.googlesource.com/1188805Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586167}
-
Victor Costan authored
Passing smart pointes by reference / const reference is strongly discouraged by the Chromium C++ style guide and makes the ownership semantics unclear. Change-Id: I937d29c18fcb7213dda5df6e5a26941b8ef484e2 Reviewed-on: https://chromium-review.googlesource.com/1189173Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#586166}
-
BUG=762641 TBR=derat@chromium.org Change-Id: I04a0960c2e99376f9367483647fb484b277ca4e9 Reviewed-on: https://chromium-review.googlesource.com/1189193Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586165}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/89e0fadc..51e736ca Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibe3f493b2607efd60b49dd69ded3f6494e403fb4 Reviewed-on: https://chromium-review.googlesource.com/1189544Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586164}
-
David Black authored
Previously, dismissing virtual keyboard with Assistant visible would leave it suspended mid-air. Bug: b:112846308 Change-Id: I2ce4e7da2495e6ba13059108e3982725a0a754db Reviewed-on: https://chromium-review.googlesource.com/1189447Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#586163}
-
David Black authored
When modifying view borders, we need to trigger a PreferredSizeChanged event because our preferred size may have indeed changed. When we don't do this, space may be robbed from other views during a layout pass to accomodate these borders. This manifested itself in some cases by stealing space from the UiElementContainerView which caused clipping of its content. Before: https://drive.google.com/open?id=1YkbyNdjtIMwa5fH8BclncCkhEiyCPzJZ Bug: b:112277188 Change-Id: Id223c7882f164ac44b989fb394170247ca9c045f Reviewed-on: https://chromium-review.googlesource.com/1188459Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I93647d276e2f99f832d11cdc1c6ed90abe27883c Reviewed-on: https://chromium-review.googlesource.com/1189207Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#586161}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/305498942654..471a946cf126 git log 305498942654..471a946cf126 --date=short --no-merges --format='%ad %ae %s' 2018-08-26 fmalita@chromium.org [skottie] Make AnimationBuilder available for value parsing Created with: gclient setdep -r src/third_party/skia@471a946cf126 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Iee66ebdf510bc87691cbbc704fe64068e0b645b2 Reviewed-on: https://chromium-review.googlesource.com/1189036Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0093536e..89e0fadc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I11fccb2163a3f3dbcef17377e2e71797621c041e Reviewed-on: https://chromium-review.googlesource.com/1189442Reviewed-by:
-
Alexei Filippov authored
The patch makes OOPHP use base::SamplingHeapProfiler in the sampling mode. BUG=876581 Change-Id: I179dbc9a40127a3fe9370c9ed0222ee45fc0556d Reviewed-on: https://chromium-review.googlesource.com/1184229 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#586158}
-
Alexander Alekseev authored
Bug: 862853 Change-Id: I5277cc404c9829353e38614b1fa94223e52152c8 Reviewed-on: https://chromium-review.googlesource.com/1188426 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#586157}
-
Stefan Zager authored
BUG=874677 R=pdr@chromium.org Change-Id: I55cf0111906307211668dd6a1448787b7e971586 Reviewed-on: https://chromium-review.googlesource.com/1188586Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#586156}
-
- 25 Aug, 2018 27 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium cc09ed9d. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23310 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ecobos@igalia.com: external/wpt/css/css-display NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I38e313b5edc66ad8b93a2f171b3f769263385bd6 Reviewed-on: https://chromium-review.googlesource.com/1189443 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#586155}
-
Farah Charab authored
Test disabled on Linux due to flakiness. However, it wasn't linked to a relevant bug. Also, I run this for 2+ hours on a Linux workstation and I got no failures. So, I am landing this unit test again. Bug: 875170 Change-Id: Ic6719945d85c0d0e707aa809cbbb18d10ed9bfb3 Reviewed-on: https://chromium-review.googlesource.com/1188320 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#586154}
-
Alexey Kozyatinskiy authored
V8 roll won't contatin hack that we used to calculate source position of EOS. This hack was introduced long time ago and is not needed now. TBR=dgozman@chromium.org Bug: v8/8092 Change-Id: I981fa08fb2bb9b9ecfb9a262571b0e07dce9ed07 Reviewed-on: https://chromium-review.googlesource.com/1188700Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#586153}
-
Wez authored
This reverts commit e0a83f96. Reason for revert: ContentTestSuiteBase is used as the base for both ContentTestSuite and ContentBrowserTestSuite, as well as for Chrome and extensions browser-test suites, so putting RegisterPathProvider() in the base class causes duplicate-registration errors in browser-tests. e.g see: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20(dbg)(1)/73970 Original change's description: > Move RegisterPathProvider() from ContentTestSuite to ContentTestSuiteBase > > Fixes network_service_content_browsertests RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler > failing to find the utility service process exe on Windows, like: > [FATAL:utility_process_host.cc(263)] Check failed: false. Unable to get utility process binary name. > > Bug: 876947 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ia7f51366e4b4db27ec8c3bbee3d57866c1bd67b9 > Reviewed-on: https://chromium-review.googlesource.com/1185628 > Commit-Queue: Matt Mueller <mattm@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586063} TBR=jam@chromium.org,mattm@chromium.org Change-Id: I649f105c58d9643dd4cab5aa685b3c6e4556097e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 876947 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1189444Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#586152}
-
Wez authored
The test assumes specific values of DummyRefCounted::ref_invokes_count_ without re-setting it to zero at the start of the test. TBR: haraken Change-Id: I265fad41cbfa5b8692a7f620d4fa253736d32c74 Reviewed-on: https://chromium-review.googlesource.com/1188701Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I9069bc96da6719441fb0ef627f55cd9fa073dcdf Reviewed-on: https://chromium-review.googlesource.com/1188699Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586150}
-
Alexey Kozyatinskiy authored
R=lushnikov@chromium.org Bug: chromium:646849 Change-Id: I8141bcdcfef7d9734ee9f1c97bfa552160fdcd9d Reviewed-on: https://chromium-review.googlesource.com/1182865 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#586149}
-
Alexey Kozyatinskiy authored
Blackbox manager may update location that we show for console message when top frame is blackboxed / unblackboxed. R=luoe@chromium.org Bug: chromium:873789 Change-Id: I8500d07877dfa6f08b57ccfb7236ad44e124137a Reviewed-on: https://chromium-review.googlesource.com/1183682Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f582e98..0093536e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1a2091733637a84c9ebba2ba05698ba6d2fe084a Reviewed-on: https://chromium-review.googlesource.com/1188693Reviewed-by:
-
Wez authored
- Fix AXPlatformUniqueIdTest.TestIdsNotReused, which made invalid assumptions about the specific identifier values that would be assigned. - Remove unused AXPlatformUniqueIdTest base-class. - Renamed both AXPlatformUniqueIdTests to better reflect their purpose. TBR: aleventhal Bug: 877777, 797992 Change-Id: I0f86092e4e785843522913fa98b0222e04dbd67d Reviewed-on: https://chromium-review.googlesource.com/1188698Reviewed-by:
-
Ned Nguyen authored
Change-Id: I401964008d178401c1066dc7968944ecbfee2bbe TBR=mythria@chromium.org Change-Id: I401964008d178401c1066dc7968944ecbfee2bbe Reviewed-on: https://chromium-review.googlesource.com/1184971Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#586145}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/95be425f5b30..305498942654 git log 95be425f5b30..305498942654 --date=short --no-merges --format='%ad %ae %s' 2018-08-25 reed@google.com do reject vertical lines if they are outside of the clip Created with: gclient setdep -r src/third_party/skia@305498942654 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I50ce9ceae5c85ae5e65e63834ebb71f4a2e05220 Reviewed-on: https://chromium-review.googlesource.com/1189035Reviewed-by:
-
Sadrul Habib Chowdhury authored
crrev.com/562737 made a change to update the surface-layer with the appropriate primary/fallback surfaces (and bounds) during surface activation. This was to improve performance with surface-sync. However, this ended up triggering a regression in the input pipeline (see linked bugs). So, update the code so that when surface-sync is not used, the surface-layer is destroyed during eviction, and recreated as needed. BUG=867581 Change-Id: I0c07f5782c06de171bec131014b66eab9a09b879 Reviewed-on: https://chromium-review.googlesource.com/1187277 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#586143}
-
Ravi Mistry authored
This is a temporary workaround till we figure out a better way to do it. TBR=agrieve@chromium.org Bug: chromium:787005 Bug: skia:8284 Change-Id: Ibc30bf17a22d4fcca31dab20addfd36b6a14f596 Reviewed-on: https://chromium-review.googlesource.com/1189187 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#586142}
-
Kurt Horimoto authored
Only one browser UI is shown at a time, so a single FullscreenController is needed for both the normal and incognito BrowserStates. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic08edb4a6c622a8dbeefc4ce02afbb35dbca9f0d Reviewed-on: https://chromium-review.googlesource.com/1184163 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#586141}
-
Kushagra Sinha authored
Add a submenu for Chrome OS Account Manager in the People section of Settings. This will link to the Chrome OS Account Manager Settings subpage. This will be visible only if the Chrome OS Account Manager feature is enabled. Bug: 833797 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id9e6a339ef16db6dbd14a6827df6fdf02c66d913 Reviewed-on: https://chromium-review.googlesource.com/1186584Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#586140}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8dabf7bda37f..cd12ac0efdbd git log 8dabf7bda37f..cd12ac0efdbd --date=short --no-merges --format='%ad %ae %s' 2018-08-25 vapier@chromium.org cros_run_unit_tests: run unittests for common.mk packages Created with: gclient setdep -r src/third_party/chromite@cd12ac0efdbd The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I64f2c084c399e94ddd269bb1263cf4e29c98f90d Reviewed-on: https://chromium-review.googlesource.com/1189343Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586139}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3cef5025. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23279 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I2b9d055130eb28143f219d445e059ad713d3b447 Reviewed-on: https://chromium-review.googlesource.com/1188831 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Miguel Casas authored
- s/arraysize/base::size/ (see crbug.com/837308#c15 for decltype trick). - s/base::bind/base::BindRepeating/ (and s/Closure/RepeatingClosure/). Bug: 876810, 837308 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0068d55985c5c4fdcf1ed987e278f402fd0e6ac0 Reviewed-on: https://chromium-review.googlesource.com/1189103Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#586137}
-
Koji Ishii authored
NGColumnLayoutAlgorithm produces a fragment for the multi- column container, then fragments for column bxoes, and flow the content into the column boxes. In the current implementation, the multi-column container and the column boxes have the same LayoutBlockFlow and that we have some places we need to handle the column containers differently. With this patch, such fragments have kColumnBox box type so that they are explicitly distinguishable. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iefb7c5ac0c5869bf30b053f435a3408403d2e9f9 Reviewed-on: https://chromium-review.googlesource.com/1175588Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#586136}
-
Alexander Alekseev authored
TBR=jdufault@chromium.org Bug: 864679 Change-Id: I2b28552eff792cceae30c18d93bf1a094af18949 Reviewed-on: https://chromium-review.googlesource.com/1188424 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#586135}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7b7eb8800be0..2d0e03cb5ddc git log 7b7eb8800be0..2d0e03cb5ddc --date=short --no-merges --format='%ad %ae %s' 2018-08-25 tandrii@chromium.org git cl: safe fallback for Gerrit RPCs even if gerrit project is unknown. Created with: gclient setdep -r src/third_party/depot_tools@2d0e03cb5ddc The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:876910 TBR=agable@chromium.org Change-Id: Iea89e24017951b3d180ff3f0c710b59b8d0efd49 Reviewed-on: https://chromium-review.googlesource.com/1188937Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586134}
-
Alexander Alekseev authored
Bug: 862852 Change-Id: I045023abf2a303f9ee0f08afc340ccbac9929a55 Reviewed-on: https://chromium-review.googlesource.com/1188485 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Calder Kitagawa authored
This is phase 4 of the work to update the WebShareTarget spec. This CL removes the old style url_template. All clients only use the new action and parameter based model. Bug: 871788 Change-Id: I0c4b3a20a4afa0d1b24bde7f52941d399ac7048e Reviewed-on: https://chromium-review.googlesource.com/1185847Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#586132}
-
Findit authored
This reverts commit a0f6eb42. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 586121 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwZjZlYjQyY2FkYTk4NDZmYjQ0ZTA0MzkyMTcwZGRiOWM1YzQ4ODgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/7482 Sample Failed Step: unit_tests Original change's description: > Allow to use ARC IMEs only in tablet mode. > > This CL also changes InputMethodManagerImpl and language settings api to > allow ArcInputMethodManagerService to restrict ARC IMEs. > > Bug: 845079 > Test: Ran on DUT and unit tests. > Change-Id: I61516b3c6a65775f42aae7e51583e933d55ab1b6 > Reviewed-on: https://chromium-review.googlesource.com/1179733 > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586121} Change-Id: I8d75017944b0b048af795e4826d5ec5fb0a7256e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845079 Reviewed-on: https://chromium-review.googlesource.com/1188826 Cr-Commit-Position: refs/heads/master@{#586131}
-
Niels Möller authored
The latter class is from webrtc/api/test, hence publicly advertised by webrtc, while the former is unused in webrtc and likely to be deleted, see https://webrtc-review.googlesource.com/c/src/+/95421 Bug: None Change-Id: I5843bf26c64cdac7f3b30a9c631ea81e15ab1a89 Reviewed-on: https://chromium-review.googlesource.com/1186322 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#586130}
-
Daniel Cheng authored
The nonce allows a unique origin to be same origin with itself, as well as copies of itself. blink::SecurityOrigin and IPC are not yet updated to propagate the necessary information through all the layers. Bug: 768460 Change-Id: I1bfce592f3fa576dff18eb7fe2071742e82d1768 Reviewed-on: https://chromium-review.googlesource.com/745986 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#586129}
-
