- 23 Aug, 2018 13 commits
-
-
Alexey Baskakov authored
Fix all GN issues and add the following to GN check_targets: //apps/* //chrome/browser/apps/* //chrome/browser/web_applications/* to make `gn check` working again. Drive by: Extract web_applications:browser_tests source set in GN. TBR=dpranke@chromium.org Bug: 367595 Change-Id: I8704d4893554fc4028c09d681871a05bc56ddbcf Reviewed-on: https://chromium-review.googlesource.com/1182902 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#585333}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7e7e0b8379c4..81e0830e6734 git log 7e7e0b8379c4..81e0830e6734 --date=short --no-merges --format='%ad %ae %s' 2018-08-22 hnakashima@chromium.org Simplify internal state of CBC_BarcodeMatrix. 2018-08-22 hnakashima@chromium.org Remove unused barcode matrix scaling code. 2018-08-22 rharrison@chromium.org Properly handle language markers in decoded text Created with: gclient setdep -r src/third_party/pdfium@81e0830e6734 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I29439ab1c305a115569bccb0a3bd6e46f0a482bf Reviewed-on: https://chromium-review.googlesource.com/1185686Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585332}
-
Will Harris authored
../../chrome_elf/pe_image_safe/pe_image_safe.cc(76,75): error: implicit conversion loses integer precision: 'long long' to 'DWORD' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32] DWORD optional_header_offset = reinterpret_cast<char*>(optional_header) - ~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ ../../chrome_elf/third_party_dlls/main.cc(77,54): error: implicit conversion loses integer precision: 'std::vector<unsigned char, std::allocator<unsigned char> >::size_type' (aka 'unsigned long long') to 'DWORD' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32] value_bytes.data(), value_bytes.size()); ~~~~~~~~~~~~^~~~~~ ../../chrome_elf/third_party_dlls/logs.cc(127,46): error: implicit conversion loses integer precision: 'unsigned long long' to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32] : kMaxLogEntries - entries_.size(); ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ ../../chrome_elf/third_party_dlls/hook.cc(283,32): error: implicit conversion loses integer precision: 'ULONG_PTR' (aka 'unsigned long long') to 'DWORD' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32] if (!GetDataFromImage(*base, *view_size, &time_date_stamp, &image_size, ~~~~~~~~~~~~~~~~ ^~~~~~~~~~ BUG=588506 Change-Id: I82abea7b741de1c56e9bcd1ce8c5bd59357ed20b Reviewed-on: https://chromium-review.googlesource.com/1184318 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#585331}
-
Erik Chen authored
The option --use-isolate-files causes compare_build_artifacts.py to compare the files referenced by .isolate. It should also compare the contents of .isolated files. Bug: 876915 Change-Id: I06eb0d3373493db90b75befe9e0b47c9de58cbe0 Reviewed-on: https://chromium-review.googlesource.com/1185991Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585330}
-
Reilly Grant authored
This change makes Web Bluetooth available by default thanks to the new WinRT-based Bluetooth Low Energy backend. Bug: 419413 Change-Id: I112349b9ede67c1217cbde6ac6a04a8bea9201b7 Reviewed-on: https://chromium-review.googlesource.com/1184970 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585329}
-
Hiroshi Ichikawa authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1a0354accc09e93c0c931e7528dce70aadfd3411 Reviewed-on: https://chromium-review.googlesource.com/1159930Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#585328}
-
Trent Apted authored
Follow-ups to review comments in https://crrev.com/c/1053338 Bug: 842987 Change-Id: I1cf78667887bb86555d3f9043e2afe5d8eacf2bb Reviewed-on: https://chromium-review.googlesource.com/1184590Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#585327}
-
Hector Carmona authored
This is technical debt that will be more expensive if we build out the email NUX before resolving. Bug: None Change-Id: Ibb92872a55bc6089a7fcda6dc52064f4ef87150a Reviewed-on: https://chromium-review.googlesource.com/1183844Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#585326}
-
Kevin Marshall authored
The test is disabled because it is causing false negatives on the bots. It will be reenabled once the root cause is diagnosed and addressed. TBR=skym@chromium.org Bug: 876894 Change-Id: I5ab50f94768bdcd27e06d9f435eddadbf1e1ec5f Reviewed-on: https://chromium-review.googlesource.com/1186029Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#585325}
-
James Cook authored
This simplifies teardown, especially in ash on Chrome OS. Also add tests for the code in crrev.com/c/1180070 which generally skips event dispatch during shutdown. Bug: 874156 Test: added to aura_unittests Change-Id: I1356c3a1ab09f07d23dca1545d3159fcc4016e2d Reviewed-on: https://chromium-review.googlesource.com/1181537Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#585324}
-
Wez authored
Bug: 875486 Change-Id: I448361ccdb91b83ab71c6eda34066e6e76c278de Reviewed-on: https://chromium-review.googlesource.com/1185490Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#585323}
-
Kai Ninomiya authored
For camera-to-WebGL on Nexus 6P at 720p, this improves blocking texImage2D time from ~12ms to ~4ms (200% speedup). On some other devices and resolutions, I think there can be up to a ~10x speedup. * Adds an optimized upload path for CPU-side YUV video frames (e.g. those coming from a video camera on Android). This path uploads the individual Y/U/V textures to the GPU, performs a GPU YUV-RGB decode, and copies the result into the WebGL texture. This code path could potentially be further optimized in 2 ways: * Avoid the extra copy of the CPU-side YUV data from browser-renderer shared memory (VideoFrame::STORAGE_SHMEM) to renderer-gpu shared memory (transfer buffer, probably). * Avoid the extra copy from the decoded image (SkImage) into the WebGL texture, and instead decode directly into the WebGL texture. * Removes an old GPU-GPU path that was obsoleted by CopyVideoTextureToPlatformTexture. This obsolete path was only handling CPU-GPU uploads instead of GPU-GPU uploads, and it was doing so by performing an expensive YUV-RGB conversion on the CPU. This also allowed some cleanup in TexImageHelperHTMLVideoElement. Bug: 867368 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id25d5dbfc76ec8f9dc606890588a20978f6943f6 Reviewed-on: https://chromium-review.googlesource.com/1161606 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#585322}
-
bsheedy authored
Modifies an existing test that brings up a keyboard so that it also inputs text via the keyboard. This is to catch future occurances of https://crbug.com/874671 where inputting text into the VR Browser's omnibox would cause a browser crash. Also installs the latest VR Keyboard APK as part of pre-test setup in test suites that could potentially use the keyboard. Bug: 874671, 874696 Change-Id: Ic04d678e14de918fbf159078422c9d5459e8d98d Reviewed-on: https://chromium-review.googlesource.com/1176876Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585321}
-
- 22 Aug, 2018 27 commits
-
-
Kevin Marshall authored
This method calls directly into WebContents::Stop(). Added a test case for end-to-end verification of browser behavior. Bug: 852145 Change-Id: Ia1301976542e3b4996579422b98e4d2ae41ea646 Reviewed-on: https://chromium-review.googlesource.com/1185737 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585320}
-
Lei Zhang authored
Most PrintPreviewHandler methods have the request ID last. Change-Id: Ie5d21e108df05859fb5b11229a2f97bd0ae93ff1 Reviewed-on: https://chromium-review.googlesource.com/1184384Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585319}
-
Hans Wennborg authored
This is a reland of 1501aabf The goma failures which caused the previous revert are believe to be flaky. Original change's description: > Clang: stop building with GCC/libstdc++ from Ubuntu Precise (roll 338452-1:338452-2) > > Previously we used a GCC/libstdc++ package from Ubuntu Precise to build a Clang > that would work on Precise or later. These days, all bots and developers are on > Trusty or later, so this should no longer be necessary. > > Bug: none > Change-Id: I518ee55d07c04dc89163fe262c81d935e05fed78 > Reviewed-on: https://chromium-review.googlesource.com/1183915 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585067} TBR=thakis Bug: none Change-Id: Ibd2be5064bbdf0ed36aa09c0525825c530465813 Reviewed-on: https://chromium-review.googlesource.com/1185684Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#585318}
-
Kevin Marshall authored
Replaces the FIDL event based handler for navigation events with a NavigationEventObserver class, which can be set or removed at any point over the lifetime of a Frame. The Observer uses acknowledgement closures for flow control. The client signals that it is ready to receive an additional navigation event by invoking the closure. Bug: 852145 Change-Id: I0a53d6d003a44d895b6616b8d19a85e524b22053 Reviewed-on: https://chromium-review.googlesource.com/1183593 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#585317}
-
Dominic Mazzoni authored
ChromeVox was ignoring the checkedStateChanged event because it didn't think that event should apply to a 'switch' role. It was correctly announcing the state, just not correctly announcing when it changed. Bug: b/111353265 Change-Id: I77c420c00e90d31c78f86610df7a3713eede360f Reviewed-on: https://chromium-review.googlesource.com/1185866Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#585316}
-
Yiming Zhou authored
Chrome extension API methods are asynchronous and use callbacks. Much of the Action Recorder Extension background script wrap Chrome Extension API methods inside functions that return promises. Prior to this change, the background script handles sequential asynchronous calls using promise chains. Promise chains are cumbersome to write and difficult to debug. This change replaces promise chains with async functions and sequential await calls. Bug: 855284 Change-Id: Ic73608d9e6a207505f2d21a8a6005ce7418344a4 Reviewed-on: https://chromium-review.googlesource.com/1179312 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#585315}
-
Moe Ahmadi authored
- Updates existing strings and adds new ones related to the new Autofill addresses and payment methods settings in components/autofill_strings to share on all platforms. - Makes visual changes to the addresses and payment methods settings pages on iOS by adding a message under toggle that controls Autofill for that type. TBR=sebsg@ Bug: 873215 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8fe68a0f1776151f062006e95219a4ad41d8bb63 Reviewed-on: https://chromium-review.googlesource.com/1180556 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#585314}
-
Sophie Chang authored
Bug: 867129 Change-Id: I4eb4fe573b0a0e9adb6a23859d2263adce9c6fe7 Reviewed-on: https://chromium-review.googlesource.com/1182606 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#585313}
-
Wez authored
Extend the base::AsyncDispatcher implementation of the |async_ops_t| to support the new exception port bind/unbind APIs. Bug: 873489 Change-Id: I24cbc4aa687296fcefb09b5261486f1f8849b4ed Reviewed-on: https://chromium-review.googlesource.com/1172149 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585312}
-
Kunihiko Sakamoto authored
This patch updates the followings: - Use the Digest header instead of the MI header - Update the identifier from mi-sha256-draft2 to mi-sha256-03 - The top-proof is now encoded in standard base64, not base64url Http-mice-03 also changes the behavior on 0-length payloads. That will be addressed in a followup CL. Bug: 875721 Change-Id: I4c53a5ed6c25a62685d523c7a9d4583875a940c2 Reviewed-on: https://chromium-review.googlesource.com/1180955 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#585311}
-
Annie Sullivan authored
This is part of a larger project to extend page load timings to include the time from user input to navigation. This CL makes it possible to see different input types separately. See the last section of the design doc: https://docs.google.com/document/d/1dkjlbAQXdeXlnAwYFP7ueAIfO84DnQJ9U01krXv4x3s/edit# Bug: 750639 Change-Id: Ia37e5fe0bad25d5428f4c34d41292e660bd6d281 Reviewed-on: https://chromium-review.googlesource.com/1183587 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#585310}
-
Scott Violet authored
It only contains the files included else where. BUG=none TEST=none Change-Id: I1df5f3280515c101818bd837d4ea7b4486a7a19a Reviewed-on: https://chromium-review.googlesource.com/1185916 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#585309}
-
Toni Barzic authored
When launching (online enrolled) demo sessions with no connectivity, ARC provisioning for the demo mode public account will timeout (it will fail to get the account auth token), and restart the public session. This CL adds a fallback for demo session when the auth token for the demo account cannot be fetched - it continues ARC provisioning with offline demo mode provisioning. BUG=875504 TEST=Start demo session with no network - ARC successfully provisions, and the session is not forcibly restarted Change-Id: I76fe36cf939a5ac8d34b89f821fc142d2618d7d4 Reviewed-on: https://chromium-review.googlesource.com/1180415 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#585308}
-
Aldo Culquicondor authored
The compositor updates the viewports and buffers accordingly per RenderLoop request. VrShellGl still inherits from RenderLoop, but it no longer accesses the Ui, but through a new interface suited for it. VrShellGl also implements the new SchedulerDelegate interface, which is in charge of making draw calls to the RenderLoop from different signals. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I68c724145cdf8c4d63e90856f59bd07994cd9f1b Reviewed-on: https://chromium-review.googlesource.com/1181949 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#585307}
-
Anna Offenwanger authored
XR devices and sessions cannot be obtained without a physical device connected to the system or a system to mock out the backend APIs. As setting up such as system would take a lot of work, it is unlikely to be worthwhile while the spec is still undergoing so much change. Therefore, the incorrect calls to get device and session have been removed, and can be written correctly at a later date. Bug: 870602 Change-Id: I0c9f512605d17dc3df890d699da016a8bc1e1c0c Reviewed-on: https://chromium-review.googlesource.com/1185285 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#585306}
-
Scott Violet authored
As part of https://chromium-review.googlesource.com/c/chromium/src/+/1183892 I wired up what was OutputProtection. That means these tests now pass. BUG=678687 TEST=test only change Change-Id: Ie68291b08973953e5d3d238ce87bb6d552a1b50e Reviewed-on: https://chromium-review.googlesource.com/1185908Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#585305}
-
Darren Shen authored
When we activate the virtual keyboard from the shelf in laptop mode, we have to do two things: 1) Enable the accessibility keyboard. 2) Change the keyset to be the requested keyset. When we close the keyboard, we have to undo steps 1 and 2. Currently, it's indeterminate as to what order these two steps happen because step 2 is a mojo call. This became a problem after we launched the new keyboard UI, because the new keyboard UI breaks when step 1 is undone before step 2 (i.e. we disable the keyboard, but then the keyset changes). We change the code so that we always disable the keyboard before resetting the keyset. TBR=shuchen@chromium.org Bug: 875456 Change-Id: Iaaa583851c7b63023a508f967f13f3d9aba42415 Reviewed-on: https://chromium-review.googlesource.com/1184588Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#585304}
-
Ryan Hamilton authored
Change-Id: I28f66dbd11c0a9cd6ab47019503fc4dbb17847a5 Reviewed-on: https://chromium-review.googlesource.com/1185638Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#585303}
-
Ted Choc authored
BUG=876369 Change-Id: I3daff1c0fbec9568edeb987b2f67a8ab168922a3 Reviewed-on: https://chromium-review.googlesource.com/1185912Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#585302}
-
Alexei Filippov authored
Add GPU process pid to the list of processes where tracing is enabled. Change-Id: Ic401ee4ea7d218cad36f687be226d092cd4e54a0 Reviewed-on: https://chromium-review.googlesource.com/1182304 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#585301}
-
Wenzhao Zang authored
1. Launch the Highlights app with AppLoadService (which is a wrapper of UnpackedInstaller). 2. Observing session state should be a cleaner solution, because we don't have to launch it from two places (user_session_manager for regular login, and chrome_session_manager for crash/restart). Launching it from two places are okay because we already have demo-mode related code in both places, but it may not be necessary for the Highlights app. Bug: 819404 Change-Id: I3879df729f02c2477ca25511947b23ebe26e5ed1 Reviewed-on: https://chromium-review.googlesource.com/1176183 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#585300}
-
Devlin Cronin authored
Rather than only displaying hosts, display the actual URLPatterns granted to an extension. Given this is a power-user surface, we can be a little less concerned with the technicality shown. Additionally, since we don't use a full string (e.g., "Read and change your data on all google.com sites"), we need to have the differentiation of which hosts the extension is granted, such as whether it includes subdomains. Also allow the user to enter patterns as an URLPattern (thus including subdomains if they so desire). Enforce that paths are always '*', since we don't use path-based permissions. To make it easier on users, also support just entering the host name (e.g., 'google.com'), which will be expanded to '*://google.com/*'. This also properly fixes the issue of clicking 'remove' or 'edit' on existing host options. Add JS tests for pattern validation, and update unittests to support pattern-based host manipulation. Bug: 844128 Change-Id: I599151bb6b89bdb113af4c39dcf0e21d152aa0fe Reviewed-on: https://chromium-review.googlesource.com/1166596 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#585299}
-
Lei Zhang authored
It really should be called PrintHostMsg_DidStartPreview. Getting the page count is usually one of the first steps in starting a print preview, but the IPC message does a bit more than that now. Change-Id: I001a66c169fa5cf42b238605d6067bf12d58962e Reviewed-on: https://chromium-review.googlesource.com/1184317Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585298}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/6c62530c666f..dbcb89be244e $ git log 6c62530c6..dbcb89be2 --date=short --no-merges --format='%ad %ae %s' 2018-08-22 jianj Revert "vp8: Fix memory address overflow in decoder." 2018-08-22 jingning Set refresh_frame_context flag off in show_existing_frame mode 2018-08-21 jingning Drop empty line in vp9_get_compressed_data() 2018-08-21 jingning Allow codec to skip temporal filter for intermediate ARFs 2018-08-21 jingning Control reference frame refresh flags for USE_BUF_FRAME 2018-08-21 jingning Safely swap the show frame buffer pointer in show_existing mode 2018-08-21 jingning Skip loop filter operation in show_existing_frame mode 2018-08-21 jingning Point show frame buffer towards existing frame buffer 2018-08-21 jingning Skip frame encoding when show_existing_frame is on 2018-08-21 jingning Add USE_BUF_FRAME enum to FRAME_UPDATE_TYPE 2018-08-20 jingning Unify set_arf_sign_bias function 2018-08-20 jingning Remove unneeded frame_till_gf_update_due assignment 2018-08-20 jingning Add multi_layer_arf flag 2018-08-20 jingning Add a comment in init_gop_frames() 2018-06-12 supradeep.tr Loopfilter MultiThread Optimization 2018-08-17 jingning Skip frame bit-stream writing for show-existing frame 2018-08-17 jingning Support code show_existing_frame in bit-stream header 2018-08-17 jingning Refactor init_gop_frame() 2018-08-17 jingning Clean up var define in apply_temporal_filter() 2018-08-17 jingning Add inline to mod_index() (...) Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com BUG=875626,875680 Change-Id: I4d395733d13462e248119791f9483396c0614f5b Reviewed-on: https://chromium-review.googlesource.com/1185797Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#585297}
-
Tien-Ren Chen authored
This CL changes StickyPositionScrollingConstraints to a struct type. It is a POD type anyway, and this allows us to remove tons of boilerplate getter/setters. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie3bee752aceab1334919613df84e25167fb9c759 Reviewed-on: https://chromium-review.googlesource.com/1184231Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585296}
-
Xiaoqian Dai authored
When dragging a tab out of a browser window (source window), the source window scales down. The background behind the source window should be the same blurred and darkened wallpaper as in overview. See recorded video: https://drive.google.com/open?id=1I_tXdQzUsiCwAqFikmZi9EywnUG1-wKl Bug: 874266 Change-Id: Ie25dd3594fbcef37cda5c427e4daebf0ecffb1fd Reviewed-on: https://chromium-review.googlesource.com/1185521Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#585295}
-
rbpotter authored
- Remove underline - Use default cursor since the button is not clickable when disabled. Bug: 875800 Change-Id: Id01f15cbde8afeb7a0e5341e4e04fd91c3b00ea0 Reviewed-on: https://chromium-review.googlesource.com/1182451Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#585294}
-