Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 17 Nov, 2017 32 commits
  3. 16 Nov, 2017 8 commits
    • Yuke Liao's avatar
      Revert "DownloadTaskImpl implementation for //ios/web Download API." · 499acc80
      Yuke Liao authored 
      This reverts commit cef83520.

Reason for revert: DownloadTaskImplTest.* tests fail on iOS 11 devices, both iPhone and iPad.

Original change's description:
> DownloadTaskImpl implementation for //ios/web Download API.
> 
> This CL implements DownloadTask public interface.
> 
> DownloadControllerImpl CL: crrev.com/c/758525
> Design doc: http://go/ios-web-download-api
> 
> Bug: 780646
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I2c508e77f3e529223499d6f2791b28011589fe90
> Reviewed-on: https://chromium-review.googlesource.com/758506
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
> Commit-Queue: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517176}

TBR=sdefresne@chromium.org,eugenebut@chromium.org,gchatz@chromium.org

Change-Id: I14f0c37aa92330b0a665bf59bb665f010ee1209d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 780646
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/776067Reviewed-by: default avatarYuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517225}
      499acc80
    • Vlad Tsyrklevich's avatar
      Revert "[cfi-icall] Use ProtectedMemory for GetProcAddress" · 5c3c4ac8
      Vlad Tsyrklevich authored 
      This reverts commit d2cc1555.

Reason for revert: speculative revert, this might cause hangs on Linux component builds due to linker symbol resolution issues.

Original change's description:
> [cfi-icall] Use ProtectedMemory for GetProcAddress
> 
> Control Flow Integrity [1] indirect call (cfi-icall) checking can not
> verify that dynamically resolved function pointers call their intended
> function. Instead we place the pointer for GLGetProcAddress in
> ProtectedMemory, a wrapper for keeping variables in read-only memory
> except for when they are initialized.  After setting the pointer in
> protected memory we can use the UnsanitizedCfiCall wrapper to disable
> cfi-icall checking when calling it since we know it can not be tampered
> with.
> 
> [1] https://www.chromium.org/developers/testing/control-flow-integrity
> 
> Bug: 771365
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Ia79c1cfab8e00f88bcc437c34cbb3012537c015a
> Reviewed-on: https://chromium-review.googlesource.com/769654
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517208}

TBR=kbr@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org

Change-Id: Ia474d99619795f9b2c40422858caf2a02461e462
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 771365
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/775596Reviewed-by: default avatarPeter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517224}
      5c3c4ac8
    • Vlad Tsyrklevich's avatar
      Revert "[CFI] Use ProtectedMemory in CertVerifyProcNSS" · 63e4d43d
      Vlad Tsyrklevich authored 
      This reverts commit d0de1771.

Reason for revert: speculative revert, this might cause hangs on Linux component builds due to linker symbol resolution issues.

Original change's description:
> [CFI] Use ProtectedMemory in CertVerifyProcNSS
> 
> Because CertVerifyProcNSS dynamically resolves a pointer to the function
> CERT_CacheOCSPResponseFromSideChannel(), Control Flow Integrity [1]
> indirect call (cfi-icall) checking can not verify that it is the
> intended target for that function pointer call site.
> 
> Since we can not use cfi-icall to check the function pointer, instead we
> place the pointer in ProtectedMemory, a wrapper for keeping variables in
> read-only memory except for when they are initialized. After setting the
> pointer in protected memory we can use the UnsanitizedCfiCall wrapper to
> disable cfi-icall checking when calling it since we know it can not be
> tampered with.
> 
> [1] https://www.chromium.org/developers/testing/control-flow-integrity
> 
> Bug: 771365
> Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I5d65b3591681f3daa917b6516eec1e5e47513d12
> Reviewed-on: https://chromium-review.googlesource.com/765098
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Eric Roman <eroman@chromium.org>
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517169}

TBR=eroman@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org

Change-Id: I2d9a65fd6284c2cf954b46588d70fd1fa6292014
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 771365
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/775595Reviewed-by: default avatarPeter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517223}
      63e4d43d
    • Tom Anderson's avatar
      Add check for missing sysroot libraries · 22c1deb1
      Tom Anderson authored 
      Linking on arm64 can fail when dependent libraries are missing.
That is, when linking against liba which depends on libb, linking
will fail when only libb is missing.

This CL adds a check to prevent these types of missing libraries.

BUG=webrtc:8535
R=thestig@chromium.org

Change-Id: I14e15ce534bd8ac5602f84dedcaab2db041656fb
Reviewed-on: https://chromium-review.googlesource.com/773200Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517222}
      22c1deb1
    • Joel Einbinder's avatar
      DevTools: Add context menu item to focus a node · 04a86be7
      Joel Einbinder authored 
      Brings the inspected page to front and focuses it

Change-Id: I0e6b18b079091fe2b0dfccbc69829470dcfaeeec
Reviewed-on: https://chromium-review.googlesource.com/761057Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Reviewed-by: default avatarAlice Boxhall <aboxhall@chromium.org>
Reviewed-by: default avatarAndrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517221}
      04a86be7
    • Ian Kilpatrick's avatar
      [LayoutNG] Properly handle block-end borders. · c5d3db64
      Ian Kilpatrick authored 
      We previously didn't correctly handle block-end borders.

This fixes a couple of subtle bugs:
 - We don't grow the block-size of a fragment if it doesn't have
   any content.
 - We expand to encapsulate floats first, then grow to encapsulate
   the border.

Bug: 	635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I7770a1d23a9c25fcab51e2e681e00e4b4d3e9d08
Reviewed-on: https://chromium-review.googlesource.com/770645
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517220}
      c5d3db64
    • dpapad's avatar
      Print preview new: Fix scrolling in sidebar. · eaa3cf0b
      dpapad authored 
      The lower part of the sidebar was incorrectly sized, causing the scrollbar
to appear after part of the content was already hidden.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I50458546e67af9dfcd5416bdc81f6dfa7ca6e5b6
Reviewed-on: https://chromium-review.googlesource.com/775554Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517219}
      eaa3cf0b
    • Vlad Tsyrklevich's avatar
      Revert "[cfi-icall] Use ProtectedMemory for localtime ptrs" · 1130da30
      Vlad Tsyrklevich authored 
      This reverts commit e77256b1.

Reason for revert: Reverting while I investigate failures causing recursive calls to hang.

Original change's description:
> [cfi-icall] Use ProtectedMemory for localtime ptrs
> 
> Control Flow Integrity [1] indirect call (cfi-icall) checking can not
> verify that dynamically resolved function pointers call their intended
> function. Instead we place the LibcFunctions pointers in
> ProtectedMemory, a wrapper for keeping variables in read-only memory
> except for when they are initialized.  After setting the pointers in
> protected memory we can use the UnsanitizedCfiCall wrapper to disable
> cfi-icall checking when calling them since we know they can not be
> tampered with.
> 
> [1] https://www.chromium.org/developers/testing/control-flow-integrity
> 
> Bug: 771365
> Change-Id: Ib74faff066e1107293b67d11f2a1a054bbff08b5
> Reviewed-on: https://chromium-review.googlesource.com/769853
> Reviewed-by: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517152}

TBR=jorgelo@chromium.org,palmer@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org

Change-Id: I77e142638d73bd53de4b6fc1b9db2ffc819f6459
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 771365
Reviewed-on: https://chromium-review.googlesource.com/775594Reviewed-by: default avatarPeter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517218}
      1130da30