GitLab

Android can default to the WebContents' default handling of key
events.

Merge-With: eureka-internal/326040

      verify that key events are plumbed to JavaScript.

Bug: Internal b/142758140
Test: cast_shell_junit_tests
Test: cast_shell_unittests
Test: Use chrome://inspect to monitor key events in Cast app to
Change-Id: Ibb4a50ab3832acfdfa6115f5771ff6b7ffbb5c73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865756
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707152}

In Chrome, URL size is limited to 2MB when serializing the IPC. As a
result, downloading a large data URL will fail.
This CL fixes the issue by creating a blob to hold the data and pass
it across process boundaries.
It also changes the implementation of RenderFrameImpl::SaveImageFromDataURL()
to also use a blob instead of passing a large std::string in IPC.

BUG=947395

Change-Id: I21779af402bb8cf4fbfa7cf73acd8cac594d0c2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832723Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707151}

This metric has been useful in helping understand the availability of
Bluetooth adapters among Chrome users on different platforms, which is
informing decisions on Web Authentication strategy around Bluetooth
authenticators, especially as we move toward supporting smartphones as
Bluetooth-connected authenticators.

Moving the expiry out a year so that we can continue to collect this
data.

Change-Id: Iaba3675f08d9f9d4b8eacfe0098289b3f7bf5b9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867201Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707150}

Change-Id: I4ca87e1c8ef4f03a24003d2119a1b49e2108a007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865684Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707149}

The recipe will essentially run a custom analyzer on chrome metric-related
config files. So it shouldn't need any build or test configs.

Bug: 1015221
Change-Id: I77cf81ed428a559727b78ad5241b382778e2306f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866926Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707148}

The old approach of adding title as a disabled item meant that this CL:

https://chromium-review.googlesource.com/c/chromium/src/+/1788198

causes the menu title to be displayed in grey text instead of solid black text. This CL introduces a new menu type that, while still disabled and non-reactive, be displayed in solid black text.

Bug: 1006203
Change-Id: I9fa38132160228ebde5bd43d8db9c2f60d5f001c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841583Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Auto-Submit: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707147}

The |Accept-Encoding| request header should be omitted from the cURL
command line to avoid problems decompressing responses on platforms
where cURL does not support the same set of decompressors as Chrome
itself.

Bug: 1015321
Change-Id: I2948affb89ff46ad1b9869b2532f75efb4acf6f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865608Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707146}

This structure is fully replaced by a C++ KeyValuePair type. The
LevelDBDatabaseImpl::GetPrefixed() API has been removed as well, and
callers have been updated to use the underlying DomStorageDatabase's
GetPrefixed API directly instead.

To support this usage cleanly, LevelDBDatabaseImpl's RunDatabaseTask
helper API has been adapted to allow tasks to return a tuple, which will
then be unpacked into explicit function arguments passed to the task's
result callback. This is used with one of the new GetPrefixed
conversions, and is also used to improve the readability of
SessionStorageContextMojo's metadata retrieval and parsing logic.

Bug: 1000959
Change-Id: Id012594dcacddbc4b708df6bd363b1a4029bb455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864466Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#707145}

Peek 1.5 items to give first-time gesture users a sense
of what's in the list.

Bug: 1015004
Change-Id: I908426d659cceedee590b83ce573d360e257ddc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865920Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707144}

https://dom.spec.whatwg.org/#interface-element

This makes it more clear where the `part` attribute is defined.

Change-Id: I89a5e98a26bb1aceb1dbf19e6782841545c7d4f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863797
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707143}

R=arthursonzogni@chromium.org,nasko@chromium.org
CC=clamy@chromium.org,alexmos@chromium.org

Change-Id: Id611558b25577926a759f98620419755d3f32253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865332Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707142}

These tests started being flaky as soon as they were initially landed.
It seems to be a timing issue, so I added in two pieces to ensure
timing is correct:

1. MainThreadFrameObserver - I was seeing that occasionally, the frame
  wouldn't have been produced by the time the test was sending the first
  scroll or zoom, resulting in the scroll or zoom bailing early and not
  happening. The MainThreadFrameObserver will make sure that execution
  waits until a frame is produced and everything is in sync before
  continuing.

2. InputMsgWatcher - This ensures that the test receives an ACK back from
  the expected event type each time a scroll or zoom is performed. The
  ACK can technically be a few different things based on different
  conditions but it doesn't really matter what it is, just that an ACK
  is received. This allows us to be certain that we are waiting long
  enough before checking the zoom or scroll amounts.

Bug: 1010911
Change-Id: Ieb1c3993cdc17afacd8aecb5e823881c539a1e12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837892Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707141}

RecommendAppsScreenTest.ParseError is very flaky on ChromeOS
since 2019/10/16.

https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSBUZsYWtlIjljaHJvbWl1bUBicm93c2VyX3Rlc3RzQFJlY29tbWVuZEFwcHNTY3JlZW5UZXN0LlBhcnNlRXJyb3IM&show_all_occurrences=1

TBR=tbarzic@chromium.org

Bug: 1015013
Change-Id: Ia93fcd4624b6c35fae4e53c740e415e3a28f9b41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867469Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707140}

The text contrast was previously either far too low or borderline too
low for all text. This CL makes the default text darker and uses the
same color for the legal/privacy paragraph as the rest of the text.

BUG=chromium:1005543
TEST=Take screenshot (on eve), check with color contrast companion.

Change-Id: I791a79c92238f4b65f3e9e52c917104b153a82dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864363Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: J Kardatzke <jkardatzke@chromium.org>
Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707139}

betty-pi-arc should be identical to betty, but with a newer version of
android. Since basic gtest unittest suites shouldn't interact with that
level of the system, running them on both the vanilla betty and betty-pi-arc
bots is redundant.

Also rename & refactor several chromeos suites in test_suites.pyl to make
things clearer.

Bug: 1000513
Change-Id: I7755323689bb85f11174132267927c46e4885a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867207Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707138}

We can handle this by not Finish()ing in this case when a read fails

Bug: b/142069294
Test: force an error to occur
Change-Id: I8383b01d1a6abbe7b6e523a37b4ea0e8be986976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867436Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707137}

This CL adds a HidConnectionWatcher client interface for
observing whether a HID connection is still open. When the
connection is closed, the HidConnectionWatcher's pipe is also
closed.

In a future CL, this will enable HidService to track the number
of open connections to HID devices for the purpose of showing
a tab indicator when there are open connections.

BUG=1007539

Change-Id: I2349e3169c58f1b9477b13d840b03643622500f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823980Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707136}

This reverts commit 2ee50cc5.

Reason for revert: Breaks clusterfuzz because of missing ssl deps

Original change's description:
> Update Crashpad to 47a342133d60018f2ffda0037ffe2b5f0d3f7482
>
> 2fb4e9e6a432 mac: Update the process_types version of
>              dyld_all_image_infos for 10.15
> c009b85449cb Use GTEST_SKIP() instead of custom DISABLED_TEST()
> d8f85829b07b linux: fix split stack test
> 7289acb78a6d linux: don't assume vdso exists
> 47a342133d60 linux: use boringssl in chromium
>
> Change-Id: If4718ea7220543c3ca10bc3f7d123ac330625461
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863255
> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707107}

TBR=jperaza@chromium.org,mark@chromium.org

Change-Id: Ia4335007735e1a51ba72d2eb177f780a0db09430
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867475
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707135}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/65adcb504d02..9bd9f4b3ed64

git log 65adcb504d02..9bd9f4b3ed64 --date=short --no-merges --format='%ad %ae %s'
2019-10-17 9856269+sarahM0@users.noreply.github.com spvc parser for a trivial shader (#839)
2019-10-17 rharrison@google.com Rolling 5 dependencies and update known_failures & known_invalids (#840)
2019-10-17 dsinclair@google.com The glslang-testsuite is moved into glslang. (#838)

Created with:
  gclient setdep -r src/third_party/shaderc/src@9bd9f4b3ed64

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: I2d0e402ce515e4e5f9a7ca1c8dc0234e38d7717a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867071Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707134}

Add metric to track SameSite cookies set which cross schemes
http-to-https and https-to-http, as seen as site-for-cookies from
response and which are Lax or Strict.

Added histrogram to track number of SameSite cookies set with Lax or
Strict in the response.

Change-Id: I14668cc9ddf334b7b575e0199e407e389133de78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867205
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707133}

This reverts commit 82f9896f.

Reason for revert: 
OverviewSessionWithDragFromShelfFeatureTest.TapOnBackgroundGoToHome is failing on linux-chromeos-rel
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel

Original change's description:
> [reland] In tablet mode, tap on overview background should go to home screen.
> 
> Clamshell mode behavior will remain the same, i.e., tapping on the
> overview background will return to its previous state, it can either be
> in-app or home screen.
> 
> Bug: 997885
> 
> Change-Id: I2dae82657d4d92876c834c78dd62d53830fbe6cf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865264
> Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707036}

TBR=xiyuan@chromium.org,xdai@chromium.org

Change-Id: I5dd88e82ecb8d5c3772be87fb749c3da88ba6d08
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 997885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867472Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707132}

This allows to tell apart 2 different shared workers that have
the same url, name and constructor origin. This is possible when
the script url and/or the constructor origin have file: scheme.

Also removed the SharedWorkerInstance::Match() overload that takes
in a SharedWorkerInstance to make it clear we're not comparing 2
instances.

Bug: 1013168
Change-Id: I7a0efbfd71dae283ecfc97f3ae87df69a0fb5695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850832Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707131}

Using wpt-import in Chromium 04fbda1c.
With Chromium commits locally applied on WPT:
6386d9d8 "Update service_worker_unregister_and_register()"
40e4a155 "Reland "[Trusted Types] Remove TrustedURL.""


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
ksakamoto@chromium.org:
  external/wpt/resource-timing

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Ia8fa99b67039f0b3d7517fb96f5ca5bf482637af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866703Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707130}

- Configures the CreditCard Banner for presentation.
- Implements Banner related methods like performInfobarAction
and dismissBannerWhenInteractionIsFinished.
- On InfobarCoordinator detachView (which is called when the Infobar
view needs to be removed) we only dismiss the VC if they have been
created. This is needed since now a CreditCard InfobarBanner can be created
while other one is being presented, since replace is not supported
it will discard the new Infobar, thus calling detachView in an Infobar
that was never presented.

Screenshot:
https://drive.google.com/open?id=1bmPWLDNIEsJYORx8YfOs82wsYUKdoXcN

Bug: 1014652
Change-Id: Icd50ed542743054b38924fba668c42f38dbcc7f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865445Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707129}

Bug: 1011908
Change-Id: If7135dc07a320e104f997ed5780bde7d5263c886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866852Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707128}

Previously, the ARC start and upgrade functions in the adapter
interface had two issues:

* They used structs in arc.proto that were in the login_manager::
  namespace although the interface is both for ARC container and
  VM.
* Parameters for upgrade were converted from the platform-neutral
  one (UpdateParams in arc_session.h) into the platform specific
  one (arc.proto) too early in arc_session_impl.cc.

This CL fixes both issues by removing arc.proto usage from
everywhere but arc_container_client_adapter.cc.

BUG=b:142144019
TEST=ran the unit tests + arc.Boot

Change-Id: I6b14631af8a3f24f879a037df0b0c289845edf95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854465
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Auto-Submit: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707127}

While there are currently per-ad frame CPU usage metrics, it is
difficult to measure the overall CPU usage of ads on a page. This adds
a UMA histogram that tracks the sum of the ad frames' CPU usage, which
is a topline metric that would allow for a better understanding of the
resource impact of ads on the web.

Bug: 1004815
Change-Id: I97e91b35ec75bc01bb4475375d2573928450fe34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853104Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707126}

Detect HDR support using the -[NSScreen
maximumPotentialExtendedDynamicRangeColorComponentValue] API introduced
in 10.15. Use the hard-coded kDefaultBitsPerPixel/Component constants
instead of reading from the NSScreen. Move the constants to a common
location.

We can only promote an IOSurface to an overlay if we can set the
color space on the IOSurface in a way that will make CoreAnimation
draw it the same way that GLRenderer would.

Merge the various checks for color space compatibility into an
IOSurfaceCanSetColorSpace function, and call this from the SDR
and HDR paths.

Update IOSurfaceSetColorSpace to use the new constants
kCGColorSpaceITUR_2020_PQ_EOTF and kCGColorSpaceITUR_2020_HLG
introduced in 10.15.

Note that this will not trigger HDR mode. Doing so requires making
visible a CAMetalLayer with wantsExtendedDynamicRangeContent set.
The next patch in this sequence will do that.

Bug: 976426
Change-Id: Ic93302aa895f182713658f1eaea89c0e91953857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863449
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707125}

The save-data WebAPI holdback is intended to only holdback the JS API
and the save-data request header, so this CL makes automatic LazyLoad
ignore the state of this holdback.

Bug: 1014640
Change-Id: Idead68187789425645ae10ff2b38a8c2cf1245fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867093Reviewed-by: rajendrant <rajendrant@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707124}

WebRTC is trying to enable the support for the component build and
when is_component_build=true some Chromium targets fail to link because
they were relying on WebRTC to link with some .frameworks.

Bug: webrtc:9419
Change-Id: I064289025aa7eab7cb5008d9d9ae71a013119c65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865330Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707123}

https://boringssl.googlesource.com/boringssl/+log/bc4c09df6416a3a0d0cf321c6c13023c77e2fec4..76918d016414bf1d71a86d28239566fbcf8aacf0

Bug: none
Change-Id: Ib459c4fc16d6bf1b8c7147d0efa16d48ecc5a9c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864322
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707122}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3e2416ee17a9..74af4241e484


Created with:
  gclient setdep -r src-internal@74af4241e484

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:996372,chromium:None,chromium:913074,chromium:None
Change-Id: Ic741b769b6fac9944b8a8cccab7cb0d84ce14dfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867135Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707121}

This reverts commit 6983e9fa.

Reason for revert: Uses X11 headers outside X11 builds & thus Breaks Chromecast build

Original change's description:
> X11 and Ozone: Move static methods to DWTHLinux.
> 
> At first, I wanted to remove these static methods, but then decided
> to keep them and remove later when we no longer need them.
> 
> Bug: 990756
> Change-Id: If6132986e25bb1c8712acdbc90ce29093616bff7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860341
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Maksim Sisov <msisov@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#705946}

TBR=sky@chromium.org,thomasanderson@chromium.org,msisov@igalia.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 990756
Change-Id: I87deff065e2f0badc8a88feff1e6a30b42799c92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867019Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707120}

Documentation of -[CAMetalLayer setWantsExtendedDynamicRangeContent:]
reads as follows.

  If any rendering context on the screen has this enabled, all rendered
  content is clamped to the screen’s
  maximumExtendedDynamicRangeColorComponentValue value rather than 1.0.

This indeed does what it says. The exact incantation under the covers
is unknown. I had previously guessed that setting IOSurface's color
space to an HDR color space would do the same trigger, but it does not.

This method privately exists on the CALayer base class.

To ensure that this is triggered appropriately, track whether or not
any IOSurfaces that we are using as CALayer contents are tagged with
an HDR color space. If so, set setWantsExtendedDynamicRangeContent
to YES on the root layer.

Add tests verifying this behavior.

Of note is that if the HDR layer is not promoted to an overlay, then
the buffer that we render it in to will not be appropriately allocated
as HDR-capable, and so the HDR content will end up being clipped.

Bug: 976426
Change-Id: Ib389f1c36d39950ddd06beea5320e5f1890b73a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863689
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707119}

This CL fixes a DCHECK failure (exposed by ClusterFuzz) when
attempting to create an cc::ImageHeaderMetadata via
ImageDecoder::MakeMetadataForDecodeAcceleration when
DeferredImageDecoder::PrepareLazyDecodedFrames is executed for the first
time with an underlying invalid image.

Bug: 1014047
Change-Id: I027d0649a775fb854079cedaab6522397e537fb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863376
Commit-Queue: Gil Dekel <gildekel@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707118}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a2b2fc8164dc..b97e8677d349

git log a2b2fc8164dc..b97e8677d349 --date=short --no-merges --format='%ad %ae %s'
2019-10-17 saklein@chromium.org call_templates: Dump a deprecated parameter.
2019-10-17 dburger@chromium.org Do not pass gclient path for sync_chrome, get from $PATH.
2019-10-17 vapier@chromium.org lkgm_manager: switch to git.Log
2019-10-17 saklein@chromium.org sdk service: Skip toolchain upgrade when no board given.

Created with:
  gclient setdep -r src/third_party/chromite@b97e8677d349

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ibf70aaf11fe87a1c080d84467b129330ff270560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867134Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707117}

This change adds a CookieAccessSemantics field to the cookie change
notification interfaces, such that the access semantics of a cookie at
the time of the reported change can also be included in the change
notification. The CookieAccessSemantics is used to determine whether a
cookie should be treated according to "legacy" rules, based on a
policy setting. It affects whether the cookie may be included on a given
request, and some cookie change consumers care about this because they
check whether the cookie change should be observed based on whether it
would have been included on a request.

This is accomplished by bundling the changed cookie, the
CookieAccessSemantics, and CookieChangeCause into a new struct,
CookieChangeInfo, and passing a CookieChangeInfo along to notification
subscribers.

This change should not produce any behavior change for consumers who
don't care about the CookieAccessSemantics, which is most of them, for
which this will just pass them an extra parameter that they don't need.
The places where behavior changes are in the CookieStore API
(CookieChangeSubscription::ShouldObserveChangeTo), the
RestrictedCookieManager::Listener (OnCookieChange), and
CookieMonsterChangeDispatcher::Subscription (DispatchChange), where
now the call to CanonicalCookie::IncludeForRequestURL is able to pass
the CookieAccessSemantics in order to properly compute whether the
cookie change should be observed.

TBR=khorimoto@chromium.org

Bug: 978172
Change-Id: I712972391ff0adcc4b94481bba156dc0e7b759a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854649Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707116}

Test: added test
Bug: 1012879
Change-Id: Ia78f06bddf0cd85ec00e76ddd7111537d03788d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865988Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707115}

Lazyload should be disabled in incognito as the other LiteMode features

Bug: 1014144
Change-Id: Ifeb03f0aec081f7adf25b6474d0ded3a6a929ad3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863758
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707114}

- Remove the small icon in before edit text.
- Move down the error messege under edit text.
- Change the color to dark red when error dialog shows.
- Change extension dialog messages.

Bug: 1012450,952425
Change-Id: I9a8d47121025058bdca44c4b461d20305d6c1396
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865663
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707113}