GitLab

Change-Id: Ia549368f095c81a296081aacaf8fd6a05da2b4ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026407Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737481}

This reverts commit 57213418.

Reason for revert: Causing compile error in win-chrome builder: https://ci.chromium.org/p/chrome/builders/ci/win-chrome

Original change's description:
> [3P blocking] Fix tests accessing the ModuleDatabase on the UI thread
> 
> The ModuleDatabase was moved to its own sequence but both the
> IncompatibleApplicationsBrowserTest and ThirdPartyBlockingBrowserTest
> test fixtures were not updated.
> 
> This CL moves the accesses to the ModuleDatabase instance to the right
> sequence.
> 
> Also added an override for the OutOfProcessQuarantine feature to allow
> local testing. This was not an issue on the bots because they respect
> the fieldtrial_testing_config.json file.
> 
> Bug: 850517
> Change-Id: I2e8955b33cd7ffc75f74dd56b01df9dec96fc604
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031742
> Commit-Queue: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737448}

TBR=chrisha@chromium.org,pmonette@chromium.org

Change-Id: I6067a3b50bb835025807ff1b81e7787cda35625d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 850517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033634Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737480}

This adds an exemption for legacy TLS errors from being fatal errors.
This also adds a browser test (to ensure the interstitial is always
bypassable) and a unittest (to ensure that legacy TLS errors aren't
marked as fatal).

Bug: 1047777
Change-Id: Ia50bff281d7c68f4f678e9b6209f7bc7aaa495f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033644Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737479}

I noticed that we leave a crufty debug.log file in the directory
when our MSI is removed.  I added a custom action to clean it
up so we don't leave cruft on the system during upgrades or
uninstalls.

Change-Id: Ibbb13dcdcbc60dc95c3db4996d1243637354afe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033625Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737478}

the editor bubble.

Bug: 1040657
Change-Id: I532ffcc9257e038292f7a3d2d33ae31a50744558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028161Reviewed-by: Connie Wan <connily@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737477}

* Remove no-longer-relevant default exclude filter for assets/unwind_cfi
* Fix diff size colorings not being correct upon first load
* Make method count mode size colorings a thing
* Add a devtools log message to show how to query the web worker

Bug: None
Change-Id: I27344c50ee0c6d1a93b97055fa7d2176fff263c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032807
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737476}

These will be used to debug extreme outlier values of the
PageLoad.InputDelay3 histogram.

First, add all event types used to calculate PageLoad.InputDelay3 to
Event.Latency.OS. Move the calls to generate the histogram into the
functions that build the events, because the calling functions for the
new event types have much more complex logic.

Second, add new versions of Event.Latency.OS without the call to
ValidateEventTimeClock(). This call fixes some potential causes of
extreme values, so adding histograms which do not include it can help
determine if it masks the problem.

Bug: 1039833
Change-Id: I48cfa3613dd7c6a1d15b75e7a91f53b3f46a90c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022346Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737475}

These are largely straightforward.

Bug: 1011446
Change-Id: Ifaf8be23c5e64743beafa0025817e3e0271788e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033437
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737474}

The C++ code generated will be used in Blink's
document_metadata_extractor.

Bug: 1044250
Change-Id: I49db529fa95bf6868eabeb6f0718476fd904898a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029010
Commit-Queue: Sam Bowen <sgbowen@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737473}

I can't repro locally nor using mb tool to repro. mb tool can
only launch jobs in chromium.tests pool which is a different
pool than internal bots.
I hope with the android id logged, we can find out what's going
on on the server side.

Bug: 1043347
Change-Id: I70ac3005b0b568284a18d76b35dee160d27c00b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031537Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737472}

Make the smart card PIN errors being dispatched to the a11y subsystem
more reliably, by directly associating the error text with the PIN input
field.

This allows to support the scenario when the PIN keyboard is hidden
during PIN verification animation and shown back. Before this CL, the
error alert would be lost in such scenario, since it's followed by the
focus switch events.

Also do a small cleanup by removing the "aria-invalid" attribute from
the <pin-keyboard> element, since it doesn't seem to be recognized by
the a11y screen reader, meanwhile the actual useful attribute is already
set thanks to the dataflow "<pin-keyboard has-error>" => "<cr-input
invalid>" => "<input aria-invalid>".

Bug: 1001612, 1016839
Change-Id: Ib7baff4bf5d172ada92fbb035455894b1baff5ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031106
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737471}

This CL adds feature parameters that create allowlists or blocklists for
warnings, blocking and silent blocking. Finally, it updates the
triggering logic to use those parameters.

The triggering code contains default file extensions which are used when the
feature parameter is not set. These are only used when the user
explicitly enables the feature for testing.

To make testing easier, we:
 - SILENT_BLOCK on files ending in the contrived
   ".silently_block_for_testing".
 - BLOCK files that are executables or archive types, or any download
   that's explicitly user-requested (e.g. from a context menu).
 - WARN on everything else except ".dont_warn_for_testing" files.

Bug: 960819
Change-Id: I006d4e0c3f45b64e3cd84b0ef21cc506988bf5cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984703
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737470}

Change-Id: Ib2b07973169a5cddf614b0a00f97a1edd15e67df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033590Reviewed-by: vikas soni <vikassoni@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Auto-Submit: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737469}

If an there's an existent modal it means one is currently presented, or in
the process of being presented. Configuring a new one would only cause
InfobarCoordinator to hold pointers to a Modal that won't be presented.

This CL prevents that by stopping any new configuration if a Modal already
exists.

It also removes modalNavigationController since we can get the
NavigationController from the modal.

Bug: 1040066
Change-Id: Ia2da22d67804e39780b19b78af2dcba58fa8a580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032565Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737468}

Mark the DeviceSamlLoginAuthenticationType policy as "future", in order
to hide it from the policy documentation.

This policy is unused. It was originally intended for configuring the
Chrome OS smart card user login feature for all users on the given
device, but the design was later changed to support users of both types
(smart card and non smart card) on the same device, by determining the
case dynamically.

BYPASS_POLICY_COMPATIBILITY_CHECK=policy was never used

Bug: 826417
Change-Id: If76b55076d09d5c09e985a3730bf954c72a9f963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030898Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737467}

This reland fixes the sequenced task runner initialisation. Set the
task runner in the constructor and reset it for each unit test execution.

Since there may be multiple instance of DWriteFontProxyImpl instantiated
for multiple RenderProcessHosts, and
DWriteFontProxyImpl::GetUniqueNameLookupTable may access
DWriteFontLookupTableBuilder::QueueShareMemoryRegionWhenReady from
separate threads, there may be race conditions around the
pending_callbacks_ member of DWriteFontLookupTableBuilder.

Sequentialise and guard access to pending_callbacks_ with a separate
sequenced task runner.

Remove explicit configuration of the FontUniqueNameBrowserTest cache
directory as [1] introduced a callback function in
ShellContentBrowserClient which sets this correctly. This avoids
instantiating DWriteFontLookupTableBuilder too early when the ThreadPool
is not yet available in a BrowserTest.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1776358/9/content/shell/browser/shell_content_browser_client.cc#422

Fixed: 1047054
Change-Id: I38cf8b84a48315980624b68bbf55d3727be457b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032119Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737466}

Using wpt-import in Chromium 27802b89.
With Chromium commits locally applied on WPT:
d455934d "Clamp the presentation time to a usable range"
4a9e20a2 "[ElementTiming and LargestContentfulPaint]Fix background img sizes"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I836d46d366b37cf2e71f57ca653dc70f3ed8453f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032306Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737465}

This fixes the following warning that was printed almost
unconditionally:

  "Ignoring untrusted value of the
  extensions.install.login_screen_extensions pref"

Also the CL removes unnecessary handling of the nullptr pref value,
as this case should never occur.

Bug: 1012892
Test: verify that no "Ignoring untrusted value" log appears in browser_tests --gtest_filter="SigninProfileExtensionsAutoUpdatePolicyTest.Test"
Change-Id: I41a18ae371b3b9a01fe9a6926731e5550fd0987f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029507Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737464}

Change-Id: I8ef8ec496ab0fb8857db60d1d8aeb55212b23bcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033542
Commit-Queue: Peter Williamson <petewil@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Auto-Submit: Peter Williamson <petewil@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737463}

Bug: 1047269
Change-Id: Idc9e1547a2be65ff638429ecffcdd6c5149c1b50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031753Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737462}

The crashes caused by this DCHECK happens when a begin-impl-frame
reports no damage, and then presented without frame end. This CL
fixes it.

Bug: 1043091
Change-Id: Idaef2477f7f2904fec87b202c47a3a9be6b95c42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018084Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737461}

https://pdfium.googlesource.com/pdfium.git/+log/62c4aa446733..7b8eb884cfd6

git log 62c4aa446733..7b8eb884cfd6 --date=short --first-parent --format='%ad %ae %s'
2020-01-31 tsepez@chromium.org Make all CXFA_FFWidget observe their CXFA_FFPageview.
2020-01-31 thestig@chromium.org Fix various build/include_order lint errors.
2020-01-31 thestig@chromium.org Give some .in test files better formatting.
2020-01-31 tsepez@chromium.org Remove dwCoordinatesType arg from GetPageMatrix().
2020-01-31 thestig@chromium.org Reduce the number of calls to HasPermissions().
2020-01-31 thestig@chromium.org Move permission constants to constants/access_permissions.h.
2020-01-31 dhoss@chromium.org Run tests with --disable-xfa in coverage_report.py

Created with:
  gclient setdep -r src/third_party/pdfium@7b8eb884cfd6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1010844,chromium:1042915
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I6415f31dfba3a5156486c3f53cb14e64d455c30a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033586Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737460}

cros_supported_configs_ is defined iff OS_CHROMEOS is defined.
However, it is used iff USE_CHROMEOS_MEDIA_ACCELERATION regardless of
OS_CHROMEOS.
This CL aligns the conditions.

BUG=1047719
TEST=Build locally.

Change-Id: I08fe8532c1778ff8c77c7a9d9cdd96ff2a83272f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030924Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737459}

This CL introduces Mojo enums for settings section names and page
visibility as well as a SettingsUserAction class and several derived
classes which encapsulate user actions in settings.

Bug: 1047062
Change-Id: I04d1648ade1f8b25dc83c2f32805a22bd4c23458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030000Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737458}

One of these retains a callback method on the object; the other uses the
lambda-captures-&controller pattern.

Bug: 1011446
Change-Id: Ic5ea4f6231a94e3e6d14d646bb78f00220e90ad0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032231Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737457}

Bug: 1021634
Change-Id: I7ac7a2ea5a9bdcc5a244057f74bc8305773546ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026150
Commit-Queue: benjamin joyce <bjoyce@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737456}

This is a reland of 97332534

Original change's description:
> x11: Ensure XEvent translation is equivalent to ui::Event ctors
>
> This is part of the patch series migrating PlatformEvent to ui::Event
> (formerly using XEvent) in Aura/X11 in order to eliminate this
> fundamental difference/incompatibility between Ozone and non-Ozone X11
> ports. Design doc [1] describes in details such effort.
>
> This CL, particularly, is meant to ensure XEvent => ui::Event
> translation code (x11_event_translation.{h,cc}) is equivalent to
> constructing ui::*Event using the PlatformEvent ctors, the mechanism
> used so far to do such "translation".
>
> To achieve it, events_unittests have been modified to use the brand new
> X11 event translation code as well as fixing discrepancies found along
> the way. Most of them are trivial and this change does not bring any
> behavioral change.
>
> [1] https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc
>
> Bug: 965991
> Change-Id: I1b738fd20c21233a611a0661b76da7fcdf176613
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022322
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736213}

Bug: 965991, 1047005
Change-Id: I07d7ced6460845faa36d91b7e38bae10ff4697c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028408
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737455}

Disable skia_gl renderer for Fuchsia since it's not supported


Bug: 1043399
Change-Id: I44a25bb3745282b701ba86ad44c19b8a466f39b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008235Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Chong Gu <chonggu@google.com>
Cr-Commit-Position: refs/heads/master@{#737454}

The plan is to stop using the platform2 functions sometime soon.

BUG=b:144199481
TEST=try

Change-Id: Iad53b4818459b31bd43d6065191ccd0c6403bbda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032721
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737453}

This CL causes dxva video decoder to send the output metadata for the
display, even if the stream doesn't provide metadata of its own.

For AMD cards, this CL also causes it to send empty stream metadata,
rather than omit sending it.  Otherwise, it crashes intermittently.

Bug: 1045586
Change-Id: If0a478bade4453c235f9f6d77c453e6ea3c179e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020744Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737452}

This CL updates pedal logic to work with and without the button row
feature enabled. Pedals may attach to matches that also have tab-switch
and keyword buttons. ExecutePedal is used instead of OpenMatch when
the intent is to perform the pedal action.

Bug: 1046523
Change-Id: I5a46383ca716df2f41f21eec3ffcf2969e7ab593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032189Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737451}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb93f7b380bc..f18fddd279d2


Created with:
  gclient setdep -r src-internal@f18fddd279d2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ib4900706c7f5527bd273a64020e0935cc0f3bc8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033420Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737450}

download_stats.cc has removed the histograms that needed to be kept in
sync with download_file_types.asciipb, so we no longer need to edit
it when updating download file types.

Change-Id: Ica4fb0027f1d1f029c6ac5ef1eedeb1c26e8fb7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033434
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737449}

The ModuleDatabase was moved to its own sequence but both the
IncompatibleApplicationsBrowserTest and ThirdPartyBlockingBrowserTest
test fixtures were not updated.

This CL moves the accesses to the ModuleDatabase instance to the right
sequence.

Also added an override for the OutOfProcessQuarantine feature to allow
local testing. This was not an issue on the bots because they respect
the fieldtrial_testing_config.json file.

Bug: 850517
Change-Id: I2e8955b33cd7ffc75f74dd56b01df9dec96fc604
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031742
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737448}

This would otherwise be created once a user logs in. This reduces friction if the admin wants to set registry entries before anyone has signed in.

Bug: 1047460
Change-Id: I035717a3c46513a23540f9b19274841b5eff3667
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031872Reviewed-by: Tien Mai <tienmai@chromium.org>
Commit-Queue: Robin Lewis <wrlewis@google.com>
Cr-Commit-Position: refs/heads/master@{#737447}

Fix a missing nullptr initialization.

Original change:
https://chromium-review.googlesource.com/c/chromium/src/+/2003256

Change-Id: I5aa663c8273449c0e77f526c55097eb288edb72d
Bug: 1047641, 1022059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032787
Commit-Queue: Eric Orth <ericorth@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Auto-Submit: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737446}

This CL adds an implementation of a dummy Reauth dialog to
SigninViewController. This dialog is needed only for developer needs
and should never be shown in production.

The dialog is hidden behind "SigninReauthPrompt" feature flag.

This CL also adds minor details to the comment of
SigninViewController::ShowReauthPrompt() method.

Bug: 1045515
Change-Id: I74b066157ddfa3d697f12e45511c9cbdceaf1c21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030766Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737445}

It's been a couple of years since this code was used, and the oncoming
refactoring will be easier without this in the way.

Bug: 1044707
Change-Id: Ic6e07b8f3ce61312d2c5a89d8af9850ea7510a2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032230Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737444}

Bug: 1030813
Change-Id: Ic368d70f3d78a49ea280f70cc795935e11cdc264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031428
Commit-Queue: Josh Simmons <jds@google.com>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737443}

Create the UrlBarController interface and a simple version of the method
createUrlBarView() without UrlOptions.

Use it in WebLayerShellActivity to show a URL bar.

UrlBarController updates url text whenever the visible URL changes. This
means that the embedder doesn't have to listen to onVisibleUriChanged and
create a new URL Bar view.

Bug: 1025607, 1044571
Change-Id: I83bff6f82354ab970dbd84d3d24e5fac2cf66db7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017408
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737442}