GitLab

Revert of Add perf tests for simd yuv->rgb conversion functions. (https://codereview.chromium.org/238353008/)

Reason for revert:
Breaks win64 compile.

Original issue's description:
> Add perf tests for simd yuv->rgb conversion functions.
> 
> BUG=172898
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266490

TBR=scherkus@chromium.org,rileya@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=172898

Review URL: https://codereview.chromium.org/251953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266496 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266494 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=172575:172711&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/258003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266493 0039d316-1c4b-4281-b951-d872f2087c98

This is a large refactoring to cleanup the code that handles video
capturing in the render process. The goal of this change is to:
* Simplify threading model for objects involved.
* Clarify ownership model.
* Remove extra complexity caused by media::VideoCapture.

Summary of this change:
* Interface media::VideoCapture is removed completely.
  This interface doesn't add much value. It fails to define threading
  model and ownership. Some of the methods are obsolete. 
* Pepper code that performs video capturing now do not inherit from
  media::VideoCapture.
  The inheritance is not necessary
* VideoCaptureImpl is now a purely IO thread object.
  VideoCaptureImpl can only be accessed on the IO thread. It now becomes
  and inner object of VideoCaptureImplManager. Client is not allowed to
  access this object directly. This helps remove code that accepts
  call from the render thread and hopping to the IO thread. This also
  makes cleanup much simpler.
* VideoCaptureHandle is removed.
  The function of VideoCaptureHandle, i.e. handle cleanup of video
  capture resource is now folded into VideoCaptureImplManager. It's
  function is now replaced by a closure.
* VideoCaptureImplManager becomes the public interface for accessing
  video capture device and start/stop capture.
  It takes VideoCaptureImpl as an internal object and sheild it from
  clients. We can now perform cleanup to prevent leak. Also ensures
  VideoCaptureImpl objects are deleted on the IO thread.
* VideoFrames delivery done using callback insteasd of an interface.
  Using callback to deliver VideoFrames and state changes make thread
  hopping much simpler. Clients no longer need to provide an
  EventHandler interface.
* Net deleted 450 lines of code.

Tested with apprtc.appspot.com and example pepper plugin.
Additional test to verify there's no leakage of VideoCaptureImpl objects.

BUG=335327, 362558

Review URL: https://codereview.chromium.org/242013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266492 0039d316-1c4b-4281-b951-d872f2087c98

server configs, so that server can replace both the server config and
source address token key when communication with keystore succeeds.

Add retry logic and more graceful fallback to code that loads QUIC
insecure secrets from keystore.  Not flag protected.

Merge internal change: 63497296

  + Changed ComputeSourceAddressTokenKey to DeriveSourceAddressTokenKey
  + Fixed comments.
  + Changed Config* to a const reference in BuildRejection,
    NewSourceAddressToken and ValidateSourceAddressToken methods.

Merge internal change: 65382861

Use QuicEncrypter and QuicDecrypter with "AES128 + GCM-12" as the AEAD
algorithm to implement CryptoSecretBoxes' Box and Unbox methods. These
methods are used in unit tests only.

R=wtc@chromium.org

Review URL: https://codereview.chromium.org/213473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172898

Review URL: https://codereview.chromium.org/238353008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266490 0039d316-1c4b-4281-b951-d872f2087c98

Use a map sorted by <timestamp, ssrc, packet_id> to keep track of duplicate
packets. This map conveniently sorts such that map.begin() is the oldest packet
and should be sent first.

Also make sure that we never buffer more than one RTSP packet per ssrc.

Review URL: https://codereview.chromium.org/248493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266488 0039d316-1c4b-4281-b951-d872f2087c98

It's need to be used by utility and browser processes.

BUG=349645

Review URL: https://codereview.chromium.org/256923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266487 0039d316-1c4b-4281-b951-d872f2087c98

The DomDistillerService now requires callers to pass in DistillerPage.
This enables callers to more closely control how the page is distilled.

BUG=361939

Review URL: https://codereview.chromium.org/254483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266486 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/258893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266485 0039d316-1c4b-4281-b951-d872f2087c98

This patch implements the getService and getServices functions of the
bluetoothLowEnergy API. The key changes introduced are:

* BluetoothLowEnergyEventRouter, which tracks Observer events from the
device/bluetooth API, maintains a mapping from instance IDs to the necessary
metadata to look up a GATT object from the adapter, and handles basic logic
such as conversion between device::BluetoothGatt* and
extensions::api::bluetooth_low_energy::* objects and sending of API events.

* Implementation of getService and getServices functions.

* In browser unit tests for the above functions.

BUG=265663
TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.*, device_unittests

Review URL: https://codereview.chromium.org/256413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266484 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357670

Review URL: https://codereview.chromium.org/259763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266483 0039d316-1c4b-4281-b951-d872f2087c98

This blacklists some specific types of HID devices from
being accessible to the chrome.hid API. Namely, any keyboard,
mice, other pointer devices, or system control inputs (such as
power and reset buttons) are blocked and cannot be enumerated
or opened by the consumers of the API.

BUG=355022
R=rpaquay

Review URL: https://codereview.chromium.org/258733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266482 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up CL of https://codereview.chromium.org/228263004/

This CL adds instances of SavePasswordProgressLogger into crucial parts of the password manager code. After this CL, the logging should already work, i.e., when the command line flag is enabled, the internals page should show debugging info about saving a password on a website.

More context in the design doc: https://docs.google.com/document/d/1ArDhTo0w-8tOPiTwqM1gG6ZGqODo8UTpXlJjjnCNK4s/edit?usp=sharing

BUG=347927

Review URL: https://codereview.chromium.org/231283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266481 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/252703006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266480 0039d316-1c4b-4281-b951-d872f2087c98

Store default search provider data in dictionary pref, and add DefaultSearchManager class to handle the reading and writing of this pref (DefaultSearchManager will eventually all default search related concerns).

This pref will be used to persist data about user-selected 
default search providers. In future CLs, support will be added for default search providers set by policy and sync.


BUG=365762

Review URL: https://codereview.chromium.org/229763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266479 0039d316-1c4b-4281-b951-d872f2087c98

Per the spec DiscardPadding is a signed integer.  Sadly the parser
only supports UInt values at the moment.  To avoid refactoring the
world, we parse DiscardPadding as binary and have a one off parser.

A re-encoded bear-opus-end-trimming.webm will be landed separately
ahead of this change.

This patch also adds a check to ensure we never parse uint64 values
which will overflow an int64 container.

BUG=366750
TEST=Existing tests pass w/ DCHECK.

Review URL: https://codereview.chromium.org/251583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266478 0039d316-1c4b-4281-b951-d872f2087c98

R=Jói

Review URL: https://codereview.chromium.org/244313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338759
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/250903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266476 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=wtc@chromium.org, brettw@chromium.org

Review URL: https://codereview.chromium.org/253643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266475 0039d316-1c4b-4281-b951-d872f2087c98

This CL reenables the change introduced in http://crrev.com/256939. The UI is updated to reflect the one approved by UX team.

BUG=314621

Review URL: https://codereview.chromium.org/225523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266474 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionGarbageCollector collects isolated storages of disabled apps as garbages,
this may cause unexpected data loss for temporarily disabled extensions.
This CL protects non-enabled installed app's isolated storage from GC.

BUG=328637
R=ajwong@chromium.org, mek@chromium.org, rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/247113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266473 0039d316-1c4b-4281-b951-d872f2087c98

rather than failing mysteriously, this will autofill the number and then mark it invalid.

BUG=365630

Review URL: https://codereview.chromium.org/252803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=169282

Review URL: https://codereview.chromium.org/242803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266471 0039d316-1c4b-4281-b951-d872f2087c98

This implements a touch dispatch model in which touchmove sending is throttled
while a scroll sequence is active and being consumed.  Such touchmove's are
marked with |cancelable = false|, indicating to any potential consumers that the
event cannot be prevented from triggering a platform gesture. Throttling limits
the touchmove sending rate during scrolling to 1 event per 200ms.

BUG=346693

Review URL: https://codereview.chromium.org/245833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266470 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a problem where the url gets stale after navigation.

BUG=365238
TEST=testTabUrl

Review URL: https://codereview.chromium.org/256843006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266467 0039d316-1c4b-4281-b951-d872f2087c98

Follow on for https://src.chromium.org/viewvc/chrome?revision=218548
which fixed various background tab issues related to visibility (see
for example bugs 118269, 142061, 155365 and 272962) by introducing a
WebContents initially_hidden creation-time flag.

Restored tabs don't currently set that flag, and that causes various
visibility issues (see bug). Fix that by ensuring that restored tabs
set their initially_hidden creation-time flag.

Note the delegated interface to tab restore service caused the error
so add tests for that: a direct test of the delegate, and a test for
a delegate user (recent tabs menu).

TEST=browser_tests --gtest_filter="*TabDisposition" 
BUG=358517

Review URL: https://codereview.chromium.org/227043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366978

Review URL: https://codereview.chromium.org/251593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266465 0039d316-1c4b-4281-b951-d872f2087c98

removed.

We explicitly cancel full screen mode on disconnection, which was resulting in
an exception in the event handler, preventing the full-screen class from being
removed from the <html> node. The left the plugin container full-screen on top
of the Disconnected dialog, making it unclickable.

BUG=365920
NOTRY=true

Review URL: https://codereview.chromium.org/258863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266464 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/256893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266463 0039d316-1c4b-4281-b951-d872f2087c98

This field is not used by the tile manager as it only affects the
resource pool and the tile manager is no longer responsible for
forwarding these changes to the resource pool.

Also removes inappropriate call to SetResourceUsageLimits in
TileManager::SetGlobalStateForTesting.

R=vmpstr
BUG=

Review URL: https://codereview.chromium.org/255533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266462 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=ben@chromium.org

Review URL: https://codereview.chromium.org/258833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266461 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/255993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266460 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266459 0039d316-1c4b-4281-b951-d872f2087c98

This CL
* Adds new filesystem type kFileSystemTypeDeviceMediaAsFileStorage,
which is handled by chromeos::FileSystemBackend.
It uses DeviceMediaAsyncFileUtil, so the implementation is
shared with MTP support in mediaGalleries API (MediaFileSystemBackend).

We need different types since we need different handlings.
(Permission management for file handler extensions, unlimited CopyOrMoveValidator
for allowing non-media files, etc.)

* Adds monitoring by storage_monitor::RemovableStorageObserver in
file_manager::VolumeManager so that MTP device is detected and
mounted to the file manager.

BUG=363960

Review URL: https://codereview.chromium.org/246293011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266458 0039d316-1c4b-4281-b951-d872f2087c98

This required disabling the benchmarks that were causing it to fail. It looks
like those failures were due to lack of tab support in ChromeShell.

BUG=337829

Review URL: https://codereview.chromium.org/250593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266457 0039d316-1c4b-4281-b951-d872f2087c98

This depends on
https://codereview.chromium.org/247193002/

BUG=None

Review URL: https://codereview.chromium.org/250793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266456 0039d316-1c4b-4281-b951-d872f2087c98

One of the horrors of using Xlib is its Output buffer.  When calling Xlib
functions, the X command bitstream is not actually sent right away.
Commands are first queued up in the Xlib output buffer, and only sent over
the wire when the output buffer is flushed.

X clients typically don't have to worry about this, since (a) commands
that require return a response are flushed immediately, and
(b) they usually have an event loop that calls XPending() (XNextEvent(),
or XWindowEvent()), which does a Flush internally.

Chrome, however, listens to the Xserver fd, and only enters its XPending()
loop if the File Can be Read Without Blocking.

The quick and dirty fix is to just send an explicit XFlush() after
XUngrabServer().
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>

BUG=chromium:366125
TEST=tbd

R=msw@chromium.org
R=erg@chromium.org

Review URL: https://codereview.chromium.org/246723006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266455 0039d316-1c4b-4281-b951-d872f2087c98

This appears to have introduced assertion failures on the
linux_gpu_triggered_tests try server -- and would have done so on the
Linux Debug (NVIDIA) bot, too, if the hardware had not failed late
last week.

Links to the failures have been added to crbug.com/269808.

> content: Add missing IPC traits for sync_query.
> 
> R=cdn@chromium.org, piman@chromium.org
> BUG=269808
> 
> Review URL: https://codereview.chromium.org/250803010

TBR=reveman@chromium.org

Review URL: https://codereview.chromium.org/252833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266454 0039d316-1c4b-4281-b951-d872f2087c98

Now nacl_irt_mmap with PROT_EXEC is implemented by non-EXEC
mmap and mprotect thanks to

https://codereview.chromium.org/239763005

BUG=359285
TEST=nacl_loader_unittests, trybots
R=jln@chromium.org, mseaborn@chromium.org

Review URL: https://codereview.chromium.org/247563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266453 0039d316-1c4b-4281-b951-d872f2087c98