Commits · 3fb507085da059ec9b03090680bc7ef3be82fe9e · eriksson monteiro / tangled

17 May, 2019 40 commits

chrome/browser/ui/views/webauthn: drop “fade” hack. · 3fb50708

Adam Langley authored May 17, 2019

With r660884, the “rotate” animation now sets the visibility of the
layer and so we no longer need to override it and use the “fade”
animation instead to avoid DCHECKs.

This effectively reverts r659735.

Change-Id: I6fbbc47a606b0bb9cbf8017e14b9f3719c16f887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617207
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#660974}

3fb50708

Navi: Update strings for background and sign-in modules · 4dc9d721

John Lee authored May 17, 2019

Bug: 964448
Change-Id: Ia44cae0803d49bf16c5df3bb945f0c8ea2841c49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617095
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660973}

4dc9d721

Roll src/third_party/angle 09eabed99d0e..52bfbd35fc96 (2 commits) · 1f1cf7d7

chromium-autoroll authored May 17, 2019

https://chromium.googlesource.com/angle/angle.git/+log/09eabed99d0e..52bfbd35fc96

git log 09eabed99d0e..52bfbd35fc96 --date=short --no-merges --format='%ad %ae %s'
2019-05-17 ynovikov@chromium.org docs: Update Android Test Instructions reference
2019-05-17 syoussefi@chromium.org Vulkan: Tighten descriptor stage usage hints

Created with:
gclient setdep -r src/third_party/angle@52bfbd35fc96

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@google.com

Change-Id: I31ebfd54dcebd3343f075130350bad9548ca1d1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618007Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#660972}

1f1cf7d7

arc: Fix arc-graphics-tracing timestamp parsing · 46a74e6a

Lloyd Pique authored May 17, 2019

When processing systrace events, a decimal timestamp in seconds like
"123.456000" was being parsed as a pair of int32_t's separated by the
dot, and then converted into an microsecond integer value by scaling the
integer seconds value appropriately, and adding the fractional part.

However if the number of seconds was large enough, the multiplication
would overflow an int32_t, resulting in an incorrect timestamp being
computed, which then caused those events to be filtered out as they were
not in the expected range.

The fix was to simply implicitly convert to an int64_t to hold the
result of the multiplication.

This was enough to fix the bug.

However the parsing makes a potentially unsafe and unchecked assumption
that the number of digits after the decimal point is always the expected
amount. If it was ever different, the computed timestamps would be
incorrect.

I also went and corrected most of the code to use a uniform type for the
timestamp of uint64_t, as parts of the code used int64_t, and other
parts used double. Doubles are still used however for JSON serialization
and deserialization.

To verify the timestamp parsing, I added some specific tests to the unit
test.

TEST=Unit tests pass, arc-graphics-tracing works
BUG=b:132907802

Change-Id: I8608fae90eb4708f5c6abd7088ca4b859aeab91f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616325Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Lloyd Pique <lpique@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660971}

46a74e6a

Roll src/third_party/swiftshader cd707e6f223e..62ad1eeb0e6b (3 commits) · 57aef65d

chromium-autoroll authored May 17, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/cd707e6f223e..62ad1eeb0e6b

git log cd707e6f223e..62ad1eeb0e6b --date=short --no-merges --format='%ad %ae %s'
2019-05-17 sugoi@google.com Allow ImageView to cast compressed texture into other formats
2019-05-17 bclayton@google.com LLVMReactorDebugInfo: Fix warning that function may end without return.
2019-05-17 bclayton@google.com CMakeLists: Allow the sanitizers to be enabled for GCC

Created with:
gclient setdep -r src/third_party/swiftshader@62ad1eeb0e6b

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

Change-Id: Iebf8e696de5ebcf20b2fb0d4573c5f7f0938a92d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618006Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#660970}

57aef65d

[ios] Adds metrics for InfobarBadge. · 3dd4a283

sczs authored May 17, 2019

Creates a Histogram and enum for an InfobarBadgeTapped either active or
inactive.

Adds IsInfobarBadgeActive flag to InfobarBadgeTabHelper, this is needed
to update the active state whenever switching webstates.*


*Unit test update coming up in a followup CL since I want to keep this
one simple, and testing that requires some changes to the unittest
setup.


Bug: 892376, 963482
Change-Id: I5d2f62bdac3d930929674b315ac6e7d54ba9b385
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612362
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660969}

3dd4a283

[LayoutNG] Re-implement `::first-line` for LayoutNG · 60b99451

Koji Ishii authored May 17, 2019

This patch implements a specialized painter for `::first-line`
background for LayoutNG.

LayoutNG tried to avoid this special code by inserting
anonymous inline box. Because the spec[1] states "behaves
similar to that of an inline-level element" and that it can
utilize existing paint code for regular inline boxes.

However, special code to build and manage LayoutObject tree
is getting bigger and bigger. It's started to be more complex
than writing a special code in paint.

This approach is more similar to what legacy does.

[1] https://drafts.csswg.org/css-pseudo-4/#first-line-styling

Bug: 963575
Change-Id: I69120ccf44fe9055d68181b83dc1bc4b91c542d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611700Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660968}

60b99451

[ios] Remove TODO in CERT_VERIFY_PROC_IOS check. · 7c18c6fc

Justin Cohen authored May 17, 2019

Bug: 964323
Change-Id: Ibf17edb4b9f736887c8c6ebfd81d8e59e838124c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618042
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660967}

7c18c6fc

Clean up LOAD_DO_NOT_SEND_COOKIES requests. · dda77484

Jesse Selover authored May 17, 2019

This CL is part of a larger project to remove the LOAD_DO_NOT_* privacy load
flags and replace them with the allow_credentials setting. See
https://crbug.com/799935,
https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4,
and
go/allow-credentials-tracker
for the motivation and progress of this change.

This is the only place where a request is configured with
LOAD_DO_NOT_SEND_COOKIES without either of the other two load flags. The
request currently saves cookies, but doesn't send them.
I've conservatively put allow_credentials = true on this request, which will
cause the saved cookies to be sent. If your service doesn't require cookies
then it should be allow_credentials = false.

Bug: 799935
Change-Id: Ibd435acc810359482ec97d633637e42dc53923a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600546
Commit-Queue: Jesse Selover <jselover@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Jesse Selover <jselover@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660966}

dda77484

Enable backdrop-filter for stable release. · 5ff2d1be

Mason Freed authored May 17, 2019

This feature has received 3LGTM's on the I2S: see [1].

SHERIFFS: If this commit causes layout (or other) tests to fail,
especially anything related to filters or backdrop-filter, feel
free to revert it. There are some known bugs (see [2]) but none
should have much impact. Perhaps the most impactful is [3], which
is that when running with GPU rendering disabled (--disable-gpu),
backdrop-filter is not fully implemented. That is in progress now,
but I would like to begin gathering other latent bugs.

[1] https://groups.google.com/a/chromium.org/forum/m/#!topic/blink-dev/GRl1_Qy97jM
[2] https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3ATopic-Backdrop-Filter
[3] https://crbug.com/916318

Bug: 497522
Change-Id: Ib2241d45e59b7b68e9e3073fd4e32028d93a2d64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614683
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660965}

5ff2d1be

Revert "Recreate DirectManipulationHelper when every LRWHH UpdateParent" · f0b69c88

David Bokan authored May 17, 2019

This reverts commit 07da8ba6.

Reason for revert: Causing issues in 962784 and 951901

Original change's description:
> Reland "Recreate DirectManipulationHelper when every LRWHH UpdateParent"
>
> This is a reland of 61450bbc
>
> Original change's description:
> > Recreate DirectManipulationHelper when every LRWHH UpdateParent
> >
> > Compositor and window event target is associated with window's parent. We call
> > LRWHH UpdateParent when window's parent update, includes window's parent
> > actually update and window initialize. Recreate DirectManipulationHelper on
> > every window's parent update helps keep DirectManipulationHelper lifecycle
> > tracking simpler. We also make CompositorAnimationObserver owned by
> > DirectManipulationHelper.
> >
> > With this changes, we start the DirectManipulation event polling when
> > DirectManipulationHelper created and stop when it destroyed. The issue should be
> > fix since event polling start no more depends on DM_POINTERHITTEST.
> >
> >
> > This also includes 2 refactoring changes:
> >
> > 1. Move CompositorAnimationObserver into DirectManipulationHelper.
> > 2. Call ZoomToRect to reset viewport of DirectManipulation when viewport is
> >    actually transformed in RUNNING - READAY sequence.
> >
> > Bug: 914914
> > Change-Id: I0a63f9a407e0231d631e64f2b22a9975471f2fd9
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547049
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#649342}
>
> TBR=sky@chromium.org
>
> Bug: 914914
> Change-Id: Ic0c8aa84d21fe7a88fd9d3552dbd5ffdb6adcc4f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562582
> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
> Reviewed-by: Jianpeng Chao <chaopeng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#649682}

TBR=sky@chromium.org,chaopeng@chromium.org

Bug: 914914,951293,951901,956579
Change-Id: I4252717e2f708643b1d6b3f8305c32142a1a2735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618008Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660964}

f0b69c88

[NTP] Add default backgrounds icon · f92d626a

Kyle Milka authored May 17, 2019

Update the default background tile to use the correct
icon.

Screencast: http://go/scrcast/NTA1MjYwODk1NzkwNjk0NHw5MDBlYzU5YS1mMg

Bug: 937570
Change-Id: Ib1aa03cb0fab2e681774424492511d239f62dd7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618001Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660963}

f92d626a

Robolectric tests using binary resources · f756b382

Sam Maier authored May 17, 2019

This change enables binary resources (instead of the deprecated legacy mode)
for Robolectric. Also, this CL fixes a number of tests which are broken by
this change.

Updated some robolectric Android jars to enable usage of this newer feature.

TBR=Last 2 files are just updating from J to K

Bug: 963624, 635199
Change-Id: If99f8850baa5de9d8ec8eaf2c58b2c0b16be0658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611875
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660962}

f756b382

Reland "[remoting][IT2ME] Register support host over remoting API" · 2704a50d

Yuwei Huang authored May 17, 2019

This is a reland of 7432ef1a

It fixes the issue of remoting_support_host_messages.proto using
host_info.proto without depending on it.

Original change's description:
> [remoting][IT2ME] Register support host over remoting API
>
> This CL adds a RemotingRegisterSupportHostRequest that registers an
> IT2ME host using the new remoting API. This will be used for the
> ChromeOS enterprise use case but the website will still use the old
> XMPP-based registration request until it is updated to support that.
>
> Bug: 962765
> Change-Id: Ifcf2eb6eaba76db6386ae27f86f20e06088383f0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611023
> Commit-Queue: Yuwei Huang <yuweih@chromium.org>
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#660738}

Bug: 962765
Change-Id: Ia5e6bf1263ad7f2e4f353c9fc0e0c13d73bb8be5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617100
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660961}

2704a50d

Roll src/third_party/chromite 819795047c32..fdbb15913346 (2 commits) · f8742970

chromium-autoroll authored May 17, 2019

https://chromium.googlesource.com/chromiumos/chromite.git/+log/819795047c32..fdbb15913346

git log 819795047c32..fdbb15913346 --date=short --no-merges --format='%ad %ae %s'
2019-05-17 evanhernandez@chromium.org api: Regenerate binhost proto
2019-05-17 mikenichols@chromium.org upload_symbols: Refactor duplicate to utilize batch api

Created with:
gclient setdep -r src/third_party/chromite@fdbb15913346

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I9156b72e613f3ddaa0cd94a079bf3eca83e44e89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616736Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#660960}

f8742970

Use PhysicalRect for outlines · 9633aac7

Xianzhu Wang authored May 17, 2019

Change-Id: I13a4bbd5f919a744ac4fecc0a48651e95a9138b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612358
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660959}

9633aac7

Update Plugin VM strings in settings page · f90249c4

Timothy Loh authored May 17, 2019

This CL updates the Plugin VM strings used in the settings page, fixes
some errors in the descriptions and marks them as translatable.

Bug: 950431
Change-Id: I45252e977860abfcbdab22649a1141eee8a49bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614727
Auto-Submit: Timothy Loh <timloh@chromium.org>
Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org>
Reviewed-by: Alex Oldemeier <aoldemeier@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660958}

f90249c4

Support CustomTabColorSchemeParams · 55cb2cc4

Pavel Shmakov authored May 17, 2019

Support the api added here:
https://android-review.googlesource.com/c/platform/frameworks/support/+/958733

Since CustomTabActivity is recreated when system setting is changed,
it's enough to pick correct scheme parameters when activity is launched
and new instance of CustomTabIntentDataProvider is created.

Bug: 960453
Change-Id: I975682a8f6dd57a5ab6fa0bc12dc769e80631bb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599591
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660957}

55cb2cc4

Add methods for acquiring Task IDs in Sync (without SyncedTabDelegate depending on chrome/browser) · b6bc5bf8

David Maunder authored May 17, 2019

Bug: 961356
Change-Id: Ibc00f936ffe9978e8599e132dfdf7f1a1a70c2c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612662
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660956}

b6bc5bf8

android: disable verity in with_asan.py on M+. · 9375cae1

John Budorick authored May 17, 2019

Bug: 790202
Change-Id: Icb8d353adb84747d5791c7a38e3ef211690cf712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614025Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660955}

9375cae1

Roll src-internal c6e50309dcbd..bbaaf61f1d99 (1 commits) · f23ad060

chromium-internal-autoroll authored May 17, 2019

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c6e50309dcbd..bbaaf61f1d99

Created with:
gclient setdep -r src-internal@bbaaf61f1d99

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com

Change-Id: I92ebb34e7beb1fe32a7f3aa6c9a0002bfc604100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616730Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#660954}

f23ad060

Screen Orientation: do not fire the event on the PageVisibilityChanged stack. · daddb975

Mounir Lamouri authored May 17, 2019

This is also delaying resolving the promise to make sure the order stays the
same.

Bug: 960657
Change-Id: I92095affb8223dd60346796eec1b6cd7d3f0efc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617552Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660953}

daddb975

Introduce content_system service · 8b941999

Ken Rockot authored May 17, 2019

This is a replacement for the global content_browser service instance.
Necessary because some random services (like pdf_compositor) connect
directly to content_browser by name. There are multiple instances of
content_browser -- the global one, and one per Browser Context -- and
it is impossible in general for the Service Manager to correctly resolve
these connection requests to the global instance.

It only works today because of a combination of luck and subtle
Service Manager complexity which is about to be deleted.

Furthermore, the work done and interfaces exposed by the global instance
vs the per-BrowserContext instances are almost entirely non-overlapping,
so they are functionally different services already anyway.

For now content_system's service manifest programmatically mirrors the
content_browser manifest (plus overlays), without its packaged services.
All non-renderer clients which connected to content_browser before are
updated in this CL to connect to content_system instead, and
content_system is designated as a singleton service to ensure the
Service Manager can always properly route to it.

This is a precursor to removing the content_packaged_services service,
as well as removing packaged services from content_browser and
generally simplifying service registration across the system.

Bug: 961869, 895615
Change-Id: I9b022f1600ff25e72795e9f63d9b9b978079f80f
TBR: avi@chromium.org
TBR: blundell@chromium.org
TBR: boliu@chromium.org
TBR: halliwell@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606764Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#660952}

8b941999

Settings WebUI: replace paper-tabs with cr-tabs · 6aea0761

Esmael El-Moslimany authored May 17, 2019

Bug: 960564
Change-Id: Ica6b02cfca8e95e5e41871153359fe36f33c0599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613372
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660951}

6aea0761

[SendTabToSelf] Created a JNI layer that listens for STTS model changes. · 9cd345a2

Tanya Gupta authored May 17, 2019

This JNI layer is needed for the SendTabToSelfInfobarController to
listen for model changes  and show an infobar accordingly. This required
refactoring the code that converted the native SendTabToSelfEntry to
the Java version.

Change-Id: I2b63c2bfbfa66ac70a2fd320ae7d9652b1ff996b
Bug: 949233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611223Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660950}

9cd345a2

[Cast MRP] Workaround for DCHECK failure when attempting to cast. · 732d06ba

John Williams authored May 17, 2019

CastDialogSinkButton::RequestFocus is called recursively, resulting
in a DCHECK failure.  As a workaround, this function now detects
when it is called recursively and aborts prematurely.

Change-Id: I4847f862868ef9c15ed0ca6cd54cb36cc559a901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488581
Commit-Queue: John Williams <jrw@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660949}

732d06ba

[DevTools] Change colors of websocket message viewer datagrid · b7376e9a

Joey Arhar authored May 17, 2019

Currently in the websocket message viewer, sent text messages have a
green background, received text messages have a white background, and
binary messages are yellow on yellow. This patch removes all of these
interesting colors and replaces them with data grid striping to look
more like the other datagrids in devtools.

Screenshots: http://crbug.com/963949#c2
Bug: 963949
Change-Id: I0403a8c67a36e5ad0bd006d59e60fc02d371d7ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614036Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660948}

b7376e9a

Add EnumTraits mapping network::mojom::NetLogCapture to net::NetLogCapture. · 60ed2572

Eric Roman authored May 17, 2019

Bug: 962523
Change-Id: Ie88be0e1cd3d132e1124aded16cdcec0bd65c2b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613936Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660947}

60ed2572

[omnibox] Remove New Variants Round 2 experiments (8 flags total) · 07c0f5c7

Tommy C. Li authored May 17, 2019

We have completed this experiment, so we don't need this code anymore.

This removes those 8 flags and the associated UI code.

Bug: 936079
Change-Id: Id120d5619807d413bd0cfea1ad702b87d72b6505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616151
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660946}

07c0f5c7

Remove DCHECK in scroll metrics recording · 7c1d37a9

David Bokan authored May 17, 2019

This is causing crashes in debug builds. Comment out for now so that it
allows running with DCHECKs enabled while we investigate.

Bug: 944706
Change-Id: I4ff0d604dc52c8893898195c6843e95d91b5598a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617881
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Auto-Submit: David Bokan <bokan@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660945}

7c1d37a9

Add documentation for myIpAddressEx(). · ac586889

Eric Roman authored May 17, 2019

Bug: 959020
Change-Id: I04e0b4e79266a04f6cafcd823ebc4a659be1cae2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616143
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660944}

ac586889

webauthn: adjust timeout bounds. · b168f89f

Adam Langley authored May 17, 2019

Sites can specify a timeout for a Webauthn operation but Blink enforces
sanity bounds on the value. This change alters those bounds from [1..60]
seconds to [10..600] seconds.

A one second timeout is unreasonable: it'll cause the UI dialog to
appear and then disappear one second later; probably too fast for the
user to read.

Also, a 60 second upper bound seems too harsh: if a site wants to allow
a longer timeout, why not? I'm sure I've spent more than 60 seconds
going downstairs to find a security key on occasion.

Change-Id: Ia9d677d0b7249059529112b4ee0b69bd870d751a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617644
Auto-Submit: Adam Langley <agl@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660943}

b168f89f

Create public function to get if AccessiblePaneView has focus. · b668c72c

Caroline Rising authored May 17, 2019

This is used to see if the tab strip has focus for showing tab hover cards during keyboard navigation. This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1612220

Bug: 963537
Change-Id: I8d684255c42007012f599b8a13d6a0fda76665d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613927Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660942}

b668c72c

Implement UsbPrinterNotification for saved printer · 046cfb5a

Bailey Berro authored May 17, 2019

This change introduces a notification that is displayed when a user
plugs in a USB printer that is saved to their profile, notifying the
user that the printer has been plugged in.

Bug: 951139
Change-Id: I679e8d19f5bacc94e96a10588c792e307259d7f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594802Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660941}

046cfb5a

Rolling r8 and d8 to 1.6.1 · 5380288b

Sam Maier authored May 17, 2019

Just rolling to stay current. Brings in some more binary size improvements.

Change-Id: If7fdcaace3cd96339c1304155f264f7c3d7361ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617132
Commit-Queue: Sam Maier <smaier@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660940}

5380288b

Roll src/third_party/depot_tools 0e405d1ac6ad..d7e41546c030 (1 commits) · d2b14c8f

chromium-autoroll authored May 17, 2019

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0e405d1ac6ad..d7e41546c030

git log 0e405d1ac6ad..d7e41546c030 --date=short --no-merges --format='%ad %ae %s'
2019-05-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
gclient setdep -r src/third_party/depot_tools@d7e41546c030

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=agable@chromium.org

Change-Id: I236990499c937469c40fe3e96d090c0971c5bbd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616733Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#660939}

d2b14c8f

Management WebUI: Remove redundant text · a89e7283

Yann Dago authored May 17, 2019

- Managed browser: http://screen/XZ1boVPgvaQ
- Unmanaged browser: http://screen/RK8VnbwyaRJ
- crOS account managed: http://screen/TzGFSeG2LSX
- crOS account and device managed: http://screen/OJB4e57XwdP
- crOS account and device managed
  different domains: http://screen/5B0NGV9BF6X
- crOS unmanaged: http://screen/d3QiBwZ3rMk

Bug: 958182
Change-Id: Ice67ddd4b1dbd07d563565fa2170d23442c7500f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595074Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660938}

a89e7283

Add switch to toggle light text inversion in dark mode. · 2cd933e8

Aran Gilman authored May 17, 2019

Not inverting already light text is expected to improve legibility of
text overlaying images. It's not yet known what the net impact will be,
though, since light text in other contexts may become less legible.

To test this feature (i.e. don't invert text in dark mode), add
darkModeTextPolicy=1 to the Blink settings flag when opening Chrome.

Bug: 963578
Change-Id: I34255ea31afe5acf4f15fb1a2473de91cdda0f43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616016
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660937}

2cd933e8

Fix bug where hover cards were showing when exiting the tab during the delay... · 580adecc

Caroline Rising authored May 17, 2019

Fix bug where hover cards were showing when exiting the tab during the delay before showing a hover card.

Bug: 910739
Change-Id: Ia86099879e19fc1d43a4b3527c9b3cc2f63d872b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617083Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660936}

580adecc

[Mac] Specify the MAP_JIT flag when allocating pages for V8. · 2011c945

Robert Sesek authored May 17, 2019

In the future, macOS executables will be signed with the "runtime"
option, which restricts the execution of writable memory. By
specifying the MAP_JIT flag to mmap and code signing with the
"com.apple.security.cs.allow-jit" entitlement, writable memory can be
executed.

Neither the runtime option or entitlement are currently specified during
signing, but setting the MAP_JIT flag is harmless. The signing options
will be specified in follow-up CLs.

Bug: 850193
Change-Id: I834a75e65b815d5a9a62ef1e3d00e143b36d2ce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613809
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660935}

2011c945