GitLab

Current evidence points to a race in cc that is causing surface invariants
violations (No invariants violations detected in LayerTreeHost but detected
in ClientLayerTreeFrameSink).

My suspicion is viewport is updated out of sync with LocalSurfaceId and
device scale factor.

This CL adds a diagnostic CHECK between the pending and active LayerImpls to
attempt to detect the race and produce a better stack trace. The invariant
we want to test here is if active tree has an invalid viewport (viewport has
changed), then the LocalSurfaceId MUST change.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I975c9dfb9c86c292d7aac052bac01510e6efb1c2
Reviewed-on: https://chromium-review.googlesource.com/989851Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547457}

Moving native android selection code to new director to allow
amaralp@ to be OWNER of them.

Change-Id: I91abd703303799745855cf40a7002c60c924197d
Reviewed-on: https://chromium-review.googlesource.com/988798Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547456}

It's helpful for tests outside of content.

Bug: 825242
Change-Id: I44c3f39a4c2c01bf31481c68bd095f7de34b1cbe
Reviewed-on: https://chromium-review.googlesource.com/989847
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547455}

Additional cleanup in preparation for moving the ash implementation
to src/ash.

Note: This CL simplifies and clarifies when and how DisplayProperties
are applied.

Bug: 682402
Change-Id: Ic89eefecbbb2c35b018d05861963044b46dad4c3
Reviewed-on: https://chromium-review.googlesource.com/983006
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547454}

Bug: 814528
Change-Id: I3abfcf7c13e95964ad4d21488e2fad82c96dd4c7
Reviewed-on: https://chromium-review.googlesource.com/987619Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547453}

Switch to an image based gradient to improve memory usage.

BUG=821961,821414

Change-Id: If5599c07cd5af0e6a5ca2fce49ed40a47ab98caa
Reviewed-on: https://chromium-review.googlesource.com/986735Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547452}

style-sheet-interfaces-001.html tested that styleSheet.media was
read-only, but the spec changed to add a [PutForwards] attribute to
|media|, meanining that the attribute is no longer truly read-only.
assert_readonly can have side-effects if the property has a
[PutForwards] attribute, so remove this check, as it was causing the
next test to fail.

Bug: 821780
Change-Id: I77bee2f11484f6e679e4aee6b0641179c686d1d3
Reviewed-on: https://chromium-review.googlesource.com/989407Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547451}

TBR=bashi@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I767f6fc522a4a70d13d85697772c6483a108ec10
Reviewed-on: https://chromium-review.googlesource.com/990083Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547450}

In all instances, I replaced it with it Android, which is functionally
equivalent.

Bug: 826138
Change-Id: I1b4c8a0adfc9c24542cd75d165fee0efac8089c3
Reviewed-on: https://chromium-review.googlesource.com/981497Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547449}

ScrollView, when using layers to scroll, imposes a layer on its contents;
doing so implies by default that the contents opaquely fill their entire
bounds. This is not true for many kinds of contents, so don't assume it to
avoid patches of un-drawn area.

Bug: 826472
Change-Id: I1364c06f43241e6cecbc4eaddb20311047b89bdf
Reviewed-on: https://chromium-review.googlesource.com/987527Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547448}

My CL https://chromium-review.googlesource.com/801979 exposed a bug with
PlainTextRange::CreateRange() when passed a collapsed range at the beginning of
a table cell. TextIterator outputs a tab character ('\t') when iterating over a
table cell boundary; PlainTextRange() is currently counting the tab character
in its character count for this case, but returning a start/end position
(they're the same since it's a collapsed range) before the <td> element, causing
an off-by-one error.

xiaochengh@ found a fix for this issue, so CreateRange() now returns a position
inside the text node, instead of before the <td> element.

Bug: 826615
Change-Id: Ief427ea6aeb0b93cf82bae3b6901cf1b2a8cb4c7
Reviewed-on: https://chromium-review.googlesource.com/987385Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547447}

The bottom container that hosts infobars and snackbars now listens to
the bottom sheet. This allows the bottom container to stack on top of
the sheet when it is showing.

Bug: 827541
Change-Id: Ib130cf4149223afc892945f84483467b88c28588
Reviewed-on: https://chromium-review.googlesource.com/988063Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547446}

Fixes minor issues with an underspecified "Cancel" button matcher and updated
swizzling to use the new LocationBarCoordinator instead of the old
LocationBarLegacyCoordinator.

BUG=825431

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6ef8c3d585f8575939ed74c7ec6eb189d31d6f22
Reviewed-on: https://chromium-review.googlesource.com/989271Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547445}

These are all the tasks required to save, load, and cleanup
thumbnails.

base change: https://chromium-review.googlesource.com/c/chromium/src/+/984952

Bug: 794828
Change-Id: I1ce081f53913a9b4c24b7f00a9d173c3fc061696
Reviewed-on: https://chromium-review.googlesource.com/985014
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547444}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/371913c4e6f0..fd5d1859f1e0

$ git log 371913c4e..fd5d1859f --date=short --no-merges --format='%ad %ae %s'
2018-03-26 achuith cros_vm: Safely create vm_dir.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:782664


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I5e35d45bd91fd417ef123d40fcf3db5f9580469e
Reviewed-on: https://chromium-review.googlesource.com/989845Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547443}

Previously BVC used self.view as superview for tab.view to
animate NTP opening. This disallowed to create a view
controller for _contentArea because views hierarchy should
always match view controller's hierarchy.

To allow view controller creation, this CL always uses _contentArea
as superview for tab.view. In order to avoid animation issues,
_contentArea is temporary resized during NTP opening animation. Doing
this resize is fine in the short term, because _contentArea always
hosts NTP for this specific case. In the long term this code will be
removed because we will need a different NTP opening animation.

A separate _contentArea view controller will allow to fix download
manager presentation. That view controller will be a base view
controller for download manager coordinator, so download manager will
be presented in _contentArea behind the bottom toolbar.

_contentArea is created in a separate CL: crrev.com/c/981684

Bug: 818264
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6e642d9e8fd856ef4c1a0fceb1cf7615dad050a7
Reviewed-on: https://chromium-review.googlesource.com/985150Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547442}

Enable better crypto retransmission in Quartc.

This fixes an issue where sending empty Brain sync messages reset the timer for
retransmitting lost crypto stream packets (most notably, the SHLO).  This means
Quartc will no longer fail to connect whenever the SHLO is lost.

n/a (only changes the Quartc library)
Merge internal change: 190280389
https://chromium-review.googlesource.com/c/chromium/src/+/988393

Base the QUIC crypto retransmission timer on the last sent crypto packet.  Protected by FLAGS_quic_reloadable_flag_quic_better_crypto_retransmission
Merge internal change: 190269115
https://chromium-review.googlesource.com/c/chromium/src/+/988974

Remove special logic for headers stream from QuicWriteBlockedList and replace it with a static streams map. Protected by FLAGS_quic_reloadable_flag_quic_register_static_streams
Merge internal change: 189971751
https://chromium-review.googlesource.com/c/chromium/src/+/988972

In QUIC, initialize packet_number_length in QuicPacketHeader to be PACKET_4BYTE_PACKET_NUMBER instead of PACKET_6BYTE_PACKET_NUMBER. Not protected. No functional change expected.

Also replace PACKET_6BYTE_PACKET_NUMBER used in tests to be PACKET_4BYTE_PACKET_NUMBER as well.
Merge internal change: 189965758
https://chromium-review.googlesource.com/c/chromium/src/+/988474

Remove AndTypeByte from IETF methods in QuicFramer because they all append the type byte, and update other comments.

n/a (method renames)
Merge internal change: 189887458
https://chromium-review.googlesource.com/c/chromium/src/+/988494

Change the QUIC/Quartc write model to buffer all stream data up front.

This isn't so much a change in model as a recognition of how things actually
work and some tweaks to make handle that correctly.  Whenever Quartc writes an
outgoing frame (eg. video, audio, data, or control message) to QUIC, it writes
the entirety of the frame to a new QUIC stream, followed immediately by a FIN.
QUIC buffers all this data, sends as much as it can immediately, and saves the
rest to write later.

QUIC never calls OnCanWrite(), because Quartc gives it a FIN bit for the first
write on every stream.  Hence, this change replaces OnCanWrite() with
OnBufferChanged(), a callback which occurs whenever the amount of data buffered
by a QUIC stream increases or decreases.

This change replaces bytes_written() with bytes_buffered(), which gives direct
access to the data Quartc needs:  how many bytes QUIC still needs to send.

Whenever the buffer size changes, Quartc will report bytes_buffered() to the
Brain.  The initial call to Write() triggers a change in buffer size, and calls
OnBufferChanged(), so Quartc no longer needs extra logic to report the initial
buffer size.

n/a (quartc change only)
Merge internal change: 189824431
https://chromium-review.googlesource.com/c/chromium/src/+/988277

Remove call to Initialize from the MockQuicSession and MockQuicSpdySession constructors.

n/a - test-only change
Merge internal change: 189783811
https://chromium-review.googlesource.com/c/chromium/src/+/988276

deprecate flag FLAGS_quic_reloadable_flag_quic_close_session_on_too_many_outstanding_sent_packets.
Merge internal change: 189774270
https://chromium-review.googlesource.com/c/chromium/src/+/988373

Add framers/deframers for IETF-format Quic BLOCKED, MAX_DATA, MAX_STREAM_DATA, MAX_STREAM_ID, STREAM BLOCKED, and STREAM ID BLOCKED frames in support of eventual migration to IETF Quic.

Not applicable, code not used in production

All of these frames have been done in one CL since they all are very similar.
Merge internal change: 189569936
https://chromium-review.googlesource.com/c/chromium/src/+/987479

R=rch@chromium.org

Change-Id: I3ef18060e76ecf66343a0d7f151402cc8c28bd6c
Reviewed-on: https://chromium-review.googlesource.com/988597
Commit-Queue: Ian Swett <ianswett@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547441}

In mash, Shell::local_state_ is loaded asynchronously. Components
that require access to local state should implement
ShellObserver::OnLocalStatePrefServiceInitialized.

Bug: 678949
Change-Id: I72917db3f83f56335333a3e7b40210c289f58a0c
Reviewed-on: https://chromium-review.googlesource.com/988213
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547440}

This change does some cleanup of SmbService, SmbFileSystem, and SmbProvider.
These changes include:
- Use AsWeakPtr() for SmbService.
- Add an SmbService::GetSmbProviderClient() helper method.
- Store provider_id_ as a member variable on SmbService.
- Remove provider_id as a parameter from SmbService::Unmount()
  - Remove provider_id from the UnmountCallbacks held by SmbProvider
    and SmbFileSystem

Bug: chromium:757625
Change-Id: Iaec9388b04f8bcd2aa781c654b00268ba0948aa2
Reviewed-on: https://chromium-review.googlesource.com/986629
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547439}

https://skia.googlesource.com/skia.git/+log/5ab52f6a3805..01a1cf92603c

$ git log 5ab52f6a3..01a1cf926 --date=short --no-merges --format='%ad %ae %s'
2018-04-02 kjlubick More nans causing infinite recursion in GrPathUtils::convertCubicToQuads

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=reed@chromium.org

Change-Id: If1257cf17825bff214f8406007cc69f8176066d1
Reviewed-on: https://chromium-review.googlesource.com/990032
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547438}

Bug: 825242
Change-Id: Ifb779d7bdc42dc98558803298576568d65a95bc5
Reviewed-on: https://chromium-review.googlesource.com/988806
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547437}

Bug: none
Change-Id: Iacc611282edb2d53bf213b75c07e4b724b2ac0ac
Reviewed-on: https://chromium-review.googlesource.com/989246Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547436}

Modifies the test to use the TabSwitcherMode enum instead of checking
IsIPadIdiom().  Adds some EG matchers for various elements of the tab grid.

BUG=825431
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I29de41c895696627f37cc26b0c7853ab068f1834
Reviewed-on: https://chromium-review.googlesource.com/988273
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547435}

https://skia.googlesource.com/skia.git/+log/c6a19f1d044e..5ab52f6a3805

$ git log c6a19f1d0..5ab52f6a3 --date=short --no-merges --format='%ad %ae %s'
2018-04-02 caryclark fix a couple of minor surface doc changes

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=reed@chromium.org

Change-Id: I5f8c2fcfcf216d331629779dc8ce4e086268d3b9
Reviewed-on: https://chromium-review.googlesource.com/989843
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547434}

Currently, default resolution is set to 2880x1800.
This CL now sets it to the actual screen size.

Bug: 257097
Change-Id: I547262c563453e31cd8be30e79148d4b92d8c90a
Reviewed-on: https://chromium-review.googlesource.com/989531
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547433}

Using wpt-import in Chromium f11c0604.
With Chromium commits locally applied on WPT:
ad7d8f49 "[css-grid] Fix resolution of percentage paddings and margins of grid items"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15230

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=ajuma

No-Export: true
Change-Id: I41891be12620bcbf667e60d2906e56f3f8dfb949
Reviewed-on: https://chromium-review.googlesource.com/989247
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547432}

https://webrtc.googlesource.com/src.git/+log/0ffe03d2ef6f..23ffbe78f3b3

$ git log 0ffe03d2e..23ffbe78f --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I5eeef4598a152d8cd89c058390b67b036d4e2a2e
Reviewed-on: https://chromium-review.googlesource.com/989842
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547431}

While working on supporting LayoutNG, it turns out that there are
several cases where the selection range becomes start > end.
  e.g., fast/text/selection/emphasis.html

Layout functions generally prefer proper checks are done in the
callers, rather than input arguments automatically corrected in
lower-level functions.

This patch makes LayoutText::LocalSelectionRect match to it.

Bug: 636993, 827925
Change-Id: I3068e70886f7cd425a2fd5f701ac0b7d77a8a978
Reviewed-on: https://chromium-review.googlesource.com/989474Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547430}

This reverts commit 3017d428.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 547425 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzMwMTdkNDI4ZTI2NzNlYjdkM2E1MDhlYWI1MzIxMzliODc0ZTAzZmEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4999

Sample Failed Step: browser_tests

Original change's description:
> Reland "Enforce user gesture requirement on browser side for WebUI."
> 
> This is a reland of f6953215
> 
> Original change's description:
> > Enforce user gesture requirement on browser side for WebUI.
> >
> > Also, don't trust the renderer process to send the correct URL.
> >
> > Bug: 823864
> > Change-Id: I1f5c1c7908d8157240b5a7d5fc2df944267cf537
> > Reviewed-on: https://chromium-review.googlesource.com/979399
> > Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#547114}
> 
> Bug: 823864
> Tbr: sky@chromium.org
> Change-Id: I9751f0f63524aa52bc5af326cd00e99a84dc1009
> Reviewed-on: https://chromium-review.googlesource.com/987694
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547425}

Change-Id: I100d8b7bdcf95693a3ee8a7d70af76bfc0ea9654
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 823864
Reviewed-on: https://chromium-review.googlesource.com/989992
Cr-Commit-Position: refs/heads/master@{#547429}

This will avoid exposing in-progress zip file to the destination folder.
It will resolve the issues like:
- the zip file is synced to Drive with incomplete state, having multiple
  revisions
- when cancelling zip packing, the file appears in the trash of Drive

Bug: 714579,785096,785093,785086,797873
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0b32515d5e896d87e1dee499f1eea40dd7a481f0
Reviewed-on: https://chromium-review.googlesource.com/844442
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547428}

Intent to Ship thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/YEHinDOBaBw

Move TransformStream.js from v8_experimental_extra_library_files to
v8_extra_library_files in //.gn.

Also update the stable webexposed interface expectations.

Bug: 780689
Change-Id: Ia16a9c2d7a45a00a0cdf72b1e53f72d60dd07e71
Reviewed-on: https://chromium-review.googlesource.com/985933
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547427}

The old names were confusing because they looked to handle any
TextControlElement instances like other IsFoo/ToFoo but actually they
don't handle non-text-field input types.

This CL has no behavior changes.

Change-Id: Ibd504e8bfb164550c33cb37d463acdbcda0b17ad
Reviewed-on: https://chromium-review.googlesource.com/989524
Commit-Queue: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547426}

This is a reland of f6953215

Original change's description:
> Enforce user gesture requirement on browser side for WebUI.
>
> Also, don't trust the renderer process to send the correct URL.
>
> Bug: 823864
> Change-Id: I1f5c1c7908d8157240b5a7d5fc2df944267cf537
> Reviewed-on: https://chromium-review.googlesource.com/979399
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547114}

Bug: 823864
Tbr: sky@chromium.org
Change-Id: I9751f0f63524aa52bc5af326cd00e99a84dc1009
Reviewed-on: https://chromium-review.googlesource.com/987694
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547425}

Bug: 821831
Change-Id: I5b3e1978e37ce34e6fb885ca1077ea90ab2f494c
Reviewed-on: https://chromium-review.googlesource.com/987972Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547424}

This patch changes |Sample| class used in |assert_selection()| by reusing IFRAME
for making |selection_test()| and |assert_selection()| faster.

# Changes of tests
## assert_selection.html
Because of |assert_selection| doesn't remove IFRAME used by |Sample|, this
patch changes assertion to check IFRAME, which "id" is "sample", available.

## overtype.html
This patch changes each test starts with overwrite mode is off, because of
the overwrite mode state is state of |LocalFrame|, each test should reset it.

## spellcheck_test.js
This patch changes |spellcheck_test()| not to reuse IFRAME used by |Sample|.

Change-Id: I6513a2ffa01caeb0ad18360b543d0ebb4bad253a
Reviewed-on: https://chromium-review.googlesource.com/987632
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547423}

Blink scheduler code is transitioning to a new directory structure.
This patch moves files for ChildScheduler and its children, and
rewrites affected include paths.

This patch only renames files; the class names are not changed yet.
The file names reflect the new names of the classes, instead of the
current names, to avoid renaming include paths twice. The class names
will be updated in a follow-up patch.

The renaming scheme of those classes is a bit complex. Look at the
design doc linked from the bug for details.

TBR=kinuko@chromium.org,dalecurtis@chromium.org

Bug: 826203
Change-Id: I72c10ee15f3510c11e9d0520d7f6e7d4a5715b66
Reviewed-on: https://chromium-review.googlesource.com/986112
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547422}

This patch changes test cases using out of bounds positions to use valid
positions. It seems these tests passes offset in Text node rather than child
index in container node.


This patch is a preparation of the patch[1].

[1] http://crrev.com/c/987655 Validate offset parameter of Position constructor
with introducing Position::CreateWithoutValidation()

Change-Id: Ia14788eb4f9d9a7123795f9ef3cd6abeca8e094a
Reviewed-on: https://chromium-review.googlesource.com/989521Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547421}

Add use counters to the constructors for ReadableStream, WritableStream
and TransformStream.

A new function, binding.countUse(), is added to the V8 Extras binding
object and called from the constructors.

See the V8 Extras Design Doc for more details on how this works:
https://docs.google.com/document/d/1AT5-T0aHGp7Lt29vPWFr2-qG8r3l9CByyvKwEuA8Ec0/edit#heading=h.334ekprhracb

binding.countUse() is registered by a new C++ function,
AddUseCounterFunctionToV8ExtrasBindings() which is called when setting
up the Javascript contexts for windows and workers.

To help implement tests for the new function, some test functions have
been factored out of core/streams/ReadableStreamOperationsTest.cpp into
V8ExtrasTestUtils.{h,cpp}.

There are also new layout tests to verify that the use counters are
correctly set. Internal creation of a ReadableStream by creating a
Response object does not set the counter.

Currently constructing a TransformStream also set the ReadableStream
constructor use counter. This will be fixed once ReadableStream has been
updated to the latest standard version (http://crbug.com/710728).

Bug: 769663
Change-Id: I484ef6843cbb800b345d56cf67d09e45b97ab3a3
Reviewed-on: https://chromium-review.googlesource.com/985345Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547420}

This CL introduce "StyleCommands.cpp" with moving |StyleCommands| member
into it. Make EditorCommand simpler for improving code health.

Bug: 818552
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Icb9a4f48ec4855d178e7b2932cc7f1bc7eef6666
Reviewed-on: https://chromium-review.googlesource.com/987652Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547419}

We have no reason to restrict links to specific WebKit sub-directories.

Bug: 622551
Change-Id: If0ebcb1b1241cb99e80d4bfffac2a24300fd3a02
Reviewed-on: https://chromium-review.googlesource.com/989812Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547418}