- 08 Sep, 2020 40 commits
-
-
Hans Wennborg authored
Otherwise a bad match can be chosen by longest_match, since it assumes that match[2] and scan[2] are equal when the hashes and the other bytes match. That assumption doesn't hold when using CRC hashing and a low number of hash bits (which can be set by via the 'memLevel' parameter). For example, the two hex byte sequences 2a 14 14 14 and 2a 14 db 14 have the same lower 9 bits CRC, and only differ in the third byte. This could cause longest_match to consider them as matching. This was already handled for x86; do the same for ARM and add a test. Bug: 1113596 Change-Id: I251150594264f401e4d8bc6e91b44b39998ab029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392457Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#805076}
-
Yusuke Sato authored
BUG=chromium:1085456 TEST=./testing/xvfb.py ./out/Release/chrome Change-Id: Ibdfb20f03846266033e55956d10a2552f5529640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398892Reviewed-by:
Long Cheng <lgcheng@google.com> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#805075}
-
Stephanie Kim authored
Bug: 1072012 Change-Id: Ibc69569b5dd521be8a02cfaffac469c83fe6727a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393060 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#805074}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e659214bc6cf..b6030fb2c818 2020-09-08 jlavrova@google.com Direct paint by default; remove save/translate/restore 2020-09-08 jvanverth@google.com Use Microsoft's ComPtr to wrap D3D12 objects. 2020-09-08 bsalomon@google.com Don't set BASE/MAX mip map level on PowerVR. 2020-09-08 borenet@google.com [infra] Fix Git package for Housekeeper-PerCommit-InfraTests_Win 2020-09-08 jvanverth@google.com Close disabled warning pragmas If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1123874 Tbr: reed@google.com Change-Id: I19a6d7006c94cd7ca37aa653d6d5d2f1c25a2c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805073}
-
Yuly Novikov authored
This is the proper configuration in order to upload data to perf dashboard in LUCI world per bit.ly/perf-dashboard-machine-group Bug: 1126174 Change-Id: I7dee106c574a94db027c6079012dedab944998f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399441 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#805072}
-
Lei Zhang authored
As suggested in a private email, update the entire row for the Debian entry with more relevant and up-to-date info. Change-Id: Ifd400f8b1766de0758f4c97906e56fc318d48789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398973Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#805071}
-
Joel Hockey authored
Fixes crrev.com/c/2337411 which inadvertently changed file scheme downloads to only work when a RenderFrameHost exists. Bug: 1106995 Change-Id: I9f87c6c2b1b8719e1c78b2aa670b02ff8ac65381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397041Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#805070}
-
Arnaud Mandy authored
These files need to be accessible when running wpt outside chromium environment. see: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#mojojs This is the first step towards making these tests pass outside the Chromium CI Bug: 1123990 Change-Id: Id96a3a2ae01beb6d9fd37eb41acad1ab0ebacf76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396219 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#805069}
-
James Darpinian authored
Bug: 1084495 Change-Id: Iecf9fdc4a60f6e5639bd4a8b5ca465f183b80eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390961Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#805068}
-
Oleh Lamzin authored
It helps us to don't wait until OnDisconnect method will be invoked after destructing fake cros_healthd client. We can invoke OnDisconnect manually without blocking test. Change-Id: I9f0f675710f8c331fabd27ea806999599595311c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390662 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#805067}
-
Sonny Sasaka authored
The powerd battery info was designed to be a periodic signal. This was fine because the need was for low battery warning. Now that we want to display the Bluetooth battery values continuously, there is a problem where Chrome does not have the battery values after Chrome restarts (for example when signing out) until powerd's next battery poll. A workaround for this is to have an API in powerd for Chrome to request a signal for a Bluetooth device. This lets Chrome sync with powerd's battery values when Chrome starts up. This workaround will be removed when we migrate to go/bluez-battery-provider-api. Corresponding powerd change: CL:2378569. BUG=b:166530001 Change-Id: Ibceb1f44f808c6bfa9752cb62f23a8fba236b60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378788 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#805066}
-
rbpotter authored
Bug: 1120279 Change-Id: I20894d22ca27fff91235b50b03d73c0445d18ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390974 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#805065}
-
Arnaud Mandy authored
use of test-only-api.js in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Bug: 1123992 Change-Id: I513e6d432f6c74a62109ea09ce0dbaeefc63b0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391224 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#805064}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2d00262a1459..e5882825af72 2020-09-08 cwallez@chromium.org Texture::copyImage: Correctly compare against FBAttachment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1125354 Tbr: ianelliott@google.com Change-Id: I0cae6175b339ac151fb8066e681ad572f38ee26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399064Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805063}
-
Michael Crouse authored
This change adds a threshold for the number of rebuffer events per frame before LiteVideos stop throttling requests attached too the frame. Bug: 1111348 Change-Id: I236fd7f647f81e45114315eb3e0dcc4c0e32083e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393012 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#805062}
-
Gang Wu authored
Test flaky, disable for now and fix it later. TBR=tedchoc@chromium.org Bug: 1126145 Change-Id: Ie6b947dc7d9b1735d25c5f1e7db2fa4cb95c3e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398975Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805061}
-
Ben Pastene authored
This adds the standard set of Tast tests to new betty-arc-r bot. But unlike other CrOS VM tests, we can't run these in GCE since the Android VM (inside the CrOS VM (inside the GCE VM)) doesn't work well on GCE. However, they could theoretically run on KVM-enabled baremetal machines in the lab, which removes the extra GCE VM layer that interferes with the tests. So we'll try running them on CrOS device hosts. A bot's device will be unused during the tests, which is unfortunate. But there's plenty of head room in the pools, and they're already running CrOS tests, so adding these fits well to their purpose in life. Bug: 1120109 Change-Id: I09e6c40935df7d95126e9848bc7f26ac70be2b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392943 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#805060}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599544645-2607fe83108ec346cd143f52f7129c53aeca332a.profdata to chrome-mac-master-1599587571-75a79fa48b42004db7f7ebb181ae53e5f370e716.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I2608647fa6fdaeaee4ed0d1e45f5886cd7b38de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399362Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805059}
-
Owen Min authored
Disable RenderWidgetHostViewChildFrameBrowserTest. VisualPropertiesPropagation_DisplayMode on Mac and Linux due to flaky. Bug: 1126153 Tbr: kenrb@chromium.org Change-Id: If31a8b4ede074539f250b2869307e36add8b4c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399302Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805058}
-
Rahul Arakeri authored
This CL fixes an issue where autoscroll may be called on a scrollbar layer that is deleted. When the pointer is pressed down, an autoscroll task is scheduled to be executed after ~250ms. The task will execute if the pointer remains held down. In LayerTreeImpl::UnregisterScrollbar, DidUnregisterScrollbarLayer only gets called after both scrollbars are removed. So if you go from 2 to 1 scrollbar while an autoscroll task is queued, the autoscroll task won't get cancelled. At this point, the ScrollbarController tries to access the deleted scrollbar and that leads to an access violation. The fix here is to ensure that the call to DidUnregisterScrollbarLayer happens for each scrollbar. Bug: 1106612 Change-Id: I4f1d684830012db8fdd73258c9a9e5231807bcb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356809Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#805057}
-
Wojciech Dzierżanowski authored
Adding a player to MediaSessionImpl automatically requests the audio focus. We need to fix this up in case a paused player is added due to entering Picture-in-Picture. Bug: 1117390, 1117397 Change-Id: I1c8b69dbefe19f6d8a99a3b8d2a01fa2123a47f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387643Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#805056}
-
Liquan (Max) Gu authored
Revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/2391598 Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2372888 Context: The revert was done because the waterfall had test failures. It was later found to be caused by another CL. So the original CL was wrongly reverted. This CL is to reland it without change. Bug: 978471, 1102522 Change-Id: I24bfe5815c34cd7fb2ffbcbe33f839334ac08d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392763Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805055}
-
manukh authored
The History URL provider cleans up trailing whitespace from the input when matching suggestions. However, using this clean input for rich autocompletion results in inputs like 'g ' matching suggestions like 'google.com' which would be displayed as 'g |[oogle.com]'. This CL uses the original input for rich autocompletion in the history URL provider. Bug: 1062446 Change-Id: If31c85a821f6dae924a1ccc8b36a83fcdff97791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392953Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#805054}
-
Joey Arhar authored
I decided to not move forward with this experiment here: https://github.com/whatwg/html/issues/5257#issuecomment-607548564 Bug: 1126053 Change-Id: Ic6dd7446f14d38dc5f9f5b9538a9278c88528ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399119Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#805053}
-
Xianzhu Wang authored
For the following case: bar/test.html [ Failure ] virtual/foo/bar/* [ Pass ] virtual/foo/bar/test.html [ Failure ] previously the last virtual expectation was mistakenly reported as redundant. Now ignore such entries if there is a virtual glob expectation overriding the base expectation. Bug: 1124787 Change-Id: I9ab0c751343cf066e5c8f2db803a610e0cbb27e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393945 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#805052}
-
manukh authored
When selected, document suggestions get added to the shortcut provider. Document suggestion descriptions include last accessed date & owner. Both these can change; caching them in the shortcut provider can result in showing stale data. A previous CL (crrev.com/c/2107811) excludes dates from being stored in the shortcut description. This CL likewise excludes owners. Bug: 1035105 Change-Id: If1c38d70457835ad41b7df3d3622f91a26fea4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392948Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#805051}
-
Yuheng Huang authored
Fuse.js is a third party fuzzy search library used to search tab in tab search Doc: https://docs.google.com/document/d/1_fXj3gDdKOI7Mk97Usjys7JEYf44bfMTGPhtaEGsMEE/edit Bug: 1099917 Change-Id: Ibd2e2c341998e5efb1ce8c0fb4f6e7aa777f6997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375728Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#805050}
-
Owen Min authored
Disable the test virtual/threaded-composited-iframes/external/wpt/ is-input-pending/tentative/same-origin-subframe.sub.html on Mac due to flaky. Bug: 1124978 TBR: npm@chromium.org Change-Id: I8c690da0f9ab0d456534d353716e708cfe12f54a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399300Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805049}
-
Hesen Zhang authored
Bug: 1115755 Change-Id: Ia67066a172ebd16f4fa9a305eed04986e98210f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391218Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805048}
-
Arnaud Mandy authored
These files need to be accessible when running wpt outside chromium environment. see: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#mojojs This is the first step towards making these tests pass outside the Chromium CI Bug: 1123989 Change-Id: I9600bc52f6c9ec2217ff09c72c6bdcc6a5af4b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391255 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#805047}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 15f9f86c. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I5301391d0e0e188a7055a5ce67f8f3d481382376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398560Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805046}
-
Cammie Smith Barnes authored
This change forwards the correct --gtest_repeat arg on to gtest instead of the incorrect --repeat arg when the --repeat flag is used with run-swarmed.py. Bug: 1124365 Change-Id: Ie2e8b1a74748f4230570721dfaef845cd1d4f022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391161Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#805045}
-
Connie Wan authored
This still ensures that the tabstrip is never in Stacked mode with any Tab Groups active. However, it allows Stacked mode if there are no groups created yet. Before, it would disallow Stacked mode if the feature was enabled, even if no groups were created yet. To keep the separation between Tab Groups and Stacked mode, this change also takes the tabstrip out of Stacked mode if a group is created while in Stacked mode. Change-Id: Ic359eaf95cf7fd2ebc2b3440a118b715640cfa45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399010Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#805044}
-
Sophey Dong authored
Also remove calls to assert sizes are the same since that is covered by asserting the models are in the right order. This will show better debug logs as well when tests fail. Bug: 1124926 Change-Id: I739c9797e0785e077d16d6a29bc9cf17ce680ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390664Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#805043}
-
Ali Juma authored
This add additional EG test coverage for real-time Safe Browsing, for scenarios identified by the test team when they were manually testing this feature. Bug: 1122997 Change-Id: I984babf81e251381965454679fa293426fc4c958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392977 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#805042}
-
Dominic Farolino authored
R=rockot@google.com Bug: N/A Change-Id: I33724debfb3416e6d5b54e5564fe8846f2103841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393976Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#805041}
-
Weblayer Skew Tests Version Updates authored
Skew tests are being added for the following versions: 1, 85.0.4183.81 2, 86.0.4240.16 3, 84.0.4147.89 TBR=estaab@chromium.org Bug: 1041619 Change-Id: Ie5ceaa9820fa20f65002a67d903a96c88e953f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398956Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#805040}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/f88383daa8de..616bd4f9aeca $ git log f88383daa..616bd4f9a --date=short --no-merges --format='%ad %ae %s' 2020-09-03 wtc Remove 16bpc cases in avifLimitedToFullY(), etc. 2020-09-03 wtc Remove the avifCodecSpecificOptionsGet() function 2020-09-01 wtc Add the libaom-specific option tune=METRIC 2020-09-01 wtc Make avifCodecSpecificOptionsGet a const function Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org Change-Id: Ia50e27556d10ac03221d1c950bcaa510614e65f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398964Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#805039}
-
Avery Musbach authored
The test was intended for a time when we would fully support tablet mode with multiple displays and no display mirroring. It seems that just will not happen in the foreseeable future. Fixed: 1125848 Change-Id: I13ee5c2a0dd3f717489e615caa083fb74b6b859c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398974Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#805038}
-
Dominic Farolino authored
Before this CL, the child process start-up flow went like this: 1.) Browser would create a Mojo invitation, with a mojom::ChildProcess receiver, that ChildThreadImpl would recover and bind. 2.) ChildThreadImpl immediately creates a remote for its ChildProcessHost so it can start queueing messages for the browser process, even though it is not bound to the browser. 3.) ChildThreadImpl asynchronously waits for ChildProcess::Initialize to be invoked by the browser process; this supplies a remote for mojom::ChildProcessHostBootstrap, which the child process uses to send the receiver for the remote created in (1). 4.) Browser receives this, binding it to either RenderProcessHostImpl::io_thread_host_impl_ or ChildProcessHostImpl In short, there's an awkward dance that has to be done between the browser <-> renderer ((3) above), so that they can both immediately initialize remotes for each other. This CL removes the extra IPC round trip by removing ChildProcessHostBootstrap, and steps (3) & (4) above. This is done by attaching a second message pipe to the mojo invitation corresponding to the ChildProcessHost receiver, so the child process has it immediately on init. At this point, the child process can create a remote for the ChildProcessHost, and immediately bind it to the pipe which is bound to the browser process's ChildProcessHost receiver. Bug: N/A R=haraken@chromium.org,rockot@google.com Change-Id: I8f7b4b698b82e25d1c5c991c9639e57de05a6360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393158Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#805037}
-