GitLab

UMA data shows that there can be a large number of active
HttpStreamRequests at a given time. The number reported by
ResourceDispatcherHostImpl doesn't account for the large number of
HttpStreamRequests. This CL adds a histogram to track the number of
active URLRequests, so we can know whether the cause for the large
number of HttpStreamRequests is internal or external to the network
stack.

BUG=711721

Review-Url: https://codereview.chromium.org/2837313002
Cr-Commit-Position: refs/heads/master@{#467332}

This CL moves the following classes off the BlinkGC heap
MediaQueryExp
MediaQuery
MediaQuerySet
MediaQueryResult
in an effort to avoid the crasher crbug.com/699269.

BUG=699269

Review-Url: https://codereview.chromium.org/2837023005
Cr-Commit-Position: refs/heads/master@{#467331}

BUG=715252

Review-Url: https://codereview.chromium.org/2839063002
Cr-Commit-Position: refs/heads/master@{#467330}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fa3a1c75..83d9ade4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2842693004
Cr-Commit-Position: refs/heads/master@{#467329}

From Chrome 60 onwards, root.baseURL will no longer be empty and will always return 'about:blank'.
See crbug/711562 for more details.

BUG=chromedriver:1775

Review-Url: https://codereview.chromium.org/2830903005
Cr-Commit-Position: refs/heads/master@{#467328}

Add a new MemoryDumpType: SUMMARY_ONLY which allows RequestGlobalDump
callers to specify the dump should not be added to the trace.

BUG=703184

Review-Url: https://codereview.chromium.org/2838913002
Cr-Commit-Position: refs/heads/master@{#467327}

The log dump directory is supposed to be under Downloads, but for a
logged-in user the download path is a non-native path:

    /special/drive-<uid>/...

The logging code uses regular file system calls from base that fail
when encountering "/special".

There is a similar code path in
NetInternalsMessageHandler::OnStoreDebugLogs (net_internals_ui.cc)
which checks for a non-native download path and changes the path to
GetDefaultDownloadDirectoryForProfile; copying that logic to
GetLogDumpDirectory fixes the problem.

API reference: https://developer.chrome.com/extensions/logPrivate

BUG=None
TEST=Build with chromeos=1. Whitelist an extension to allow using the logPrivate API and have the extension call chrome.logPrivate.dumpLogs. Run the extension while logged in (not ephemeral user) and confirm that logs are dumped to Downloads/log_dumps.

Review-Url: https://codereview.chromium.org/2838923004
Cr-Commit-Position: refs/heads/master@{#467326}

Revert of SharedArrayBuffer throws serializing to indexeddb (patchset #4 id:60001 of https://codereview.chromium.org/2838783002/ )

Reason for revert:
Suspect for http://crbug.com/715567 (crash when typing in hangouts chat window).

Original issue's description:
> SharedArrayBuffer throws serializing to indexeddb
>
> The StructuredDeserialize spec now has a special case for serializing
> for storage: it doesn't allow SharedArrayBuffers to be serialized, and
> instead throws a DataCloneError.
>
> BUG=chromium:714820
>
> Review-Url: https://codereview.chromium.org/2838783002
> Cr-Commit-Position: refs/heads/master@{#467093}
> Committed: https://chromium.googlesource.com/chromium/src/+/08d35f601c7cfbdc66f9a7f8836e32028d344559

TBR=jbroman@chromium.org,haraken@chromium.org,jsbell@chromium.org,binji@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:714820

Review-Url: https://codereview.chromium.org/2845623002
Cr-Commit-Position: refs/heads/master@{#467325}

https://pdfium.googlesource.com/pdfium.git/+log/012ae898a069..2bbb55162f0c

$ git log 012ae898a..2bbb55162 --date=short --no-merges --format='%ad %ae %s'
2017-04-25 thestig Remove CPDF_Document parameter from CPDF_DeviceCS ctor.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ie3fd99a2c2412296acc7e143b7928a6ae708f726
Reviewed-on: https://chromium-review.googlesource.com/487823
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467324}

This patch is intended to make existing cc unit tests test both
ways of mask tiling flag.

Notice that the cc pixel test is already testing multi texture
masks.

BUG=708582
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2835213002
Cr-Commit-Position: refs/heads/master@{#467323}

Reland of Update V8 to version 6.0.66. (patchset #2 id:40001 of https://codereview.chromium.org/2842903003/ )

Reason for revert:
It was not the culprit for

BUG=chromium:715391

Original issue's description:
> Revert of Update V8 to version 6.0.66. (patchset #1 id:1 of https://codereview.chromium.org/2837923002/ )
>
> Reason for revert:
> Roll caused failed check in IsSane(), see bug for details
> BUG=715391
>
> Original issue's description:
> > Update V8 to version 6.0.66.
> >
> > Summary of changes available at:
> > https://chromium.googlesource.com/v8/v8/+log/9f6be2e9..ab1af916
> >
> > Please follow these instructions for assigning/CC'ing issues:
> > https://github.com/v8/v8/wiki/Triaging%20issues
> >
> > Please close rolling in case of a roll revert:
> > https://v8-roll.appspot.com/
> > This only works with a Google account.
> >
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> >
> > TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org
> >
> > Review-Url: https://codereview.chromium.org/2837923002
> > Cr-Commit-Position: refs/heads/master@{#466756}
> > Committed: https://chromium.googlesource.com/chromium/src/+/ddb812975b721aee41c39a12ac739eab0e8b053f
>
> TBR=hablich@chromium.org,kozyatinskiy@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
>
> Review-Url: https://codereview.chromium.org/2842903003
> Cr-Commit-Position: refs/heads/master@{#467250}
> Committed: https://chromium.googlesource.com/chromium/src/+/650a5e0b7db28b5d4a69bb8a3be600cf636e662e

TBR=kozyatinskiy@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org,sashab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=715391

Review-Url: https://codereview.chromium.org/2842913003
Cr-Commit-Position: refs/heads/master@{#467322}

BUG=715119

Review-Url: https://codereview.chromium.org/2840013002
Cr-Commit-Position: refs/heads/master@{#467321}

Rename *_task_runner_ member variables to *_task_queue_ to match
variable type.

BUG=710063

Review-Url: https://codereview.chromium.org/2840873002
Cr-Commit-Position: refs/heads/master@{#467320}

__ANDROID_API__ is the minimum API supported by the NDK we are compiling
against, not the API level of the device we are running on. Because we
support 16+ we were always returning false.

BUG=714623

Review-Url: https://codereview.chromium.org/2841943003
Cr-Commit-Position: refs/heads/master@{#467319}

This partially reverts:
https://codereview.chromium.org/2828143007
to fix broken GPU Linux builder.

BUG=714976,714336
TBR=dpranke@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2842963003
Cr-Commit-Position: refs/heads/master@{#467318}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2839793002
Cr-Commit-Position: refs/heads/master@{#467317}

Right now we have specific ifdefs for android as opposed to just relying on ENABLE_NATIVE_NOTIFICATIONS + features::kNativeNotifications like all other platforms.

BUG=

Review-Url: https://codereview.chromium.org/2836093002
Cr-Commit-Position: refs/heads/master@{#467316}

This patch adds support for the --log-net-log command line flag to
headless to help diagnosing issues with networking.

BUG=706355

Review-Url: https://codereview.chromium.org/2841953002
Review-Url: https://codereview.chromium.org/2841953002
Cr-Commit-Position: refs/heads/master@{#467315}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=asanka@chromium.org

Review-Url: https://codereview.chromium.org/2839643003
Cr-Commit-Position: refs/heads/master@{#467314}

https://crbug.com/252482 demonstrates that
a) V8HTMLDocument's locationAttributeGetter is NOT using a private
  property to keep the location's wrapper alive.
b) Location.idl does NOT specify [DependentLifetime].
c) V8 minor GC can collect a wrapper object of document.location
  if author script has no reference to it.
d) V8Window::locationAttributeGetterCustom is using a private
  property to keep it alive, but it may be too late.  At c), V8
  may have already collected the location's wrapper object, and
  expandos may have been gone.

The direct cause is that
1) There are two paths to create a Location's wrapper object;
  window.location and document.location.
2) document.location doesn't use a private property (keep_alive)
  though window.location uses it.

This CL makes the following changes.
i) Uses the wrapper tracing in order to make Location's wrapper
  objects alive.
ii) Makes Location [DependentLifetime] so that the wrapper tracing
  works.

BUG=252482

Review-Url: https://codereview.chromium.org/2826393004
Cr-Commit-Position: refs/heads/master@{#467313}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=asanka@chromium.org

Review-Url: https://codereview.chromium.org/2841713002
Cr-Commit-Position: refs/heads/master@{#467312}

CC=skyostil@chromium.org
BUG=710063

Review-Url: https://codereview.chromium.org/2836203003
Cr-Commit-Position: refs/heads/master@{#467311}

Revert of Don't lower priority for scripts inserted by doc.write (patchset #5 id:70001 of https://codereview.chromium.org/2826213003/ )

Reason for revert:
The layout test was broken and racy (http://crbug.com/715528).  SHould be trivial to fix (use the same query param for the preloaded and real image) but best to revert, fix and re-land separately.

Original issue's description:
> Don't lower priority for scripts inserted by doc.write
>
> HTML Chunks inserted by document.write() are run through a separate
> instance of the preload scanner from the main document.  If the main
> document scanner has already discovered an image then all scripts
> discovered by any preload scanner regardless of where they came from
> would be considered late-body.
>
> This behavior causes a regression where a document.write() in the head
> that includes multiple script tags will discover them but treat them as
> late-body scripts and only load them one at a time.
>
> BUG=713727,712338
>
> Review-Url: https://codereview.chromium.org/2826213003
> Cr-Commit-Position: refs/heads/master@{#467029}
> Committed: https://chromium.googlesource.com/chromium/src/+/1e0d3cbbf60c67ba9856eadcb9e829b3c4bec6c7

TBR=yoav@yoav.ws,kinuko@chromium.org,csharrison@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=713727,712338

Review-Url: https://codereview.chromium.org/2843013002
Cr-Commit-Position: refs/heads/master@{#467310}

BUG=none

Review-Url: https://codereview.chromium.org/2836423003
Cr-Commit-Position: refs/heads/master@{#467309}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/9cdb538..ce4e632

$ git log 9cdb538..ce4e632 --date=short --no-merges --format=%ad %ae %s
2017-04-26 mbonadei@webrtc.org Reland of Creating webrtc/modules:module_api (patchset #1 id:1 of https://codereview.webrtc.org/2839963005/ )
2017-04-26 ilnik@webrtc.org Fix default extension id for video content type extension
2017-04-26 magjed@webrtc.org ObjC: Split out I420 texture uploading into separate class
2017-04-26 mbonadei@webrtc.org Revert of Creating webrtc/modules:module_api (patchset #5 id:80001 of https://codereview.webrtc.org/2838873002/ )
2017-04-26 mbonadei@webrtc.org Creating webrtc/modules:module_api
2017-04-26 nisse@webrtc.org Move autowrap from ThreadManager constructor to Thread::Current.
2017-04-26 mbonadei@webrtc.org Revert of Enable GN check for webrtc/base (patchset #9 id:350001 of https://codereview.webrtc.org/2840453004/ )
2017-04-26 mbonadei@webrtc.org Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ )
2017-04-26 brandtr@webrtc.org Use field_trial::IsEnabled for FlexFEC.
2017-04-25 mbonadei@webrtc.org Creating webrtc:video_stream_api
2017-04-25 philipp.hancke@googlemail.com Fix comment about remote restart being requested in createOffer
2017-04-25 kwiberg@webrtc.org Add SafeMin() and SafeMax(), which accept args of different types
2017-04-25 ilnik@webrtc.org Remove deprecated headers
2017-04-25 magjed@webrtc.org Android: Move EglBase10/EglBase14 from to API to src

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2842993002
Cr-Commit-Position: refs/heads/master@{#467308}

BUG=695279

Review-Url: https://codereview.chromium.org/2838153002
Cr-Commit-Position: refs/heads/master@{#467307}

Fixes https://github.com/w3c/web-platform-tests/issues/4822

BUG=673664
R=lunalu@chromium.org,kojii@chromium.org,ksakamoto@chromium.org

Review-Url: https://codereview.chromium.org/2841903002
Cr-Commit-Position: refs/heads/master@{#467306}

This change implements dropping the SiteBoundCredential interface in
favor of the CredentialUserData mixin. This change was introduced in the
Credential Manager API specification with commit
a43865bd8aa9842dbc8d8e688d5668c087677eac
(https://github.com/w3c/webappsec-credential-management/commit/a43865bd8aa9842dbc8d8e688d5668c087677eac).

Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X-5zjSOzLC4

R=vasilii@chromium.org,mkwst@chromium.org,jochen@chromium.org
BUG=714615

Review-Url: https://codereview.chromium.org/2832813002
Cr-Commit-Position: refs/heads/master@{#467305}

Remove the stored payment instrument in associated service worker registration.

Related Spec Link:
  https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
TEST=payment_manager_unittest.cc, payment-instruments.html

Review-Url: https://codereview.chromium.org/2844463002
Cr-Commit-Position: refs/heads/master@{#467304}

Remove FrameViewBase.cpp file.
This CL is in preparation to move core/paint/ScrollbarManager
to platform/scroll and use it as replacement for FrameViewBase.

BUG=637460

Review-Url: https://codereview.chromium.org/2843693003
Cr-Commit-Position: refs/heads/master@{#467303}

BUG=647411

Review-Url: https://codereview.chromium.org/2843723004
Cr-Commit-Position: refs/heads/master@{#467302}

Revert of 🏠 Polish bottom sheet content transitions (patchset #1 id:1 of https://codereview.chromium.org/2839673002/ )

Reason for revert:
Appears to be causing multiple chrome_public_test_apk failures on Marshmallow 64 bit Tester.
crbug.com/715336

Original issue's description:
> [Home] Polish bottom sheet content transitions
>
> This change adds animation when transitioning between bottom sheet
> content. The existing view is faded out completely before the new
> view is faded in. The animation is applied to both the sheet content
> and the toolbar view.
>
> Notably, the onContentChanged() event is now called when the
> transition animation has finished instead of immediately when
> showContent(...) is called.
>
> BUG=702717
>
> Review-Url: https://codereview.chromium.org/2839673002
> Cr-Commit-Position: refs/heads/master@{#466780}
> Committed: https://chromium.googlesource.com/chromium/src/+/419509cbf0ac3a8a8595b3ce9e56daf75e5c2f0c

TBR=twellington@chromium.org,mdjones@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=702717

Review-Url: https://codereview.chromium.org/2838313003
Cr-Commit-Position: refs/heads/master@{#467301}

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time,
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.
Therefore, this CL moved it from Worklet to ThreadedWorklet.

Motivation of this change: MainThreadWorklet will have a separate initialization
logic after the above CL and the similar initialization function will be an
obstacle.

BUG=627945

Review-Url: https://codereview.chromium.org/2845533002
Cr-Commit-Position: refs/heads/master@{#467300}

Because the things in ClassicPendingScript::DisposeInternal() except for
ScriptStreamer::Cancel() doesn't have to be called as a prefinalizer,
this CL introduces ClassicPendingScript::Prefinalize() that only calls
ScriptStreamer::Cancel() and thus makes Dispose() not to be called there.

This CL simplified the prefinalization of ClassicPendingScript, especially
order dependencies between ClassicPendingScript's prefinalizer and the
prefinalizer of its parent class (ResourceOwner).
Leaving ClassicPendingScript in a not-Dispose()d state is not observable
if the related classes obeys the rule of Oilpan, and
https://codereview.chromium.org/2837413002/ checks that in case there were
a bug.

BUG=715309

Review-Url: https://codereview.chromium.org/2844583002
Cr-Commit-Position: refs/heads/master@{#467299}

Bug: 709815
Change-Id: I8f35864239dc5a606b473cdd82add2e68a76cb08
Reviewed-on: https://chromium-review.googlesource.com/487861Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467298}

Revert of headless: Add support for net logging (patchset #2 id:20001 of https://codereview.chromium.org/2841953002/ )

Reason for revert:

Findit(https://goo.gl/kROfz5) identified CL at revision 467289 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I5YTQyYWI2ZjA3M2IwNTdjOGMwNWQyYmZjNzk5ZGNjODA4MmUyYTYM

Sheriff's note:
See crbug.com/715513 for details.

Original issue's description:
> headless: Add support for net logging
>
> This patch adds support for the --log-net-log command line flag to
> headless to help diagnosing issues with networking.
>
> BUG=706355
>
> Review-Url: https://codereview.chromium.org/2841953002
> Cr-Commit-Position: refs/heads/master@{#467289}
> Committed: https://chromium.googlesource.com/chromium/src/+/b9a42ab6f073b057c8c05d2bfc799dcc8082e2a6

TBR=eseckler@chromium.org,skyostil@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=706355,715513

Review-Url: https://codereview.chromium.org/2839153002
Cr-Commit-Position: refs/heads/master@{#467297}

+ Correctly focus the inner WebContents when the attachment frame is
  focused.
+ Enable Enable WebViewFocusInteractiveTest.Focus_FocusBeforeNavigation.
+ Prevent BrowserPluginGuest from unfocusing the guest in oopif mode.

BUG=672947
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2715213009
Cr-Commit-Position: refs/heads/master@{#467296}

This is web-exposed via Document and other interfaces.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Bug: 713843
Change-Id: Idff897e4f3177a0ff67ecfda413b8fae9d51f556
Reviewed-on: https://chromium-review.googlesource.com/487882
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467295}

This new parameter intends to replace or complement the version override
param to distinguish various published versions of Popular Sites.

BUG=715039

Review-Url: https://codereview.chromium.org/2841643005
Cr-Commit-Position: refs/heads/master@{#467294}

Bug: 709815
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6e5a2665f2b82b993a4544a8cbd052fadc35d987

Change-Id: I6e5a2665f2b82b993a4544a8cbd052fadc35d987
Reviewed-on: https://chromium-review.googlesource.com/487901
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467293}