GitLab

Convert LoadTimingTabHelper to directly track the
registration with the observed WebState instead of
relying on the deprecated code in WebStateObserver.

Bug: 775684
Change-Id: I606bc4b62a5d10f695cee9f44b723feb9111ab9c
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/768717
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517074}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bce18538..2db9c912

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I29f996571653ba1d2e82a345a59438b8a7d228ba
Reviewed-on: https://chromium-review.googlesource.com/774180Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517073}

TBR=palmer@chromium.org

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie480b411314e25628e6a8e1aea7da83cdd5f6e84
Reviewed-on: https://chromium-review.googlesource.com/773663
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517072}

- Previously when migrating to channels, the content settings were
simply copied over to the NotificationChannelsProviderAndroid from
the PrefProvider.

- Now they are deleted from the PrefProvider after they are copied over
to the NCPA.

- This avoids old content settings hanging around and getting
reinstated on channel deletion.

Bug: 781524,784823
Change-Id: I01ec7974831f6a2be192c7e6e2a587148e736b9e
Reviewed-on: https://chromium-review.googlesource.com/768722Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517071}

This CL splits window_tree_host.mojom, separating WindowTreeHostFactory
interface declaration into its own mojom file.

In practice, there is no behavior change at all, but the separation makes
it easier for downstreamers to having a Mojo interface sibling of
WindowTreeHostFactory (for instance, in case of external window mode,
there is a ExternalWindowTreeHostFactory, which has a different API).

BUG=666958

Change-Id: I664f9ac3895612b53c6a4b1cfc85785554fe9bab
Reviewed-on: https://chromium-review.googlesource.com/767527Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#517070}

This reverts commit bd3be85e.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [Perf] Switch loading.* to histogram pipeline
> 
> This CL enables the histogram pipeline for loading.desktop and loading.mobile.
> 
> Bug: 744736
> Change-Id: Id12cf136d78e4cae6b552e5713d6aba9c27b6d2a
> Reviewed-on: https://chromium-review.googlesource.com/769329
> Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#516878}

TBR=eakuefner@chromium.org,nednguyen@google.com,eyaich@chromium.org,ashleymarie@chromium.org

Change-Id: Iba3674f272545c1a6771feeb423fb097d5bbcd9d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 744736
Reviewed-on: https://chromium-review.googlesource.com/774698Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517069}

Prior to this patch, TopSites only stripped the "www." prefix when
mapping a URL to a visit segment, which reflects how tiles will be
formed (deduplicated, or lack thereof) on the NTP.

We update this logic to handle common prefixes on mobile, as well as
ignoring the distinction between http and https.

The proposed implementation involves a history DB upgrade, which
processes the persisted segment names with the new version of the
function.

Bug: 784337
Change-Id: Ibe6b609bf22df28866b069efd47acc483389509d
Reviewed-on: https://chromium-review.googlesource.com/766747Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517068}

With this CL the gin platform implements the new v8::Platform API
functions {GetForegroundTaskRunner} and {GetBackgroundTaskRunner}.

The existing task posting function of the V8Platform now also use these
taskrunners to post tasks. Thereby we can move some of the
implementation from the V8Platform and the PerIsolateData to the new
taskrunners.

R=rmcilroy@chromium.org

Change-Id: I27ea6dd5f6ef8409e394f23ad914f468c09ded4a
Reviewed-on: https://chromium-review.googlesource.com/758578
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517067}

TBR=allada

Bug: 785179
Change-Id: I7a1c756322a6e89e3bba07009fe38c7c5911710b
Reviewed-on: https://chromium-review.googlesource.com/774285Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517066}

This patch imports all remaining tests that the original CL below had.
https://chromium-review.googlesource.com/c/chromium/src/+/558226

Bug: 736308
Change-Id: I9cfad08f695d63a440f395bdf51c9b072fc812ba
Reviewed-on: https://chromium-review.googlesource.com/763148
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517065}

This reverts commit 67329635.

Reason for revert: Suspect of breaking a number of mac bots.

For example:
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/20401



Original change's description:
> Roll src/third_party/skia/ d8d984ecc..4355b26b3 (14 commits)
> 
> https://skia.googlesource.com/skia.git/+log/d8d984ecc99d..4355b26b359d
> 
> $ git log d8d984ecc..4355b26b3 --date=short --no-merges --format='%ad %ae %s'
> 2017-11-15 csmartdalton Fold analytic clip FPs into GrReducedClip
> 2017-11-15 csmartdalton Fix precision caps and rrect/ellipse effect precisions
> 2017-11-16 angle-deps-roller Roll skia/third_party/externals/angle2/ 4d1469315..39644feeb (2 commits)
> 2017-11-16 angle-deps-roller Roll skia/third_party/externals/angle2/ 0acb268c9..4d1469315 (1 commit)
> 2017-11-15 bsalomon Use GrContextFactories that produce a single GrContext in unit tests.
> 2017-11-15 reed rename overloaded methods as speculative fix/diagnostic
> 2017-11-15 benjaminwagner Remove Win7/Win8 Perf-Release jobs.
> 2017-11-15 egdaniel Revert "Add private grpixelconfigs for alpha_8 and alpha_half"
> 2017-11-15 egdaniel Revert "Nit clean up to add private GrPixelConfig CL"
> 2017-11-15 benjaminwagner Remove/move remaining Win2k8 GCE jobs.
> 2017-11-15 egdaniel Nit clean up to add private GrPixelConfig CL
> 2017-11-15 vmpstr Ensure that removing last extension from GrGLExtension doesn't assert.
> 2017-11-15 bsalomon Remove support for image load/store
> 2017-11-15 egdaniel Add private grpixelconfigs for alpha_8 and alpha_half
> 
> Created with:
>   roll-dep src/third_party/skia
> 
> 
> The AutoRoll server is located here: https://autoroll.skia.org
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> TBR=brianosman@chromium.org
> 
> Change-Id: Iebb2f097a4e08a0c213c0f8b14ee2b52e6ab494f
> Reviewed-on: https://chromium-review.googlesource.com/773449
> Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517013}

TBR=skia-deps-roller@chromium.org,brianosman@google.com

Change-Id: Ie7621352d252e2df58fef599b3a33a55100f9da6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/774598
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517064}

* Add uma logging callback to CreateDeviceEnumeratorInternal,
CreateDeviceInternal and CreateClientInternal
* Add 5 new histograms to track HRESULT of the steps in which
GetPreferredOutputStreamParameters can potentially fail: creating
device enumerator, creating device, creating client, getting
shared-mode mix format and getting device period
* Keep public only one version of each of the 3 CreateDevice,
3 CreateClient and 2 GetPreferredAudioParameters functions and
move the behavior of removed public functions to internal functions
* Refactor CreateDevice and CreateClient
* Remove IsDefaultDevice that duplicates
AudioDeviceDescription::IsDeviceDefault behavior
* Remove unused functions DeviceIsDefault

Bug: 774998
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8688f38a6b7bc8b093a95ba3ccf83f5b7eafaced
Reviewed-on: https://chromium-review.googlesource.com/750807
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517063}

Convert VoiceSearchNavigationTabHelper to directly track
the registration with the observed WebState instead of
relying on the deprecated code in WebStateObserver.

Bug: 775684
Change-Id: I0ab524c26da8afb97753788fa36db0f5df603430
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/768743
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517062}

The contentload event from <webview> is dispached at the same time with 'load'
event in webview.
To ensure that posted message is handled in webview, we should post message to
webview asynchronously on 'contentload' event.

Bug: 783734
Test: Manually tested.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic875eff26d8ace5783941504c8f864a0573b8a8c
Reviewed-on: https://chromium-review.googlesource.com/771453Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517061}

The Experiment results are stated in https://goo.gl/EfU2ti.

BUG=715852

Change-Id: Ic4fc697bc5dcf627a89263e3faf61c78d5b1fb85
Reviewed-on: https://chromium-review.googlesource.com/762343
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517060}

TBR=nparker@chromium.org

Bug: 785494
Change-Id: I4962501edae4815c60c4d00107053ee6f577639a
Reviewed-on: https://chromium-review.googlesource.com/773281
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517059}

Reconciliation now ignores unverified accounts.

Bug: 780041
Change-Id: Iebec322ca38b512d1f4ef56f9a09ad779fb08680
Reviewed-on: https://chromium-review.googlesource.com/749943
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517058}

This patch adds a comment to |LineLayoutInlineItem::SetAncestorLineBoxDirty()|.

Change-Id: I504e7a12494e92752c7ab60916b6549e523c870d
Reviewed-on: https://chromium-review.googlesource.com/773455Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517057}

Implement simple FetchRequestMode check in CORSURLLoader, and add
kDisallowedByMode CORSError to pass the error type to Blink.

CORSError::GetErrorString() supports the kDisallowedByMode error
and DocumentThreadableLoader uses it to generate console errors.

TBR: mkwst@chromium.org
Bug: 736308
Change-Id: I0b3a5f77732e00598b729648aeb18d9c969d696b
Reviewed-on: https://chromium-review.googlesource.com/743883
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517056}

Convert TextToSpeechListener to directly track the
registration with the observed WebState instead of
relying on the deprecated code in WebStateObserver.

Remove TextToSpeechWebStateObserver and convert the
TextToSpeechListener to implement CRWWebStateObserver.

Bug: 775684
Change-Id: I40592a8cd9e5819168e1a65b9b0738b54d429b38
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/768715
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517055}

Follow up of https://chromium-review.googlesource.com/c/chromium/src/+/744012

Bug: 785673, 775684
Change-Id: I85e06ac43db3098ed4d297ea6ad9c242dd8ecae2
Reviewed-on: https://chromium-review.googlesource.com/774261Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517054}

This feature for many years was set enabled by default, so let's remove
the feature and leave enabled behaviour.

Bug: 
Change-Id: I3e3ccdbda73a0ac8043aaa439b1d0a1e9844b114
Reviewed-on: https://chromium-review.googlesource.com/771811Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517053}

When opening the profile switcher menu using the shortcut (cmd-shift-m), the first
profile (other than the current one) in the list should be highlighted. This should
happens only when opening the menu with the keyboard (and not with the mouse).

This was done with Cocoa implementation: crrev.com/2638853003
It should have been done when moving the profile chooser menu to views-toolkit:
crrev.com/c/750901

Bug: 728141
Change-Id: I724d08ce626ec88144edabe7d928d8315606fd71
Reviewed-on: https://chromium-review.googlesource.com/771753
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517052}

Note that most Chrome developers and a fraction of Canary users have
dchecks on, so this is causing real crashes.

Bug: 756435
Change-Id: I33150f6565da96f5d2004b4e22ea2fa229119a69
Reviewed-on: https://chromium-review.googlesource.com/772076Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517051}

Bug: 777763
Change-Id: I7c311ade27f40c723f9afbe0dad1ebbcb632099c
Reviewed-on: https://chromium-review.googlesource.com/771631
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517050}

Convert JavaScriptDialogBlockingState to directly track
registration with the observed WebState instead of
relying on the deprecated code in WebStateObserver.

Bug: 775684
Change-Id: I5add60c72e6046400c2dc1c4a609e9f443ecb782
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/768420
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517049}

SetMark caches the VisibleSelection and is always set by
FrameSelection::ComputeVisibleSelectionInDOMTreeDeprecated.
So instead of passing VisibleSelection, this CL passes
FrameSelection, and then compute the visible selection
at call site. With this, it also prepares for the movement
of is_directional_ to FrameSelection.

Bug: 740804
Change-Id: I0e7a27af4d926ae0c68f15fbba612cb7d9a5f268
Reviewed-on: https://chromium-review.googlesource.com/766027Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#517048}

Corresponding spec change:
https://github.com/w3c/webappsec-clear-site-data/pull/43

Bug: 607897
Change-Id: Ib9d0c994917ff801dd64404734efdcb34c9507e1
Reviewed-on: https://chromium-review.googlesource.com/771890Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517047}

From discussion on chromium-dev, it was decided to remove 'chrome'
namespace.

Bug: 289619
Change-Id: I7e424529d4dacd61e8c272f8c4261546db55407a
Reviewed-on: https://chromium-review.googlesource.com/768469
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517046}

This CL adds a test for handling a bigger number of stored
passwords in iOS settings than how much fit on a single screen.

Bug: 750884
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I459ecbda1ad18b046ba54652c2fb393c51c708e2
Reviewed-on: https://chromium-review.googlesource.com/593012
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517045}

This patch gets rid of redundant function call introduces by the patch[1] from
|LayoutInline::DirtyLinesFromChangedChild()| and checking runtime flag before
calling non-cheap function call |EnclosingNGBlockFlow()| to avoid speed
regression.

This patch also removes a TODO comment from |SetAncestorLineBoxDirty()| call
site since the patch[2] explains it.

[1] http://crrev.com/c/768257: [LayoutNG] LayoutInline::DirtyLinesFromChangedChild()
[2] http://crrev.com/c/773455: Add a comment to LineLayoutInlineItem::SetAncestorLineBoxDirty()

Change-Id: I7eedd7753b0c901380c55c8234cc78ae65f82574
Reviewed-on: https://chromium-review.googlesource.com/774339Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517044}

chromium/ directory is no longer necessary because tests were upstreamed to WPT
and all remaining tests under http/tests/worklet/ are chromium-specific.

Bug: n/a
Change-Id: I9540b3d889f45e311cdd43562c2b23dd9cededda
Reviewed-on: https://chromium-review.googlesource.com/770917
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517043}

Finch config groups for testing. Should include the Control group as it
changes the default behavior.

Change-Id: I41c2f03bd4acd421c227291a961cc7353b8bff63
Reviewed-on: https://chromium-review.googlesource.com/768720Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517042}

BUG=717091
R=nikunjb@chromium.org, skare@chromium.org

Change-Id: I1e8d1d9ac4dd7f5f9e1feb80aaad38dfea6ba7cc
Reviewed-on: https://chromium-review.googlesource.com/544817
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517041}

This includes user-initiated navigations to other pages (click-like
events), which could otherwise lead to favicon mixups (the favicon of
the landing page could be associated to the page where the event was
initiated by the user.

BUG=776346,759631

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ic8536c848fd2ce93b2b558320fb97211a933042d
Reviewed-on: https://chromium-review.googlesource.com/758356
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517040}

This CL logs the following metrics for the DICE flow to sign in to Chrome:
1. Sign-in started:
* histogram: Signin.SigninStartedAccessPoint
* user action Signin_Signin_From<AccessPoint>
2. Sign-in completed:
* histograms: Signin.SigninCompletedAccessPoint and Signin.SigninReason

This CL also removes the usage of the continue_url from OneSigninSyncStarter as it was
never used.

acronym: DICE = Desktop Identity Consistency

Bug: 772365
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie5b6e42baa5b771051e1f9fc1afc7d60f9f605ca
Reviewed-on: https://chromium-review.googlesource.com/768744Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517039}

https://webrtc.googlesource.com/src.git/+log/7aee3d538c54..801b868bd8e3

$ git log 7aee3d538..801b868bd --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I70f184407e5ad8a14efdd05f14c1c873209a7bdc
Reviewed-on: https://chromium-review.googlesource.com/773453Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517038}

The 'qpc_position' result of IAudioClock::GetPosition must be
converted to raw QPC value before base::TimeTicks::FromQPCValue
can be called on it.

Bug: 783784
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4918c71e439d87b4e231cd9f8d73ac5ed6c69abb
Reviewed-on: https://chromium-review.googlesource.com/768682Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Cr-Commit-Position: refs/heads/master@{#517037}

This reverts commit 02192497.

Reason for revert: 
The following tests started failing consistently right after this CL landed:
ChromeNetworkServiceRestartBrowserTest.StoragePartitionGetNetworkContext
ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext

First failure: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64657


Sample logs:
[330/331] ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext (TIMED OUT)
[331/331] PrerenderBrowserTestWithExtensions.StreamsTest (6672 ms)
Retrying 1 test (retry #2)
Still waiting for the following processes to finish:
	".\browser_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_25891\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_10509"
Still waiting for the following processes to finish:
	".\browser_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_25891\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_10509"
Still waiting for the following processes to finish:
	".\browser_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_25891\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_10509"
[ RUN      ] ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext
[1320:5532:1115/211725.385:WARNING:chrome_browser_main_win.cc(613)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_25891\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_10509" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=45 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --enable-features=NetworkService,TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[5536:4644:1115/211726.031:INFO:media_foundation_video_encode_accelerator_win.cc(370)] Windows versions earlier than 8 are not supported.
[332/332] ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext (TIMED OUT)
Retrying 1 test (retry #3)
Still waiting for the following processes to finish:
	".\browser_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_29411\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_16217"
Still waiting for the following processes to finish:
	".\browser_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_29411\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_16217"
Still waiting for the following processes to finish:
	".\browser_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_29411\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_16217"
[ RUN      ] ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext
[4852:4412:1115/211810.497:WARNING:chrome_browser_main_win.cc(613)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_29411\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_16217" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=45 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --enable-features=NetworkService,TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[2460:2636:1115/211811.151:INFO:media_foundation_video_encode_accelerator_win.cc(370)] Windows versions earlier than 8 are not supported.
[333/333] ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext (TIMED OUT)
1 test timed out:
    ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext (../../chrome/browser/chrome_network_service_restart_browsertest.cc:96)
+------------------------------------------------------------------------+

Original change's description:
> Handle NetworkContext error in StoragePartitionImpl and SystemNetworkContextManager
> 
> This CL:
>  1.Adds reconnect logic to |StoragePartitionImpl::GetNetworkContext()|
>    and |SystemNetworkContextManager::GetContext()| to makes sure they return
>    valid interface after crash.
>  2.Adds browser tests to ensure the new |NetworkContext| can make URL
>    requests.
> 
> Note:
>  * This CL only makes sure the returned |NetworkContext| is valid. More
>    tests will be added to ensure other NetworkContext providers
>    (e.g. IOThread) and |URLLoaderFactoryGetter| is working.
> 
> Bug: 780956
> Change-Id: Ie8bc4e2bb2e86c5e72f946eef1eb84fb8102910f
> Reviewed-on: https://chromium-review.googlesource.com/758831
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Chong Zhang <chongz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516766}

TBR=jam@chromium.org,yzshen@chromium.org,mmenke@chromium.org,chongz@chromium.org

Change-Id: If30e7394e6f2e4a9c14d7671a4106243aa72b9c1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 780956
Reviewed-on: https://chromium-review.googlesource.com/774398Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517036}

This is a reland of b58d6940
Original change's description:
> Get base building with -Wshadow
> 
> Variable shadowing is legal and well defined but can make code harder to
> read and can hide some classes of bugs. This change gets base building
> with -Wshadow. The changes required seem to improve the code in most
> cases, and neutral in others.
> 
> This CL uses a number of techniques to avoid shadowing
> * reuse - don't declare a new variable if not needed
> * rename - if a new variable is needed, use a new name
> * reduce - make the scope smaller
> * remove - remove duplicate constant declarations
> 
> I particularly like the for loop technique for reducing scope. We
> should probably prefer 'for' over 'while' for many loops.
> 
> Change-Id: Iad81f0ca22937653a36781e55d53aca8e38672aa
> Reviewed-on: https://chromium-review.googlesource.com/767654
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516850}

Change-Id: I43258f86c51263b2aad665f61527823c3fea9db5
Reviewed-on: https://chromium-review.googlesource.com/773832Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517035}