- 13 May, 2019 40 commits
-
-
Robert Sesek authored
Previously the app_mode_loader was packaged into a .app bundle. But because the Info.plist is modified as part of creating app shim shortcuts, only the executable was code signed. This left the Info.plist as an un-sealed resource. Under stricter code signing verification rules required for macOS notarization, an .app bundle cannot have an un-sealed Info.plist. To work around this, place the un-bundled executable in the Framework's Helpers directory and store the Info.plist file under Resources. When building app shims at runtime, the .app bundle structure will be created manually (rather than copying the whole pre-built bundle). Created app shims will still not be validly signed .app bundles, but the components carried within Chrome will pass validation. Test: Browser menu > More tools > Create shortcut creates an app shortcut that launches. Bug: 960886, 850199 Change-Id: Ia4521ee436bc3288084004e247fd9765fb93816a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609886Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#659223}
-
Alexei Filippov authored
This reverts commit 391dff3d. Reason for revert: Broke build https://ci.chromium.org/p/chrome/builders/ci/win-google-rel/3737 Original change's description: > Create source sets for tests in chrome/browser/conflicts > > This solves a filename collision that happens when moving all the files > in chrome/browser/conflicts to chrome/browser/win/conflicts because > module_info_win_unittest.cc becomes module_info_unittest.cc, and this > file already exists at > chrome/browser/install_verification/win/module_info_unittest.cc > > Change-Id: Id269f582259ac8e53a8a5aa64a61f4232ad732ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593894 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659186} TBR=sky@chromium.org,pmonette@chromium.org Change-Id: Iac5e9ba70ca8f15625b366374aeeaf24188d5d19 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609719Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#659222}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d696f8e6bca3..2b8b06e79309 git log d696f8e6bca3..2b8b06e79309 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 mtklein@google.com rewrite docs to explicitly use python2 2019-05-13 brianosman@google.com Interpreter: Fix bool literals 2019-05-13 bsalomon@google.com Blacklikst AsyncReadPixels on MoltenVK Created with: gclient setdep -r src/third_party/skia@2b8b06e79309 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I6abb1087c55167819f0c77a943b5b5087f2f07cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610740Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659221}
-
Matthew Jones authored
Bug: 958469 Change-Id: I88129f30f187636de500a34583fe002b44352b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592521 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#659220}
-
Alexei Filippov authored
This reverts commit 192ccc29. Reason for revert: Needed to revert https://chromium-review.googlesource.com/c/chromium/src/+/1593894 that broke the build Original change's description: > Move chrome/browser/conflicts to chrome/browser/win/conflicts > > This allow us to remove all the _win suffixes to every files in the > directory. > > This CL contains no functional change. In addition to the directory > move, I only fixed file names (removing the _win suffix) and formatted > the resulting CL. > > Change-Id: I2158afd065fe81cb5350711653359983d9b790e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593724 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659208} TBR=sky@chromium.org,pmonette@chromium.org,wfh@chromium.org Change-Id: I5b74a56f2dc3e0601cd684a2a2abe6c157fea52c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610590Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a69e8c1681da..58d7304e63dc Created with: gclient setdep -r src-internal@58d7304e63dc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,battre@google.com Change-Id: I0ad3e167f8428e437edeba621a620f08bc35bb24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610837Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659218}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a40840a4e11c..ccf1a17964ab git log a40840a4e11c..ccf1a17964ab --date=short --no-merges --format='%ad %ae %s' 2019-05-13 saklein@chromium.org BuildPackages: Add USE flags to environment Created with: gclient setdep -r src/third_party/chromite@ccf1a17964ab The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ie4c07322ce13a646041d5823deb15f17dd143835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610840Reviewed-by:
-
Suman Nelson Kancherla authored
This can happen when a VRService couldn't be started on browser process, which calls an error handler callback that releases the service_ pointer. Fixed it by adding a nullptr check around the usage of service_. Also, checked if there are any other similar references. Bug: 961971 Change-Id: Icda57d91280e46df07b88db858a0539b7fac1526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610467 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#659216}
-
Elly Fong-Jones authored
Bug: None Change-Id: Ibfce3c1740c07cbcf74705d459b54faefc3be217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609881 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#659215}
-
Becky Zhou authored
Bug: 948443 Change-Id: I2fe90e283fad46f5d2fecc71abd61392074c9af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601933 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#659214}
-
Alexander Timin authored
Add alexclarke@, altimin@ and skyostil@ to base/task/OWNERS as base/task now contains all base task scheduling infrastructure. Also update component tagging: - base/task: Internals>TaskScheduling - base/task/sequence_manager: Internals>SequenceManager R=gab@chromium.org,fdoray@chromium.org CC=alexclarke@chromium.org,skyostil@chromium.org Change-Id: I0a92c5d67630774d932ea109de896c5764c30301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605904Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659213}
-
Evan Stade authored
This relands 4bace02d without includes of stale header kiosk_app_info.mojom.h TBR=derat@chromium.org,tsepez@chromium.org Bug: 962631 Change-Id: I2c13a3453a12c6369431191dc53aed28b0595fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610843Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#659212}
-
Hongchan Choi authored
* This is branched off from: crrev.com/c/1524645 This CL implements a front-end for the WebAudio inspector agent. The UX design review is done by julialiang@ at the project design doc: https://docs.google.com/document/d/1TRgzZwp6M7sWL06UO3GYktqrv9TUv4G0QK6Io6VYVzc/edit#bookmark=id.id0mjwkct14i Bug: 837323 Change-Id: If0478ec96e74e93ce6615ab7322b33db704a6c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578947 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#659211}
-
Josh Karlin authored
CacheStorageCache dooms entries before closing them if their write operations fail. This prevents them from being used in the future. In the event that a ScopedEntry is held by a callback and the callback never gets to run, but does get deleted, a partially written entry would be closed and will be reusable. This is a hypothetical problem. We're not actually sure this can happen since the CacheStorageCache is kept alive by its manager during async operations. But for safety, I've made a new smart pointer for disk_cache::Entry*'s that will by default doom an entry before closing it unless WritingCompleted() has been called on its deleter. This new smart pointer is used anywhere that Entry* writing occurs in CacheStorage. Bug: 617683 Change-Id: Ia5b83bd87b4997fea08cba013fc4701441db6f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600267 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#659210}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3dfb68082e1a..5fc28b11a029 git log 3dfb68082e1a..5fc28b11a029 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 hta@webrtc.org Reland "Reland "Version 2 "Refactoring DataContentDescription class""" 2019-05-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7da20dc3..b06ee6f3 (658985:659110) Created with: gclient setdep -r src/third_party/webrtc@5fc28b11a029 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia8bcbaf7c4e22ffa3fd0b013cfc5fc499f5a6cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609674Reviewed-by:
-
Patrick Monette authored
This allow us to remove all the _win suffixes to every files in the directory. This CL contains no functional change. In addition to the directory move, I only fixed file names (removing the _win suffix) and formatted the resulting CL. Change-Id: I2158afd065fe81cb5350711653359983d9b790e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593724 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659208}
-
Scott Violet authored
This functionality was added purely for mus and is no longer necessary. BUG=958241 TEST=purely dead code removal Change-Id: I856576f9adef9728d837d56e82f94a87aeea040b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610497 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e1de1ab33d7f..0a1eeb80641a git log e1de1ab33d7f..0a1eeb80641a --date=short --no-merges --format='%ad %ae %s' 2019-05-13 jmadill@chromium.org Call robust resource init before object sync. 2019-05-13 jmadill@chromium.org Roll dEQP (May 2019) 2019-05-13 syoussefi@chromium.org Vulkan: Rework layout block storage conversion 2019-05-13 syoussefi@chromium.org Add test to verify uniform matrix upload Created with: gclient setdep -r src/third_party/angle@0a1eeb80641a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: Ib7846401842c4bdcd8500528ecfeb782f7a4a39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610741Reviewed-by:
-
Alexei Filippov authored
This reverts commit 3f4fcf06. Reason for revert: Broke compile https://ci.chromium.org/p/chrome/builders/ci/linux-google-rel/3606 Original change's description: > [Payment Request][Desktop] Add dark mode Chrome logo. > > Before this patch, Chrome in dark mode (on desktop) would display light > gray "chrome" text on dark gray background in the payment sheet. The > text was not readable. > > This patch adds the white text logo and uses it when the dark mode is > enabled. > > After this patch, Chrome in dark mode displays white "chrome" text on > dark gray background. This is readable. > > Bug: 959880 > Change-Id: I8d705cddebbb9b7bd01c433c7fbee9721520185f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594348 > Reviewed-by: Mitsuru Oshima (slow - gardening) <oshima@chromium.org> > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659183} TBR=oshima@chromium.org,rouslan@chromium.org Change-Id: I5cfb23dc19f8106afcdc38067a868cf85d1e630a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 959880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610574Reviewed-by:
-
Oystein Eftevaag authored
This reverts commit 996da9c1. Reason for revert: Revering due to https://crbug.com/962478 Original change's description: > Reland "Background tracing: Use the new Perfetto Consumer mojo endpoint" > > This reverts commit 5116072f. > > Reason for revert: Relanding with fix for fully waiting for trace shutdown. > > Original change's description: > > Revert "Background tracing: Use the new Perfetto Consumer mojo endpoint" > > > > This reverts commit 67f4c2f3. > > > > Reason for revert: Revert while investigating new TSan warnings > > > > Original change's description: > > > Background tracing: Use the new Perfetto Consumer mojo endpoint > > > rather than the TracingController. > > > > > > This is in preparation for being able to handle proto traces > > > in addition to JSON. > > > > > > R=ssid@chromium.org > > > BUG=925151 > > > > > > Change-Id: I91ed3c9648587fb19a5102b869a5d5ab688e0187 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546146 > > > Commit-Queue: oysteine <oysteine@chromium.org> > > > Reviewed-by: Avi Drissman <avi@chromium.org> > > > Reviewed-by: ssid <ssid@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#657413} > > > > TBR=avi@chromium.org,oysteine@chromium.org,ssid@chromium.org > > > > Change-Id: I92db1fa46353cfb960071f44d110a5faa0c25421 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 925151 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600305 > > Reviewed-by: oysteine <oysteine@chromium.org> > > Commit-Queue: oysteine <oysteine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#657520} > > TBR=avi@chromium.org,oysteine@chromium.org,ssid@chromium.org > > Change-Id: Ic3cc44a563a98871de8003221cb015fbc3b890d0 > Bug: 925151 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601555 > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657925} TBR=avi@chromium.org,oysteine@chromium.org,ssid@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 925151 Change-Id: Id214d9547e18cb35b5ecf987f611b204944e51a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610301Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#659204}
-
Greg Thompson authored
ShowAndFocusNativeWindow often fails on Win 10 bots with an indication that the foreground window is owned by OpenWith.exe. We don't understand why this dialog is onscreen. It appears to be leftover from a previous test on the bot. This CL here includes a textual representation of the UI accessibility tree of the foreground window when ShowAndFocusNativeWindow fails. This should shed some light on what the dialog is asking for. With luck, this understanding will help us find the culprit and/or close the window so that interactive_ui_tests can proceed. BUG=711256 R=sky@chromium.org Change-Id: If81cca9f8a97c0e25d3810c47416ec37a8bdc2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609898 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Sinan Sahin authored
Bug: 961780 Change-Id: I919783dc96c81b06bd576cb0f6b15b3b2e14e9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605448 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
-
Manas Verma authored
A new mojom pipe that is meant for internal components to facilitate WebAuthn protocol. This allows the caller to set its own origin, that does not necessarily match the origin of the render frame host Bug: 945993 Change-Id: I8e553166277821f74f01c45789e58769b605092d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540310Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#659201}
-
Peng Huang authored
Bug: 928873 Change-Id: If88e7712d01660343c743373ac2bebee109882bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610470Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#659200}
-
Ryan Sleevi authored
This updates the set of well-known root CAs to consider the following platforms: - Android: pie-cts-release - macOS: 10.13.4 - 10.14.1 - Microsoft Windows: 2019-04-16 - Mozilla NSS: 2.26 - 2.32 root stores Bug: none Change-Id: I6cb753b91aa24af1271db9fbca1f652742a05093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607041Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659199}
-
Stephen McGruer authored
InterpolableNumber can represent doubles, but SVGNumber can only represent floats. Previously this conversion was implicit and resulted in +/- inf for non-representable doubles; this CL makes it explicit and clamps the result to max/min float instead. Clamping rather than infinity was chosen arbitrarily just based on existing WTF math helpers; it is unlikely that it results in much visual difference (since max-float is a very big number already...). Bug: 961859 Change-Id: I675471c552b2bd0419698a64d3a1c68c66d8a3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610465 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659198}
-
Patrick Monette authored
This reverts commit 0b9afd3b. Reason for revert: This CL changed the behavior of IMEs by launching them in TF_TMF_IMMERSIVEMODE Original change's description: > Disable legacy hooking in the browser process > > Now that TSF is enabled by default in m75, there are no > known blocking issue anymore. > > Bug: 557798 > Change-Id: Iaf060e267982d3f90acc5281caf99ff02e155dbd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597282 > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657798} TBR=pmonette@chromium.org,wfh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 557798, 962310 Change-Id: I58fc91b39077520afcb5f39d3d881c72ecac2bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610089 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#659197}
-
Julie Jeongeun Kim authored
This is a reland of 72316111. It removes unused condition for AppCacheBackendImpl from AppCacheInterceptor::SetExtraRequestInfo because AppCacheServiceImpl manages AppCacheHost. Original change's description: > Use DocumentInterfaceBroker to register AppCacheHost > > This CL uses DocumentInterfaceBroker to stop passing frame ID > over mojo from WebApplicationCacheHostImpl for the render > frame path and moves AppCacheHost registration and |host_| > from AppCacheBackendImpl to AppCacheServiceImpl. > > Now AppCacheBackend is only used for workers and it registers > AppCacheHost through AppCacheServiceImpl. > > Bug: 950159 > Change-Id: Ic1ba441a6a4bb7f430cf8fce8267ba69a7a4c32c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589478 > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658481} Bug: 950159 Change-Id: I4e9dde26e9dd161c002089a467d2b0ea6b5b2881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607703 Commit-Queue: Julie Jeongeun Kim(OOO till May 19) <jkim@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#659196}
-
Tibor Goldschwendt authored
Change-Id: I42e21fe8e789a396a76e90eb88e194716bbb3bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554370 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#659195}
-
Etienne Bergeron authored
This CL is adding a trace event to observe the side-effects of fonts enumeration in content. This API is used font_settings_api. See: chrome/browser/extensions/api/font_settings/font_settings_api.cc Bug: 944227 Change-Id: Id6af649c3abc2f6806abf9d11a5df17e91ce915c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604313Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659194}
-
Sebastien Marchand authored
Change-Id: Ifb83230b1a3621d0bcf02cf9b9b2b71617df6462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606443Reviewed-by:
-
Ian Vollick authored
Previously, we hadn't applied this style via LayoutTheme, but this appears to be normative (cf. mac.css). touchless.css also contained a universal rule, which tripped a DCHECK, and I've also slightly qualified it in this CL. Bug: 961026 Change-Id: I0626299f7dee1c0c5a8b04e506d6feae05f80663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600960 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659192}
-
Jonathan Ross authored
gpu/vulkan was not compiling on Windows. This fixes the errors. Bug: 961874 Change-Id: I7c3412819d0d445d48c12f43ce175284317c99d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610450Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#659191}
-
Caleb Rouleau authored
Now there are two types of benchmarks: 1. official benchmarks: benchmarks defined in tools/perf/benchmarks. -- These are officially supported and we will keep them working. -- They also are the only ones scheduled on main chrome.perf waterfall. 2. contrib benchmarks: benchmarks defined in tools/perf/contrib. -- We don't run these on our own bots (except in rare circumstances) -- We maintain the right to break these when necessary to move the framework forward. "all benchmarks" now means "official benchmarks" + "contrib benchmarks". Also remove the word "all" in places where it is redundant/confusing. This changelist prepares the ground for the changes for issue 961830. TBR: jbudorick@chromium.org Bug: 961830 Change-Id: I9985cd75814b284fc3b748597ce6724f9a53068a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606223 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659190}
-
Marcelo Almeida authored
Creates ChildStatusCollector as a copy of DeviceStatusCollector, but removing enterprise parts. It also uses common code that was previously extracted from DeviceStatusCollector (in crrev.com/c/1558024). There's still some duplication in the code, but that's only during the migration phase. Once it's done, each class will be completely independent from each other. Notice that this change is already plugging ChildStatusCollector into consumer_status_reporting_service.cc, meaning that it will be used as soon as submitted. Bug: 827386 Change-Id: I88095ea5bcadb166f447ef90c3987d3c5c348416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566427Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Marcelo Almeida <marcelocra@chromium.org> Cr-Commit-Position: refs/heads/master@{#659189}
-
Darwin Huang authored
Change-Id: Ie3a5ec68bf3cd00f3f2f749b5df4aae9563d2314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607157 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 38a36217. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" 4d43fa2e "[Feature Policy] Introduce 'focus-without-user-activation'" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Icb4e67453f2448a50c5750e70444e6f63ddcaba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610466Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659187}
-
Patrick Monette authored
This solves a filename collision that happens when moving all the files in chrome/browser/conflicts to chrome/browser/win/conflicts because module_info_win_unittest.cc becomes module_info_unittest.cc, and this file already exists at chrome/browser/install_verification/win/module_info_unittest.cc Change-Id: Id269f582259ac8e53a8a5aa64a61f4232ad732ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593894 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL moves the type alias of FieldTrialParams from field_trial_param_associator.h to field_trial_params.h and use base::FieldTrialParams in blink. Bug: 952716 Change-Id: Ia6587a4799a43591ef19cd88cc0c7292bc22c7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605282Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Miyoung Shin(OOO till May 17) <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#659185}
-
Becky Zhou authored
Bug: 944061 Change-Id: If83cb176e3623784af1477731fa586295cd9459f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610471 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
-
