- 17 Aug, 2020 31 commits
-
-
Keith Lee authored
Applying comments in https://chromium-review.googlesource.com/c/chromium/src/+/2327773. Bug: 1108170 Change-Id: I3a528db4f4a7df288af0a5b02d758f5d9616f011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355657Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#798537}
-
Jing Wang authored
This is requested by UX in https://docs.google.com/document/d/1bZASllOcjDJdufpJdedUuM0cTQlIaoVO7K8AhXtWBrs/edit# Besides the announcement text change, now we will always announce the instruction about how to browse, accept and dismiss no matter if the annotation icon is displayed. So removed one inapplicable test. Test: Tested on DUT Bug: 1116298 Change-Id: I9fe24ea6ff50de5af4c24d4512dcf337f616b391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355530 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#798536}
-
Naoki Fukino authored
This is a follow-up of CL:2354115. As only one client listen to the click event of filter buttons, setting onclick property is sufficient and concise over addEventListener. Bug: none Change-Id: I13b5ad9c658c8489ec50a99754db422a79dc5551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359594Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#798535}
-
chrome://media-appTrent Apted authored
Currently user settings for default websites that may block these web features leak into system apps unless explicitly auto-granted. Bug: b/163088459 Change-Id: I22fb8bfcdd3a83c1a054c663bda0e54f89a6c238 Test: Open an image from ChromeOS Files app after setting chrome://settings/content/javascript to "Blocked" Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358940 Commit-Queue: dstockwell <dstockwell@google.com> Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Cr-Commit-Position: refs/heads/master@{#798534}
-
My Nguyen authored
Bug: 1113612 Change-Id: I831b447955cc147c80cb9dac9da4414933d787ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358716Reviewed-by:
-
My Nguyen authored
Spell check logic is from languages_page. It's currently disabled. Further logic for spellcheck languages will be added later. Spec: http://go/cros-lang-settings-ux slide 23. Current view: http://screen/36a08c58-4057-46d7-a6ef-7f43d370cbdc Note: All strings are not finalised so they are translateable false and no screenshots required. Bug: 1113439 Change-Id: Ic79458b605eda3fafc35f606f961e42b4ab23ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354118 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798532}
-
Prashant Nevase authored
There is no need to treat raster images differently. The element role added for images were used for deciding initial classification which is now moved to DarkModeFilter::AnalyzeShouldApplyToImage(), which should be called before calling ApplyToImageFlagsIfNeeded(). The functions added in Image class which were used for deciding element role for svg image container and gradient generated image are removed. Along with skipping filter to images drawn into larger rects, this patch adds logic for considering images for applying dark mode filter which have very smaller source rect. The analysis based on |src| and |dst| rects is extended for all kinds of images. With this rastered content from SVG images and gradient generated images undergo classification. Bug: 1094005 Change-Id: I6d24c770e2c703ddccfb70c00c0a5c9c51507498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352251Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#798531}
-
Naoki Fukino authored
Adding unit tests to evaluate the behavior of FileTypeFiltersController class, which was added with CL:2354115. Bug: 1114721 Test: Ran browser_tests --gtest_filter=*FileTypeFiltersController Change-Id: I9cc1cc8379fb35de909202d3043bda6d5304a024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359314Reviewed-by:
-
Xianzhu Wang authored
These were created in crrev.com/c/2146093 probably after we removed the mac10.10 bot for web tests and before we removed mac10.10 from blinkpy/web_tests scripts. TBR=szager@chromium.org Bug: 1107003 Change-Id: If64631c91dd341f580dad15e6deb72395c63c6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359366Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798529}
-
Ana SollanoKim authored
Previously, we had made the legends fragment in the following change https://chromium-review.googlesource.com/c/chromium/src/+/2090762. In this other change https://chromium-review.googlesource.com/c/chromium/src/+/2263353 we decided to not break borders for now. Because the legend is part of the fieldset border, we now want to treat the legend as monolithic. We still have logic for breaking the fieldset border, this will be addressed in a follow up change. Bug: 1097012 Change-Id: Iace252447063eb694c47fb9eea2a406ba2fe79d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353354 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#798528}
-
My Nguyen authored
Spec: http://go/cros-lang-settings-ux slide 23. Current view: http://screen/f9bbb539-b983-4ac7-aa9f-cb0886bd2f9f Note: All strings are not finalised so they are translateable false and no screenshots required. Bug: 1113439 Change-Id: Ic1ab01755fe86c28b89468aba54cc5dff010ced5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354113Reviewed-by:
-
tby authored
This is the first in a series of changes to how search providers are created and configured, with the aim of reducing the number of ranking and filtering steps between the providers and the UI. Eventually I'd like to repurpose the concept of a 'mixer group'. This change makes a small start by removing a feature of groups that we don't use anymore: multipliers on result scores. This CL also deletes some obsolete tests that don't take into account modern ranking. This coverage is mostly duplicated by search result ranker tests. Bug: 1028447 Change-Id: Ib6d27975ede3b9ee0a9d4b508d262ebff154670b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342533 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798526}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ic2ce391f18c132cb7347d71461b190ed928b0711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359406Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798525}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic9b8e4cdb3a9d94af651f8e9663c042078ebcc94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359237Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798524}
-
Koji Ishii authored
This patch checks hyphenation alias first, before trying to open dictionaries. When the `lang` attribute is aliases, this change can reduce one IPC call. Bug: 1116540 Change-Id: I2ffe71a7f7c063238545320b538474e0e03307b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358714Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#798523}
-
Fergus Dall authored
Mark compositing/layer-creation/overflow-scroll-overlap.html as failing on Mac This appears to have been broken by CL:2146093 which won't revert cleanly at this point. TBR=szager@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org Bug: 1069546 Change-Id: I8a72c5e9e4e9d61df0365f4bb6b4158a6a11b9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359317Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#798522}
-
danielng authored
Adding lxj to owners for pluginvm-show-camera-permissions and plugin-vm-show-microphone-permissions. Bug: 1106149 Change-Id: Ifcaf168fb48142632098f4ad3206878bc8240880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355359Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Jason Lin <lxj@google.com> Auto-Submit: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#798521}
-
Adam Rice authored
Always resolve tee's cancel promise after stream closes or errors. Applies https://github.com/whatwg/streams/pull/1039 to our implementation. BUG=1114014 Change-Id: Ic6d665bd928553ea3a292fe8221f0812d1c613e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358929Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#798520}
-
Mike Jackson authored
Update AppBannerManagerDesktop::OnWebAppInstalled to use the winning display mode when display_override is set. To test the change use: chrome --enable-features=WebAppManifestDisplayOverride Example websites: https://mwjacksonmsft.github.io/pwa/display-override-custom/index.html (display == browser, display_override == [standard]) Explainer: https://github.com/WICG/display-override/blob/master/explainer.m Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion Bug: 1109520 Change-Id: If0b589f0a19367f01501e2eb52aec16f4f2645cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354665Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#798519}
-
Justin Donnelly authored
This preserves the existing behavior where you can focus the omnibox and <text matching keyword><tab key> enters keyword mode. Bug: 1046523 Change-Id: I2e7d380cf31938e056b90b072df54e21e16ad348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346732 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#798518}
-
Dominic Mazzoni authored
This looks better and better matches the mock. Bug: 1108114 Change-Id: I7f31c856bfe66b7d3fb4d4ae277ac633e8517295 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357855 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798517}
-
Peter Kasting authored
* Shorten code * Trivial naming/comment fixes * Use const more * Inline temps * Event::marking_time_in_bytes_per_second() is unused (and actually mis-named); remove * Use TimeDelta::InMicrosecondsF() to get a double Bug: none Change-Id: I324c6d82e04514e2a9105df05b5942eb2cfd9efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359006 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This CL adds kReadOnceStream enum value for fetch upload streaming instead of kChunkedDataPipe. kReadOnceStream means the data is non repeatable unlike kChunkedDataPipe. This is a preparation for "[fetch] Cache request stream body up to 64k bytes." (crrev.com/c/2269622) Bug: 1077174, 688906 Change-Id: I78c45777eb85751b20287bab6e55be0dd3502cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342525 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
David Maunder authored
We now do not allow Tab attributes to be acquired on an uninitialized Tab. We are finding tabs passed to getDomain() are uninitialized so we should handle this. Bug: 1116341 Change-Id: I69510196bf47b2b4939450905552a30ccb536d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358050 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798514}
-
Thanh Nguyen authored
This is a reland of dd116903 The original CL was reverted because mac-arm64-rel was failing. It works fine now. TBR=xiyuan@chromium.org,jiameng@chromium.org,tby@chromium.org,austinct@chromium.org Original change's description: > Using vector icons for launcher search provider > > Currently LauncherSearchProvider use png as the format for the result. > This CL changes the format to vector icons (.icon). > > Bug: 1067326 > Change-Id: I55fb11ed50906a5199bc28339de42d4903433b36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352290 > Reviewed-by: Austin Tankiang <austinct@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Reviewed-by: Tony Yeoman <tby@chromium.org> > Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798087} Bug: 1067326 Change-Id: I3558b2f0b023227d06893eda14b88fe3fe967b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358936Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
-
Sam McNally authored
When initialized incorrectly, some touchscreen controllers can report bogus values for their sizes. Chrome uses the touchscreen area in calculations; if that area overflows a signed 32-bit int, it check-fails. Thus, a misbehaving touchscreen can cause Chrome to crash-loop, rendering a device unusable. Mitigate this by warning about the bogus size and then ignoring the touchscreen input device. A non-functional touchscreen is better than an unusable device. BUG=b:162596241 Change-Id: I9291c176ed778f5ddb8a80d9ea75f17be7bd0554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353973Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798512}
-
Luciano Pacheco authored
The disabled state wasn't applied to disabled button because the selector was less specific. Fixed by adding a rule with "files-ng" to increase the specificity and using the semantic color. FIXED: 1116401 Change-Id: Ib3bb638d82b2bf488eca34894c86c63550ccb63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359590 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#798511}
-
Naoki Fukino authored
When file-type filters in Recents is available, it provides equivalent functionality with media views and they become redundant. We can hide media views to save vertical space in directory tree in this situation. Bug: 1114721 Change-Id: Id4dd9660634560c71eb1a2a8e62879ad3b5206a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358937Reviewed-by:
-
Fergus Dall authored
PasswordManagerBrowserTest.PlaceholderPasswordOverwritten TBR=dvadym@chromium.org TBR=jdoerrie@chromium.org TBR=kolos@chromium.org TBR=mamir@chromium.org TBR=vasilii@chromium.org Bug: 1116886 Change-Id: I24b11647678d1cecefacc98dac6455f2e001399a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359589Reviewed-by:
-
Fergus Dall authored
AddressViewControllerTestCase/testIPadTappingOutsidePopOverDismissAddressController TBR=javierrobles@chromium.org TBR=mahmadi@chromium.org TBR=olivierrobin@chromium.org Bug: 1116887 Change-Id: Ic0af6e48c22db51e49d2e0959c40bfa91e7850d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358935Reviewed-by:
-
Mei Liang authored
This CL adds the release candidate of TabGroups to chrome://flags. It also removes all the old options that are related to changing the thumbnail aspect ratio. Bug: 1116699 Change-Id: I658bdb20383a9169149faf645c3c4b263bed6b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359400Reviewed-by:
-
- 16 Aug, 2020 9 commits
-
-
Fergus Dall authored
This reverts commit 0e1132cc. Reason for revert: Probably broke the Windows deterministic builder, see https://ci.chromium.org/p/chromium/builders/ci/Windows%20deterministic/17001 for first failure Original change's description: > Roll clang llvmorg-12-init-1771-g1bd7046e-5 : llvmorg-12-init-3132-g95fad44e-1. > > Ran `./tools/clang/scripts/upload_revision.py 95fad44e34c3c20263961a715571d798d90921f6`. > > Bug: 1113154 > Change-Id: I2cbd4533fcedea8acfb6d5f5067e56c7d758d25b > Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng > Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng > Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng > Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng > Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng > Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan > Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel > Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng > Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 > Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng > Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 > Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel > Cq-Include-Trybots: chrome/try:iphone-device,ipad-device > Cq-Include-Trybots: chrome/try:linux-chromeos-chrome > Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357413 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798480} TBR=thakis@chromium.org,hans@chromium.org,aeubanks@google.com Change-Id: Ifdc8d2aefe7c8750c9b11c97d17de59c363140df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358934 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
-
Naoki Fukino authored
This is a reland of 4de14608 The CL was reverted as a culprit of a compile error in v8 on win build. https://ci.chromium.org/p/chromium/builders/ci/win-official/356 However, this CL can not affect v8, and it is build only in Chrome OS. Original change's description: > [Files] Add file-type filter buttons in Recents view. > > This adds file-type filter buttons (Audio, Images, Videos) above the > file list only in the Recents view. > Expected behavior: > Users can toggle(enable/disable) file-type filters by clicking it. > Only one filter can be applied at the same time. > Active filter should be cleared when a user leaves Recents view. > > Bug: 1114721 > Test: Manually tested with flag #files-filters-in-recents > Change-Id: I50ecd9c1c2f9a587d63e6ae89f88d6b5fe0cba4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354115 > Commit-Queue: Naoki Fukino <fukino@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798490} TBR=noel@chromium.org Bug: 1114721 Change-Id: Iabaa6b34ec500d020023a77c33948cd683c5a311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358715Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#798505}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7dff8b43..4ae1505c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie2e8d664815f2b0acbaf5ccb9d8b2fd7453097d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358953Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798504}
-
phillis authored
Add a CHECK for icon_manager_ before using it in |WebAppShortcutManager:: GetShortcutInfoForApp| to diagnose a crash in this function on MacOS. Bug: 1113276 Change-Id: I55a00abd394c4b3baf0759751b922d0ba2a81f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354906 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f93d7f924e80..384ea8475558 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ic8149d11c5258b8dfc098c5d7b375ad2c967ac8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359363Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798502}
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: Ie29e6422f28d70844351d16ed16237d5e2d6b7a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358032Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#798501}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3342c64d1ba14a2fbd52102162b338ffbcd86857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359361Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a008b0fa8bbb..7491e8b30f77 2020-08-16 herb@google.com inline routine small routines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I61d394b2b4abb7f808492d8c600f4d95e3c3d797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359360Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c1c3c6d70d32..a008b0fa8bbb 2020-08-16 johnstiles@google.com Enable ClangTidy check readability-redundant-smartptr-get. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: Ibaa795eeddef86731c71d41af568cce611f502c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359454Reviewed-by:
-
