GitLab

Test for CL:1943777 behavior.

The background page for FilesApp stores state for file operations in
progress, as well as error states. This information is propagated to
all the Files App foreground windows during their lifetime, and also
propagated to any newly created foreground windows.

The background progress center has 2 callback functions for changing
state - one for cancel of an operation in progress, the other for
dismissal of an error state.

This test triggers an error state, simulates a click on the 'dismiss'
button on the error panel that is displayed in the foreground window. It
then closes the foreground window and opens a new one to check the error
panel is not displayed. Detection of the lack of an error panel is done
by triggering a copy operation that never ends and checking for that
panel. If the error had persisted, it would be present when the copy
panel appeared.

Bug: 990919
Tests: browser_tests --gtest_filter="*transferDismissedErrorIsRemembered"
Change-Id: I38789d4e621801c8a03c9e7f606d841830332b1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950372
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723597}

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/68b4dfdbd607..252792a1ff65

$ git log 68b4dfdbd..252792a1f --date=short --no-merges --format='%ad %ae %s'
2019-12-09 tguilbert Fix null pointer addition error
2019-12-06 tguilbert Fix null pointer arithmetic

Created with:
  roll-dep src/third_party/ffmpeg

Bug: 1031252
Change-Id: I63615b0744a5fac96358dccc6ba16bf62c6dedf4
TBR: tmathmeyer
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960892Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723596}

This patch updates RequestDevice() into an asynchronous function
RequestDeviceAsync() and moves the creation of GPUDevice into the
callback function passed as a parameter of RequestDeviceAsync().

BUG=chromium:996713

Change-Id: I7208a107670ca6e79ad3a4a3107f35ae26330edf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955171
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723595}

Migration first implemented in M77, so safe to now remove
in M81.

Bug: 946273
Change-Id: I7944f601b6193c983fec66a3859ca079f4b8a5a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958269Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Jason Lin <lxj@google.com>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723594}

Some websites alter basic javascript objects (Promise, Array, Symbol)
in ways that break ChromeDriver. This cl saves the original javascript
objects, and then uses those when making javascript calls.

Unittests were reconfigured to support the 2 SendCommand calls needed in
ConnectIfNecessary.

Bug: chromedriver:3237
Change-Id: Id7375ec78d661c5400f44db4e2e0d4e443cbd8a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947385
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723593}

When the app_id is empty from web contents, the tab could be an webpage
without app_id, so set the app_id as Chrome app_id, and set the correct
InstanceState for Chrome:
1. When the tab is active, it should be started, running and visible.
2. When the tab or an app is inactive, it should be started, running.

This CL also fix a crash bug which is caused by AppWindowBase smart
pointer.

Update AppServiceAppWindowLauncherController and browser_status_monitor
init order, so when browser status is updated, AppService app window
can be updated with the function OnInstanceUpdate.

BUG=1011235

Change-Id: Ie5146d44517f844d9bced6812b4c4c6e83930845
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959191
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723592}

Bug: 1032339
Change-Id: Iae5891afdb72391b0ba5844dac48867dc045eae0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960069Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723591}

Renaming mask as remove_data_mask.

Bug: b/144316586
Test: CQ
Change-Id: I49f490e11bee9e837ec24ff611142cee1b334e19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961167Reviewed-by: Sean Topping <seantopping@chromium.org>
Commit-Queue: Zhaoxin Liang <zxliang@google.com>
Cr-Commit-Position: refs/heads/master@{#723590}

Now that PDFium has APIs to return float values, use them in conjunction
with gfx::SizeF to simplify CalculateScaleFactor() and related code.

Change-Id: I8d8e96c05db5eb6225e9f0a332b69706fa5a2d5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954770
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723589}

Chrome OS swapped its default linker to lld for Chrome quite a while
ago. At this point, we no longer support anything _but_ lld in our SDK
for linking Chrome. Hence, this workaround now seems unnecessary.

Bug: 837095
Change-Id: I4fb50552c9f88c230683a29d8135c77cec3fa7d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960181
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723588}

Bug: 1028829
Change-Id: Ib56fd477453da0579e3a4372acb24484e086ccd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958908
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723587}

If a CompositorFrame is not produced in response to a begin-frame, then
it can be either because the compositor is attempting to recover from
high-latency, or because there was no update to the frame (i.e. there
was no damage). The latter cases should not cause the throughput metrics
to go down. This is currently handled for some cases (e.g. when the
main-frame is aborted due to no damage), but there are other cases where
the trackers are not notified, and thus they report lower throughput
metrics. To correct this, use the newly introduced FrameSkippedReason to
notify the trackers when a frame is not produced because there were no
damage.

BUG=1021963

Change-Id: I415e919738928c30322dd56cc67c23e4ebd73788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956567Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723586}

The success and failure callbacks are only run once, so they can be
OnceCallbacks.

Introduces SuccessOnceCallback and FailureOnceCallback in
VpnService to avoid blowing the change up to the whole
VpnService API.

TBR=dcheng

Bug: 1007763
Change-Id: I668083ab94ecbb9a3c06e3ba8f60d72d493570f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960891
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723585}

Bug: 1032230
Change-Id: I6d024f2027a11d20ab667dd9a95ffe256181c906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960067Reviewed-by: Peter Kvitek <kvitekp@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723584}

Change-Id: I07db7e028c14bb06d414c191ef0941a619859d7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960530
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723583}

For side shelf, the method returns shelf width, so "size" is more
appropriate than "height".

Also, cleans up how shelf dimensions are passed to
AppListConfigProvider::CreateForAppListWidget - instead of passing shelf
height and width separatelly, the method now takes insets.

BUG=none

Change-Id: Iaea6f8fad699e03f35e6d9dc70d9ab3f43a262c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959980Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723582}

Use OnceCallback where possible because the callback is only used once
and RepeatingCallback and BindRepeating otherwise.

R=liberato@chromium.org

Bug: 1007760
Change-Id: I250e6d7c0c84404ad1a7fdcfcdbe4c5de4b9bb2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959403Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723581}

Obsoleted by c5ff0bef

Bug: none
Change-Id: Ib69d6ccd8fd671774fa37c5457721893587de567
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959387Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723580}

This CL clarifies that comments about crbug.com/891872 only apply to
URLLoaderFactories that are vended/handed-out to a renderer process
(in the long-term such factories need to be associated with a specific
origin / in the long-term there should be no way to get a factory via
process-wide mojo APIs like
RenderProcessHostImpl::CreateURLLoaderFactoryForRendererProcess.

This CL also observes that https://crbug.com/888079 no longer blocks
making request_initiator_site_lock non-optional and origin-focused.
This was fixed by r708618.

This CL also observes that CreateURLLoaderFactoryWithOptionalOrigin
no longer exists.  This CL replaces references to this method
with RenderProcessHostImpl::CreateURLLoaderFactoryForRendererProcess.

Bug: 891872, 1025303
Change-Id: If4e79ebb9551ad2675b3fc98cf0d6dd24525b4d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921464Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723579}

Bug: None
Change-Id: Id9bb87e0ebe02192d3fac971610b3e518f975d7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960988Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723578}

- The stories which have been flaky in the past weak are removed
    - css_value_type_filter (android, mac)
    - twitch_2018 (android)
    - extra_large_texture_uploads (mac)
    - mix_blend_mode_animation_screen (mac)
    - web_animation_value_type_transform_simple (mac)
    - bouncing_clipped_rectangles (mac)
    - css_animations_simultaneous_inline_style (windows)

- Stories with low number of frames are removed
    - bouncing_clipped_rectangles (android, mac)
    - css_value_type_filter (android)
    - animometer_webgl_attrib_arrays (android)
    - ie_chalkboard (android)
    - mix_blend_mode_animation_screen (android)
    - web_animation_value_type_transform_simple (android)

- main_30fps_impl_60fps is added to all sets as a control case for noise

Bug: chromium:1032562
Change-Id: I7a957e532513c7d50e76d1b12a8bf4e9ff5ca64a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960177
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723577}

Move storage cleaning logic from CastDemoService and ManagedModeService
to CastWebService in the upstream. Therefore those two classes no longer
need to depend on content/browser/browser_context and a few other
things.

Merge-With: eureka-internal/342450

Bug: b/144316586
Test: CQ
Change-Id: Id5908d78207003c22f306e739d5272cee774aa7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956105Reviewed-by: Sean Topping <seantopping@chromium.org>
Commit-Queue: Zhaoxin Liang <zxliang@google.com>
Cr-Commit-Position: refs/heads/master@{#723576}

The user-facing bug that this change fixes is that Narrator is
reporting some editable text inputs as read-only. This results in
several poor experiences for Narrator users, primarily that Scan Mode
doesn't exit when focusing on certain text inputs, so key presses
trigger Narrator commands instead of typing text.

This is because Narrator is creating a UIA TextRange, then querying
the UIA_IsReadonly property via GetAttributeValue. GetAttributeValue
is getting a leaf text position from the text range, but for certain
text inputs, this ends up being a node under the actual text input
node. These sub-nodes are structural and used for things like
<input type="search">'s clear button. Since these sub-nodes are not
accessible, and can often have attributes like readonly that interfere
with their exposed node's attributes, it does not make sense to
account for them in GetAttributeValue queries.

The internal tree for such text inputs can look like this:
++++searchBox
++++++genericContainer
++++++++genericContainer
++++++++++staticText
++++++++++++inlineTextBox

...but UIA clients can only actually see the topmost node of that
subtree (in this case, a single "edit" node).

The fix here is to traverse up the tree until a node is found that is
in the tree, and query the text attributes from that node, ignoring
any text attributes on non-exposed sub-nodes. This also allowed for
removing an existing special-case for text nodes that was more
apparent, however the fix there should have been this fix in the
first place.

This required moving two methods from the BrowserAccessibility down to
the delegate so they can be accessed from AXPlatformNodeWin.

Bug: 928948
Change-Id: Ie12ceb44dc020d0f08e01e660ca6b5451deb0d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959266Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#723575}

GbmWrapper is needed on non-Ozone linux to support GMBs. Fortunately, there
weren't any real ozone dependencies from //ui/ozone/common/linux so the move is
trivial.

BUG=1031269
R=rjkroege
CC=msisov

Change-Id: Ieff3218b1ba352d2f410d6646b52878eb53d1e06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960666Reviewed-by: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723574}

STACK_UNINITIALIZED is __attribute__((uninitialized)) and it disables
-ftrivial-auto-var-init=pattern on a particular variable.
-ftrivial-auto-var-init=pattern inserts initialization of all
local variables including those which are not required by
language standard. Additional initialization usually can be
optimized out by compiled, however in cases when code is too
complicated for optimizer we can see performance regression.

To avoid that we need either to rewrite code or just disabled
initialization with the attribute. Particularly here I don't see
a reasonable way to restructure the code to preserve performance
without loosing readability.

hit-test-lots-of-layers of blink_perf.events was 12% slower.
Before: https://pinpoint-dot-chromeperf.appspot.com/job/15069da7220000
After: https://pinpoint-dot-chromeperf.appspot.com/job/117e2deb220000

Bug: 977230

Change-Id: I92f64956f71e46ec613dbec31bb1eb545b7e9b05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955030
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723573}

This listed the Secure Shell App (stable) which is the most common
currently, but we're moving to the Extension as being the primary
one, and each have dev variants.

Change-Id: I129c8b16118beab999afe640022292c05ad5b191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960071Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723572}

This change adds metrics to capture whether a prediction model was valid
or not when being constructed and captures the latency of performing the
validation when instantiating models for use.

Bug: 1001194
Change-Id: If176f62ebc6ba37691fdc32cf551351c71e27c1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959330
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Auto-Submit: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723571}

This attribute was long ago cut from the spec and is not present in the
current VideoPlaybackQuality interface.

Bug: 644731
Change-Id: Icbea9bb3ce4eb9afb1530dde56a6f45930d7facc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956496
Auto-Submit: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723570}

The inner ring is currently painted white which is not correct in dark
mode.

Bug: 1015634
Change-Id: Id028c5ed109b885ac20eeb4804bb493eae63567f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961007
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723569}

This reverts commit 255e9823.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 723530 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzI1NWU5ODIzYjdjMDk0YzAyMTE3Y2FlYTBlYzUyNTUyYzc4NDdjNGEM

Sample Failed Build: https://ci.chromium.org/b/8894421393952007408

Sample Failed Step: compile

Original change's description:
> Add a histogram for HSTS includeSubDomains masking behavior
> 
> If c.example has HSTS with includeSubDomains and b.c.example has HSTS
> *without* includeSubDomains, we currently treat a.b.c.example as *not*
> HSTS. The b.c.example masks off the c.example entry.
> 
> This behavior was, at one point, relied on by a corporate deployment per
> https://crbug.com/469957. However, the analysis in the bug that it
> matches the spec was incorrect. RFC 6797 sections 8.2 and 8.3 spell out
> the matching rules explicitly and they do not include the shadowing
> behavior.
> 
> The analysis that it matches all other browsers was also incorrect.
> Chrome and Firefox have the shadowing behavior while Edge and Safari do
> not.
> 
> This behavior is also surprising and increases the risk of a
> misconfigured site losing HSTS's security properties, particularly
> around cookie injection. As the first step towards fixing this, measure
> how often this makes a difference,
> 
> Bug: 469957, 821811
> Change-Id: I22cb443cd1f1a378ec1794575b9082905f74150c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955334
> Commit-Queue: David Benjamin <davidben@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Nick Harper <nharper@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#723530}


Change-Id: I96194c483b927475ee95e235f939ca987364bb37
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 469957, 821811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961076
Cr-Commit-Position: refs/heads/master@{#723568}

If a client uses an earlier version of the protocol and this event is
sent to it, it can crash in in several ways.

BUG=b:145916692
TEST=Builds

Change-Id: Ia43a724076165ff771fe399407c5fc0464e3df84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960987
Auto-Submit: Lloyd Pique <lpique@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Lloyd Pique <lpique@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723567}

https://skia.googlesource.com/skia.git/+log/3f9199a162ff..ad994cd8941d

git log 3f9199a162ff..ad994cd8941d --date=short --first-parent --format='%ad %ae %s'
2019-12-10 egdaniel@google.com Store GrSurfaceProxyView on shadow ops.
2019-12-10 herb@google.com Put SubRuns in an alloc on GrTextBlob
2019-12-10 fmalita@chromium.org [skottie] Add frame time histogram to SkottieSlide UI
2019-12-10 jlavrova@google.com Font features
2019-12-10 fmalita@chromium.org [skottie] Initial SkottieSlide UI
2019-12-10 halcanary@google.com utils/mac/SkCreateCGImageRef: cleanup

Created with:
  gclient setdep -r src/third_party/skia@ad994cd8941d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1029972
Tbr: djsollen@google.com
Change-Id: I547e84ac1af74a5449142a7ce0f669ea0549430e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960772Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723566}

Offer methods to read and write specific keys instead of generic ones
that can access any key.

Bug: 1022108
Change-Id: I33d8be0798b9ef4504b14720f159469ebbf80c7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958655Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723565}

Instead of contacting the primary agent for UrlRequestRewriteRules,
CastRunner will now contact the agent specified by
ApplicationConfigManager. If this agent does not provide
UrlRequestRewriteRules (which are now optional), then CastRunner will
inject an empty vector of rules. Also added a new test to ensure that
UrlRequestRewriteRules are in fact optional.

Bug: b/141573972
Test: cast_runner_integration_tests, launch application
Change-Id: I82cda7117dec88b657d9f6888ad081cc4d248cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959386
Commit-Queue: Connor Lange <connorl@chromium.org>
Auto-Submit: Connor Lange <connorl@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723564}

Report:
"courgette/disassembler_win32.cc:241:44: runtime error: applying non-zero offset 255 to null pointer"

courgette::DisassemblerWin32::ParseRelocs
courgette::DisassemblerWin32::ExtractAbs32Locations
courgette::Disassembler::CreateProgram

The fix seems to move bounds check on |relocs_start| before computing |relocs_end|.

Bug: 1027893
Change-Id: Iec3f81ab0db077467d28dd8e122aa33d92d52a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960548
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723563}

Using wpt-import in Chromium dd8930f8.
With Chromium commits locally applied on WPT:
a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders."
eb00b4d6 "LazyLoad: move invisible-image.html test to WPT"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure

NOAUTOREVERT=true
TBR=smcgruer

No-Export: true
Change-Id: I763d992341b8a844ba57637a196d7c1e71ab65f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960794Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723562}

This CL adds calls to the sites where we enter and leave keyword
search mode, so the user knows that there has been a state change,
and plumbs those calls to the View layer.

Bug: 785375
Change-Id: Ie5963fc4741979af7be296107ff9704620d41c20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955161
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723561}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d9b33e92da7f..c1c5bec5ed00

git log d9b33e92da7f..c1c5bec5ed00 --date=short --first-parent --format='%ad %ae %s'
2019-12-10 mandy.chen@microsoft.com Check for null to avoid UnhandledPromiseRejection in Main.Main.SearchActionDelegate.handleAction
2019-12-10 tvanderlippe@chromium.org Revert "Updates common/ legacy; resoves internal refs"
2019-12-10 aerotwist@chromium.org Updates common/ legacy; resoves internal refs
2019-12-10 aerotwist@chromium.org Migrates main/ to esm
2019-12-10 tvanderlippe@chromium.org Migrate elements/ to use ES-imports
2019-12-10 tvanderlippe@chromium.org Update Runtime to automatically lazy load -legacy files

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@c1c5bec5ed00

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ie104c2b936266fa7e331567cd51331976bbbffdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960775Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723560}

After this change, ExtensionInstalledBubbleView no longer depends on
ExtensionInstalledBubble. The subsequent CL will break the dependency on
BubbleReference as well as having ExtensionInstalledBubbleObserver
directly create and show an ExtensionInstalledBubbleView, bypassing
BubbleUi.

Bug: 496955
Change-Id: Ic1a1165da911a5fe8bc8e2840fc23dee8b2f87b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959937
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723559}

These callbacks are run once, though only if ShouldOpenDownload()
returns false.

Note that some implementations return false but still don't run the
callback, which violates the contract defined in the
DownloadManagerDelegate header. This adds TODOs in those places.

R=avi@chromium.org, qinmin@chromium.org
TBR=servolk

Bug: 1007763
Change-Id: Iae4e741fe4cc1a6d5c308e7608a4805cc4f17efb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959542
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723558}