- 05 Feb, 2020 40 commits
-
-
Chris Hall authored
R=aboxhall,dmazzoni Change-Id: I82c4687fd9923bf2669248419c7ed8616f1a7406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010227 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#738486}
-
Kent Tamura authored
Bug: 924929 Change-Id: I29afe6b8e36c1101d81a3f2c02171662907f4057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035482Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#738485}
-
Xiaocheng Hu authored
There's a CSSParserContext ctor that allows implicit conversion from a |const CSSParserContext*| to |const CSSParserContext&|, where the latter is actually a new object constructed on stack with different member values. So this patch stops the conversion. Change-Id: Ibf98e8b0012122d2fc42e3fc4b4b38e8fe9b797a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037854Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#738484}
-
Clemens Backes authored
This should have been included in https://crrev.com/c/2030951 already. I missed that both "android_webview" and "ios" were missing. The set of "android", "android_webview" and "ios" hopefully covers all mobile platforms. R=bcwhite@chromium.org Bug: 1040061, 1040030 Change-Id: I8aa87b15c849be9d62c88df0a9f7eb7615eb6ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036056Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#738483}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/25cf469a112f..6c9b1fd6663e git log 25cf469a112f..6c9b1fd6663e --date=short --first-parent --format='%ad %ae %s' 2020-02-05 jvanverth@google.com Update Viewer docs for Android and iOS. 2020-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 41a7302e9c62..8e8e1d0dd729 (4 commits) 2020-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 aa6dd50de0c5..58fc8b11cf3a (7 commits) 2020-02-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-04 egdaniel@google.com Make sure we invalidate mapped memory from vk transfer buffers before reading. 2020-02-04 tdenniston@google.com Revert "Initial checkin of GM verifier framework" 2020-02-04 tdenniston@google.com Initial checkin of GM verifier framework 2020-02-04 jvanverth@google.com Update iOS build instructions. Created with: gclient setdep -r src/third_party/skia@6c9b1fd6663e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: Ieeaf17a5514f142e6a145bc025f9fba4512d2265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038118Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738482}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d8c4b5fb80d4..f764fc02e94c git log d8c4b5fb80d4..f764fc02e94c --date=short --first-parent --format='%ad %ae %s' 2020-02-05 syoussefi@chromium.org Fix varying linking by location 2020-02-04 lexa.knyazev@gmail.com Implement RGTC (BC4, BC5) compressed texture formats 2020-02-04 cnorthrop@google.com Capture/Replay: Track compressed texture data 2020-02-04 jmadill@chromium.org Vulkan: Count active renderpasses in overlay. Created with: gclient setdep -r src/third_party/angle@f764fc02e94c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I9bfe5267a5088f96823a8528585e690647277a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038115Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738481}
-
rbpotter authored
Add Polymer 3 closure compiler targets for the files in settings_page/. Bug: 1026426 Change-Id: Ia672c0edbf05ef8779dcde296bcd704ff4c7b427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036524 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#738480}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6a299ca2..30fcb3eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9d4065de8a55f0931d8758928f0ed974f00ab0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038372Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738479}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e06acb7de1b8..d28c5fe2b8b8 git log e06acb7de1b8..d28c5fe2b8b8 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 thestig@chromium.org Roll third_party/freetype/src/ e5038be70..4a19a53d5 (1 commit) 2020-02-04 tsepez@chromium.org Remove stray CFXJSE_Value forward declaration from ijs_runtime.h 2020-02-04 tsepez@chromium.org Add dumpTree() testing helper JS function. Created with: gclient setdep -r src/third_party/pdfium@d28c5fe2b8b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3fdc6a748845ab58cedb8bb39058e6d9684ed1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036429Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738478}
-
Naoki Fukino authored
Results from RecentModel are cached for 10 seconds. However, if the requested file type is different from previous one, the cache should be invalidated and not reused. Bug: 1040049 Test: Run browser_tests Change-Id: I0e9a90d6faeb612531ebdd64ff5b152bd9989755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035509 Auto-Submit: Naoki Fukino <fukino@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738477}
-
Demetrios Papadopoulos authored
Bug: 1026426 Change-Id: Ib0f10d3267899069c53794e4ae42db23b4f8b98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037026 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738476}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0165beed0829..f72ef2db9462 git log 0165beed0829..f72ef2db9462 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 dberris@chromium.org E-Divisive: Reduce permutation testing iterations 2020-02-05 dberris@chromium.org Raise ceiling for upload-processing Created with: gclient setdep -r src/third_party/catapult@f72ef2db9462 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: I9c1a4398f2fd0d2e81b83bde5d661e3d23684344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038116Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738475}
-
Eriko Kurimoto authored
This CL adds shared-worker-import-referrer.html for web-platform-test. Bug: 824646 Change-Id: I3031e34f1181303f7a0455974b3c614340d939f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037275 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#738474}
-
Nick Diego Yamane authored
After crrev.com/c/2028408, keyboard input handling has been broken in Ozone/X11 desktop builds (CrOS on Linux is not affected), when IBus IME is setup, among other cases which depend on KeyEvents::Properties being properly set. This fixes it as well as adds a unit test to prevent future similar regressions. Bug: 1047999 Change-Id: If67b78eb795b8d5efabf987a25ebf68de733948e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034810 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#738473}
-
Roman Sorokin authored
Still used in EasyUnlockAuthAttempt Fixed: 927498 Change-Id: Ice2c8c791d808349b508b6af79e684ca203644d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035972Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738472}
-
Alexey Baskakov authored
This getter will be needed for WebAppMigrationManager to convert downloaded icon sizes info. Bug: 1020037 Change-Id: I6d3fcb2e878671f9af455c3555aa4cf99053ea85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037302Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#738471}
-
Yutaka Hirano authored
We're planning to introduce a non-copyable request body to blink::ResourceRequest and blink::WebURLRequest in order to support streaming upload. WebURLLoader::LoadAsynchronously and WebURLLoader::LoadSynchronously take a const reference to WebURLRequest, but we'll need to modify the request when a non-copyable request body is introduced. Here we stop using WebURLRequest and pass std::unique_ptr<network::ResourceRequest> instead. This is better than using a mutable reference to WebURLRequest because it is hard to distinguish whether an argument is const reference or mutable reference. Moreover, WebURLRequest is planned to be deprecated and we are planning to use network::ResourceRequest or network::mojom::URLRequest for the "request" struct for IPC. This change is also a step of that larger refactoring effort. third_party/blink/PRESUBMIT.py is updated to reflect the discussion at https://groups.google.com/a/chromium.org/forum/#!topic/platform-architecture-dev/ntSzerId4gw . Bug: 860403, 688906 Change-Id: Ieb42432e30495d03f8cfb924a41a1327070c7aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032688Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#738470}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I8db12eacd2838ebf00b3094d744a0fde4dc28bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038371Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738469}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cecc4d627631..be70f94fa57b Created with: gclient setdep -r src-internal@be70f94fa57b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1048438 Tbr: jbudorick@google.com Change-Id: I19d45e54ef9d7a1846cac21a4b41afcc6eb316ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038117Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738468}
-
Nick Diego Yamane authored
Ozone/X11 unit tests are kept separately so that non-X11 tests don't depend on X server to be performed. Having x11 event translation tests in events_unittests currently depends on GN config ozone_platform_x11 being set (more precisely after crrev.com/c/1895399), which breaks the aforementioned rule, when running unit tests within a ssh session, where DISPLAY env var is not set, among other scenarios. This fixes such regression by keeping such tests in events_unittests binary only for Aura/X11, while for ozone they are added to ozone_x11_unittests instead. This must be cleaned up once X11 is fully migrated to Ozone/X11, by moving x11 event translation impl and its tests into ozone/platform/x11 dir. R=spang@chromium.org --gtest_filter=XEventTranslationTest.KeyEventDomKeyExtraction Bug: 1029365 Test: DISPLAY= ./out/linux_ozone_rel/events_unittests \ Change-Id: I053d8dc9e2a1a26a844479c0fb503351053b12a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036995 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#738467}
-
Jeevan Shikaram authored
This CL checks if an ARC app is "sticky" and classifies it as a system installed app if it is. Fixed: 1010821, 1048874 Change-Id: I1c6fdf752a0437cf012a0051c01c4e1600f0353e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038191 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#738466}
-
Raul Tambre authored
map() returns a list in Python 2. Python 3 returns an iterator. Wrapping in a list() results in the same behaviour on both. Traceback (most recent call last): File "../../third_party/blink/renderer/build/scripts/make_instrumenting_probes.py", line 283, in <module> main() File "../../third_party/blink/renderer/build/scripts/make_instrumenting_probes.py", line 262, in main cpp_file.write(cpp_template.render(template_context)) File "C:\Google\chromium\src\third_party\jinja2\asyncsupport.py", line 76, in render return original_render(self, *args, **kwargs) File "C:\Google\chromium\src\third_party\jinja2\environment.py", line 1008, in render return self.environment.handle_exception(exc_info, True) File "C:\Google\chromium\src\third_party\jinja2\environment.py", line 780, in handle_exception reraise(exc_type, exc_value, tb) File "C:\Google\chromium\src\third_party\jinja2\_compat.py", line 37, in reraise raise value.with_traceback(tb) File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\templates\instrumenting_probes_impl.cc.tmpl", line 129, in <module> void {{probe.name}}Impl({{ params_list(probe) }}) { File "C:\Google\chromium\src\third_party\jinja2\runtime.py", line 579, in _invoke rv = self._func(*arguments) File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\templates\instrumenting_probes_impl.cc.tmpl", line 91, in <module> {%- for param in probe.params %} File "C:\Google\chromium\src\third_party\jinja2\runtime.py", line 435, in __init__ self._after = self._safe_next() File "C:\Google\chromium\src\third_party\jinja2\runtime.py", line 455, in _safe_next return next(self._iterator) File "../../third_party/blink/renderer/build/scripts/make_instrumenting_probes.py", line 148, in __init__ self.default_value = parts[1] if len(parts) != 1 else None TypeError: object of type 'map' has no len() Traceback (most recent call last): File "../../third_party/blink/renderer/build/scripts/make_instrumenting_probes.py", line 283, in <module> main() File "../../third_party/blink/renderer/build/scripts/make_instrumenting_probes.py", line 262, in main cpp_file.write(cpp_template.render(template_context)) File "C:\Google\chromium\src\third_party\jinja2\asyncsupport.py", line 76, in render return original_render(self, *args, **kwargs) File "C:\Google\chromium\src\third_party\jinja2\environment.py", line 1008, in render return self.environment.handle_exception(exc_info, True) File "C:\Google\chromium\src\third_party\jinja2\environment.py", line 780, in handle_exception reraise(exc_type, exc_value, tb) File "C:\Google\chromium\src\third_party\jinja2\_compat.py", line 37, in reraise raise value.with_traceback(tb) File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\templates\instrumenting_probes_impl.cc.tmpl", line 130, in <module> {{sink_class}}* probe_sink = To{{sink_class}}({{probe.params[0].name}}); File "C:\Google\chromium\src\third_party\jinja2\environment.py", line 430, in getattr return getattr(obj, attribute) jinja2.exceptions.UndefinedError: map object has no element 0 Bug: 941669 Change-Id: Ie584b13c8b3e54ee9f06faffd57d93917c88ccfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033510 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#738465}
-
Jason Lin authored
The UI tweak is based on the mock [1] and spec [2]. [1] https://docs.google.com/presentation/d/1BrYiEWolfwVwX1Z-4W7c1BgJNjnn7DZZ5lJTs-mFcxI/edit?ts=5e0ebd8b#slide=id.g7c663e3687_0_12 [2] https://drive.google.com/file/d/1323cL3Bv-H-R1L_u50wNezGhFWTbP5rE/view Bug: 1016195 Change-Id: Ic6f4094e567825dbd6223e271483abaa748bb284 Test: manually with crostini-username flag on Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032760 Commit-Queue: Jason Lin <lxj@google.com> Auto-Submit: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#738464}
-
Findit authored
This reverts commit 7eefdcbf. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 738454 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzdlZWZkY2JmNjNjZDNjOGMzYmNhZTZkNmQ4OTQ2ODM4OWFmOGRiNWMM Sample Failed Build: https://ci.chromium.org/b/8889318408391750976 Sample Failed Step: compile Original change's description: > Grit: Avoid rebuilding all pak files when ID ranges do not change > > We are now generating ID ranges for .grd files as part of the build. The > tool was already smart enough to leave padding for each range so that > the ranges would not change for every single resource added / removed. > However, since it was unconditinoally writing the resource_ids file, > ninja was considering all grit targets as stale even when ID ranges did > not change. > > We now write the file only when it is changing so that ninja will not > consider grit targets stale in the did-not-change case. > > Bug: 979886 > Change-Id: Ib38620e1be097b31ec876be9b07172a7ff945c07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036528 > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738454} Change-Id: I5e0e2bc30ae2a10d5fafb74aef9575c6991573c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 979886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038068 Cr-Commit-Position: refs/heads/master@{#738463}
-
Joel Hockey authored
Unsharing a crostini folder can fail if a user has a file open in some application. When this happens, we will show a dialog to the user to inform them that unsharing has failed and allow them to retry the unsharing presumably after they have closed associated files. Bug: 920416 Change-Id: I303200f7e0e40fe8c7e1382bf19878d7ed2b31fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037276Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#738462}
-
Ionel Popescu authored
Prior to this CL on platforms where popups don't have drop shadow, the content of the popups is going to blend with the rest of the page. This CL adds border to popups in order to avoid the issue described above. Bug: 1048219 Change-Id: Ifb69fb204239f8d95f6b3feab704505709cbddf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036250 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#738461}
-
Yoshisato Yanagisawa authored
Since it is out of src by default, it is not possible for us to provide hermetic compile. Let me make that within Chromium src. Bug: 1015730 Change-Id: I4283a6ccf54d8f30401a6ad3f0084b7fe791b2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027015 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#738460}
-
Ben Mason authored
This reverts commit 835cde27. Reason for revert: Causing crash: crbug/1048145 Original change's description: > Add DomainDiversityReporter for domain diversity metrics > > This CL adds DomainDiversityReporter to schedule domain metrics > computation tasks and emit histograms. The reporting task is > executed shortly after startup and then scheduled once per 24 > hours thereafter. > > Bug: 1015424 > Change-Id: Id4b8043c1a9b9ea0ee70d4be68e9c35017a82de1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864522 > Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735713} TBR=sadrul@chromium.org,sky@chromium.org,mpearson@chromium.org,gab@chromium.org,mjzhang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015424 Change-Id: I8b9d3f2b9866569cf7f55d842cca19bd2c3f65c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037952Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#738459}
-
Austin Eng authored
This test is flaky on Win NVIDIA GTX 1660 - D3D11 TBR=kbr@chromium.org Bug: angleproject:4377 Change-Id: I0bbd316794186d7362790a34dea57a0dc09056c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038270Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#738458}
-
Kevin Marshall authored
Allows embedders to specify a virtual resolution used when rendering web content. Web content will be laid out differently, either supersampled or subsampled depending on whether the overridden resolution is smaller or larger relative to the View's native resolution. The virtual resolution is then scaled to fit the View. The GPU surface resolution will remain unaffected; it is the same as the View's native resolution. Bug: b/144361044,b/144725868 Change-Id: Iefaa0059235319420dc1e050d33d706c1d96ab18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977001 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#738457}
-
Toby Huang authored
Child users should not be able to install extensions and themes with mature content from Chrome Web Store (CWS). Add a new disable reason BLOCKED_MATURE to block any extensions or themes marked mature in CWS for child users. Bug: 1037965,1040614 Change-Id: I37cec6efb51e0e88c1714e57be0ef279b1b32ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017646 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#738456}
-
Ankit Kumar authored
The CL enables highlight feature flag kAccessiblePDFHighlight in PDFExtensionAccessibilityTextExtractionTest. The CL updates the test expectation file as well. Bug: 1008775 Change-Id: Ic09596e920e409d4c2290092317bde1510571bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035491Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#738455} -
Andrew Grieve authored
We are now generating ID ranges for .grd files as part of the build. The tool was already smart enough to leave padding for each range so that the ranges would not change for every single resource added / removed. However, since it was unconditinoally writing the resource_ids file, ninja was considering all grit targets as stale even when ID ranges did not change. We now write the file only when it is changing so that ninja will not consider grit targets stale in the did-not-change case. Bug: 979886 Change-Id: Ib38620e1be097b31ec876be9b07172a7ff945c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036528 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#738454}
-
Koji Ishii authored
Following bot results are included. 1263 1266 1267 1268 1271 1273 1275 1276 8 lines were removed and 12 lines were deflaked by consecutive results since 1255. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I9b26ee7e124c921421664fab8e943c9ef75c5f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035646Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738453}
-
Rafael Cintron authored
Expose kForwardMemoryPressureEventsToGpuProcess in content_features.h so that it can more easily be used by Chromium hosts. Bug: 1048924 Change-Id: I911f44b0274be30d5b33b01a0ec2c338417920a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036801Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#738452}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/a779c4ef526e..cba278682002 git log a779c4ef526e..cba278682002 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 rwkeane@google.com mDNS: Change Continuous Multicast Query Handling 2020-02-04 rwkeane@google.com Discovery: Recoverable Error Reporting Created with: gclient setdep -r src/third_party/openscreen/src@cba278682002 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Id255d24fd7826077ddfc3dbb2c52934662c526e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037194Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738451}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/047cb6914ae5..e22c450dfeb2 git log 047cb6914ae5..e22c450dfeb2 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-04 chshrest@microsoft.com [Elements]: Keyboard and screen reader accessibility of swatch drag element in color picker Created with: gclient setdep -r src/third_party/devtools-frontend/src@e22c450dfeb2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iae2d1dc1dab75f5e890e3937269410bf9dbf9a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038175Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738450}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/59a29e3c4f03..8e8e1d0dd729 git log 59a29e3c4f03..8e8e1d0dd729 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 bclayton@google.com Shader: Add missing switch cases to operationString 2020-02-04 bclayton@google.com OpenGL: Fix switch with only a default case. Created with: gclient setdep -r src/third_party/swiftshader@8e8e1d0dd729 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If91d956eb882e7d7b5f9d1ef6109fcb0e426b155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037626Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738449}
-
Demetrios Papadopoulos authored
- Fix a bug in route.js where pageVisibility is undefined in Polymer 3. - Fix a newly found type-check error in global_scroll_target_begavior.js (only happens in the context of a JS module). - Update search_engines_page/ prod and test code as needed. - Update BUILD.gn, grdp files as needed. Bug: 1026426 Change-Id: Ic2229bebdca80d08189943fabd62e1d86f050a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032669 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738448}
-
Daniel Hosseinian authored
Create a header, hb_scoped.h, which contains std::unique_ptr wrappings of commonly used Harfbuzz objects that clean up the objects when they go out of scope. Subsequently, remove calls of hb_*_destroy() functions in harfbuzz_fuzzer.cc. Bug: 1046803 Change-Id: Icbc13201f77336fe3f7e0f6c9191a0e52c2f76cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034111 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#738447}
-